Skip to content

feat: openapiformat enum cleanup - #2326

Merged
Vincent Biret (baywet) merged 3 commits into
mainfrom
mw/openapiformat-enum-cleanup
Apr 16, 2025
Merged

feat: openapiformat enum cleanup#2326
Vincent Biret (baywet) merged 3 commits into
mainfrom
mw/openapiformat-enum-cleanup

Conversation

@Michael-Wamae

@Michael-WamaeMichael Wamae (Michael-Wamae) commented Apr 15, 2025

Copy link
Copy Markdown
Contributor
  • openapiformat enum cleanup

fixes#2306

baywet
Vincent Biret (baywet) requested changes Apr 15, 2025
View reviewed changes

@baywetVincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this.
In addition to the inline comments, can you also add an entry to the upgrade guide please?

Comment threadsrc/Microsoft.OpenApi.Hidi/Options/CommandOptions.cs Outdated
Comment threadsrc/Microsoft.OpenApi/Extensions/OpenApiSerializableExtensions.cs Outdated
Comment threadsrc/Microsoft.OpenApi.Hidi/OpenApiService.cs Outdated
@Michael-Wamae@baywet
align string options
8ad002d
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@Michael-Wamae
resolve PR comments
1b86cec
@sonarqubecloud

sonarqubecloudBot commented Apr 16, 2025

Copy link
Copy Markdown

Quality Gate PassedQuality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@baywet
Vincent Biret (baywet) deleted the mw/openapiformat-enum-cleanup branch April 16, 2025 10:49
@release-pleaserelease-pleaseBot mentioned this pull request Apr 16, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywetVincent Biret (baywet)baywet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v2 - OpenApiFormat enum could be cleaned up before release

2 participants

@Michael-Wamae@baywet