Skip to content

Fix handling of nullable enums for 3.0 - #2920

Merged
Vincent Biret (baywet) merged 4 commits into
microsoft:mainfrom
Youssef1313:nullable-enum
Jul 3, 2026
Merged

Fix handling of nullable enums for 3.0#2920
Vincent Biret (baywet) merged 4 commits into
microsoft:mainfrom
Youssef1313:nullable-enum

Conversation

@Youssef1313

@Youssef1313Youssef Fahmy (Youssef1313) commented Jul 1, 2026

Copy link
Copy Markdown
Member

Previously, this scenario wasn't producing a type and wasn't producing a null value in the enum array.

This fixes it so that they are produced.

In the future, we could also avoid adding a oneOf with a single element in this scenario.

@Youssef1313
Youssef Fahmy (Youssef1313) requested a review from a team as a code ownerJuly 1, 2026 16:35
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jul 1, 2026
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs Fixed
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jul 1, 2026
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs Fixed
DeagleGross
Korolev Dmitry (DeagleGross) approved these changes Jul 1, 2026
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs Outdated
baywet
Vincent Biret (baywet) requested changes Jul 2, 2026
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs Outdated
Comment threadtest/Microsoft.OpenApi.Tests/Models/OpenApiSchemaTests.cs Outdated
Comment threadtest/Microsoft.OpenApi.Tests/Models/OpenApiSchemaTests.cs Outdated
Comment threadtest/Microsoft.OpenApi.Tests/Models/OpenApiSchemaTests.cs
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jul 2, 2026
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs Fixed
baywet
Vincent Biret (baywet) previously approved these changes Jul 2, 2026
View reviewed changes

@baywetVincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@Youssef1313

Youssef Fahmy (Youssef1313) commented Jul 3, 2026

Copy link
Copy Markdown
MemberAuthor

Vincent Biret (@baywet) Is there anything remaining to get this merged? Would we have a new version released before .NET 11 Preview 7 so that we try to get that in aspnetcore repo and possibly build some fixes on our side on top of this?

github-advanced-security[bot]
github-advanced-securityAI found potential problems Jul 3, 2026
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs Dismissed
baywet
Vincent Biret (baywet) reviewed Jul 3, 2026
View reviewed changes
Comment threadsrc/Microsoft.OpenApi/Models/OpenApiSchema.cs Outdated
baywet
Vincent Biret (baywet) approved these changes Jul 3, 2026
View reviewed changes

@baywetVincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet
Vincent Biret (baywet) merged commit beb68f5 into microsoft:mainJul 3, 2026
9 checks passed
@Youssef1313
Youssef Fahmy (Youssef1313) deleted the nullable-enum branch July 3, 2026 14:23
@release-please-token-providerrelease-please-token-providerBot mentioned this pull request Jul 3, 2026
Merged
@baywetVincent Biret (baywet) mentioned this pull request Jul 3, 2026
Merged
@release-please-token-providerrelease-please-token-providerBot mentioned this pull request Jul 2, 2026
Merged
This was referenced Jul 6, 2026
Closed
Closed
Closed
Closed
Merged
Closed
Closed
This was referenced Aug 8, 2026
Closed
Closed
Open
Merged
Open
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Closed
Open
Open
Closed
Open
Open
Closed
Open
Open
Open
Closed
Open
Open
Open
Youssef Fahmy (Youssef1313) added a commit to Youssef1313/OpenAPI.NET that referenced this pull request Aug 11, 2026
@Youssef1313@baywet
fix: handling of nullable enums for 3.0 (microsoft#2920)
f4778e0
* Fix handling of nullable enums for 3.0
* Address comments
* Add
* Use JsonNullSentinel.JsonNull
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywetVincent Biret (baywet)baywet approved these changes
+2 more reviewers
@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
@DeagleGrossKorolev Dmitry (DeagleGross)DeagleGross approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Youssef1313@baywet@DeagleGross@github-advanced-security