From 50ff5ae2008e5d464213a6f1c87f89359a9ba886 Mon Sep 17 00:00:00 2001
From: "Stephan T. Lavavej" <stl@microsoft.com>
Date: Wed, 27 Mar 2024 14:45:14 -0700
Subject: [PATCH] Avoid `ConvertTo-SecureString` in
 `create-1es-hosted-pool.ps1`

---
 azure-devops/create-1es-hosted-pool.ps1 | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/azure-devops/create-1es-hosted-pool.ps1 b/azure-devops/create-1es-hosted-pool.ps1
index 232464f305f..bba0c57a831 100644
--- a/azure-devops/create-1es-hosted-pool.ps1
+++ b/azure-devops/create-1es-hosted-pool.ps1
@@ -79,9 +79,9 @@ function New-Password {
     }
   }
 
-  $result = ''
+  [SecureString] $result = [SecureString]::new()
   for ($idx = 0; $idx -lt $Length; $idx++) {
-    $result += $alphabet[$randomData[$idx] -band $mask]
+    $result.AppendChar($alphabet[$randomData[$idx] -band $mask])
   }
 
   return $result
@@ -143,8 +143,7 @@ New-AzResourceGroup `
 ####################################################################################################
 Display-ProgressBar -Status 'Creating credentials'
 
-$AdminPW = New-Password
-$AdminPWSecure = ConvertTo-SecureString $AdminPW -AsPlainText -Force
+$AdminPWSecure = New-Password
 $Credential = New-Object System.Management.Automation.PSCredential ('AdminUser', $AdminPWSecure)
 
 ####################################################################################################