From 7559245310ede8668149db682d904bd4f77cc3f8 Mon Sep 17 00:00:00 2001 From: Casey Carter Date: Fri, 9 Aug 2024 16:24:37 -0700 Subject: [PATCH 1/2] Skip libcxx test with timing assumptions Upon observing https://dev.azure.com/vclibs/STL/_build/results?buildId=17286&view=ms.vss-test-web.build-test-results-tab&runId=1421419&resultId=102126&paneView=debug; sporadic test failures are anathema. --- tests/libcxx/expected_results.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/libcxx/expected_results.txt b/tests/libcxx/expected_results.txt index f42f50b04e1..a14630690bc 100644 --- a/tests/libcxx/expected_results.txt +++ b/tests/libcxx/expected_results.txt @@ -518,6 +518,7 @@ std/thread/futures/futures.shared_future/wait_until.pass.cpp SKIPPED std/thread/futures/futures.unique_future/get.pass.cpp SKIPPED std/thread/futures/futures.unique_future/wait.pass.cpp SKIPPED std/thread/futures/futures.unique_future/wait_for.pass.cpp SKIPPED +std/thread/thread.condition/thread.condition.condvarany/notify_one.pass.cpp SKIPPED std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_duration.pass.cpp SKIPPED std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_time_point.pass.cpp SKIPPED std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_try_to_lock.pass.cpp SKIPPED From e9e5a62d7673def525b2a8170f94cf41be6e0476 Mon Sep 17 00:00:00 2001 From: Casey Carter Date: Fri, 9 Aug 2024 16:50:07 -0700 Subject: [PATCH 2/2] Skip all tests annotated `ALLOW_RETRIES` to indicate they have sporadic failures. --- tests/libcxx/expected_results.txt | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/tests/libcxx/expected_results.txt b/tests/libcxx/expected_results.txt index a14630690bc..7b2c765cf61 100644 --- a/tests/libcxx/expected_results.txt +++ b/tests/libcxx/expected_results.txt @@ -509,26 +509,17 @@ std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.asgn/move_convert. std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.asgn/move_convert.single.pass.cpp FAIL std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.asgn/move.pass.cpp FAIL -# Not analyzed, likely bogus tests. Appears to be timing assumptions. +# `ALLOW_RETRIES` comments indicate tests with timing assumptions std/thread/futures/futures.async/async.pass.cpp SKIPPED -std/thread/futures/futures.shared_future/get.pass.cpp SKIPPED -std/thread/futures/futures.shared_future/wait.pass.cpp SKIPPED -std/thread/futures/futures.shared_future/wait_for.pass.cpp SKIPPED -std/thread/futures/futures.shared_future/wait_until.pass.cpp SKIPPED -std/thread/futures/futures.unique_future/get.pass.cpp SKIPPED -std/thread/futures/futures.unique_future/wait.pass.cpp SKIPPED std/thread/futures/futures.unique_future/wait_for.pass.cpp SKIPPED std/thread/thread.condition/thread.condition.condvarany/notify_one.pass.cpp SKIPPED -std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_duration.pass.cpp SKIPPED -std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_time_point.pass.cpp SKIPPED std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_try_to_lock.pass.cpp SKIPPED -std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex.pass.cpp SKIPPED -std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/lock.pass.cpp SKIPPED std/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex_duration.pass.cpp SKIPPED std/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex_time_point.pass.cpp SKIPPED std/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex_try_to_lock.pass.cpp SKIPPED std/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.cons/mutex.pass.cpp SKIPPED std/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.locking/lock.pass.cpp SKIPPED +std/thread/thread.mutex/thread.lock/thread.lock.unique/thread.lock.unique.locking/try_lock.pass.cpp SKIPPED std/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.class/lock.pass.cpp SKIPPED std/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.class/try_lock.pass.cpp SKIPPED std/thread/thread.mutex/thread.mutex.requirements/thread.mutex.requirements.mutex/thread.mutex.recursive/lock.pass.cpp SKIPPED @@ -553,6 +544,18 @@ std/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements std/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.recursive/try_lock_for.pass.cpp SKIPPED std/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.recursive/try_lock_until.pass.cpp SKIPPED std/thread/thread.mutex/thread.mutex.requirements/thread.timedmutex.requirements/thread.timedmutex.recursive/try_lock.pass.cpp SKIPPED + +# Not analyzed, likely bogus tests. Appears to be timing assumptions. +std/thread/futures/futures.shared_future/get.pass.cpp SKIPPED +std/thread/futures/futures.shared_future/wait.pass.cpp SKIPPED +std/thread/futures/futures.shared_future/wait_for.pass.cpp SKIPPED +std/thread/futures/futures.shared_future/wait_until.pass.cpp SKIPPED +std/thread/futures/futures.unique_future/get.pass.cpp SKIPPED +std/thread/futures/futures.unique_future/wait.pass.cpp SKIPPED +std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_duration.pass.cpp SKIPPED +std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_time_point.pass.cpp SKIPPED +std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex.pass.cpp SKIPPED +std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/lock.pass.cpp SKIPPED std/thread/thread.threads/thread.thread.this/sleep_until.pass.cpp SKIPPED # Not analyzed, likely bogus tests. Various assertions, probably POSIX assumptions.