From 49495c8af9d4d5e73016e60e5c760b7c7a32e2b9 Mon Sep 17 00:00:00 2001 From: Casey Carter Date: Tue, 19 Nov 2024 15:51:10 -0800 Subject: [PATCH] Internally remove workaround in `Dev09_056375_locale_cleanup` The `FreeLibrary` call made the ASan runtime do Very Bad Things when statically linking the STL. The ASan bug was fixed by MSVC-PR-582781. Let's enable test coverage internally to prevent regressions until the fix ships in 17.13p2. Fixes VSO-2046190/AB#2046190. --- tests/std/tests/Dev09_056375_locale_cleanup/test.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/std/tests/Dev09_056375_locale_cleanup/test.cpp b/tests/std/tests/Dev09_056375_locale_cleanup/test.cpp index 0e8f1b29da2..4c2c434b6cb 100644 --- a/tests/std/tests/Dev09_056375_locale_cleanup/test.cpp +++ b/tests/std/tests/Dev09_056375_locale_cleanup/test.cpp @@ -83,9 +83,9 @@ void test_dll() { TheFuncProc pFunc = reinterpret_cast(GetProcAddress(hLibrary, "DllTest")); assert(pFunc != nullptr); pFunc(); -#if defined(_DLL) || !defined(__SANITIZE_ADDRESS__) // TRANSITION, VSO-2046190 +#if defined(_MSVC_INTERNAL_TESTING) || defined(_DLL) || !defined(__SANITIZE_ADDRESS__) // TRANSITION, vs17.13p2 FreeLibrary(hLibrary); -#endif // defined(_DLL) || !defined(__SANITIZE_ADDRESS__) +#endif // ^^^ no workaround ^^^ #endif // ^^^ !defined(_M_CEE) ^^^ }