From 5cd34695d360b1c52765a43234b59c09f1d7d52f Mon Sep 17 00:00:00 2001 From: Casey Carter Date: Mon, 9 Sep 2019 16:20:08 -0700 Subject: [PATCH] Suppress warning C4180 STL-wide C4180 "qualifier applied to function type has no meaning; ignored" is emitted from `std::remove_reference` when `T` is a function type or reference to such after applying the changes in #82. We could suppress it locally, but the warning is extremely low-value for the STL in general so let's simply suppress it globally. --- stl/inc/type_traits | 2 -- stl/inc/yvals_core.h | 7 ++++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/stl/inc/type_traits b/stl/inc/type_traits index 05ce44e7b66..6e1820399e2 100644 --- a/stl/inc/type_traits +++ b/stl/inc/type_traits @@ -17,8 +17,6 @@ _STL_DISABLE_CLANG_WARNINGS #pragma push_macro("new") #undef new -#pragma warning(disable : 4180) // qualifier applied to function type has no meaning; ignored - _STD_BEGIN // STRUCT TEMPLATE integer_sequence template diff --git a/stl/inc/yvals_core.h b/stl/inc/yvals_core.h index 3d7c4212258..fbefa2ae915 100644 --- a/stl/inc/yvals_core.h +++ b/stl/inc/yvals_core.h @@ -317,6 +317,7 @@ #define _STL_EXTRA_DISABLED_WARNINGS #endif // _STL_EXTRA_DISABLED_WARNINGS +// warning C4180: qualifier applied to function type has no meaning; ignored // warning C4412: function signature contains type 'meow'; C++ objects are unsafe to pass between pure code // and mixed or native. (/Wall) // warning C4455: literal suffix identifiers that do not start with an underscore are reserved @@ -347,9 +348,9 @@ #ifndef _STL_DISABLED_WARNINGS // clang-format off #define _STL_DISABLED_WARNINGS \ - 4412 4455 4472 4494 4514 4571 4574 4582 4583 4587 \ - 4588 4619 4623 4625 4626 4643 4702 4793 4820 4988 \ - 5026 5027 5045 \ + 4180 4412 4455 4472 4494 4514 4571 4574 4582 4583 \ + 4587 4588 4619 4623 4625 4626 4643 4702 4793 4820 \ + 4988 5026 5027 5045 \ _STL_DISABLED_WARNING_C4577 \ _STL_DISABLED_WARNING_C4984 \ _STL_DISABLED_WARNING_C5053 \