chore(cli): require explicit target for attach

- attach now errors if no positional target / --cdp / --extension is
supplied; the implicit fallback through PLAYWRIGHT_CLI_SESSION /
--config is gone.
- list output drops the per-server status line; serverRegistry.list()
already filters to connectable descriptors, so dashboard and
sessionSidebar drop their redundant canConnect filters too.
- Attach helper text suggests the short --s= form.

Author: pavelfeldman

packages/dashboard/src/dashboardChannel.ts

@@ -15,9 +15,9 @@
  */
 
 importtype{ClientInfo}from'../../playwright-core/src/tools/cli-client/registry';
-importtype{BrowserStatus}from'../../playwright-core/src/serverRegistry';
+importtype{BrowserDescriptor}from'../../playwright-core/src/serverRegistry';
 
-exporttypeSessionStatus=BrowserStatus;
+exporttypeSessionStatus=BrowserDescriptor;
 
 exporttypeTab={
 browser: string;

packages/dashboard/src/sessionSidebar.tsx

@@ -78,7 +78,7 @@ const TabRow: React.FC<{ tab: Tab; model: DashboardModel }> = ({ tab, model }) =
 
 exportconstSessionSidebar: React.FC<SessionSidebarProps>=({ model })=>{
 const{ sessions, clientInfo, loadingSessions,tabs: allTabs}=model.state;
-constopenSessions=React.useMemo(()=>sessions.filter(session=>session.canConnect),[sessions]);
+constopenSessions=sessions;
 
 consttabsByBrowserAndContext=React.useMemo(()=>{
 constmap=newMap<string,Map<string,Tab[]>>();

packages/playwright-core/src/serverRegistry.ts

@@ -89,7 +89,7 @@ class ServerRegistry extends EventEmitter {
 returnthis._ready??Promise.resolve();
 }
 
-asynclist(): Promise<Map<string,BrowserStatus[]>>{
+asynclist(): Promise<Map<string,BrowserDescriptor[]>>{
 constownWatcher=!this._watcher;
 letdispose: (()=>void)|undefined;
 if(ownWatcher)
@@ -102,7 +102,7 @@ class ServerRegistry extends EventEmitter {
 return{ descriptor, canConnect };
 }),
 );
-constresult=newMap<string,BrowserStatus[]>();
+constresult=newMap<string,BrowserDescriptor[]>();
 for(const{ descriptor, canConnect }ofstatuses){
 if(!canConnect){
 awaitfs.promises.unlink(path.join(this._browsersDir(),descriptor.browser.guid)).catch(()=>{});
@@ -114,7 +114,7 @@ class ServerRegistry extends EventEmitter {
 list=[];
 result.set(key,list);
 }
-list.push({ ...descriptor, canConnect });
+list.push(descriptor);
 }
 returnresult;
 }finally{
@@ -133,7 +133,7 @@ class ServerRegistry extends EventEmitter {
 endpoint: endpoint.endpoint,
 workspaceDir: endpoint.workspaceDir,
 };
-awaitfs.promises.writeFile(file,JSON.stringify(descriptor),'utf-8');
+awaitfs.promises.writeFile(file,JSON.stringify(descriptor,null,2),'utf-8');
 }
 
 asyncdelete(guid: string): Promise<void>{

packages/playwright-core/src/tools/cli-client/output.ts

@@ -22,7 +22,7 @@ import path from 'path';
 import{playwrightExtensionInstallUrl}from'../utils/extension';
 
 importtype{ChannelSession}from'./channelSessions';
-importtype{BrowserStatus}from'../../serverRegistry';
+importtype{BrowserDescriptor}from'../../serverRegistry';
 
 exporttypeListedBrowser={
 name: string;
@@ -40,7 +40,7 @@ export type ListedBrowser = {
 exporttypeListData={
 all: boolean;
 browsers: ListedBrowser[];
-servers?: BrowserStatus[];
+servers?: BrowserDescriptor[];
 channelSessions?: ChannelSession[];
 };
 
@@ -55,6 +55,7 @@ export interface Output {
 errorAttachConflict(): never;
 errorDetachNotAttached(session: string): never;
 errorBrowserNotOpenForTool(session: string): never;
+errorAttachNoTarget(): never;
 
 list(data: ListData): void;
 closeAll(sessions: string[]): void;
@@ -112,6 +113,11 @@ export class TextOutput implements Output {
 returnprocess.exit(1);
 }
 
+errorAttachNoTarget(): never{
+console.error(`Error: no target specified for attach command; use one of [name], --cdp, --endpoint, or --extension to specify the target to attach to.`);
+returnprocess.exit(1);
+}
+
 list({ all, browsers, servers, channelSessions }: ListData): void{
 constbyWorkspace=newMap<string,ListedBrowser[]>();
 for(constbrowserofbrowsers){
@@ -144,7 +150,7 @@ export class TextOutput implements Output {
 if(count)
 console.log('');
 console.log('### Browser servers available for attach');
-constserversByWorkspace=newMap<string,BrowserStatus[]>();
+constserversByWorkspace=newMap<string,BrowserDescriptor[]>();
 for(constserverofservers){
 letlist=serversByWorkspace.get(server.workspaceDir??'');
 if(!list){
@@ -204,7 +210,8 @@ export class TextOutput implements Output {
 attach(session: string,pid: number|undefined,endpoint: string|undefined,toolResult: string): void{
 if(endpoint){
 console.log(`### Session \`${session}\` created, attached to \`${endpoint}\`.`);
-console.log(`Run commands with: playwright-cli --session=${session} <command>`);
+console.log(`Run commands with: playwright-cli --s=${session} <command>`);
+console.log('');
 }else{
 console.log(`### Browser \`${session}\` opened with pid ${pid}.`);
 }
@@ -282,6 +289,11 @@ export class JsonOutput implements Output {
 returnprocess.exit(1);
 }
 
+errorAttachNoTarget(): never{
+this._emit({isError: true,error: `no target specified for attach command; use one of [name], --cdp, --endpoint, or --extension to specify the target to attach to.`});
+returnprocess.exit(1);
+}
+
 list({ all, browsers, servers, channelSessions }: ListData): void{
 constpayload: Record<string,unknown>={ browsers };
 if(all){
@@ -372,11 +384,10 @@ function renderBrowser(browser: ListedBrowser): string {
 returnlines.join('\n');
 }
 
-functionrenderServer(server: BrowserStatus): string{
+functionrenderServer(server: BrowserDescriptor): string{
 constlines=[`- browser "${server.title}":`];
 lines.push(` - browser: ${server.browser.browserName}`);
 lines.push(` - version: v${server.playwrightVersion}`);
-lines.push(` - status: ${server.canConnect ? 'open' : 'closed'}`);
 if(server.browser.userDataDir)
 lines.push(` - data-dir: ${server.browser.userDataDir}`);
 else

packages/playwright-core/src/tools/cli-client/program.ts

@@ -165,13 +165,17 @@ export async function program(options?: { embedderVersion?: string}) {
 args.browser=args.extension;
 args.extension=true;
 }
+
 constcdpChannel=typeofargs.cdp==='string'&&isKnownChannel(args.cdp) ? args.cdp : undefined;
+consttargetName=attachTarget??cdpChannel??extensionChannel??args.cdpasstring;
+if(!targetName)
+output.errorAttachNoTarget();
 constattachSessionName=explicitSessionName(args.sessionasstring)??attachTarget??cdpChannel??extensionChannel??sessionName;
 args.session=attachSessionName;
-const{ pid, endpoint}=awaitstartSession(attachSessionName,registry,clientInfo,args,'attach');
+const{ pid }=awaitstartSession(attachSessionName,registry,clientInfo,args,'attach');
 constnewEntry=awaitregistry.loadEntry(clientInfo,attachSessionName);
 consttoolText=awaitrunInSession(newEntry,clientInfo,{_: ['snapshot'],filename: '<auto>'},output);
-output.attach(attachSessionName,pid,endpoint,toolText);
+output.attach(attachSessionName,pid,targetName,toolText);
 return;
 }
 case'close': {
@@ -341,14 +345,17 @@ async function killAllDaemons(): Promise<number[]> {
 asyncfunctioncollectList(registry: Registry,clientInfo: ClientInfo,all: boolean): Promise<ListData>{
 constbrowsers: ListedBrowser[]=[];
 constentries=registry.entryMap();
+
+// List early to GC.
+constserverEntries=awaitserverRegistry.list();
 constkey=clientKey(clientInfo);
 for(const[workspaceKey,list]ofentries){
 if(!all&&workspaceKey!==key)
 continue;
 for(constentryoflist){
 constsession=newSession(entry);
 constcanConnect=awaitsession.canConnect();
-if(!canConnect&&!session.config.cli.persistent){
+if(!canConnect){
 awaitsession.deleteSessionConfig();
 continue;
 }
@@ -372,7 +379,6 @@ async function collectList(registry: Registry, clientInfo: ClientInfo, all: bool
 if(!all)
 return{ all, browsers };
 
-constserverEntries=awaitserverRegistry.list();
 constservers=[...serverEntries.values()].flat();
 return{ all, browsers, servers,channelSessions: awaitlistChannelSessions()};
 }

packages/playwright-core/src/tools/cli-client/skill/SKILL.md

@@ -209,8 +209,8 @@ playwright-cli open --persistent
 # Use persistent profile with custom directory
 playwright-cli open --profile=/path/to/profile
 
-# Connect to browser via extension
-playwright-cli attach --extension
+# Connect to browser via Playwright Extension
+playwright-cli attach --extension=chrome
 
 # Connect to a running Chrome or Edge by channel name
 playwright-cli attach --cdp=chrome

packages/playwright-core/src/tools/dashboard/dashboardController.ts

@@ -28,7 +28,7 @@ import { createClientInfo } from '../cli-client/registry';
 importtype*asapifrom'../../..';
 importtype{Transport}from'@utils/httpServer';
 importtype{AnnotationData,Tab}from'@dashboard/dashboardChannel';
-importtype{BrowserDescriptor,BrowserStatus}from'../../serverRegistry';
+importtype{BrowserDescriptor}from'../../serverRegistry';
 
 typeBrowserTrackerCallbacks={
 onTabsChanged: ()=>void;
@@ -274,7 +274,7 @@ export class DashboardConnection implements Transport {
 returnthis._visible;
 }
 
-emitSessions(sessions: BrowserStatus[]){
+emitSessions(sessions: BrowserDescriptor[]){
 this.sendEvent?.('sessions',{ sessions,clientInfo: createClientInfo()});
 }
 
@@ -379,7 +379,7 @@ export class DashboardConnection implements Transport {
 this._pushSessionsScheduled=false;
 try{
 constbyWs=awaitserverRegistry.list();
-constsessions: BrowserStatus[]=[];
+constsessions: BrowserDescriptor[]=[];
 for(constlistofbyWs.values()){
 for(conststatusoflist){
 if(status.title.startsWith('--playwright-internal'))
@@ -397,12 +397,10 @@ export class DashboardConnection implements Transport {
 });
 };
 
-privateasync_reconcile(sessions: BrowserStatus[]){
-constconnectable=newMap<string,BrowserStatus>();
-for(conststatusofsessions){
-if(status.canConnect)
-connectable.set(status.browser.guid,status);
-}
+privateasync_reconcile(sessions: BrowserDescriptor[]){
+constconnectable=newMap<string,BrowserDescriptor>();
+for(conststatusofsessions)
+connectable.set(status.browser.guid,status);
 
 for(const[guid,slot]ofthis._browsers){
 if(connectable.has(guid))

tests/mcp/cli-cdp.spec.ts

@@ -93,10 +93,9 @@ test('cdp server', async ({ cdpServer, cli, server }) => {
 
 constconfigPath=test.info().outputPath('config.ini');
 awaitfs.promises.writeFile(configPath,`
-browser.cdpEndpoint=${cdpServer.endpoint}
 browser.isolated=false
 `);
-awaitcli('attach',`--config=${configPath}`);
+awaitcli('attach',`--cdp=${cdpServer.endpoint}`,`--config=${configPath}`);
 const{ inlineSnapshot }=awaitcli('snapshot');
 expect(inlineSnapshot).toContain(`- generic [active] [ref=e1]: Hello, world!`);
 });

tests/mcp/cli-session.spec.ts

@@ -69,19 +69,6 @@ test('close non-running session', async ({ cli }) => {
 expect(output).toContain(`Browser 'nonexistent' is not open.`);
 });
 
-test('persistent session shows in list after close',async({ cli, server })=>{
-awaitcli('open',server.HELLO_WORLD,'--persistent');
-
-const{output: listBefore}=awaitcli('list');
-expect(listBefore).toContain('- default:');
-expect(listBefore).not.toContain('<in-memory>');
-
-awaitcli('close');
-
-const{output: listAfter}=awaitcli('list');
-expect(listAfter).toContain('- default:');
-});
-
 test('close-all',async({ cli, server })=>{
 awaitcli('-s','session1','open',server.HELLO_WORLD);
 awaitcli('-s','session2','open',server.HELLO_WORLD);
@@ -310,7 +297,6 @@ workspace1:
 - browser "foobar":
  - browser: ${/* FIX browser._options */mcpBrowser.replace('chrome','chromium')}
  - version: ${version}
- - status: open
  - data-dir: <in-memory>
  - run \`playwright-cli attach "foobar"\` to attach`);
 });
@@ -323,7 +309,7 @@ workspace1:
 awaitpage.setContent('<title>My Page</title>');
 const{output: openOutput}=awaitcli('attach','foobar');
 expect(openOutput).toContain('### Session `foobar` created, attached to `foobar`.');
-expect(openOutput).toContain('Run commands with: playwright-cli --session=foobar <command>');
+expect(openOutput).toContain('Run commands with: playwright-cli --s=foobar <command>');
 const{output: listOutput}=awaitcli('list','--all');
 expect(listOutput).toBe(`### Browsers
 /:
@@ -336,7 +322,6 @@ workspace1:
 - browser "foobar":
  - browser: ${mcpBrowser.replace('chrome','chromium')}
  - version: ${version}
- - status: open
  - data-dir: <in-memory>
  - run \`playwright-cli attach "foobar"\` to attach`);
 });
@@ -349,33 +334,6 @@ workspace1:
 expect(error).toContain('Error: unable to connect to a browser that does not have any contexts');
 });
 
-test('attach via PLAYWRIGHT_CLI_SESSION env',async({ cli, mcpBrowser })=>{
-constbrowserName=mcpBrowser.replace('chrome','chromium');
-await using browser=awaitplaywright[browserName].launch({headless: true});
-constpage=awaitbrowser.newPage();
-awaitpage.setContent('<title>Env Page</title><h1>Hello from env</h1>');
-awaitbrowser.bind('foobar',{workspaceDir: 'workspace1'});
-const{output: openOutput, snapshot }=awaitcli('attach',{env: {PLAYWRIGHT_CLI_SESSION: 'foobar'}});
-expect(openOutput).toContain('### Browser `foobar` opened with pid');
-expect(openOutput).toContain('Env Page');
-expect(snapshot).toContain('Hello from env');
-const{output: listOutput}=awaitcli('list','--all');
-expect(listOutput).toBe(`### Browsers
-/:
-- foobar:
- - status: open
- - browser-type: ${mcpBrowser.replace('chrome','chromium')} (attached)
-
-### Browser servers available for attach
-workspace1:
-- browser "foobar":
- - browser: ${mcpBrowser.replace('chrome','chromium')}
- - version: ${version}
- - status: open
- - data-dir: <in-memory>
- - run \`playwright-cli attach "foobar"\` to attach`);
-});
-
 test('attach with session alias',async({ cli, mcpBrowser })=>{
 constbrowserName=mcpBrowser.replace('chrome','chromium');
 await using browser=awaitplaywright[browserName].launch({headless: true});
@@ -384,7 +342,7 @@ workspace1:
 awaitpage.setContent('<title>Alias Page</title>');
 const{output: openOutput}=awaitcli('attach','foobar','--session=mybrowser');
 expect(openOutput).toContain('### Session `mybrowser` created, attached to `foobar`.');
-expect(openOutput).toContain('Run commands with: playwright-cli --session=mybrowser <command>');
+expect(openOutput).toContain('Run commands with: playwright-cli --s=mybrowser <command>');
 awaitcli('-s','mybrowser','close');
 });
 
@@ -402,7 +360,6 @@ workspace1:
 - browser \"foobar\":
  - browser: ${/* FIX browser._options */mcpBrowser.replace('chrome','chromium')}
  - version: ${version}
- - status: open
  - data-dir: <in-memory>
  - run \`playwright-cli attach \"foobar\"\` to attach`);
 });