From c7567e737d2c531dfd024d9ecc93067b19e233a6 Mon Sep 17 00:00:00 2001 From: abetomo Date: Wed, 5 Jul 2017 17:27:09 +0900 Subject: [PATCH] Fix to set boolean in params.Publish --- lib/main.js | 7 ++++++- test/main.js | 29 +++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/lib/main.js b/lib/main.js index ade00b39..b51afce8 100644 --- a/lib/main.js +++ b/lib/main.js @@ -163,7 +163,12 @@ Lambda.prototype._params = (program, buffer) => { Description: program.description, MemorySize: program.memorySize, Timeout: program.timeout, - Publish: program.publish, + Publish: (() => { + if (typeof program.publish === 'boolean') { + return program.publish + } + return program.publish === 'true' + })(), VpcConfig: { SubnetIds: [], SecurityGroupIds: [] diff --git a/test/main.js b/test/main.js index 5eaa2618..74623dd8 100644 --- a/test/main.js +++ b/test/main.js @@ -222,6 +222,35 @@ describe('lib/main', function () { assert.isNull(params.TracingConfig.Mode) }) + describe('params.Publish', () => { + describe('boolean', () => { + it('If true, it is set to true', () => { + program.publish = true + const params = lambda._params(program) + assert.isTrue(params.Publish) + }) + it('If false, it is set to false', () => { + program.publish = false + const params = lambda._params(program) + assert.isFalse(params.Publish) + }) + }) + + describe('string', () => { + it('If "true", it is set to true', () => { + program.publish = 'true' + const params = lambda._params(program) + assert.isTrue(params.Publish) + }) + it('If not "true", it is set to false', () => { + program.publish = 'false' + assert.isFalse(lambda._params(program).Publish) + program.publish = 'aaa' + assert.isFalse(lambda._params(program).Publish) + }) + }) + }) + describe('configFile', () => { beforeEach(() => { // Prep...