From 72820df518a81fb382af509d29a48eae6ead265e Mon Sep 17 00:00:00 2001 From: abetomo Date: Thu, 10 Aug 2017 13:10:01 +0900 Subject: [PATCH 1/3] Fix commandline version option Version is displayed with the following command. ``` node-lambda --version 0.11.3 ``` It was an error before modification. ``` % node-lambda --version error: unknown option `--version' ``` --- bin/node-lambda | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/bin/node-lambda b/bin/node-lambda index 14945cfe..5cb588a7 100755 --- a/bin/node-lambda +++ b/bin/node-lambda @@ -57,7 +57,6 @@ const PROXY = process.env.PROXY || process.env.http_proxy || '' program .command('deploy') - .version(lambda.version) .description('Deploy your application to Amazon Lambda') .option('-e, --environment [' + AWS_ENVIRONMENT + ']', 'Choose environment {dev, staging, production}', AWS_ENVIRONMENT) @@ -135,7 +134,9 @@ program .option('-x, --contextFile [' + CONTEXT_FILE + ']', 'Context JSON File', CONTEXT_FILE) .action((prg) => lambda.setup(prg)) -program.parse(process.argv) +program + .version(lambda.version) + .parse(process.argv) if (!process.argv.slice(2).length) { program.outputHelp() From 1768e2f89054eb6732b3356b910ffe96e6c07732 Mon Sep 17 00:00:00 2001 From: abetomo Date: Thu, 10 Aug 2017 13:12:27 +0900 Subject: [PATCH 2/3] Add version option test --- test/node-lambda.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/node-lambda.js b/test/node-lambda.js index bd99c70b..05aeb2ed 100644 --- a/test/node-lambda.js +++ b/test/node-lambda.js @@ -198,4 +198,12 @@ describe('bin/node-lambda', () => { }) }) }) + + describe('node-lambda --version', () => { + const packageJson = require(path.join(__dirname, '..', 'package.json')) + it('The current version is displayed', () => { + const ret = execSync(`${nodeLambdaPath} --version`) + assert.equal(ret.toString().trim(), packageJson.version) + }) + }) }) From ec773bcecfbbb8f39152ac3580ca570b84df446a Mon Sep 17 00:00:00 2001 From: abetomo Date: Thu, 10 Aug 2017 13:24:41 +0900 Subject: [PATCH 3/3] Add node command for Windows --- test/node-lambda.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/node-lambda.js b/test/node-lambda.js index 05aeb2ed..dcabaf30 100644 --- a/test/node-lambda.js +++ b/test/node-lambda.js @@ -202,7 +202,7 @@ describe('bin/node-lambda', () => { describe('node-lambda --version', () => { const packageJson = require(path.join(__dirname, '..', 'package.json')) it('The current version is displayed', () => { - const ret = execSync(`${nodeLambdaPath} --version`) + const ret = execSync(`node ${nodeLambdaPath} --version`) assert.equal(ret.toString().trim(), packageJson.version) }) })