From af0049ba701dd85eefa4f1e1f90853d2d4ddd94d Mon Sep 17 00:00:00 2001 From: abetomo Date: Fri, 8 Dec 2017 14:37:33 +0900 Subject: [PATCH 1/2] Use reject in schedule_events.js --- lib/schedule_events.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/schedule_events.js b/lib/schedule_events.js index 51bee5d3..a8142a47 100644 --- a/lib/schedule_events.js +++ b/lib/schedule_events.js @@ -33,10 +33,10 @@ class ScheduleEvents { _putRule (params) { // return RuleArn if created - return new Promise((resolve) => { + return new Promise((resolve, reject) => { const _params = this._putRulePrams(params) this.cloudwatchevents.putRule(_params, (err, rule) => { - if (err) throw err + if (err) reject(err) resolve(rule) }) }) @@ -53,11 +53,11 @@ class ScheduleEvents { } _addPermission (params) { - return new Promise((resolve) => { + return new Promise((resolve, reject) => { const _params = this._addPermissionParams(params) this.lambda.addPermission(_params, (err, data) => { if (err) { - if (err.code !== 'ResourceConflictException') throw err + if (err.code !== 'ResourceConflictException') reject(err) // If it exists it will result in an error but there is no problem. resolve('Permission already set') } @@ -78,11 +78,11 @@ class ScheduleEvents { } _putTargets (params) { - return new Promise((resolve) => { + return new Promise((resolve, reject) => { const _params = this._putTargetsParams(params) this.cloudwatchevents.putTargets(_params, (err, data) => { // even if it is already registered, it will not be an error. - if (err) throw (err) + if (err) reject(err) resolve(data) }) }) From 38efc26add253d3909eed266e8667d0ac617f554 Mon Sep 17 00:00:00 2001 From: abetomo Date: Fri, 8 Dec 2017 14:37:49 +0900 Subject: [PATCH 2/2] Modify to omit parentheses in schedule_events.js --- lib/schedule_events.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/schedule_events.js b/lib/schedule_events.js index a8142a47..520f3a7d 100644 --- a/lib/schedule_events.js +++ b/lib/schedule_events.js @@ -91,9 +91,9 @@ class ScheduleEvents { add (params) { return Promise.resolve().then(() => { return this._putRule(params) - }).then((rule) => { + }).then(rule => { return this._addPermission(Object.assign(params, rule)) - }).then((data) => { + }).then(data => { return this._putTargets(params) }) }