From 2a504940a20e689655802606e354c7d6261b5d9c Mon Sep 17 00:00:00 2001 From: abetomo Date: Thu, 14 Dec 2017 11:06:12 +0900 Subject: [PATCH 1/4] Remove catch just to reject --- lib/main.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/main.js b/lib/main.js index bc8729da..6b22feb5 100644 --- a/lib/main.js +++ b/lib/main.js @@ -848,8 +848,6 @@ so you can easily test run multiple events. ]).then((results) => { resolve(results) }) - }).catch((err) => { - reject(err) }) }).catch(() => { // Function does not exist @@ -882,8 +880,6 @@ so you can easily test run multiple events. ]).then((results) => { resolve(results) }) - }).catch((err) => { - reject(err) }) }) }) From 3421d9b25a0a3b4f8882834cbb8cb36be70e5091 Mon Sep 17 00:00:00 2001 From: abetomo Date: Thu, 14 Dec 2017 11:07:55 +0900 Subject: [PATCH 2/4] Remove only reject catch and unnecessary resolve --- lib/main.js | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/main.js b/lib/main.js index 6b22feb5..6f3678c6 100644 --- a/lib/main.js +++ b/lib/main.js @@ -678,9 +678,7 @@ so you can easily test run multiple events. } return Promise.resolve() })).then((data) => { - return Promise.resolve(data) - }).catch((err) => { - return Promise.reject(err) + return data }) } @@ -701,9 +699,7 @@ so you can easily test run multiple events. // Since `scheduleEvents.add(params)` returns only `{}` if it succeeds // it is not very meaningful. // Therefore, return the params used for execution - return Promise.resolve(paramsList) - }).catch((err) => { - return Promise.reject(err) + return paramsList }) } From f8af5ce7a4c75121fe775fae8f33ce210bf0288c Mon Sep 17 00:00:00 2001 From: abetomo Date: Thu, 14 Dec 2017 11:08:09 +0900 Subject: [PATCH 3/4] Remove unnecessary resolve --- lib/main.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/main.js b/lib/main.js index 6f3678c6..2d33395f 100644 --- a/lib/main.js +++ b/lib/main.js @@ -842,7 +842,7 @@ so you can easily test run multiple events. params.FunctionName ) ]).then((results) => { - resolve(results) + return results }) }) }).catch(() => { @@ -874,7 +874,7 @@ so you can easily test run multiple events. params.FunctionName ) ]).then((results) => { - resolve(results) + return results }) }) }) From 4199c2e8945ca361d082c6cbcb8536b74e3ced8a Mon Sep 17 00:00:00 2001 From: abetomo Date: Thu, 14 Dec 2017 11:08:30 +0900 Subject: [PATCH 4/4] Modify to Promise.resolve --- lib/main.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/main.js b/lib/main.js index 2d33395f..831ec186 100644 --- a/lib/main.js +++ b/lib/main.js @@ -769,7 +769,7 @@ so you can easily test run multiple events. console.log('=> Reading event source file to memory') const eventSourceList = this._eventSourceList(program) - return new Promise((resolve, reject) => { + return Promise.resolve().then(() => { console.log('=> Uploading zip file to AWS Lambda ' + region + ' with parameters:') console.log(params)