From 3819a97ff154f2b6f19a8f692cde9c305d8fcfd8 Mon Sep 17 00:00:00 2001 From: mroczect Date: Thu, 20 Aug 2026 20:32:21 +0700 Subject: [PATCH 1/3] test(handler): fix empty slice assertion --- libvctrl_handler/tests/blob.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libvctrl_handler/tests/blob.rs b/libvctrl_handler/tests/blob.rs index c4bd4e4..bfe66d4 100644 --- a/libvctrl_handler/tests/blob.rs +++ b/libvctrl_handler/tests/blob.rs @@ -5,9 +5,10 @@ mod common; #[test] fn test_blob_valid_empty() { let blob = common::ok(Blob::new(Vec::new())); + let empty: &[u8] = &[]; assert!(blob.is_empty()); assert_eq!(blob.size(), 0); - assert_eq!(blob.data(), &[] as &[u8]); + assert_eq!(blob.data(), empty); } #[test] From ad2587cc471d05e862c1a2340bde00fedd209583 Mon Sep 17 00:00:00 2001 From: mroczect Date: Thu, 20 Aug 2026 20:32:21 +0700 Subject: [PATCH 2/3] test(handler): make test helpers public and add lint attributes --- libvctrl_handler/tests/common/mod.rs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libvctrl_handler/tests/common/mod.rs b/libvctrl_handler/tests/common/mod.rs index bbd3878..2ad43f8 100644 --- a/libvctrl_handler/tests/common/mod.rs +++ b/libvctrl_handler/tests/common/mod.rs @@ -1,13 +1,15 @@ -#[allow(dead_code, clippy::panic)] -pub(crate) fn ok(result: Result) -> T { +#![allow(unreachable_pub)] +#![allow(dead_code)] +#![allow(clippy::panic)] + +pub fn ok(result: Result) -> T { match result { Ok(value) => value, Err(err) => panic!("expected Ok(..), got Err({err:?})"), } } -#[allow(dead_code, clippy::panic)] -pub(crate) fn err(result: Result) -> E { +pub fn err(result: Result) -> E { match result { Ok(value) => panic!("expected Err(..), got Ok({value:?})"), Err(err) => err, From 3f17ffeb148a31c80e6eb6299d05edbbb4433569 Mon Sep 17 00:00:00 2001 From: mroczect Date: Thu, 20 Aug 2026 20:32:21 +0700 Subject: [PATCH 3/3] test(handler): use first() instead of get(0) --- libvctrl_handler/tests/tree.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvctrl_handler/tests/tree.rs b/libvctrl_handler/tests/tree.rs index a17a90e..4661f9c 100644 --- a/libvctrl_handler/tests/tree.rs +++ b/libvctrl_handler/tests/tree.rs @@ -44,7 +44,7 @@ fn test_tree_new_sorts_entries() { let tree = common::ok(Tree::new(vec![e1, e2])); assert_eq!(tree.len(), 2); - assert_eq!(tree.entries().get(0).map(TreeEntry::name), Some("a")); + assert_eq!(tree.entries().first().map(TreeEntry::name), Some("a")); assert_eq!(tree.entries().get(1).map(TreeEntry::name), Some("b")); }