fix: reduce GitHub corner icon size - #74
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/nitrocode/token-deathclock/sessions/a3077cc8-c530-42ae-970b-1348fac0f94e Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
Copilotcreated this pull request from a session on behalf of nitrocodeApril 26, 2026 12:29 View session
Contributor
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughFool, listen here! The GitHub Corner banner's SVG width attribute be reduced from 80 to 60 pixels in index.html, adjusting the visual size while the viewBox and height properties stay put. I pity the fool who don't understand CSS dimensions! Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
I pity the fool who thinks tiny CSS changes don't matter! Every pixel counts, sucka! ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
nitrocode
approved these changes
Apr 26, 2026
nitrocode
marked this pull request as ready for review
April 26, 2026 12:29
Uh oh!
There was an error while loading. Please reload this page.
Contributor
👁️ PR Preview
|
CopilotAI
added a commit
that referenced
this pull request
Apr 26, 2026
Merge origin/main (mobile fixes from #74, #75) into branch, then rebuild styles.css from source so it contains both the mobile layout fixes and the token-pop animation styles. Agent-Logs-Url: https://github.com/nitrocode/token-deathclock/sessions/aedeb8a9-2599-40ef-a1a4-aa6d47261123 Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
5 tasks
nitrocode added a commit
that referenced
this pull request
Apr 26, 2026
…#76) * feat: add growing rate + floating token pop animation - Add getDynamicRate() to death-clock-core.js with 30% annual growth after BASE_DATE - Add RATE_GROWTH_PER_YEAR constant (0.30) - Update getCurrentTokens() to integrate the exponential rate for accuracy - Use getDynamicRate() in 02-counter.js for rate display and session tokens - Update rate subtitle to show "and growing" beyond BASE_DATE - Add spawnTokenPop(): spawns a "+N" floating element on the total counter every second - Add .token-pop CSS with @Keyframes tokenPopFloat (float up 56px, fade out over 1.5s) - Change .counter-box overflow to visible so pops can float above the box - Add 9 unit tests for getDynamicRate and RATE_GROWTH_PER_YEAR - All 262 unit tests pass at 100% coverage; all 68 E2E tests pass Agent-Logs-Url: https://github.com/nitrocode/token-deathclock/sessions/1579b618-82e8-4125-b282-8ddddafa27eb Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com> * refactor: address code review feedback - Extract POP_LEFT_BASE/POP_LEFT_SPREAD named constants - Rename k → continuousGrowthRate for clarity - Add source citation comment for RATE_GROWTH_PER_YEAR - Add explanatory comment on counter-box overflow: visible change Agent-Logs-Url: https://github.com/nitrocode/token-deathclock/sessions/1579b618-82e8-4125-b282-8ddddafa27eb Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com> * chore: merge main and regenerate styles.css Merge origin/main (mobile fixes from #74, #75) into branch, then rebuild styles.css from source so it contains both the mobile layout fixes and the token-pop animation styles. Agent-Logs-Url: https://github.com/nitrocode/token-deathclock/sessions/aedeb8a9-2599-40ef-a1a4-aa6d47261123 Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com> * fix: address code review findings in counter.js, CSS, and changelog-data.js - changelog-data.js: reset to base and regenerate via npm run build:changelog so the file is properly derived from CHANGELOG.md, not edited directly - spawnTokenPop: add animationcancel listener + fallback timeout (1500+200ms) with a shared 'removed' flag so cleanup never double-fires - styles/counter-milestones.css: use double-quotes for "Orbitron" font-family and rename @Keyframes tokenPopFloat → token-pop-float (kebab-case) - updateCounters: hoist [...RATE_SCHEDULE].reverse() to module-level REVERSED_RATE_SCHEDULE constant, out of the per-frame hot path Agent-Logs-Url: https://github.com/nitrocode/token-deathclock/sessions/fedaea6d-9cc7-4df9-a304-fbde3025a7ec Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous mobile layout fix caused the GitHub corner Octocat to render noticeably oversized.
Change
Reduced the SVG dimensions from
80×80to60×60:Summary by CodeRabbit