Uh oh!
There was an error while loading. Please reload this page.
fix: Incorrect authorization prefix for basic auth, and undocumented env var - #454
Merged
Merged
Conversation
plumpNationforce-pushed
the
incorrect-authorization-type
branch
from
April 11, 2024 15:30
780acec to
11419a2CompareplumpNation
marked this pull request as ready for review
April 11, 2024 15:39
plumpNationforce-pushed
the
incorrect-authorization-type
branch
from
April 12, 2024 10:02
0cabeae to
78ae0edCompareaduh95
reviewed
Apr 12, 2024
Uh oh!
There was an error while loading. Please reload this page.
plumpNationforce-pushed
the
incorrect-authorization-type
branch
from
April 12, 2024 10:28
78ae0ed to
a6cfd0fCompareThe location of the registry should be validated against the input.origin. With the current code, it simply checks to see if DEFAULT_NPM_REGISTRY_URL exists. I made the registries into an array to make a regression less likely.
aduh95
reviewed
Apr 12, 2024
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes auth type header strings to use
Basicprefix for base64 encoded username:password.In addition, it seems like an undocumented env var
COREPACK_NPM_USERis being used in tests, meaning that this value will beundefinedand the user will always get a 401 as the documented env var isCOREPACK_NPM_USERNAME.This bit me when I was using a test to help debug why my COREPACK_NPM_REGISTRY was being ignored when running
yarn --versionin real life.