Uh oh!
There was an error while loading. Please reload this page.
process: resize stderr on SIGWINCH - #2231
Conversation
cjihrig
commented
Jul 23, 2015
LGTM. I'd say it's definitely a bug fix. |
bnoordhuis
commented
Jul 23, 2015
LGTM and I agree with @cjihrig. |
thefourtheye
commented
Jul 23, 2015
LGTMT |
There was a problem hiding this comment.
I'm not sure but it looks like this will fail if _refreshSize needs to access this
Edit: that would explain why it was wrapped in a function.
There was a problem hiding this comment.
Isn't this referring to the stream though? i.e. the stdout or stderr objects?
There was a problem hiding this comment.
@Fishrock123 You might have to bind. stdout._refreshSize.bind(stdout)
EDIT: The actual definition https://github.com/nodejs/io.js/blob/master/lib/tty.js#L76-92 uses this.
There was a problem hiding this comment.
it is supposed to, but in this case you are passing the method to the event emitter, without its context.
Result is the same as:
varobj={method(){console.log(this)}};obj.method();// objvarmethod=obj.method;method();// undefinedThere was a problem hiding this comment.
Doh. Right. Javascript.
e35c4a4 to
1b381e2CompareFishrock123
commented
Jul 23, 2015
@targos fixed, PTAL |
targos
commented
Jul 23, 2015
LGTM |
Fixes: nodejs#2219 PR-URL: nodejs#2231 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Fixes: #2219
I'd consider this a patch level thing, but it could possibly be considered semver-minor; does anyone have opinions about that?