Skip to content

fix: mark external memory and version APIs as basic - #1597

Merged
legendecas merged 1 commit into
nodejs:mainfrom
legendecas:basic-env-apis
Oct 25, 2024
Merged

fix: mark external memory and version APIs as basic#1597
legendecas merged 1 commit into
nodejs:mainfrom
legendecas:basic-env-apis

Conversation

@legendecas

Copy link
Copy Markdown
Member

Fixes#1594

@codecov-commenter

codecov-commenter commented Oct 21, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.40%. Comparing base (ae2c23e) to head (7ab86a2).
⚠️ Report is 40 commits behind head on main.

Files with missing linesPatch %Lines
napi-inl.h50.00%0 Missing and 3 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1597 +/- ##
==========================================
+ Coverage 64.42% 66.40% +1.97% 
==========================================
Files 3 3 Lines 2010 2143 +133 Branches 699 702 +3 ==========================================
+ Hits 1295 1423 +128 - Misses 147 150 +3 - Partials 568 570 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NickNasoNickNaso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legendecas

Copy link
Copy Markdown
MemberAuthor

Thanks for pointing it out, updated!

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas
legendecas merged commit 78da4fa into nodejs:mainOct 25, 2024
@legendecas
legendecas deleted the basic-env-apis branch October 25, 2024 19:07
@github-actionsgithub-actionsBot mentioned this pull request Oct 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Should AdjustExternalMemory take a BasicEnv?

4 participants

@legendecas@codecov-commenter@NickNaso@mhdawson