Uh oh!
There was an error while loading. Please reload this page.
feat(git-node): add support for the --gpg-sign git flag - #684
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@## main #684 +/- ##
=======================================
Coverage 83.45% 83.45% =======================================
Files 37 37 Lines 4158 4158 =======================================
Hits 3470 3470 Misses 688 688 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
aduh95
commented
Mar 18, 2023
ping @nodejs/node-core-utils |
I personally set this in my git config. What's the advantage of this flag compared to it ? |
aduh95
commented
Mar 18, 2023
The flag let's you select a specific keyid to sign the commit with. |
In the git config you can set ˋuser.signingkey` with the key id |
aduh95
commented
Mar 18, 2023
If you have set a specific key id in your git config, the flag lets you specify a different one. |
targos
commented
Mar 18, 2023
I still don't understand the use case. Don't you always use the same key for the node repo? |
aduh95
commented
Mar 18, 2023
No, I usually don't sign my commits for the node repo (why would I, the CQ would sign them for me), but in the rare cases when I need to push manually to |
I've also extended the max line length from 80 to 100 as it was making less readable to keep it at 80 IMO.