Skip to content

feat: request cve automatically - #777

Merged
RafaelGSS merged 12 commits into
nodejs:mainfrom
marco-ippolito:feat/automate-cve-creation
Apr 4, 2024
Merged

feat: request cve automatically#777
RafaelGSS merged 12 commits into
nodejs:mainfrom
marco-ippolito:feat/automate-cve-creation

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented Mar 8, 2024

Copy link
Copy Markdown
Member

the command git-node security --request-cve
will read the vulnerabilities.json and request a cve for each report, if does not find the severity in the report will try to fetch it from hackerone, we can probably make the json path optional and try to read it from the standard location

@marco-ippolito
marco-ippolitoforce-pushed the feat/automate-cve-creation branch 2 times, most recently from 0e74e96 to 2cf417bCompareMarch 8, 2024 09:55
@codecov

codecovBot commented Mar 8, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.97%. Comparing base (59526a8) to head (a9505eb).

Additional details and impacted files
@@ Coverage Diff @@## main #777 +/- ##
=======================================
Coverage 82.97% 82.97% =======================================
Files 37 37 Lines 4200 4200 =======================================
Hits 3485 3485 Misses 715 715 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marco-ippolito
marco-ippolitoforce-pushed the feat/automate-cve-creation branch 2 times, most recently from 4f7ae71 to 4dd90a2CompareMarch 8, 2024 13:57
@marco-ippolito

Copy link
Copy Markdown
MemberAuthor

cc @RafaelGSS

Comment threadcomponents/git/security.js Outdated
@marco-ippolito
marco-ippolitoforce-pushed the feat/automate-cve-creation branch 2 times, most recently from ae94214 to 10b3680CompareMarch 20, 2024 14:43
Comment threadcomponents/git/security.js Outdated
@marco-ippolito

Copy link
Copy Markdown
MemberAuthor

this needs to land before: #780

@marco-ippolito
marco-ippolitoforce-pushed the feat/automate-cve-creation branch 3 times, most recently from 47a5e7e to 6c9e091CompareMarch 26, 2024 08:01
@marco-ippolito
marco-ippolito marked this pull request as ready for review March 27, 2024 11:47
Comment threadcomponents/git/security.js Outdated
Comment threadcomponents/git/security.js Outdated
Comment threadlib/h1-cve.js Outdated
Comment threadlib/h1-cve.js Outdated
Comment threadlib/h1-cve.js Outdated
Comment threadlib/h1-cve.js Outdated
Comment threadlib/h1-cve.js Outdated
Comment threadlib/h1-cve.js Outdated
@marco-ippolito
marco-ippolitoforce-pushed the feat/automate-cve-creation branch 2 times, most recently from aee7183 to 70b871cCompareApril 1, 2024 13:53
@marco-ippolito

Copy link
Copy Markdown
MemberAuthor

reminder to remove createdAt and always set cve creation as today

@RafaelGSS

Copy link
Copy Markdown
Member

@marco-ippolito would you mind creating a list of tasks remaining for this PR?

  • createdAt
  • ...

@marco-ippolito
marco-ippolitoforce-pushed the feat/automate-cve-creation branch from 70b871c to 2c7a4cfCompareApril 4, 2024 08:32
@marco-ippolito
marco-ippolitoforce-pushed the feat/automate-cve-creation branch from 2c7a4cf to be3e9e8CompareApril 4, 2024 08:38
@RafaelGSS
RafaelGSS merged commit 8a04848 into nodejs:mainApr 4, 2024
@github-actionsgithub-actionsBot mentioned this pull request Apr 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@marco-ippolito@RafaelGSS