Uh oh!
There was an error while loading. Please reload this page.
feat: add releaseDate to json - #796
Merged
RafaelGSS merged 2 commits intoApr 18, 2024
Merged
Conversation
RafaelGSS
approved these changes
Apr 16, 2024
RafaelGSS
left a comment
Member
There was a problem hiding this comment.
actually, we need to check if a valid date is given, if not it should leave it empty. For instance, TBD.
MemberAuthor
if invalid date is given it will throw right now |
marco-ippolitoforce-pushed
the
feat/add-release-date-to-json
branch
from
April 16, 2024 16:40
63e4d62 to
28a6129CompareRafaelGSS
commented
Apr 16, 2024
Member
But, what if we don't have a target date? I would like to pass TBD |
marco-ippolito
commented
Apr 18, 2024
MemberAuthor
ok so I'll validate only if different from 'TBD' |
RafaelGSS
approved these changes
Apr 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/nodejs-private/security-release/issues/23
@RafaelGSS