Commit 7535e44

Browse files
rodrigcrvagg
authored andcommitted
gyp: replace deprecated functions
* assertEquals() with assertEqual() * iteritems() with items() for Python 3. * xrange() with range() for Python 3. #1150 Reviewed-By: Refael Ackermann <refack@gmail.com>
1 parent 2040cd2 commit 7535e44

22 files changed

Lines changed: 129 additions & 130 deletions

‎gyp/PRESUBMIT.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@
7676
def_LicenseHeader(input_api):
7777
# Accept any year number from 2009 to the current year.
7878
current_year=int(input_api.time.strftime('%Y'))
79-
allowed_years= (str(s) forsinreversed(xrange(2009, current_year+1)))
80-
79+
allowed_years= (str(s) forsinreversed(range(2009, current_year+1)))
8180
years_re='('+'|'.join(allowed_years) +')'
8281

8382
# The (c) is deprecated, but tolerate it until it's removed from all files.

‎gyp/pylib/gyp/MSVSSettings.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ def ConvertVCMacrosToMSBuild(s):
435435
'$(PlatformName)': '$(Platform)',
436436
'$(SafeInputName)': '%(Filename)',
437437
}
438-
forold, newinreplace_map.iteritems():
438+
forold, newinreplace_map.items():
439439
s=s.replace(old, new)
440440
s=FixVCMacroSlashes(s)
441441
returns
@@ -455,10 +455,10 @@ def ConvertToMSBuildSettings(msvs_settings, stderr=sys.stderr):
455455
dictionaries of settings and their values.
456456
"""
457457
msbuild_settings= {}
458-
formsvs_tool_name, msvs_tool_settingsinmsvs_settings.iteritems():
458+
formsvs_tool_name, msvs_tool_settingsinmsvs_settings.items():
459459
ifmsvs_tool_namein_msvs_to_msbuild_converters:
460460
msvs_tool=_msvs_to_msbuild_converters[msvs_tool_name]
461-
formsvs_setting, msvs_valueinmsvs_tool_settings.iteritems():
461+
formsvs_setting, msvs_valueinmsvs_tool_settings.items():
462462
ifmsvs_settinginmsvs_tool:
463463
# Invoke the translation function.
464464
try:
@@ -515,7 +515,7 @@ def _ValidateSettings(validators, settings, stderr):
515515
fortool_nameinsettings:
516516
iftool_nameinvalidators:
517517
tool_validators=validators[tool_name]
518-
forsetting, valueinsettings[tool_name].iteritems():
518+
forsetting, valueinsettings[tool_name].items():
519519
ifsettingintool_validators:
520520
try:
521521
tool_validators[setting](value)

‎gyp/pylib/gyp/MSVSUserFile.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def AddDebugSettings(self, config_name, command, environment = {},
9191

9292
ifenvironmentandisinstance(environment, dict):
9393
env_list= ['%s="%s"'% (key, val)
94-
for (key,val) inenvironment.iteritems()]
94+
for (key,val) inenvironment.items()]
9595
environment=' '.join(env_list)
9696
else:
9797
environment=''
@@ -135,7 +135,7 @@ def AddDebugSettings(self, config_name, command, environment = {},
135135
defWriteIfChanged(self):
136136
"""Writes the user file."""
137137
configs= ['Configurations']
138-
forconfig, specinsorted(self.configurations.iteritems()):
138+
forconfig, specinsorted(self.configurations.items()):
139139
configs.append(spec)
140140

141141
content= ['VisualStudioUserFile',

‎gyp/pylib/gyp/MSVSUtil.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ def InsertLargePdbShims(target_list, target_dicts, vars):
235235

236236
# Set up the shim to output its PDB to the same location as the final linker
237237
# target.
238-
forconfig_name, configinshim_dict.get('configurations').iteritems():
238+
forconfig_name, configinshim_dict.get('configurations').items():
239239
pdb_path=_GetPdbPath(target_dict, config_name, vars)
240240

241241
# A few keys that we don't want to propagate.

‎gyp/pylib/gyp/__init__.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def Noop(value):
209209
# We always want to ignore the environment when regenerating, to avoid
210210
# duplicate or changed flags in the environment at the time of regeneration.
211211
flags= ['--ignore-environment']
212-
forname, metadatainoptions._regeneration_metadata.iteritems():
212+
forname, metadatainoptions._regeneration_metadata.items():
213213
opt=metadata['opt']
214214
value=getattr(options, name)
215215
value_predicate=metadata['type'] =='path'andFixPathorNoop
@@ -434,7 +434,7 @@ def gyp_main(args):
434434
build_file_dir=os.path.abspath(os.path.dirname(build_file))
435435
build_file_dir_components=build_file_dir.split(os.path.sep)
436436
components_len=len(build_file_dir_components)
437-
forindexinxrange(components_len-1, -1, -1):
437+
forindexinrange(components_len-1, -1, -1):
438438
ifbuild_file_dir_components[index] =='src':
439439
options.depth=os.path.sep.join(build_file_dir_components)
440440
break

‎gyp/pylib/gyp/easy_xml.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def _ConstructContentList(xml_parts, specification, pretty, level=0):
8181
# Optionally in second position is a dictionary of the attributes.
8282
rest=specification[1:]
8383
ifrestandisinstance(rest[0], dict):
84-
forat, valinsorted(rest[0].iteritems()):
84+
forat, valinsorted(rest[0].items()):
8585
xml_parts.append(' %s="%s"'% (at, _XmlEscape(val, attr=True)))
8686
rest=rest[1:]
8787
ifrest:

‎gyp/pylib/gyp/generator/android.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ def WriteSourceFlags(self, spec, configs):
460460
Args:
461461
spec, configs: input from gyp.
462462
"""
463-
forconfigname, configinsorted(configs.iteritems()):
463+
forconfigname, configinsorted(configs.items()):
464464
extracted_includes= []
465465

466466
self.WriteLn('\n# Flags passed to both C and C++ files.')
@@ -790,7 +790,7 @@ def WriteTargetFlags(self, spec, configs, link_deps):
790790
static_libs, dynamic_libs, ldflags_libs=self.FilterLibraries(libraries)
791791

792792
ifself.type!='static_library':
793-
forconfigname, configinsorted(configs.iteritems()):
793+
forconfigname, configinsorted(configs.items()):
794794
ldflags=list(config.get('ldflags', []))
795795
self.WriteLn('')
796796
self.WriteList(ldflags, 'LOCAL_LDFLAGS_%s'%configname)
@@ -839,7 +839,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, part_of_all,
839839
settings=spec.get('aosp_build_settings', {})
840840
ifsettings:
841841
self.WriteLn('### Set directly by aosp_build_settings.')
842-
fork, vinsettings.iteritems():
842+
fork, vinsettings.items():
843843
ifisinstance(v, list):
844844
self.WriteList(v, k)
845845
else:

‎gyp/pylib/gyp/generator/gypd.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
8888
ifnotoutput_fileinoutput_files:
8989
output_files[output_file] =input_file
9090

91-
foroutput_file, input_fileinoutput_files.iteritems():
91+
foroutput_file, input_fileinoutput_files.items():
9292
output=open(output_file, 'w')
9393
pprint.pprint(data[input_file], output)
9494
output.close()

‎gyp/pylib/gyp/generator/make.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -674,7 +674,7 @@ def _ValidateSourcesForOSX(spec, all_sources):
674674
basenames.setdefault(basename, []).append(source)
675675

676676
error=''
677-
forbasename, filesinbasenames.iteritems():
677+
forbasename, filesinbasenames.items():
678678
iflen(files) >1:
679679
error+=' %s: %s\n'% (basename, ' '.join(files))
680680

@@ -1547,7 +1547,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, bundle_deps,
15471547
# Postbuilds expect to be run in the gyp file's directory, so insert an
15481548
# implicit postbuild to cd to there.
15491549
postbuilds.insert(0, gyp.common.EncodePOSIXShellList(['cd', self.path]))
1550-
foriinxrange(len(postbuilds)):
1550+
foriinrange(len(postbuilds)):
15511551
ifnotpostbuilds[i].startswith('$'):
15521552
postbuilds[i] =EscapeShellArgument(postbuilds[i])
15531553
self.WriteLn('%s: builddir := $(abs_builddir)'%QuoteSpaces(self.output))

‎gyp/pylib/gyp/generator/msvs.py‎

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ def _AddCustomBuildToolForMSVS(p, spec, primary_input,
451451
'CommandLine': cmd,
452452
})
453453
# Add to the properties of primary input for each config.
454-
forconfig_name, c_datainspec['configurations'].iteritems():
454+
forconfig_name, c_datainspec['configurations'].items():
455455
p.AddFileConfig(_FixPath(primary_input),
456456
_ConfigFullName(config_name, c_data), tools=[tool])
457457

@@ -971,7 +971,7 @@ def _ValidateSourcesForMSVSProject(spec, version):
971971
basenames.setdefault(basename, []).append(source)
972972

973973
error=''
974-
forbasename, filesinbasenames.iteritems():
974+
forbasename, filesinbasenames.items():
975975
iflen(files) >1:
976976
error+=' %s: %s\n'% (basename, ' '.join(files))
977977

@@ -1003,7 +1003,7 @@ def _GenerateMSVSProject(project, options, version, generator_flags):
10031003
relative_path_of_gyp_file=gyp.common.RelativePath(gyp_path, project_dir)
10041004

10051005
config_type=_GetMSVSConfigurationType(spec, project.build_file)
1006-
forconfig_name, configinspec['configurations'].iteritems():
1006+
forconfig_name, configinspec['configurations'].items():
10071007
_AddConfigurationToMSVSProject(p, spec, config_type, config_name, config)
10081008

10091009
# MSVC08 and prior version cannot handle duplicate basenames in the same
@@ -1369,10 +1369,10 @@ def _ConvertToolsToExpectedForm(tools):
13691369
A list of Tool objects.
13701370
"""
13711371
tool_list= []
1372-
fortool, settingsintools.iteritems():
1372+
fortool, settingsintools.items():
13731373
# Collapse settings with lists.
13741374
settings_fixed= {}
1375-
forsetting, valueinsettings.iteritems():
1375+
forsetting, valueinsettings.items():
13761376
iftype(value) ==list:
13771377
if ((tool=='VCLinkerTool'and
13781378
setting=='AdditionalDependencies') or
@@ -1547,7 +1547,7 @@ def _IdlFilesHandledNonNatively(spec, sources):
15471547
def_GetPrecompileRelatedFiles(spec):
15481548
# Gather a list of precompiled header related sources.
15491549
precompiled_related= []
1550-
for_, configinspec['configurations'].iteritems():
1550+
for_, configinspec['configurations'].items():
15511551
forkinprecomp_keys:
15521552
f=config.get(k)
15531553
iff:
@@ -1558,7 +1558,7 @@ def _GetPrecompileRelatedFiles(spec):
15581558
def_ExcludeFilesFromBeingBuilt(p, spec, excluded_sources, excluded_idl,
15591559
list_excluded):
15601560
exclusions=_GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl)
1561-
forfile_name, excluded_configsinexclusions.iteritems():
1561+
forfile_name, excluded_configsinexclusions.items():
15621562
if (notlist_excludedand
15631563
len(excluded_configs) ==len(spec['configurations'])):
15641564
# If we're not listing excluded files, then they won't appear in the
@@ -1575,7 +1575,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15751575
# Exclude excluded sources from being built.
15761576
forfinexcluded_sources:
15771577
excluded_configs= []
1578-
forconfig_name, configinspec['configurations'].iteritems():
1578+
forconfig_name, configinspec['configurations'].items():
15791579
precomped= [_FixPath(config.get(i, '')) foriinprecomp_keys]
15801580
# Don't do this for ones that are precompiled header related.
15811581
iffnotinprecomped:
@@ -1585,7 +1585,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15851585
# Exclude them now.
15861586
forfinexcluded_idl:
15871587
excluded_configs= []
1588-
forconfig_name, configinspec['configurations'].iteritems():
1588+
forconfig_name, configinspec['configurations'].items():
15891589
excluded_configs.append((config_name, config))
15901590
exclusions[f] =excluded_configs
15911591
returnexclusions
@@ -1594,7 +1594,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15941594
def_AddToolFilesToMSVS(p, spec):
15951595
# Add in tool files (rules).
15961596
tool_files=OrderedSet()
1597-
for_, configinspec['configurations'].iteritems():
1597+
for_, configinspec['configurations'].items():
15981598
forfinconfig.get('msvs_tool_files', []):
15991599
tool_files.add(f)
16001600
forfintool_files:
@@ -1607,7 +1607,7 @@ def _HandlePreCompiledHeaders(p, sources, spec):
16071607
# kind (i.e. C vs. C++) as the precompiled header source stub needs
16081608
# to have use of precompiled headers disabled.
16091609
extensions_excluded_from_precompile= []
1610-
forconfig_name, configinspec['configurations'].iteritems():
1610+
forconfig_name, configinspec['configurations'].items():
16111611
source=config.get('msvs_precompiled_source')
16121612
ifsource:
16131613
source=_FixPath(source)
@@ -1628,7 +1628,7 @@ def DisableForSourceTree(source_tree):
16281628
else:
16291629
basename, extension=os.path.splitext(source)
16301630
ifextensioninextensions_excluded_from_precompile:
1631-
forconfig_name, configinspec['configurations'].iteritems():
1631+
forconfig_name, configinspec['configurations'].items():
16321632
tool=MSVSProject.Tool('VCCLCompilerTool',
16331633
{'UsePrecompiledHeader': '0',
16341634
'ForcedIncludeFiles': '$(NOINHERIT)'})
@@ -1679,7 +1679,7 @@ def _WriteMSVSUserFile(project_path, version, spec):
16791679
return# Nothing to add
16801680
# Write out the user file.
16811681
user_file=_CreateMSVSUserFile(project_path, version, spec)
1682-
forconfig_name, c_datainspec['configurations'].iteritems():
1682+
forconfig_name, c_datainspec['configurations'].items():
16831683
user_file.AddDebugSettings(_ConfigFullName(config_name, c_data),
16841684
action, environment, working_directory)
16851685
user_file.WriteIfChanged()
@@ -1730,7 +1730,7 @@ def _GetPathDict(root, path):
17301730
def_DictsToFolders(base_path, bucket, flat):
17311731
# Convert to folders recursively.
17321732
children= []
1733-
forfolder, contentsinbucket.iteritems():
1733+
forfolder, contentsinbucket.items():
17341734
iftype(contents) ==dict:
17351735
folder_children=_DictsToFolders(os.path.join(base_path, folder),
17361736
contents, flat)
@@ -1802,7 +1802,7 @@ def _GetPlatformOverridesOfProject(spec):
18021802
# Prepare a dict indicating which project configurations are used for which
18031803
# solution configurations for this target.
18041804
config_platform_overrides= {}
1805-
forconfig_name, cinspec['configurations'].iteritems():
1805+
forconfig_name, cinspec['configurations'].items():
18061806
config_fullname=_ConfigFullName(config_name, c)
18071807
platform=c.get('msvs_target_platform', _ConfigPlatform(c))
18081808
fixed_config_fullname='%s|%s'% (
@@ -1941,7 +1941,7 @@ def PerformBuild(data, configurations, params):
19411941
msvs_version=params['msvs_version']
19421942
devenv=os.path.join(msvs_version.path, 'Common7', 'IDE', 'devenv.com')
19431943

1944-
forbuild_file, build_file_dictindata.iteritems():
1944+
forbuild_file, build_file_dictindata.items():
19451945
(build_file_root, build_file_ext) =os.path.splitext(build_file)
19461946
ifbuild_file_ext!='.gyp':
19471947
continue
@@ -1990,7 +1990,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
19901990
configs=set()
19911991
forqualified_targetintarget_list:
19921992
spec=target_dicts[qualified_target]
1993-
forconfig_name, configinspec['configurations'].iteritems():
1993+
forconfig_name, configinspec['configurations'].items():
19941994
configs.add(_ConfigFullName(config_name, config))
19951995
configs=list(configs)
19961996

@@ -2630,7 +2630,7 @@ def _GetConfigurationCondition(name, settings):
26302630

26312631
def_GetMSBuildProjectConfigurations(configurations):
26322632
group= ['ItemGroup', {'Label': 'ProjectConfigurations'}]
2633-
for (name, settings) insorted(configurations.iteritems()):
2633+
for (name, settings) insorted(configurations.items()):
26342634
configuration, platform=_GetConfigurationAndPlatform(name, settings)
26352635
designation='%s|%s'% (configuration, platform)
26362636
group.append(
@@ -2700,7 +2700,7 @@ def _GetMSBuildGlobalProperties(spec, guid, gyp_file_name):
27002700

27012701
def_GetMSBuildConfigurationDetails(spec, build_file):
27022702
properties= {}
2703-
forname, settingsinspec['configurations'].iteritems():
2703+
forname, settingsinspec['configurations'].items():
27042704
msbuild_attributes=_GetMSBuildAttributes(spec, settings, build_file)
27052705
condition=_GetConfigurationCondition(name, settings)
27062706
character_set=msbuild_attributes.get('CharacterSet')
@@ -2729,7 +2729,7 @@ def _GetMSBuildPropertySheets(configurations):
27292729
user_props=r'$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props'
27302730
additional_props= {}
27312731
props_specified=False
2732-
forname, settingsinsorted(configurations.iteritems()):
2732+
forname, settingsinsorted(configurations.items()):
27332733
configuration=_GetConfigurationCondition(name, settings)
27342734
if'msbuild_props'insettings:
27352735
additional_props[configuration] =_FixPaths(settings['msbuild_props'])
@@ -2751,7 +2751,7 @@ def _GetMSBuildPropertySheets(configurations):
27512751
]
27522752
else:
27532753
sheets= []
2754-
forcondition, propsinadditional_props.iteritems():
2754+
forcondition, propsinadditional_props.items():
27552755
import_group= [
27562756
'ImportGroup',
27572757
{'Label': 'PropertySheets',
@@ -2878,7 +2878,7 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
28782878
new_paths='$(ExecutablePath);'+';'.join(new_paths)
28792879

28802880
properties= {}
2881-
for (name, configuration) insorted(configurations.iteritems()):
2881+
for (name, configuration) insorted(configurations.items()):
28822882
condition=_GetConfigurationCondition(name, configuration)
28832883
attributes=_GetMSBuildAttributes(spec, configuration, build_file)
28842884
msbuild_settings=configuration['finalized_msbuild_settings']
@@ -2903,7 +2903,7 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
29032903
_AddConditionalProperty(properties, condition, 'ExecutablePath',
29042904
new_paths)
29052905
tool_settings=msbuild_settings.get('', {})
2906-
forname, valueinsorted(tool_settings.iteritems()):
2906+
forname, valueinsorted(tool_settings.items()):
29072907
formatted_value=_GetValueFormattedForMSBuild('', name, value)
29082908
_AddConditionalProperty(properties, condition, name, formatted_value)
29092909
return_GetMSBuildPropertyGroup(spec, None, properties)
@@ -2972,7 +2972,7 @@ def GetEdges(node):
29722972
# NOTE: reverse(topsort(DAG)) = topsort(reverse_edges(DAG))
29732973
fornameinreversed(properties_ordered):
29742974
values=properties[name]
2975-
forvalue, conditionsinsorted(values.iteritems()):
2975+
forvalue, conditionsinsorted(values.items()):
29762976
iflen(conditions) ==num_configurations:
29772977
# If the value is the same all configurations,
29782978
# just add one unconditional entry.
@@ -2985,18 +2985,18 @@ def GetEdges(node):
29852985

29862986
def_GetMSBuildToolSettingsSections(spec, configurations):
29872987
groups= []
2988-
for (name, configuration) insorted(configurations.iteritems()):
2988+
for (name, configuration) insorted(configurations.items()):
29892989
msbuild_settings=configuration['finalized_msbuild_settings']
29902990
group= ['ItemDefinitionGroup',
29912991
{'Condition': _GetConfigurationCondition(name, configuration)}
29922992
]
2993-
fortool_name, tool_settingsinsorted(msbuild_settings.iteritems()):
2993+
fortool_name, tool_settingsinsorted(msbuild_settings.items()):
29942994
# Skip the tool named '' which is a holder of global settings handled
29952995
# by _GetMSBuildConfigurationGlobalProperties.
29962996
iftool_name:
29972997
iftool_settings:
29982998
tool= [tool_name]
2999-
forname, valueinsorted(tool_settings.iteritems()):
2999+
forname, valueinsorted(tool_settings.items()):
30003000
formatted_value=_GetValueFormattedForMSBuild(tool_name, name,
30013001
value)
30023002
tool.append([name, formatted_value])
@@ -3196,7 +3196,7 @@ def _AddSources2(spec, sources, exclusions, grouped_sources,
31963196
{'Condition': condition},
31973197
'true'])
31983198
# Add precompile if needed
3199-
forconfig_name, configurationinspec['configurations'].iteritems():
3199+
forconfig_name, configurationinspec['configurations'].items():
32003200
precompiled_source=configuration.get('msvs_precompiled_source', '')
32013201
ifprecompiled_source!='':
32023202
precompiled_source=_FixPath(precompiled_source)
@@ -3436,7 +3436,7 @@ def _GenerateActionsForMSBuild(spec, actions_to_add):
34363436
"""
34373437
sources_handled_by_action=OrderedSet()
34383438
actions_spec= []
3439-
forprimary_input, actionsinactions_to_add.iteritems():
3439+
forprimary_input, actionsinactions_to_add.items():
34403440
inputs=OrderedSet()
34413441
outputs=OrderedSet()
34423442
descriptions= []

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Commit 7535e44

Browse files
rodrigcrvagg
authored andcommitted
gyp: replace deprecated functions
* assertEquals() with assertEqual() * iteritems() with items() for Python 3. * xrange() with range() for Python 3. #1150 Reviewed-By: Refael Ackermann <refack@gmail.com>
1 parent 2040cd2 commit 7535e44

22 files changed

Lines changed: 129 additions & 130 deletions

‎gyp/PRESUBMIT.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@
7676
def_LicenseHeader(input_api):
7777
# Accept any year number from 2009 to the current year.
7878
current_year=int(input_api.time.strftime('%Y'))
79-
allowed_years= (str(s) forsinreversed(xrange(2009, current_year+1)))
80-
79+
allowed_years= (str(s) forsinreversed(range(2009, current_year+1)))
8180
years_re='('+'|'.join(allowed_years) +')'
8281

8382
# The (c) is deprecated, but tolerate it until it's removed from all files.

‎gyp/pylib/gyp/MSVSSettings.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ def ConvertVCMacrosToMSBuild(s):
435435
'$(PlatformName)': '$(Platform)',
436436
'$(SafeInputName)': '%(Filename)',
437437
}
438-
forold, newinreplace_map.iteritems():
438+
forold, newinreplace_map.items():
439439
s=s.replace(old, new)
440440
s=FixVCMacroSlashes(s)
441441
returns
@@ -455,10 +455,10 @@ def ConvertToMSBuildSettings(msvs_settings, stderr=sys.stderr):
455455
dictionaries of settings and their values.
456456
"""
457457
msbuild_settings= {}
458-
formsvs_tool_name, msvs_tool_settingsinmsvs_settings.iteritems():
458+
formsvs_tool_name, msvs_tool_settingsinmsvs_settings.items():
459459
ifmsvs_tool_namein_msvs_to_msbuild_converters:
460460
msvs_tool=_msvs_to_msbuild_converters[msvs_tool_name]
461-
formsvs_setting, msvs_valueinmsvs_tool_settings.iteritems():
461+
formsvs_setting, msvs_valueinmsvs_tool_settings.items():
462462
ifmsvs_settinginmsvs_tool:
463463
# Invoke the translation function.
464464
try:
@@ -515,7 +515,7 @@ def _ValidateSettings(validators, settings, stderr):
515515
fortool_nameinsettings:
516516
iftool_nameinvalidators:
517517
tool_validators=validators[tool_name]
518-
forsetting, valueinsettings[tool_name].iteritems():
518+
forsetting, valueinsettings[tool_name].items():
519519
ifsettingintool_validators:
520520
try:
521521
tool_validators[setting](value)

‎gyp/pylib/gyp/MSVSUserFile.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def AddDebugSettings(self, config_name, command, environment = {},
9191

9292
ifenvironmentandisinstance(environment, dict):
9393
env_list= ['%s="%s"'% (key, val)
94-
for (key,val) inenvironment.iteritems()]
94+
for (key,val) inenvironment.items()]
9595
environment=' '.join(env_list)
9696
else:
9797
environment=''
@@ -135,7 +135,7 @@ def AddDebugSettings(self, config_name, command, environment = {},
135135
defWriteIfChanged(self):
136136
"""Writes the user file."""
137137
configs= ['Configurations']
138-
forconfig, specinsorted(self.configurations.iteritems()):
138+
forconfig, specinsorted(self.configurations.items()):
139139
configs.append(spec)
140140

141141
content= ['VisualStudioUserFile',

‎gyp/pylib/gyp/MSVSUtil.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ def InsertLargePdbShims(target_list, target_dicts, vars):
235235

236236
# Set up the shim to output its PDB to the same location as the final linker
237237
# target.
238-
forconfig_name, configinshim_dict.get('configurations').iteritems():
238+
forconfig_name, configinshim_dict.get('configurations').items():
239239
pdb_path=_GetPdbPath(target_dict, config_name, vars)
240240

241241
# A few keys that we don't want to propagate.

‎gyp/pylib/gyp/__init__.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def Noop(value):
209209
# We always want to ignore the environment when regenerating, to avoid
210210
# duplicate or changed flags in the environment at the time of regeneration.
211211
flags= ['--ignore-environment']
212-
forname, metadatainoptions._regeneration_metadata.iteritems():
212+
forname, metadatainoptions._regeneration_metadata.items():
213213
opt=metadata['opt']
214214
value=getattr(options, name)
215215
value_predicate=metadata['type'] =='path'andFixPathorNoop
@@ -434,7 +434,7 @@ def gyp_main(args):
434434
build_file_dir=os.path.abspath(os.path.dirname(build_file))
435435
build_file_dir_components=build_file_dir.split(os.path.sep)
436436
components_len=len(build_file_dir_components)
437-
forindexinxrange(components_len-1, -1, -1):
437+
forindexinrange(components_len-1, -1, -1):
438438
ifbuild_file_dir_components[index] =='src':
439439
options.depth=os.path.sep.join(build_file_dir_components)
440440
break

‎gyp/pylib/gyp/easy_xml.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def _ConstructContentList(xml_parts, specification, pretty, level=0):
8181
# Optionally in second position is a dictionary of the attributes.
8282
rest=specification[1:]
8383
ifrestandisinstance(rest[0], dict):
84-
forat, valinsorted(rest[0].iteritems()):
84+
forat, valinsorted(rest[0].items()):
8585
xml_parts.append(' %s="%s"'% (at, _XmlEscape(val, attr=True)))
8686
rest=rest[1:]
8787
ifrest:

‎gyp/pylib/gyp/generator/android.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ def WriteSourceFlags(self, spec, configs):
460460
Args:
461461
spec, configs: input from gyp.
462462
"""
463-
forconfigname, configinsorted(configs.iteritems()):
463+
forconfigname, configinsorted(configs.items()):
464464
extracted_includes= []
465465

466466
self.WriteLn('\n# Flags passed to both C and C++ files.')
@@ -790,7 +790,7 @@ def WriteTargetFlags(self, spec, configs, link_deps):
790790
static_libs, dynamic_libs, ldflags_libs=self.FilterLibraries(libraries)
791791

792792
ifself.type!='static_library':
793-
forconfigname, configinsorted(configs.iteritems()):
793+
forconfigname, configinsorted(configs.items()):
794794
ldflags=list(config.get('ldflags', []))
795795
self.WriteLn('')
796796
self.WriteList(ldflags, 'LOCAL_LDFLAGS_%s'%configname)
@@ -839,7 +839,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, part_of_all,
839839
settings=spec.get('aosp_build_settings', {})
840840
ifsettings:
841841
self.WriteLn('### Set directly by aosp_build_settings.')
842-
fork, vinsettings.iteritems():
842+
fork, vinsettings.items():
843843
ifisinstance(v, list):
844844
self.WriteList(v, k)
845845
else:

‎gyp/pylib/gyp/generator/gypd.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
8888
ifnotoutput_fileinoutput_files:
8989
output_files[output_file] =input_file
9090

91-
foroutput_file, input_fileinoutput_files.iteritems():
91+
foroutput_file, input_fileinoutput_files.items():
9292
output=open(output_file, 'w')
9393
pprint.pprint(data[input_file], output)
9494
output.close()

‎gyp/pylib/gyp/generator/make.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -674,7 +674,7 @@ def _ValidateSourcesForOSX(spec, all_sources):
674674
basenames.setdefault(basename, []).append(source)
675675

676676
error=''
677-
forbasename, filesinbasenames.iteritems():
677+
forbasename, filesinbasenames.items():
678678
iflen(files) >1:
679679
error+=' %s: %s\n'% (basename, ' '.join(files))
680680

@@ -1547,7 +1547,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, bundle_deps,
15471547
# Postbuilds expect to be run in the gyp file's directory, so insert an
15481548
# implicit postbuild to cd to there.
15491549
postbuilds.insert(0, gyp.common.EncodePOSIXShellList(['cd', self.path]))
1550-
foriinxrange(len(postbuilds)):
1550+
foriinrange(len(postbuilds)):
15511551
ifnotpostbuilds[i].startswith('$'):
15521552
postbuilds[i] =EscapeShellArgument(postbuilds[i])
15531553
self.WriteLn('%s: builddir := $(abs_builddir)'%QuoteSpaces(self.output))

‎gyp/pylib/gyp/generator/msvs.py‎

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ def _AddCustomBuildToolForMSVS(p, spec, primary_input,
451451
'CommandLine': cmd,
452452
})
453453
# Add to the properties of primary input for each config.
454-
forconfig_name, c_datainspec['configurations'].iteritems():
454+
forconfig_name, c_datainspec['configurations'].items():
455455
p.AddFileConfig(_FixPath(primary_input),
456456
_ConfigFullName(config_name, c_data), tools=[tool])
457457

@@ -971,7 +971,7 @@ def _ValidateSourcesForMSVSProject(spec, version):
971971
basenames.setdefault(basename, []).append(source)
972972

973973
error=''
974-
forbasename, filesinbasenames.iteritems():
974+
forbasename, filesinbasenames.items():
975975
iflen(files) >1:
976976
error+=' %s: %s\n'% (basename, ' '.join(files))
977977

@@ -1003,7 +1003,7 @@ def _GenerateMSVSProject(project, options, version, generator_flags):
10031003
relative_path_of_gyp_file=gyp.common.RelativePath(gyp_path, project_dir)
10041004

10051005
config_type=_GetMSVSConfigurationType(spec, project.build_file)
1006-
forconfig_name, configinspec['configurations'].iteritems():
1006+
forconfig_name, configinspec['configurations'].items():
10071007
_AddConfigurationToMSVSProject(p, spec, config_type, config_name, config)
10081008

10091009
# MSVC08 and prior version cannot handle duplicate basenames in the same
@@ -1369,10 +1369,10 @@ def _ConvertToolsToExpectedForm(tools):
13691369
A list of Tool objects.
13701370
"""
13711371
tool_list= []
1372-
fortool, settingsintools.iteritems():
1372+
fortool, settingsintools.items():
13731373
# Collapse settings with lists.
13741374
settings_fixed= {}
1375-
forsetting, valueinsettings.iteritems():
1375+
forsetting, valueinsettings.items():
13761376
iftype(value) ==list:
13771377
if ((tool=='VCLinkerTool'and
13781378
setting=='AdditionalDependencies') or
@@ -1547,7 +1547,7 @@ def _IdlFilesHandledNonNatively(spec, sources):
15471547
def_GetPrecompileRelatedFiles(spec):
15481548
# Gather a list of precompiled header related sources.
15491549
precompiled_related= []
1550-
for_, configinspec['configurations'].iteritems():
1550+
for_, configinspec['configurations'].items():
15511551
forkinprecomp_keys:
15521552
f=config.get(k)
15531553
iff:
@@ -1558,7 +1558,7 @@ def _GetPrecompileRelatedFiles(spec):
15581558
def_ExcludeFilesFromBeingBuilt(p, spec, excluded_sources, excluded_idl,
15591559
list_excluded):
15601560
exclusions=_GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl)
1561-
forfile_name, excluded_configsinexclusions.iteritems():
1561+
forfile_name, excluded_configsinexclusions.items():
15621562
if (notlist_excludedand
15631563
len(excluded_configs) ==len(spec['configurations'])):
15641564
# If we're not listing excluded files, then they won't appear in the
@@ -1575,7 +1575,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15751575
# Exclude excluded sources from being built.
15761576
forfinexcluded_sources:
15771577
excluded_configs= []
1578-
forconfig_name, configinspec['configurations'].iteritems():
1578+
forconfig_name, configinspec['configurations'].items():
15791579
precomped= [_FixPath(config.get(i, '')) foriinprecomp_keys]
15801580
# Don't do this for ones that are precompiled header related.
15811581
iffnotinprecomped:
@@ -1585,7 +1585,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15851585
# Exclude them now.
15861586
forfinexcluded_idl:
15871587
excluded_configs= []
1588-
forconfig_name, configinspec['configurations'].iteritems():
1588+
forconfig_name, configinspec['configurations'].items():
15891589
excluded_configs.append((config_name, config))
15901590
exclusions[f] =excluded_configs
15911591
returnexclusions
@@ -1594,7 +1594,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15941594
def_AddToolFilesToMSVS(p, spec):
15951595
# Add in tool files (rules).
15961596
tool_files=OrderedSet()
1597-
for_, configinspec['configurations'].iteritems():
1597+
for_, configinspec['configurations'].items():
15981598
forfinconfig.get('msvs_tool_files', []):
15991599
tool_files.add(f)
16001600
forfintool_files:
@@ -1607,7 +1607,7 @@ def _HandlePreCompiledHeaders(p, sources, spec):
16071607
# kind (i.e. C vs. C++) as the precompiled header source stub needs
16081608
# to have use of precompiled headers disabled.
16091609
extensions_excluded_from_precompile= []
1610-
forconfig_name, configinspec['configurations'].iteritems():
1610+
forconfig_name, configinspec['configurations'].items():
16111611
source=config.get('msvs_precompiled_source')
16121612
ifsource:
16131613
source=_FixPath(source)
@@ -1628,7 +1628,7 @@ def DisableForSourceTree(source_tree):
16281628
else:
16291629
basename, extension=os.path.splitext(source)
16301630
ifextensioninextensions_excluded_from_precompile:
1631-
forconfig_name, configinspec['configurations'].iteritems():
1631+
forconfig_name, configinspec['configurations'].items():
16321632
tool=MSVSProject.Tool('VCCLCompilerTool',
16331633
{'UsePrecompiledHeader': '0',
16341634
'ForcedIncludeFiles': '$(NOINHERIT)'})
@@ -1679,7 +1679,7 @@ def _WriteMSVSUserFile(project_path, version, spec):
16791679
return# Nothing to add
16801680
# Write out the user file.
16811681
user_file=_CreateMSVSUserFile(project_path, version, spec)
1682-
forconfig_name, c_datainspec['configurations'].iteritems():
1682+
forconfig_name, c_datainspec['configurations'].items():
16831683
user_file.AddDebugSettings(_ConfigFullName(config_name, c_data),
16841684
action, environment, working_directory)
16851685
user_file.WriteIfChanged()
@@ -1730,7 +1730,7 @@ def _GetPathDict(root, path):
17301730
def_DictsToFolders(base_path, bucket, flat):
17311731
# Convert to folders recursively.
17321732
children= []
1733-
forfolder, contentsinbucket.iteritems():
1733+
forfolder, contentsinbucket.items():
17341734
iftype(contents) ==dict:
17351735
folder_children=_DictsToFolders(os.path.join(base_path, folder),
17361736
contents, flat)
@@ -1802,7 +1802,7 @@ def _GetPlatformOverridesOfProject(spec):
18021802
# Prepare a dict indicating which project configurations are used for which
18031803
# solution configurations for this target.
18041804
config_platform_overrides= {}
1805-
forconfig_name, cinspec['configurations'].iteritems():
1805+
forconfig_name, cinspec['configurations'].items():
18061806
config_fullname=_ConfigFullName(config_name, c)
18071807
platform=c.get('msvs_target_platform', _ConfigPlatform(c))
18081808
fixed_config_fullname='%s|%s'% (
@@ -1941,7 +1941,7 @@ def PerformBuild(data, configurations, params):
19411941
msvs_version=params['msvs_version']
19421942
devenv=os.path.join(msvs_version.path, 'Common7', 'IDE', 'devenv.com')
19431943

1944-
forbuild_file, build_file_dictindata.iteritems():
1944+
forbuild_file, build_file_dictindata.items():
19451945
(build_file_root, build_file_ext) =os.path.splitext(build_file)
19461946
ifbuild_file_ext!='.gyp':
19471947
continue
@@ -1990,7 +1990,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
19901990
configs=set()
19911991
forqualified_targetintarget_list:
19921992
spec=target_dicts[qualified_target]
1993-
forconfig_name, configinspec['configurations'].iteritems():
1993+
forconfig_name, configinspec['configurations'].items():
19941994
configs.add(_ConfigFullName(config_name, config))
19951995
configs=list(configs)
19961996

@@ -2630,7 +2630,7 @@ def _GetConfigurationCondition(name, settings):
26302630

26312631
def_GetMSBuildProjectConfigurations(configurations):
26322632
group= ['ItemGroup', {'Label': 'ProjectConfigurations'}]
2633-
for (name, settings) insorted(configurations.iteritems()):
2633+
for (name, settings) insorted(configurations.items()):
26342634
configuration, platform=_GetConfigurationAndPlatform(name, settings)
26352635
designation='%s|%s'% (configuration, platform)
26362636
group.append(
@@ -2700,7 +2700,7 @@ def _GetMSBuildGlobalProperties(spec, guid, gyp_file_name):
27002700

27012701
def_GetMSBuildConfigurationDetails(spec, build_file):
27022702
properties= {}
2703-
forname, settingsinspec['configurations'].iteritems():
2703+
forname, settingsinspec['configurations'].items():
27042704
msbuild_attributes=_GetMSBuildAttributes(spec, settings, build_file)
27052705
condition=_GetConfigurationCondition(name, settings)
27062706
character_set=msbuild_attributes.get('CharacterSet')
@@ -2729,7 +2729,7 @@ def _GetMSBuildPropertySheets(configurations):
27292729
user_props=r'$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props'
27302730
additional_props= {}
27312731
props_specified=False
2732-
forname, settingsinsorted(configurations.iteritems()):
2732+
forname, settingsinsorted(configurations.items()):
27332733
configuration=_GetConfigurationCondition(name, settings)
27342734
if'msbuild_props'insettings:
27352735
additional_props[configuration] =_FixPaths(settings['msbuild_props'])
@@ -2751,7 +2751,7 @@ def _GetMSBuildPropertySheets(configurations):
27512751
]
27522752
else:
27532753
sheets= []
2754-
forcondition, propsinadditional_props.iteritems():
2754+
forcondition, propsinadditional_props.items():
27552755
import_group= [
27562756
'ImportGroup',
27572757
{'Label': 'PropertySheets',
@@ -2878,7 +2878,7 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
28782878
new_paths='$(ExecutablePath);'+';'.join(new_paths)
28792879

28802880
properties= {}
2881-
for (name, configuration) insorted(configurations.iteritems()):
2881+
for (name, configuration) insorted(configurations.items()):
28822882
condition=_GetConfigurationCondition(name, configuration)
28832883
attributes=_GetMSBuildAttributes(spec, configuration, build_file)
28842884
msbuild_settings=configuration['finalized_msbuild_settings']
@@ -2903,7 +2903,7 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
29032903
_AddConditionalProperty(properties, condition, 'ExecutablePath',
29042904
new_paths)
29052905
tool_settings=msbuild_settings.get('', {})
2906-
forname, valueinsorted(tool_settings.iteritems()):
2906+
forname, valueinsorted(tool_settings.items()):
29072907
formatted_value=_GetValueFormattedForMSBuild('', name, value)
29082908
_AddConditionalProperty(properties, condition, name, formatted_value)
29092909
return_GetMSBuildPropertyGroup(spec, None, properties)
@@ -2972,7 +2972,7 @@ def GetEdges(node):
29722972
# NOTE: reverse(topsort(DAG)) = topsort(reverse_edges(DAG))
29732973
fornameinreversed(properties_ordered):
29742974
values=properties[name]
2975-
forvalue, conditionsinsorted(values.iteritems()):
2975+
forvalue, conditionsinsorted(values.items()):
29762976
iflen(conditions) ==num_configurations:
29772977
# If the value is the same all configurations,
29782978
# just add one unconditional entry.
@@ -2985,18 +2985,18 @@ def GetEdges(node):
29852985

29862986
def_GetMSBuildToolSettingsSections(spec, configurations):
29872987
groups= []
2988-
for (name, configuration) insorted(configurations.iteritems()):
2988+
for (name, configuration) insorted(configurations.items()):
29892989
msbuild_settings=configuration['finalized_msbuild_settings']
29902990
group= ['ItemDefinitionGroup',
29912991
{'Condition': _GetConfigurationCondition(name, configuration)}
29922992
]
2993-
fortool_name, tool_settingsinsorted(msbuild_settings.iteritems()):
2993+
fortool_name, tool_settingsinsorted(msbuild_settings.items()):
29942994
# Skip the tool named '' which is a holder of global settings handled
29952995
# by _GetMSBuildConfigurationGlobalProperties.
29962996
iftool_name:
29972997
iftool_settings:
29982998
tool= [tool_name]
2999-
forname, valueinsorted(tool_settings.iteritems()):
2999+
forname, valueinsorted(tool_settings.items()):
30003000
formatted_value=_GetValueFormattedForMSBuild(tool_name, name,
30013001
value)
30023002
tool.append([name, formatted_value])
@@ -3196,7 +3196,7 @@ def _AddSources2(spec, sources, exclusions, grouped_sources,
31963196
{'Condition': condition},
31973197
'true'])
31983198
# Add precompile if needed
3199-
forconfig_name, configurationinspec['configurations'].iteritems():
3199+
forconfig_name, configurationinspec['configurations'].items():
32003200
precompiled_source=configuration.get('msvs_precompiled_source', '')
32013201
ifprecompiled_source!='':
32023202
precompiled_source=_FixPath(precompiled_source)
@@ -3436,7 +3436,7 @@ def _GenerateActionsForMSBuild(spec, actions_to_add):
34363436
"""
34373437
sources_handled_by_action=OrderedSet()
34383438
actions_spec= []
3439-
forprimary_input, actionsinactions_to_add.iteritems():
3439+
forprimary_input, actionsinactions_to_add.items():
34403440
inputs=OrderedSet()
34413441
outputs=OrderedSet()
34423442
descriptions= []

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 7535e44

Browse files
rodrigcrvagg
authored andcommitted
gyp: replace deprecated functions
* assertEquals() with assertEqual() * iteritems() with items() for Python 3. * xrange() with range() for Python 3. #1150 Reviewed-By: Refael Ackermann <refack@gmail.com>
1 parent 2040cd2 commit 7535e44

22 files changed

Lines changed: 129 additions & 130 deletions

‎gyp/PRESUBMIT.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@
7676
def_LicenseHeader(input_api):
7777
# Accept any year number from 2009 to the current year.
7878
current_year=int(input_api.time.strftime('%Y'))
79-
allowed_years= (str(s) forsinreversed(xrange(2009, current_year+1)))
80-
79+
allowed_years= (str(s) forsinreversed(range(2009, current_year+1)))
8180
years_re='('+'|'.join(allowed_years) +')'
8281

8382
# The (c) is deprecated, but tolerate it until it's removed from all files.

‎gyp/pylib/gyp/MSVSSettings.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ def ConvertVCMacrosToMSBuild(s):
435435
'$(PlatformName)': '$(Platform)',
436436
'$(SafeInputName)': '%(Filename)',
437437
}
438-
forold, newinreplace_map.iteritems():
438+
forold, newinreplace_map.items():
439439
s=s.replace(old, new)
440440
s=FixVCMacroSlashes(s)
441441
returns
@@ -455,10 +455,10 @@ def ConvertToMSBuildSettings(msvs_settings, stderr=sys.stderr):
455455
dictionaries of settings and their values.
456456
"""
457457
msbuild_settings= {}
458-
formsvs_tool_name, msvs_tool_settingsinmsvs_settings.iteritems():
458+
formsvs_tool_name, msvs_tool_settingsinmsvs_settings.items():
459459
ifmsvs_tool_namein_msvs_to_msbuild_converters:
460460
msvs_tool=_msvs_to_msbuild_converters[msvs_tool_name]
461-
formsvs_setting, msvs_valueinmsvs_tool_settings.iteritems():
461+
formsvs_setting, msvs_valueinmsvs_tool_settings.items():
462462
ifmsvs_settinginmsvs_tool:
463463
# Invoke the translation function.
464464
try:
@@ -515,7 +515,7 @@ def _ValidateSettings(validators, settings, stderr):
515515
fortool_nameinsettings:
516516
iftool_nameinvalidators:
517517
tool_validators=validators[tool_name]
518-
forsetting, valueinsettings[tool_name].iteritems():
518+
forsetting, valueinsettings[tool_name].items():
519519
ifsettingintool_validators:
520520
try:
521521
tool_validators[setting](value)

‎gyp/pylib/gyp/MSVSUserFile.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def AddDebugSettings(self, config_name, command, environment = {},
9191

9292
ifenvironmentandisinstance(environment, dict):
9393
env_list= ['%s="%s"'% (key, val)
94-
for (key,val) inenvironment.iteritems()]
94+
for (key,val) inenvironment.items()]
9595
environment=' '.join(env_list)
9696
else:
9797
environment=''
@@ -135,7 +135,7 @@ def AddDebugSettings(self, config_name, command, environment = {},
135135
defWriteIfChanged(self):
136136
"""Writes the user file."""
137137
configs= ['Configurations']
138-
forconfig, specinsorted(self.configurations.iteritems()):
138+
forconfig, specinsorted(self.configurations.items()):
139139
configs.append(spec)
140140

141141
content= ['VisualStudioUserFile',

‎gyp/pylib/gyp/MSVSUtil.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ def InsertLargePdbShims(target_list, target_dicts, vars):
235235

236236
# Set up the shim to output its PDB to the same location as the final linker
237237
# target.
238-
forconfig_name, configinshim_dict.get('configurations').iteritems():
238+
forconfig_name, configinshim_dict.get('configurations').items():
239239
pdb_path=_GetPdbPath(target_dict, config_name, vars)
240240

241241
# A few keys that we don't want to propagate.

‎gyp/pylib/gyp/__init__.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def Noop(value):
209209
# We always want to ignore the environment when regenerating, to avoid
210210
# duplicate or changed flags in the environment at the time of regeneration.
211211
flags= ['--ignore-environment']
212-
forname, metadatainoptions._regeneration_metadata.iteritems():
212+
forname, metadatainoptions._regeneration_metadata.items():
213213
opt=metadata['opt']
214214
value=getattr(options, name)
215215
value_predicate=metadata['type'] =='path'andFixPathorNoop
@@ -434,7 +434,7 @@ def gyp_main(args):
434434
build_file_dir=os.path.abspath(os.path.dirname(build_file))
435435
build_file_dir_components=build_file_dir.split(os.path.sep)
436436
components_len=len(build_file_dir_components)
437-
forindexinxrange(components_len-1, -1, -1):
437+
forindexinrange(components_len-1, -1, -1):
438438
ifbuild_file_dir_components[index] =='src':
439439
options.depth=os.path.sep.join(build_file_dir_components)
440440
break

‎gyp/pylib/gyp/easy_xml.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def _ConstructContentList(xml_parts, specification, pretty, level=0):
8181
# Optionally in second position is a dictionary of the attributes.
8282
rest=specification[1:]
8383
ifrestandisinstance(rest[0], dict):
84-
forat, valinsorted(rest[0].iteritems()):
84+
forat, valinsorted(rest[0].items()):
8585
xml_parts.append(' %s="%s"'% (at, _XmlEscape(val, attr=True)))
8686
rest=rest[1:]
8787
ifrest:

‎gyp/pylib/gyp/generator/android.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ def WriteSourceFlags(self, spec, configs):
460460
Args:
461461
spec, configs: input from gyp.
462462
"""
463-
forconfigname, configinsorted(configs.iteritems()):
463+
forconfigname, configinsorted(configs.items()):
464464
extracted_includes= []
465465

466466
self.WriteLn('\n# Flags passed to both C and C++ files.')
@@ -790,7 +790,7 @@ def WriteTargetFlags(self, spec, configs, link_deps):
790790
static_libs, dynamic_libs, ldflags_libs=self.FilterLibraries(libraries)
791791

792792
ifself.type!='static_library':
793-
forconfigname, configinsorted(configs.iteritems()):
793+
forconfigname, configinsorted(configs.items()):
794794
ldflags=list(config.get('ldflags', []))
795795
self.WriteLn('')
796796
self.WriteList(ldflags, 'LOCAL_LDFLAGS_%s'%configname)
@@ -839,7 +839,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, part_of_all,
839839
settings=spec.get('aosp_build_settings', {})
840840
ifsettings:
841841
self.WriteLn('### Set directly by aosp_build_settings.')
842-
fork, vinsettings.iteritems():
842+
fork, vinsettings.items():
843843
ifisinstance(v, list):
844844
self.WriteList(v, k)
845845
else:

‎gyp/pylib/gyp/generator/gypd.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
8888
ifnotoutput_fileinoutput_files:
8989
output_files[output_file] =input_file
9090

91-
foroutput_file, input_fileinoutput_files.iteritems():
91+
foroutput_file, input_fileinoutput_files.items():
9292
output=open(output_file, 'w')
9393
pprint.pprint(data[input_file], output)
9494
output.close()

‎gyp/pylib/gyp/generator/make.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -674,7 +674,7 @@ def _ValidateSourcesForOSX(spec, all_sources):
674674
basenames.setdefault(basename, []).append(source)
675675

676676
error=''
677-
forbasename, filesinbasenames.iteritems():
677+
forbasename, filesinbasenames.items():
678678
iflen(files) >1:
679679
error+=' %s: %s\n'% (basename, ' '.join(files))
680680

@@ -1547,7 +1547,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, bundle_deps,
15471547
# Postbuilds expect to be run in the gyp file's directory, so insert an
15481548
# implicit postbuild to cd to there.
15491549
postbuilds.insert(0, gyp.common.EncodePOSIXShellList(['cd', self.path]))
1550-
foriinxrange(len(postbuilds)):
1550+
foriinrange(len(postbuilds)):
15511551
ifnotpostbuilds[i].startswith('$'):
15521552
postbuilds[i] =EscapeShellArgument(postbuilds[i])
15531553
self.WriteLn('%s: builddir := $(abs_builddir)'%QuoteSpaces(self.output))

‎gyp/pylib/gyp/generator/msvs.py‎

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ def _AddCustomBuildToolForMSVS(p, spec, primary_input,
451451
'CommandLine': cmd,
452452
})
453453
# Add to the properties of primary input for each config.
454-
forconfig_name, c_datainspec['configurations'].iteritems():
454+
forconfig_name, c_datainspec['configurations'].items():
455455
p.AddFileConfig(_FixPath(primary_input),
456456
_ConfigFullName(config_name, c_data), tools=[tool])
457457

@@ -971,7 +971,7 @@ def _ValidateSourcesForMSVSProject(spec, version):
971971
basenames.setdefault(basename, []).append(source)
972972

973973
error=''
974-
forbasename, filesinbasenames.iteritems():
974+
forbasename, filesinbasenames.items():
975975
iflen(files) >1:
976976
error+=' %s: %s\n'% (basename, ' '.join(files))
977977

@@ -1003,7 +1003,7 @@ def _GenerateMSVSProject(project, options, version, generator_flags):
10031003
relative_path_of_gyp_file=gyp.common.RelativePath(gyp_path, project_dir)
10041004

10051005
config_type=_GetMSVSConfigurationType(spec, project.build_file)
1006-
forconfig_name, configinspec['configurations'].iteritems():
1006+
forconfig_name, configinspec['configurations'].items():
10071007
_AddConfigurationToMSVSProject(p, spec, config_type, config_name, config)
10081008

10091009
# MSVC08 and prior version cannot handle duplicate basenames in the same
@@ -1369,10 +1369,10 @@ def _ConvertToolsToExpectedForm(tools):
13691369
A list of Tool objects.
13701370
"""
13711371
tool_list= []
1372-
fortool, settingsintools.iteritems():
1372+
fortool, settingsintools.items():
13731373
# Collapse settings with lists.
13741374
settings_fixed= {}
1375-
forsetting, valueinsettings.iteritems():
1375+
forsetting, valueinsettings.items():
13761376
iftype(value) ==list:
13771377
if ((tool=='VCLinkerTool'and
13781378
setting=='AdditionalDependencies') or
@@ -1547,7 +1547,7 @@ def _IdlFilesHandledNonNatively(spec, sources):
15471547
def_GetPrecompileRelatedFiles(spec):
15481548
# Gather a list of precompiled header related sources.
15491549
precompiled_related= []
1550-
for_, configinspec['configurations'].iteritems():
1550+
for_, configinspec['configurations'].items():
15511551
forkinprecomp_keys:
15521552
f=config.get(k)
15531553
iff:
@@ -1558,7 +1558,7 @@ def _GetPrecompileRelatedFiles(spec):
15581558
def_ExcludeFilesFromBeingBuilt(p, spec, excluded_sources, excluded_idl,
15591559
list_excluded):
15601560
exclusions=_GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl)
1561-
forfile_name, excluded_configsinexclusions.iteritems():
1561+
forfile_name, excluded_configsinexclusions.items():
15621562
if (notlist_excludedand
15631563
len(excluded_configs) ==len(spec['configurations'])):
15641564
# If we're not listing excluded files, then they won't appear in the
@@ -1575,7 +1575,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15751575
# Exclude excluded sources from being built.
15761576
forfinexcluded_sources:
15771577
excluded_configs= []
1578-
forconfig_name, configinspec['configurations'].iteritems():
1578+
forconfig_name, configinspec['configurations'].items():
15791579
precomped= [_FixPath(config.get(i, '')) foriinprecomp_keys]
15801580
# Don't do this for ones that are precompiled header related.
15811581
iffnotinprecomped:
@@ -1585,7 +1585,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15851585
# Exclude them now.
15861586
forfinexcluded_idl:
15871587
excluded_configs= []
1588-
forconfig_name, configinspec['configurations'].iteritems():
1588+
forconfig_name, configinspec['configurations'].items():
15891589
excluded_configs.append((config_name, config))
15901590
exclusions[f] =excluded_configs
15911591
returnexclusions
@@ -1594,7 +1594,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15941594
def_AddToolFilesToMSVS(p, spec):
15951595
# Add in tool files (rules).
15961596
tool_files=OrderedSet()
1597-
for_, configinspec['configurations'].iteritems():
1597+
for_, configinspec['configurations'].items():
15981598
forfinconfig.get('msvs_tool_files', []):
15991599
tool_files.add(f)
16001600
forfintool_files:
@@ -1607,7 +1607,7 @@ def _HandlePreCompiledHeaders(p, sources, spec):
16071607
# kind (i.e. C vs. C++) as the precompiled header source stub needs
16081608
# to have use of precompiled headers disabled.
16091609
extensions_excluded_from_precompile= []
1610-
forconfig_name, configinspec['configurations'].iteritems():
1610+
forconfig_name, configinspec['configurations'].items():
16111611
source=config.get('msvs_precompiled_source')
16121612
ifsource:
16131613
source=_FixPath(source)
@@ -1628,7 +1628,7 @@ def DisableForSourceTree(source_tree):
16281628
else:
16291629
basename, extension=os.path.splitext(source)
16301630
ifextensioninextensions_excluded_from_precompile:
1631-
forconfig_name, configinspec['configurations'].iteritems():
1631+
forconfig_name, configinspec['configurations'].items():
16321632
tool=MSVSProject.Tool('VCCLCompilerTool',
16331633
{'UsePrecompiledHeader': '0',
16341634
'ForcedIncludeFiles': '$(NOINHERIT)'})
@@ -1679,7 +1679,7 @@ def _WriteMSVSUserFile(project_path, version, spec):
16791679
return# Nothing to add
16801680
# Write out the user file.
16811681
user_file=_CreateMSVSUserFile(project_path, version, spec)
1682-
forconfig_name, c_datainspec['configurations'].iteritems():
1682+
forconfig_name, c_datainspec['configurations'].items():
16831683
user_file.AddDebugSettings(_ConfigFullName(config_name, c_data),
16841684
action, environment, working_directory)
16851685
user_file.WriteIfChanged()
@@ -1730,7 +1730,7 @@ def _GetPathDict(root, path):
17301730
def_DictsToFolders(base_path, bucket, flat):
17311731
# Convert to folders recursively.
17321732
children= []
1733-
forfolder, contentsinbucket.iteritems():
1733+
forfolder, contentsinbucket.items():
17341734
iftype(contents) ==dict:
17351735
folder_children=_DictsToFolders(os.path.join(base_path, folder),
17361736
contents, flat)
@@ -1802,7 +1802,7 @@ def _GetPlatformOverridesOfProject(spec):
18021802
# Prepare a dict indicating which project configurations are used for which
18031803
# solution configurations for this target.
18041804
config_platform_overrides= {}
1805-
forconfig_name, cinspec['configurations'].iteritems():
1805+
forconfig_name, cinspec['configurations'].items():
18061806
config_fullname=_ConfigFullName(config_name, c)
18071807
platform=c.get('msvs_target_platform', _ConfigPlatform(c))
18081808
fixed_config_fullname='%s|%s'% (
@@ -1941,7 +1941,7 @@ def PerformBuild(data, configurations, params):
19411941
msvs_version=params['msvs_version']
19421942
devenv=os.path.join(msvs_version.path, 'Common7', 'IDE', 'devenv.com')
19431943

1944-
forbuild_file, build_file_dictindata.iteritems():
1944+
forbuild_file, build_file_dictindata.items():
19451945
(build_file_root, build_file_ext) =os.path.splitext(build_file)
19461946
ifbuild_file_ext!='.gyp':
19471947
continue
@@ -1990,7 +1990,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
19901990
configs=set()
19911991
forqualified_targetintarget_list:
19921992
spec=target_dicts[qualified_target]
1993-
forconfig_name, configinspec['configurations'].iteritems():
1993+
forconfig_name, configinspec['configurations'].items():
19941994
configs.add(_ConfigFullName(config_name, config))
19951995
configs=list(configs)
19961996

@@ -2630,7 +2630,7 @@ def _GetConfigurationCondition(name, settings):
26302630

26312631
def_GetMSBuildProjectConfigurations(configurations):
26322632
group= ['ItemGroup', {'Label': 'ProjectConfigurations'}]
2633-
for (name, settings) insorted(configurations.iteritems()):
2633+
for (name, settings) insorted(configurations.items()):
26342634
configuration, platform=_GetConfigurationAndPlatform(name, settings)
26352635
designation='%s|%s'% (configuration, platform)
26362636
group.append(
@@ -2700,7 +2700,7 @@ def _GetMSBuildGlobalProperties(spec, guid, gyp_file_name):
27002700

27012701
def_GetMSBuildConfigurationDetails(spec, build_file):
27022702
properties= {}
2703-
forname, settingsinspec['configurations'].iteritems():
2703+
forname, settingsinspec['configurations'].items():
27042704
msbuild_attributes=_GetMSBuildAttributes(spec, settings, build_file)
27052705
condition=_GetConfigurationCondition(name, settings)
27062706
character_set=msbuild_attributes.get('CharacterSet')
@@ -2729,7 +2729,7 @@ def _GetMSBuildPropertySheets(configurations):
27292729
user_props=r'$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props'
27302730
additional_props= {}
27312731
props_specified=False
2732-
forname, settingsinsorted(configurations.iteritems()):
2732+
forname, settingsinsorted(configurations.items()):
27332733
configuration=_GetConfigurationCondition(name, settings)
27342734
if'msbuild_props'insettings:
27352735
additional_props[configuration] =_FixPaths(settings['msbuild_props'])
@@ -2751,7 +2751,7 @@ def _GetMSBuildPropertySheets(configurations):
27512751
]
27522752
else:
27532753
sheets= []
2754-
forcondition, propsinadditional_props.iteritems():
2754+
forcondition, propsinadditional_props.items():
27552755
import_group= [
27562756
'ImportGroup',
27572757
{'Label': 'PropertySheets',
@@ -2878,7 +2878,7 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
28782878
new_paths='$(ExecutablePath);'+';'.join(new_paths)
28792879

28802880
properties= {}
2881-
for (name, configuration) insorted(configurations.iteritems()):
2881+
for (name, configuration) insorted(configurations.items()):
28822882
condition=_GetConfigurationCondition(name, configuration)
28832883
attributes=_GetMSBuildAttributes(spec, configuration, build_file)
28842884
msbuild_settings=configuration['finalized_msbuild_settings']
@@ -2903,7 +2903,7 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
29032903
_AddConditionalProperty(properties, condition, 'ExecutablePath',
29042904
new_paths)
29052905
tool_settings=msbuild_settings.get('', {})
2906-
forname, valueinsorted(tool_settings.iteritems()):
2906+
forname, valueinsorted(tool_settings.items()):
29072907
formatted_value=_GetValueFormattedForMSBuild('', name, value)
29082908
_AddConditionalProperty(properties, condition, name, formatted_value)
29092909
return_GetMSBuildPropertyGroup(spec, None, properties)
@@ -2972,7 +2972,7 @@ def GetEdges(node):
29722972
# NOTE: reverse(topsort(DAG)) = topsort(reverse_edges(DAG))
29732973
fornameinreversed(properties_ordered):
29742974
values=properties[name]
2975-
forvalue, conditionsinsorted(values.iteritems()):
2975+
forvalue, conditionsinsorted(values.items()):
29762976
iflen(conditions) ==num_configurations:
29772977
# If the value is the same all configurations,
29782978
# just add one unconditional entry.
@@ -2985,18 +2985,18 @@ def GetEdges(node):
29852985

29862986
def_GetMSBuildToolSettingsSections(spec, configurations):
29872987
groups= []
2988-
for (name, configuration) insorted(configurations.iteritems()):
2988+
for (name, configuration) insorted(configurations.items()):
29892989
msbuild_settings=configuration['finalized_msbuild_settings']
29902990
group= ['ItemDefinitionGroup',
29912991
{'Condition': _GetConfigurationCondition(name, configuration)}
29922992
]
2993-
fortool_name, tool_settingsinsorted(msbuild_settings.iteritems()):
2993+
fortool_name, tool_settingsinsorted(msbuild_settings.items()):
29942994
# Skip the tool named '' which is a holder of global settings handled
29952995
# by _GetMSBuildConfigurationGlobalProperties.
29962996
iftool_name:
29972997
iftool_settings:
29982998
tool= [tool_name]
2999-
forname, valueinsorted(tool_settings.iteritems()):
2999+
forname, valueinsorted(tool_settings.items()):
30003000
formatted_value=_GetValueFormattedForMSBuild(tool_name, name,
30013001
value)
30023002
tool.append([name, formatted_value])
@@ -3196,7 +3196,7 @@ def _AddSources2(spec, sources, exclusions, grouped_sources,
31963196
{'Condition': condition},
31973197
'true'])
31983198
# Add precompile if needed
3199-
forconfig_name, configurationinspec['configurations'].iteritems():
3199+
forconfig_name, configurationinspec['configurations'].items():
32003200
precompiled_source=configuration.get('msvs_precompiled_source', '')
32013201
ifprecompiled_source!='':
32023202
precompiled_source=_FixPath(precompiled_source)
@@ -3436,7 +3436,7 @@ def _GenerateActionsForMSBuild(spec, actions_to_add):
34363436
"""
34373437
sources_handled_by_action=OrderedSet()
34383438
actions_spec= []
3439-
forprimary_input, actionsinactions_to_add.iteritems():
3439+
forprimary_input, actionsinactions_to_add.items():
34403440
inputs=OrderedSet()
34413441
outputs=OrderedSet()
34423442
descriptions= []

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 7535e44

Browse files
rodrigcrvagg
authored andcommitted
gyp: replace deprecated functions
* assertEquals() with assertEqual() * iteritems() with items() for Python 3. * xrange() with range() for Python 3. #1150 Reviewed-By: Refael Ackermann <refack@gmail.com>
1 parent 2040cd2 commit 7535e44

22 files changed

Lines changed: 129 additions & 130 deletions

‎gyp/PRESUBMIT.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@
7676
def_LicenseHeader(input_api):
7777
# Accept any year number from 2009 to the current year.
7878
current_year=int(input_api.time.strftime('%Y'))
79-
allowed_years= (str(s) forsinreversed(xrange(2009, current_year+1)))
80-
79+
allowed_years= (str(s) forsinreversed(range(2009, current_year+1)))
8180
years_re='('+'|'.join(allowed_years) +')'
8281

8382
# The (c) is deprecated, but tolerate it until it's removed from all files.

‎gyp/pylib/gyp/MSVSSettings.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ def ConvertVCMacrosToMSBuild(s):
435435
'$(PlatformName)': '$(Platform)',
436436
'$(SafeInputName)': '%(Filename)',
437437
}
438-
forold, newinreplace_map.iteritems():
438+
forold, newinreplace_map.items():
439439
s=s.replace(old, new)
440440
s=FixVCMacroSlashes(s)
441441
returns
@@ -455,10 +455,10 @@ def ConvertToMSBuildSettings(msvs_settings, stderr=sys.stderr):
455455
dictionaries of settings and their values.
456456
"""
457457
msbuild_settings= {}
458-
formsvs_tool_name, msvs_tool_settingsinmsvs_settings.iteritems():
458+
formsvs_tool_name, msvs_tool_settingsinmsvs_settings.items():
459459
ifmsvs_tool_namein_msvs_to_msbuild_converters:
460460
msvs_tool=_msvs_to_msbuild_converters[msvs_tool_name]
461-
formsvs_setting, msvs_valueinmsvs_tool_settings.iteritems():
461+
formsvs_setting, msvs_valueinmsvs_tool_settings.items():
462462
ifmsvs_settinginmsvs_tool:
463463
# Invoke the translation function.
464464
try:
@@ -515,7 +515,7 @@ def _ValidateSettings(validators, settings, stderr):
515515
fortool_nameinsettings:
516516
iftool_nameinvalidators:
517517
tool_validators=validators[tool_name]
518-
forsetting, valueinsettings[tool_name].iteritems():
518+
forsetting, valueinsettings[tool_name].items():
519519
ifsettingintool_validators:
520520
try:
521521
tool_validators[setting](value)

‎gyp/pylib/gyp/MSVSUserFile.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def AddDebugSettings(self, config_name, command, environment = {},
9191

9292
ifenvironmentandisinstance(environment, dict):
9393
env_list= ['%s="%s"'% (key, val)
94-
for (key,val) inenvironment.iteritems()]
94+
for (key,val) inenvironment.items()]
9595
environment=' '.join(env_list)
9696
else:
9797
environment=''
@@ -135,7 +135,7 @@ def AddDebugSettings(self, config_name, command, environment = {},
135135
defWriteIfChanged(self):
136136
"""Writes the user file."""
137137
configs= ['Configurations']
138-
forconfig, specinsorted(self.configurations.iteritems()):
138+
forconfig, specinsorted(self.configurations.items()):
139139
configs.append(spec)
140140

141141
content= ['VisualStudioUserFile',

‎gyp/pylib/gyp/MSVSUtil.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ def InsertLargePdbShims(target_list, target_dicts, vars):
235235

236236
# Set up the shim to output its PDB to the same location as the final linker
237237
# target.
238-
forconfig_name, configinshim_dict.get('configurations').iteritems():
238+
forconfig_name, configinshim_dict.get('configurations').items():
239239
pdb_path=_GetPdbPath(target_dict, config_name, vars)
240240

241241
# A few keys that we don't want to propagate.

‎gyp/pylib/gyp/__init__.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def Noop(value):
209209
# We always want to ignore the environment when regenerating, to avoid
210210
# duplicate or changed flags in the environment at the time of regeneration.
211211
flags= ['--ignore-environment']
212-
forname, metadatainoptions._regeneration_metadata.iteritems():
212+
forname, metadatainoptions._regeneration_metadata.items():
213213
opt=metadata['opt']
214214
value=getattr(options, name)
215215
value_predicate=metadata['type'] =='path'andFixPathorNoop
@@ -434,7 +434,7 @@ def gyp_main(args):
434434
build_file_dir=os.path.abspath(os.path.dirname(build_file))
435435
build_file_dir_components=build_file_dir.split(os.path.sep)
436436
components_len=len(build_file_dir_components)
437-
forindexinxrange(components_len-1, -1, -1):
437+
forindexinrange(components_len-1, -1, -1):
438438
ifbuild_file_dir_components[index] =='src':
439439
options.depth=os.path.sep.join(build_file_dir_components)
440440
break

‎gyp/pylib/gyp/easy_xml.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def _ConstructContentList(xml_parts, specification, pretty, level=0):
8181
# Optionally in second position is a dictionary of the attributes.
8282
rest=specification[1:]
8383
ifrestandisinstance(rest[0], dict):
84-
forat, valinsorted(rest[0].iteritems()):
84+
forat, valinsorted(rest[0].items()):
8585
xml_parts.append(' %s="%s"'% (at, _XmlEscape(val, attr=True)))
8686
rest=rest[1:]
8787
ifrest:

‎gyp/pylib/gyp/generator/android.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ def WriteSourceFlags(self, spec, configs):
460460
Args:
461461
spec, configs: input from gyp.
462462
"""
463-
forconfigname, configinsorted(configs.iteritems()):
463+
forconfigname, configinsorted(configs.items()):
464464
extracted_includes= []
465465

466466
self.WriteLn('\n# Flags passed to both C and C++ files.')
@@ -790,7 +790,7 @@ def WriteTargetFlags(self, spec, configs, link_deps):
790790
static_libs, dynamic_libs, ldflags_libs=self.FilterLibraries(libraries)
791791

792792
ifself.type!='static_library':
793-
forconfigname, configinsorted(configs.iteritems()):
793+
forconfigname, configinsorted(configs.items()):
794794
ldflags=list(config.get('ldflags', []))
795795
self.WriteLn('')
796796
self.WriteList(ldflags, 'LOCAL_LDFLAGS_%s'%configname)
@@ -839,7 +839,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, part_of_all,
839839
settings=spec.get('aosp_build_settings', {})
840840
ifsettings:
841841
self.WriteLn('### Set directly by aosp_build_settings.')
842-
fork, vinsettings.iteritems():
842+
fork, vinsettings.items():
843843
ifisinstance(v, list):
844844
self.WriteList(v, k)
845845
else:

‎gyp/pylib/gyp/generator/gypd.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
8888
ifnotoutput_fileinoutput_files:
8989
output_files[output_file] =input_file
9090

91-
foroutput_file, input_fileinoutput_files.iteritems():
91+
foroutput_file, input_fileinoutput_files.items():
9292
output=open(output_file, 'w')
9393
pprint.pprint(data[input_file], output)
9494
output.close()

‎gyp/pylib/gyp/generator/make.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -674,7 +674,7 @@ def _ValidateSourcesForOSX(spec, all_sources):
674674
basenames.setdefault(basename, []).append(source)
675675

676676
error=''
677-
forbasename, filesinbasenames.iteritems():
677+
forbasename, filesinbasenames.items():
678678
iflen(files) >1:
679679
error+=' %s: %s\n'% (basename, ' '.join(files))
680680

@@ -1547,7 +1547,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, bundle_deps,
15471547
# Postbuilds expect to be run in the gyp file's directory, so insert an
15481548
# implicit postbuild to cd to there.
15491549
postbuilds.insert(0, gyp.common.EncodePOSIXShellList(['cd', self.path]))
1550-
foriinxrange(len(postbuilds)):
1550+
foriinrange(len(postbuilds)):
15511551
ifnotpostbuilds[i].startswith('$'):
15521552
postbuilds[i] =EscapeShellArgument(postbuilds[i])
15531553
self.WriteLn('%s: builddir := $(abs_builddir)'%QuoteSpaces(self.output))

‎gyp/pylib/gyp/generator/msvs.py‎

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ def _AddCustomBuildToolForMSVS(p, spec, primary_input,
451451
'CommandLine': cmd,
452452
})
453453
# Add to the properties of primary input for each config.
454-
forconfig_name, c_datainspec['configurations'].iteritems():
454+
forconfig_name, c_datainspec['configurations'].items():
455455
p.AddFileConfig(_FixPath(primary_input),
456456
_ConfigFullName(config_name, c_data), tools=[tool])
457457

@@ -971,7 +971,7 @@ def _ValidateSourcesForMSVSProject(spec, version):
971971
basenames.setdefault(basename, []).append(source)
972972

973973
error=''
974-
forbasename, filesinbasenames.iteritems():
974+
forbasename, filesinbasenames.items():
975975
iflen(files) >1:
976976
error+=' %s: %s\n'% (basename, ' '.join(files))
977977

@@ -1003,7 +1003,7 @@ def _GenerateMSVSProject(project, options, version, generator_flags):
10031003
relative_path_of_gyp_file=gyp.common.RelativePath(gyp_path, project_dir)
10041004

10051005
config_type=_GetMSVSConfigurationType(spec, project.build_file)
1006-
forconfig_name, configinspec['configurations'].iteritems():
1006+
forconfig_name, configinspec['configurations'].items():
10071007
_AddConfigurationToMSVSProject(p, spec, config_type, config_name, config)
10081008

10091009
# MSVC08 and prior version cannot handle duplicate basenames in the same
@@ -1369,10 +1369,10 @@ def _ConvertToolsToExpectedForm(tools):
13691369
A list of Tool objects.
13701370
"""
13711371
tool_list= []
1372-
fortool, settingsintools.iteritems():
1372+
fortool, settingsintools.items():
13731373
# Collapse settings with lists.
13741374
settings_fixed= {}
1375-
forsetting, valueinsettings.iteritems():
1375+
forsetting, valueinsettings.items():
13761376
iftype(value) ==list:
13771377
if ((tool=='VCLinkerTool'and
13781378
setting=='AdditionalDependencies') or
@@ -1547,7 +1547,7 @@ def _IdlFilesHandledNonNatively(spec, sources):
15471547
def_GetPrecompileRelatedFiles(spec):
15481548
# Gather a list of precompiled header related sources.
15491549
precompiled_related= []
1550-
for_, configinspec['configurations'].iteritems():
1550+
for_, configinspec['configurations'].items():
15511551
forkinprecomp_keys:
15521552
f=config.get(k)
15531553
iff:
@@ -1558,7 +1558,7 @@ def _GetPrecompileRelatedFiles(spec):
15581558
def_ExcludeFilesFromBeingBuilt(p, spec, excluded_sources, excluded_idl,
15591559
list_excluded):
15601560
exclusions=_GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl)
1561-
forfile_name, excluded_configsinexclusions.iteritems():
1561+
forfile_name, excluded_configsinexclusions.items():
15621562
if (notlist_excludedand
15631563
len(excluded_configs) ==len(spec['configurations'])):
15641564
# If we're not listing excluded files, then they won't appear in the
@@ -1575,7 +1575,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15751575
# Exclude excluded sources from being built.
15761576
forfinexcluded_sources:
15771577
excluded_configs= []
1578-
forconfig_name, configinspec['configurations'].iteritems():
1578+
forconfig_name, configinspec['configurations'].items():
15791579
precomped= [_FixPath(config.get(i, '')) foriinprecomp_keys]
15801580
# Don't do this for ones that are precompiled header related.
15811581
iffnotinprecomped:
@@ -1585,7 +1585,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15851585
# Exclude them now.
15861586
forfinexcluded_idl:
15871587
excluded_configs= []
1588-
forconfig_name, configinspec['configurations'].iteritems():
1588+
forconfig_name, configinspec['configurations'].items():
15891589
excluded_configs.append((config_name, config))
15901590
exclusions[f] =excluded_configs
15911591
returnexclusions
@@ -1594,7 +1594,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15941594
def_AddToolFilesToMSVS(p, spec):
15951595
# Add in tool files (rules).
15961596
tool_files=OrderedSet()
1597-
for_, configinspec['configurations'].iteritems():
1597+
for_, configinspec['configurations'].items():
15981598
forfinconfig.get('msvs_tool_files', []):
15991599
tool_files.add(f)
16001600
forfintool_files:
@@ -1607,7 +1607,7 @@ def _HandlePreCompiledHeaders(p, sources, spec):
16071607
# kind (i.e. C vs. C++) as the precompiled header source stub needs
16081608
# to have use of precompiled headers disabled.
16091609
extensions_excluded_from_precompile= []
1610-
forconfig_name, configinspec['configurations'].iteritems():
1610+
forconfig_name, configinspec['configurations'].items():
16111611
source=config.get('msvs_precompiled_source')
16121612
ifsource:
16131613
source=_FixPath(source)
@@ -1628,7 +1628,7 @@ def DisableForSourceTree(source_tree):
16281628
else:
16291629
basename, extension=os.path.splitext(source)
16301630
ifextensioninextensions_excluded_from_precompile:
1631-
forconfig_name, configinspec['configurations'].iteritems():
1631+
forconfig_name, configinspec['configurations'].items():
16321632
tool=MSVSProject.Tool('VCCLCompilerTool',
16331633
{'UsePrecompiledHeader': '0',
16341634
'ForcedIncludeFiles': '$(NOINHERIT)'})
@@ -1679,7 +1679,7 @@ def _WriteMSVSUserFile(project_path, version, spec):
16791679
return# Nothing to add
16801680
# Write out the user file.
16811681
user_file=_CreateMSVSUserFile(project_path, version, spec)
1682-
forconfig_name, c_datainspec['configurations'].iteritems():
1682+
forconfig_name, c_datainspec['configurations'].items():
16831683
user_file.AddDebugSettings(_ConfigFullName(config_name, c_data),
16841684
action, environment, working_directory)
16851685
user_file.WriteIfChanged()
@@ -1730,7 +1730,7 @@ def _GetPathDict(root, path):
17301730
def_DictsToFolders(base_path, bucket, flat):
17311731
# Convert to folders recursively.
17321732
children= []
1733-
forfolder, contentsinbucket.iteritems():
1733+
forfolder, contentsinbucket.items():
17341734
iftype(contents) ==dict:
17351735
folder_children=_DictsToFolders(os.path.join(base_path, folder),
17361736
contents, flat)
@@ -1802,7 +1802,7 @@ def _GetPlatformOverridesOfProject(spec):
18021802
# Prepare a dict indicating which project configurations are used for which
18031803
# solution configurations for this target.
18041804
config_platform_overrides= {}
1805-
forconfig_name, cinspec['configurations'].iteritems():
1805+
forconfig_name, cinspec['configurations'].items():
18061806
config_fullname=_ConfigFullName(config_name, c)
18071807
platform=c.get('msvs_target_platform', _ConfigPlatform(c))
18081808
fixed_config_fullname='%s|%s'% (
@@ -1941,7 +1941,7 @@ def PerformBuild(data, configurations, params):
19411941
msvs_version=params['msvs_version']
19421942
devenv=os.path.join(msvs_version.path, 'Common7', 'IDE', 'devenv.com')
19431943

1944-
forbuild_file, build_file_dictindata.iteritems():
1944+
forbuild_file, build_file_dictindata.items():
19451945
(build_file_root, build_file_ext) =os.path.splitext(build_file)
19461946
ifbuild_file_ext!='.gyp':
19471947
continue
@@ -1990,7 +1990,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
19901990
configs=set()
19911991
forqualified_targetintarget_list:
19921992
spec=target_dicts[qualified_target]
1993-
forconfig_name, configinspec['configurations'].iteritems():
1993+
forconfig_name, configinspec['configurations'].items():
19941994
configs.add(_ConfigFullName(config_name, config))
19951995
configs=list(configs)
19961996

@@ -2630,7 +2630,7 @@ def _GetConfigurationCondition(name, settings):
26302630

26312631
def_GetMSBuildProjectConfigurations(configurations):
26322632
group= ['ItemGroup', {'Label': 'ProjectConfigurations'}]
2633-
for (name, settings) insorted(configurations.iteritems()):
2633+
for (name, settings) insorted(configurations.items()):
26342634
configuration, platform=_GetConfigurationAndPlatform(name, settings)
26352635
designation='%s|%s'% (configuration, platform)
26362636
group.append(
@@ -2700,7 +2700,7 @@ def _GetMSBuildGlobalProperties(spec, guid, gyp_file_name):
27002700

27012701
def_GetMSBuildConfigurationDetails(spec, build_file):
27022702
properties= {}
2703-
forname, settingsinspec['configurations'].iteritems():
2703+
forname, settingsinspec['configurations'].items():
27042704
msbuild_attributes=_GetMSBuildAttributes(spec, settings, build_file)
27052705
condition=_GetConfigurationCondition(name, settings)
27062706
character_set=msbuild_attributes.get('CharacterSet')
@@ -2729,7 +2729,7 @@ def _GetMSBuildPropertySheets(configurations):
27292729
user_props=r'$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props'
27302730
additional_props= {}
27312731
props_specified=False
2732-
forname, settingsinsorted(configurations.iteritems()):
2732+
forname, settingsinsorted(configurations.items()):
27332733
configuration=_GetConfigurationCondition(name, settings)
27342734
if'msbuild_props'insettings:
27352735
additional_props[configuration] =_FixPaths(settings['msbuild_props'])
@@ -2751,7 +2751,7 @@ def _GetMSBuildPropertySheets(configurations):
27512751
]
27522752
else:
27532753
sheets= []
2754-
forcondition, propsinadditional_props.iteritems():
2754+
forcondition, propsinadditional_props.items():
27552755
import_group= [
27562756
'ImportGroup',
27572757
{'Label': 'PropertySheets',
@@ -2878,7 +2878,7 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
28782878
new_paths='$(ExecutablePath);'+';'.join(new_paths)
28792879

28802880
properties= {}
2881-
for (name, configuration) insorted(configurations.iteritems()):
2881+
for (name, configuration) insorted(configurations.items()):
28822882
condition=_GetConfigurationCondition(name, configuration)
28832883
attributes=_GetMSBuildAttributes(spec, configuration, build_file)
28842884
msbuild_settings=configuration['finalized_msbuild_settings']
@@ -2903,7 +2903,7 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
29032903
_AddConditionalProperty(properties, condition, 'ExecutablePath',
29042904
new_paths)
29052905
tool_settings=msbuild_settings.get('', {})
2906-
forname, valueinsorted(tool_settings.iteritems()):
2906+
forname, valueinsorted(tool_settings.items()):
29072907
formatted_value=_GetValueFormattedForMSBuild('', name, value)
29082908
_AddConditionalProperty(properties, condition, name, formatted_value)
29092909
return_GetMSBuildPropertyGroup(spec, None, properties)
@@ -2972,7 +2972,7 @@ def GetEdges(node):
29722972
# NOTE: reverse(topsort(DAG)) = topsort(reverse_edges(DAG))
29732973
fornameinreversed(properties_ordered):
29742974
values=properties[name]
2975-
forvalue, conditionsinsorted(values.iteritems()):
2975+
forvalue, conditionsinsorted(values.items()):
29762976
iflen(conditions) ==num_configurations:
29772977
# If the value is the same all configurations,
29782978
# just add one unconditional entry.
@@ -2985,18 +2985,18 @@ def GetEdges(node):
29852985

29862986
def_GetMSBuildToolSettingsSections(spec, configurations):
29872987
groups= []
2988-
for (name, configuration) insorted(configurations.iteritems()):
2988+
for (name, configuration) insorted(configurations.items()):
29892989
msbuild_settings=configuration['finalized_msbuild_settings']
29902990
group= ['ItemDefinitionGroup',
29912991
{'Condition': _GetConfigurationCondition(name, configuration)}
29922992
]
2993-
fortool_name, tool_settingsinsorted(msbuild_settings.iteritems()):
2993+
fortool_name, tool_settingsinsorted(msbuild_settings.items()):
29942994
# Skip the tool named '' which is a holder of global settings handled
29952995
# by _GetMSBuildConfigurationGlobalProperties.
29962996
iftool_name:
29972997
iftool_settings:
29982998
tool= [tool_name]
2999-
forname, valueinsorted(tool_settings.iteritems()):
2999+
forname, valueinsorted(tool_settings.items()):
30003000
formatted_value=_GetValueFormattedForMSBuild(tool_name, name,
30013001
value)
30023002
tool.append([name, formatted_value])
@@ -3196,7 +3196,7 @@ def _AddSources2(spec, sources, exclusions, grouped_sources,
31963196
{'Condition': condition},
31973197
'true'])
31983198
# Add precompile if needed
3199-
forconfig_name, configurationinspec['configurations'].iteritems():
3199+
forconfig_name, configurationinspec['configurations'].items():
32003200
precompiled_source=configuration.get('msvs_precompiled_source', '')
32013201
ifprecompiled_source!='':
32023202
precompiled_source=_FixPath(precompiled_source)
@@ -3436,7 +3436,7 @@ def _GenerateActionsForMSBuild(spec, actions_to_add):
34363436
"""
34373437
sources_handled_by_action=OrderedSet()
34383438
actions_spec= []
3439-
forprimary_input, actionsinactions_to_add.iteritems():
3439+
forprimary_input, actionsinactions_to_add.items():
34403440
inputs=OrderedSet()
34413441
outputs=OrderedSet()
34423442
descriptions= []

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Commit 7535e44

Browse files
rodrigcrvagg
authored andcommitted
gyp: replace deprecated functions
* assertEquals() with assertEqual() * iteritems() with items() for Python 3. * xrange() with range() for Python 3. #1150 Reviewed-By: Refael Ackermann <refack@gmail.com>
1 parent 2040cd2 commit 7535e44

22 files changed

Lines changed: 129 additions & 130 deletions

‎gyp/PRESUBMIT.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@
7676
def_LicenseHeader(input_api):
7777
# Accept any year number from 2009 to the current year.
7878
current_year=int(input_api.time.strftime('%Y'))
79-
allowed_years= (str(s) forsinreversed(xrange(2009, current_year+1)))
80-
79+
allowed_years= (str(s) forsinreversed(range(2009, current_year+1)))
8180
years_re='('+'|'.join(allowed_years) +')'
8281

8382
# The (c) is deprecated, but tolerate it until it's removed from all files.

‎gyp/pylib/gyp/MSVSSettings.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ def ConvertVCMacrosToMSBuild(s):
435435
'$(PlatformName)': '$(Platform)',
436436
'$(SafeInputName)': '%(Filename)',
437437
}
438-
forold, newinreplace_map.iteritems():
438+
forold, newinreplace_map.items():
439439
s=s.replace(old, new)
440440
s=FixVCMacroSlashes(s)
441441
returns
@@ -455,10 +455,10 @@ def ConvertToMSBuildSettings(msvs_settings, stderr=sys.stderr):
455455
dictionaries of settings and their values.
456456
"""
457457
msbuild_settings= {}
458-
formsvs_tool_name, msvs_tool_settingsinmsvs_settings.iteritems():
458+
formsvs_tool_name, msvs_tool_settingsinmsvs_settings.items():
459459
ifmsvs_tool_namein_msvs_to_msbuild_converters:
460460
msvs_tool=_msvs_to_msbuild_converters[msvs_tool_name]
461-
formsvs_setting, msvs_valueinmsvs_tool_settings.iteritems():
461+
formsvs_setting, msvs_valueinmsvs_tool_settings.items():
462462
ifmsvs_settinginmsvs_tool:
463463
# Invoke the translation function.
464464
try:
@@ -515,7 +515,7 @@ def _ValidateSettings(validators, settings, stderr):
515515
fortool_nameinsettings:
516516
iftool_nameinvalidators:
517517
tool_validators=validators[tool_name]
518-
forsetting, valueinsettings[tool_name].iteritems():
518+
forsetting, valueinsettings[tool_name].items():
519519
ifsettingintool_validators:
520520
try:
521521
tool_validators[setting](value)

‎gyp/pylib/gyp/MSVSUserFile.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def AddDebugSettings(self, config_name, command, environment = {},
9191

9292
ifenvironmentandisinstance(environment, dict):
9393
env_list= ['%s="%s"'% (key, val)
94-
for (key,val) inenvironment.iteritems()]
94+
for (key,val) inenvironment.items()]
9595
environment=' '.join(env_list)
9696
else:
9797
environment=''
@@ -135,7 +135,7 @@ def AddDebugSettings(self, config_name, command, environment = {},
135135
defWriteIfChanged(self):
136136
"""Writes the user file."""
137137
configs= ['Configurations']
138-
forconfig, specinsorted(self.configurations.iteritems()):
138+
forconfig, specinsorted(self.configurations.items()):
139139
configs.append(spec)
140140

141141
content= ['VisualStudioUserFile',

‎gyp/pylib/gyp/MSVSUtil.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ def InsertLargePdbShims(target_list, target_dicts, vars):
235235

236236
# Set up the shim to output its PDB to the same location as the final linker
237237
# target.
238-
forconfig_name, configinshim_dict.get('configurations').iteritems():
238+
forconfig_name, configinshim_dict.get('configurations').items():
239239
pdb_path=_GetPdbPath(target_dict, config_name, vars)
240240

241241
# A few keys that we don't want to propagate.

‎gyp/pylib/gyp/__init__.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def Noop(value):
209209
# We always want to ignore the environment when regenerating, to avoid
210210
# duplicate or changed flags in the environment at the time of regeneration.
211211
flags= ['--ignore-environment']
212-
forname, metadatainoptions._regeneration_metadata.iteritems():
212+
forname, metadatainoptions._regeneration_metadata.items():
213213
opt=metadata['opt']
214214
value=getattr(options, name)
215215
value_predicate=metadata['type'] =='path'andFixPathorNoop
@@ -434,7 +434,7 @@ def gyp_main(args):
434434
build_file_dir=os.path.abspath(os.path.dirname(build_file))
435435
build_file_dir_components=build_file_dir.split(os.path.sep)
436436
components_len=len(build_file_dir_components)
437-
forindexinxrange(components_len-1, -1, -1):
437+
forindexinrange(components_len-1, -1, -1):
438438
ifbuild_file_dir_components[index] =='src':
439439
options.depth=os.path.sep.join(build_file_dir_components)
440440
break

‎gyp/pylib/gyp/easy_xml.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def _ConstructContentList(xml_parts, specification, pretty, level=0):
8181
# Optionally in second position is a dictionary of the attributes.
8282
rest=specification[1:]
8383
ifrestandisinstance(rest[0], dict):
84-
forat, valinsorted(rest[0].iteritems()):
84+
forat, valinsorted(rest[0].items()):
8585
xml_parts.append(' %s="%s"'% (at, _XmlEscape(val, attr=True)))
8686
rest=rest[1:]
8787
ifrest:

‎gyp/pylib/gyp/generator/android.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ def WriteSourceFlags(self, spec, configs):
460460
Args:
461461
spec, configs: input from gyp.
462462
"""
463-
forconfigname, configinsorted(configs.iteritems()):
463+
forconfigname, configinsorted(configs.items()):
464464
extracted_includes= []
465465

466466
self.WriteLn('\n# Flags passed to both C and C++ files.')
@@ -790,7 +790,7 @@ def WriteTargetFlags(self, spec, configs, link_deps):
790790
static_libs, dynamic_libs, ldflags_libs=self.FilterLibraries(libraries)
791791

792792
ifself.type!='static_library':
793-
forconfigname, configinsorted(configs.iteritems()):
793+
forconfigname, configinsorted(configs.items()):
794794
ldflags=list(config.get('ldflags', []))
795795
self.WriteLn('')
796796
self.WriteList(ldflags, 'LOCAL_LDFLAGS_%s'%configname)
@@ -839,7 +839,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, part_of_all,
839839
settings=spec.get('aosp_build_settings', {})
840840
ifsettings:
841841
self.WriteLn('### Set directly by aosp_build_settings.')
842-
fork, vinsettings.iteritems():
842+
fork, vinsettings.items():
843843
ifisinstance(v, list):
844844
self.WriteList(v, k)
845845
else:

‎gyp/pylib/gyp/generator/gypd.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
8888
ifnotoutput_fileinoutput_files:
8989
output_files[output_file] =input_file
9090

91-
foroutput_file, input_fileinoutput_files.iteritems():
91+
foroutput_file, input_fileinoutput_files.items():
9292
output=open(output_file, 'w')
9393
pprint.pprint(data[input_file], output)
9494
output.close()

‎gyp/pylib/gyp/generator/make.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -674,7 +674,7 @@ def _ValidateSourcesForOSX(spec, all_sources):
674674
basenames.setdefault(basename, []).append(source)
675675

676676
error=''
677-
forbasename, filesinbasenames.iteritems():
677+
forbasename, filesinbasenames.items():
678678
iflen(files) >1:
679679
error+=' %s: %s\n'% (basename, ' '.join(files))
680680

@@ -1547,7 +1547,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, bundle_deps,
15471547
# Postbuilds expect to be run in the gyp file's directory, so insert an
15481548
# implicit postbuild to cd to there.
15491549
postbuilds.insert(0, gyp.common.EncodePOSIXShellList(['cd', self.path]))
1550-
foriinxrange(len(postbuilds)):
1550+
foriinrange(len(postbuilds)):
15511551
ifnotpostbuilds[i].startswith('$'):
15521552
postbuilds[i] =EscapeShellArgument(postbuilds[i])
15531553
self.WriteLn('%s: builddir := $(abs_builddir)'%QuoteSpaces(self.output))

‎gyp/pylib/gyp/generator/msvs.py‎

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ def _AddCustomBuildToolForMSVS(p, spec, primary_input,
451451
'CommandLine': cmd,
452452
})
453453
# Add to the properties of primary input for each config.
454-
forconfig_name, c_datainspec['configurations'].iteritems():
454+
forconfig_name, c_datainspec['configurations'].items():
455455
p.AddFileConfig(_FixPath(primary_input),
456456
_ConfigFullName(config_name, c_data), tools=[tool])
457457

@@ -971,7 +971,7 @@ def _ValidateSourcesForMSVSProject(spec, version):
971971
basenames.setdefault(basename, []).append(source)
972972

973973
error=''
974-
forbasename, filesinbasenames.iteritems():
974+
forbasename, filesinbasenames.items():
975975
iflen(files) >1:
976976
error+=' %s: %s\n'% (basename, ' '.join(files))
977977

@@ -1003,7 +1003,7 @@ def _GenerateMSVSProject(project, options, version, generator_flags):
10031003
relative_path_of_gyp_file=gyp.common.RelativePath(gyp_path, project_dir)
10041004

10051005
config_type=_GetMSVSConfigurationType(spec, project.build_file)
1006-
forconfig_name, configinspec['configurations'].iteritems():
1006+
forconfig_name, configinspec['configurations'].items():
10071007
_AddConfigurationToMSVSProject(p, spec, config_type, config_name, config)
10081008

10091009
# MSVC08 and prior version cannot handle duplicate basenames in the same
@@ -1369,10 +1369,10 @@ def _ConvertToolsToExpectedForm(tools):
13691369
A list of Tool objects.
13701370
"""
13711371
tool_list= []
1372-
fortool, settingsintools.iteritems():
1372+
fortool, settingsintools.items():
13731373
# Collapse settings with lists.
13741374
settings_fixed= {}
1375-
forsetting, valueinsettings.iteritems():
1375+
forsetting, valueinsettings.items():
13761376
iftype(value) ==list:
13771377
if ((tool=='VCLinkerTool'and
13781378
setting=='AdditionalDependencies') or
@@ -1547,7 +1547,7 @@ def _IdlFilesHandledNonNatively(spec, sources):
15471547
def_GetPrecompileRelatedFiles(spec):
15481548
# Gather a list of precompiled header related sources.
15491549
precompiled_related= []
1550-
for_, configinspec['configurations'].iteritems():
1550+
for_, configinspec['configurations'].items():
15511551
forkinprecomp_keys:
15521552
f=config.get(k)
15531553
iff:
@@ -1558,7 +1558,7 @@ def _GetPrecompileRelatedFiles(spec):
15581558
def_ExcludeFilesFromBeingBuilt(p, spec, excluded_sources, excluded_idl,
15591559
list_excluded):
15601560
exclusions=_GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl)
1561-
forfile_name, excluded_configsinexclusions.iteritems():
1561+
forfile_name, excluded_configsinexclusions.items():
15621562
if (notlist_excludedand
15631563
len(excluded_configs) ==len(spec['configurations'])):
15641564
# If we're not listing excluded files, then they won't appear in the
@@ -1575,7 +1575,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15751575
# Exclude excluded sources from being built.
15761576
forfinexcluded_sources:
15771577
excluded_configs= []
1578-
forconfig_name, configinspec['configurations'].iteritems():
1578+
forconfig_name, configinspec['configurations'].items():
15791579
precomped= [_FixPath(config.get(i, '')) foriinprecomp_keys]
15801580
# Don't do this for ones that are precompiled header related.
15811581
iffnotinprecomped:
@@ -1585,7 +1585,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15851585
# Exclude them now.
15861586
forfinexcluded_idl:
15871587
excluded_configs= []
1588-
forconfig_name, configinspec['configurations'].iteritems():
1588+
forconfig_name, configinspec['configurations'].items():
15891589
excluded_configs.append((config_name, config))
15901590
exclusions[f] =excluded_configs
15911591
returnexclusions
@@ -1594,7 +1594,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15941594
def_AddToolFilesToMSVS(p, spec):
15951595
# Add in tool files (rules).
15961596
tool_files=OrderedSet()
1597-
for_, configinspec['configurations'].iteritems():
1597+
for_, configinspec['configurations'].items():
15981598
forfinconfig.get('msvs_tool_files', []):
15991599
tool_files.add(f)
16001600
forfintool_files:
@@ -1607,7 +1607,7 @@ def _HandlePreCompiledHeaders(p, sources, spec):
16071607
# kind (i.e. C vs. C++) as the precompiled header source stub needs
16081608
# to have use of precompiled headers disabled.
16091609
extensions_excluded_from_precompile= []
1610-
forconfig_name, configinspec['configurations'].iteritems():
1610+
forconfig_name, configinspec['configurations'].items():
16111611
source=config.get('msvs_precompiled_source')
16121612
ifsource:
16131613
source=_FixPath(source)
@@ -1628,7 +1628,7 @@ def DisableForSourceTree(source_tree):
16281628
else:
16291629
basename, extension=os.path.splitext(source)
16301630
ifextensioninextensions_excluded_from_precompile:
1631-
forconfig_name, configinspec['configurations'].iteritems():
1631+
forconfig_name, configinspec['configurations'].items():
16321632
tool=MSVSProject.Tool('VCCLCompilerTool',
16331633
{'UsePrecompiledHeader': '0',
16341634
'ForcedIncludeFiles': '$(NOINHERIT)'})
@@ -1679,7 +1679,7 @@ def _WriteMSVSUserFile(project_path, version, spec):
16791679
return# Nothing to add
16801680
# Write out the user file.
16811681
user_file=_CreateMSVSUserFile(project_path, version, spec)
1682-
forconfig_name, c_datainspec['configurations'].iteritems():
1682+
forconfig_name, c_datainspec['configurations'].items():
16831683
user_file.AddDebugSettings(_ConfigFullName(config_name, c_data),
16841684
action, environment, working_directory)
16851685
user_file.WriteIfChanged()
@@ -1730,7 +1730,7 @@ def _GetPathDict(root, path):
17301730
def_DictsToFolders(base_path, bucket, flat):
17311731
# Convert to folders recursively.
17321732
children= []
1733-
forfolder, contentsinbucket.iteritems():
1733+
forfolder, contentsinbucket.items():
17341734
iftype(contents) ==dict:
17351735
folder_children=_DictsToFolders(os.path.join(base_path, folder),
17361736
contents, flat)
@@ -1802,7 +1802,7 @@ def _GetPlatformOverridesOfProject(spec):
18021802
# Prepare a dict indicating which project configurations are used for which
18031803
# solution configurations for this target.
18041804
config_platform_overrides= {}
1805-
forconfig_name, cinspec['configurations'].iteritems():
1805+
forconfig_name, cinspec['configurations'].items():
18061806
config_fullname=_ConfigFullName(config_name, c)
18071807
platform=c.get('msvs_target_platform', _ConfigPlatform(c))
18081808
fixed_config_fullname='%s|%s'% (
@@ -1941,7 +1941,7 @@ def PerformBuild(data, configurations, params):
19411941
msvs_version=params['msvs_version']
19421942
devenv=os.path.join(msvs_version.path, 'Common7', 'IDE', 'devenv.com')
19431943

1944-
forbuild_file, build_file_dictindata.iteritems():
1944+
forbuild_file, build_file_dictindata.items():
19451945
(build_file_root, build_file_ext) =os.path.splitext(build_file)
19461946
ifbuild_file_ext!='.gyp':
19471947
continue
@@ -1990,7 +1990,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
19901990
configs=set()
19911991
forqualified_targetintarget_list:
19921992
spec=target_dicts[qualified_target]
1993-
forconfig_name, configinspec['configurations'].iteritems():
1993+
forconfig_name, configinspec['configurations'].items():
19941994
configs.add(_ConfigFullName(config_name, config))
19951995
configs=list(configs)
19961996

@@ -2630,7 +2630,7 @@ def _GetConfigurationCondition(name, settings):
26302630

26312631
def_GetMSBuildProjectConfigurations(configurations):
26322632
group= ['ItemGroup', {'Label': 'ProjectConfigurations'}]
2633-
for (name, settings) insorted(configurations.iteritems()):
2633+
for (name, settings) insorted(configurations.items()):
26342634
configuration, platform=_GetConfigurationAndPlatform(name, settings)
26352635
designation='%s|%s'% (configuration, platform)
26362636
group.append(
@@ -2700,7 +2700,7 @@ def _GetMSBuildGlobalProperties(spec, guid, gyp_file_name):
27002700

27012701
def_GetMSBuildConfigurationDetails(spec, build_file):
27022702
properties= {}
2703-
forname, settingsinspec['configurations'].iteritems():
2703+
forname, settingsinspec['configurations'].items():
27042704
msbuild_attributes=_GetMSBuildAttributes(spec, settings, build_file)
27052705
condition=_GetConfigurationCondition(name, settings)
27062706
character_set=msbuild_attributes.get('CharacterSet')
@@ -2729,7 +2729,7 @@ def _GetMSBuildPropertySheets(configurations):
27292729
user_props=r'$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props'
27302730
additional_props= {}
27312731
props_specified=False
2732-
forname, settingsinsorted(configurations.iteritems()):
2732+
forname, settingsinsorted(configurations.items()):
27332733
configuration=_GetConfigurationCondition(name, settings)
27342734
if'msbuild_props'insettings:
27352735
additional_props[configuration] =_FixPaths(settings['msbuild_props'])
@@ -2751,7 +2751,7 @@ def _GetMSBuildPropertySheets(configurations):
27512751
]
27522752
else:
27532753
sheets= []
2754-
forcondition, propsinadditional_props.iteritems():
2754+
forcondition, propsinadditional_props.items():
27552755
import_group= [
27562756
'ImportGroup',
27572757
{'Label': 'PropertySheets',
@@ -2878,7 +2878,7 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
28782878
new_paths='$(ExecutablePath);'+';'.join(new_paths)
28792879

28802880
properties= {}
2881-
for (name, configuration) insorted(configurations.iteritems()):
2881+
for (name, configuration) insorted(configurations.items()):
28822882
condition=_GetConfigurationCondition(name, configuration)
28832883
attributes=_GetMSBuildAttributes(spec, configuration, build_file)
28842884
msbuild_settings=configuration['finalized_msbuild_settings']
@@ -2903,7 +2903,7 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
29032903
_AddConditionalProperty(properties, condition, 'ExecutablePath',
29042904
new_paths)
29052905
tool_settings=msbuild_settings.get('', {})
2906-
forname, valueinsorted(tool_settings.iteritems()):
2906+
forname, valueinsorted(tool_settings.items()):
29072907
formatted_value=_GetValueFormattedForMSBuild('', name, value)
29082908
_AddConditionalProperty(properties, condition, name, formatted_value)
29092909
return_GetMSBuildPropertyGroup(spec, None, properties)
@@ -2972,7 +2972,7 @@ def GetEdges(node):
29722972
# NOTE: reverse(topsort(DAG)) = topsort(reverse_edges(DAG))
29732973
fornameinreversed(properties_ordered):
29742974
values=properties[name]
2975-
forvalue, conditionsinsorted(values.iteritems()):
2975+
forvalue, conditionsinsorted(values.items()):
29762976
iflen(conditions) ==num_configurations:
29772977
# If the value is the same all configurations,
29782978
# just add one unconditional entry.
@@ -2985,18 +2985,18 @@ def GetEdges(node):
29852985

29862986
def_GetMSBuildToolSettingsSections(spec, configurations):
29872987
groups= []
2988-
for (name, configuration) insorted(configurations.iteritems()):
2988+
for (name, configuration) insorted(configurations.items()):
29892989
msbuild_settings=configuration['finalized_msbuild_settings']
29902990
group= ['ItemDefinitionGroup',
29912991
{'Condition': _GetConfigurationCondition(name, configuration)}
29922992
]
2993-
fortool_name, tool_settingsinsorted(msbuild_settings.iteritems()):
2993+
fortool_name, tool_settingsinsorted(msbuild_settings.items()):
29942994
# Skip the tool named '' which is a holder of global settings handled
29952995
# by _GetMSBuildConfigurationGlobalProperties.
29962996
iftool_name:
29972997
iftool_settings:
29982998
tool= [tool_name]
2999-
forname, valueinsorted(tool_settings.iteritems()):
2999+
forname, valueinsorted(tool_settings.items()):
30003000
formatted_value=_GetValueFormattedForMSBuild(tool_name, name,
30013001
value)
30023002
tool.append([name, formatted_value])
@@ -3196,7 +3196,7 @@ def _AddSources2(spec, sources, exclusions, grouped_sources,
31963196
{'Condition': condition},
31973197
'true'])
31983198
# Add precompile if needed
3199-
forconfig_name, configurationinspec['configurations'].iteritems():
3199+
forconfig_name, configurationinspec['configurations'].items():
32003200
precompiled_source=configuration.get('msvs_precompiled_source', '')
32013201
ifprecompiled_source!='':
32023202
precompiled_source=_FixPath(precompiled_source)
@@ -3436,7 +3436,7 @@ def _GenerateActionsForMSBuild(spec, actions_to_add):
34363436
"""
34373437
sources_handled_by_action=OrderedSet()
34383438
actions_spec= []
3439-
forprimary_input, actionsinactions_to_add.iteritems():
3439+
forprimary_input, actionsinactions_to_add.items():
34403440
inputs=OrderedSet()
34413441
outputs=OrderedSet()
34423442
descriptions= []

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 7535e44

Browse files
rodrigcrvagg
authored andcommitted
gyp: replace deprecated functions
* assertEquals() with assertEqual() * iteritems() with items() for Python 3. * xrange() with range() for Python 3. #1150 Reviewed-By: Refael Ackermann <refack@gmail.com>
1 parent 2040cd2 commit 7535e44

22 files changed

Lines changed: 129 additions & 130 deletions

‎gyp/PRESUBMIT.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@
7676
def_LicenseHeader(input_api):
7777
# Accept any year number from 2009 to the current year.
7878
current_year=int(input_api.time.strftime('%Y'))
79-
allowed_years= (str(s) forsinreversed(xrange(2009, current_year+1)))
80-
79+
allowed_years= (str(s) forsinreversed(range(2009, current_year+1)))
8180
years_re='('+'|'.join(allowed_years) +')'
8281

8382
# The (c) is deprecated, but tolerate it until it's removed from all files.

‎gyp/pylib/gyp/MSVSSettings.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ def ConvertVCMacrosToMSBuild(s):
435435
'$(PlatformName)': '$(Platform)',
436436
'$(SafeInputName)': '%(Filename)',
437437
}
438-
forold, newinreplace_map.iteritems():
438+
forold, newinreplace_map.items():
439439
s=s.replace(old, new)
440440
s=FixVCMacroSlashes(s)
441441
returns
@@ -455,10 +455,10 @@ def ConvertToMSBuildSettings(msvs_settings, stderr=sys.stderr):
455455
dictionaries of settings and their values.
456456
"""
457457
msbuild_settings= {}
458-
formsvs_tool_name, msvs_tool_settingsinmsvs_settings.iteritems():
458+
formsvs_tool_name, msvs_tool_settingsinmsvs_settings.items():
459459
ifmsvs_tool_namein_msvs_to_msbuild_converters:
460460
msvs_tool=_msvs_to_msbuild_converters[msvs_tool_name]
461-
formsvs_setting, msvs_valueinmsvs_tool_settings.iteritems():
461+
formsvs_setting, msvs_valueinmsvs_tool_settings.items():
462462
ifmsvs_settinginmsvs_tool:
463463
# Invoke the translation function.
464464
try:
@@ -515,7 +515,7 @@ def _ValidateSettings(validators, settings, stderr):
515515
fortool_nameinsettings:
516516
iftool_nameinvalidators:
517517
tool_validators=validators[tool_name]
518-
forsetting, valueinsettings[tool_name].iteritems():
518+
forsetting, valueinsettings[tool_name].items():
519519
ifsettingintool_validators:
520520
try:
521521
tool_validators[setting](value)

‎gyp/pylib/gyp/MSVSUserFile.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def AddDebugSettings(self, config_name, command, environment = {},
9191

9292
ifenvironmentandisinstance(environment, dict):
9393
env_list= ['%s="%s"'% (key, val)
94-
for (key,val) inenvironment.iteritems()]
94+
for (key,val) inenvironment.items()]
9595
environment=' '.join(env_list)
9696
else:
9797
environment=''
@@ -135,7 +135,7 @@ def AddDebugSettings(self, config_name, command, environment = {},
135135
defWriteIfChanged(self):
136136
"""Writes the user file."""
137137
configs= ['Configurations']
138-
forconfig, specinsorted(self.configurations.iteritems()):
138+
forconfig, specinsorted(self.configurations.items()):
139139
configs.append(spec)
140140

141141
content= ['VisualStudioUserFile',

‎gyp/pylib/gyp/MSVSUtil.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ def InsertLargePdbShims(target_list, target_dicts, vars):
235235

236236
# Set up the shim to output its PDB to the same location as the final linker
237237
# target.
238-
forconfig_name, configinshim_dict.get('configurations').iteritems():
238+
forconfig_name, configinshim_dict.get('configurations').items():
239239
pdb_path=_GetPdbPath(target_dict, config_name, vars)
240240

241241
# A few keys that we don't want to propagate.

‎gyp/pylib/gyp/__init__.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def Noop(value):
209209
# We always want to ignore the environment when regenerating, to avoid
210210
# duplicate or changed flags in the environment at the time of regeneration.
211211
flags= ['--ignore-environment']
212-
forname, metadatainoptions._regeneration_metadata.iteritems():
212+
forname, metadatainoptions._regeneration_metadata.items():
213213
opt=metadata['opt']
214214
value=getattr(options, name)
215215
value_predicate=metadata['type'] =='path'andFixPathorNoop
@@ -434,7 +434,7 @@ def gyp_main(args):
434434
build_file_dir=os.path.abspath(os.path.dirname(build_file))
435435
build_file_dir_components=build_file_dir.split(os.path.sep)
436436
components_len=len(build_file_dir_components)
437-
forindexinxrange(components_len-1, -1, -1):
437+
forindexinrange(components_len-1, -1, -1):
438438
ifbuild_file_dir_components[index] =='src':
439439
options.depth=os.path.sep.join(build_file_dir_components)
440440
break

‎gyp/pylib/gyp/easy_xml.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def _ConstructContentList(xml_parts, specification, pretty, level=0):
8181
# Optionally in second position is a dictionary of the attributes.
8282
rest=specification[1:]
8383
ifrestandisinstance(rest[0], dict):
84-
forat, valinsorted(rest[0].iteritems()):
84+
forat, valinsorted(rest[0].items()):
8585
xml_parts.append(' %s="%s"'% (at, _XmlEscape(val, attr=True)))
8686
rest=rest[1:]
8787
ifrest:

‎gyp/pylib/gyp/generator/android.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ def WriteSourceFlags(self, spec, configs):
460460
Args:
461461
spec, configs: input from gyp.
462462
"""
463-
forconfigname, configinsorted(configs.iteritems()):
463+
forconfigname, configinsorted(configs.items()):
464464
extracted_includes= []
465465

466466
self.WriteLn('\n# Flags passed to both C and C++ files.')
@@ -790,7 +790,7 @@ def WriteTargetFlags(self, spec, configs, link_deps):
790790
static_libs, dynamic_libs, ldflags_libs=self.FilterLibraries(libraries)
791791

792792
ifself.type!='static_library':
793-
forconfigname, configinsorted(configs.iteritems()):
793+
forconfigname, configinsorted(configs.items()):
794794
ldflags=list(config.get('ldflags', []))
795795
self.WriteLn('')
796796
self.WriteList(ldflags, 'LOCAL_LDFLAGS_%s'%configname)
@@ -839,7 +839,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, part_of_all,
839839
settings=spec.get('aosp_build_settings', {})
840840
ifsettings:
841841
self.WriteLn('### Set directly by aosp_build_settings.')
842-
fork, vinsettings.iteritems():
842+
fork, vinsettings.items():
843843
ifisinstance(v, list):
844844
self.WriteList(v, k)
845845
else:

‎gyp/pylib/gyp/generator/gypd.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
8888
ifnotoutput_fileinoutput_files:
8989
output_files[output_file] =input_file
9090

91-
foroutput_file, input_fileinoutput_files.iteritems():
91+
foroutput_file, input_fileinoutput_files.items():
9292
output=open(output_file, 'w')
9393
pprint.pprint(data[input_file], output)
9494
output.close()

‎gyp/pylib/gyp/generator/make.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -674,7 +674,7 @@ def _ValidateSourcesForOSX(spec, all_sources):
674674
basenames.setdefault(basename, []).append(source)
675675

676676
error=''
677-
forbasename, filesinbasenames.iteritems():
677+
forbasename, filesinbasenames.items():
678678
iflen(files) >1:
679679
error+=' %s: %s\n'% (basename, ' '.join(files))
680680

@@ -1547,7 +1547,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, bundle_deps,
15471547
# Postbuilds expect to be run in the gyp file's directory, so insert an
15481548
# implicit postbuild to cd to there.
15491549
postbuilds.insert(0, gyp.common.EncodePOSIXShellList(['cd', self.path]))
1550-
foriinxrange(len(postbuilds)):
1550+
foriinrange(len(postbuilds)):
15511551
ifnotpostbuilds[i].startswith('$'):
15521552
postbuilds[i] =EscapeShellArgument(postbuilds[i])
15531553
self.WriteLn('%s: builddir := $(abs_builddir)'%QuoteSpaces(self.output))

‎gyp/pylib/gyp/generator/msvs.py‎

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ def _AddCustomBuildToolForMSVS(p, spec, primary_input,
451451
'CommandLine': cmd,
452452
})
453453
# Add to the properties of primary input for each config.
454-
forconfig_name, c_datainspec['configurations'].iteritems():
454+
forconfig_name, c_datainspec['configurations'].items():
455455
p.AddFileConfig(_FixPath(primary_input),
456456
_ConfigFullName(config_name, c_data), tools=[tool])
457457

@@ -971,7 +971,7 @@ def _ValidateSourcesForMSVSProject(spec, version):
971971
basenames.setdefault(basename, []).append(source)
972972

973973
error=''
974-
forbasename, filesinbasenames.iteritems():
974+
forbasename, filesinbasenames.items():
975975
iflen(files) >1:
976976
error+=' %s: %s\n'% (basename, ' '.join(files))
977977

@@ -1003,7 +1003,7 @@ def _GenerateMSVSProject(project, options, version, generator_flags):
10031003
relative_path_of_gyp_file=gyp.common.RelativePath(gyp_path, project_dir)
10041004

10051005
config_type=_GetMSVSConfigurationType(spec, project.build_file)
1006-
forconfig_name, configinspec['configurations'].iteritems():
1006+
forconfig_name, configinspec['configurations'].items():
10071007
_AddConfigurationToMSVSProject(p, spec, config_type, config_name, config)
10081008

10091009
# MSVC08 and prior version cannot handle duplicate basenames in the same
@@ -1369,10 +1369,10 @@ def _ConvertToolsToExpectedForm(tools):
13691369
A list of Tool objects.
13701370
"""
13711371
tool_list= []
1372-
fortool, settingsintools.iteritems():
1372+
fortool, settingsintools.items():
13731373
# Collapse settings with lists.
13741374
settings_fixed= {}
1375-
forsetting, valueinsettings.iteritems():
1375+
forsetting, valueinsettings.items():
13761376
iftype(value) ==list:
13771377
if ((tool=='VCLinkerTool'and
13781378
setting=='AdditionalDependencies') or
@@ -1547,7 +1547,7 @@ def _IdlFilesHandledNonNatively(spec, sources):
15471547
def_GetPrecompileRelatedFiles(spec):
15481548
# Gather a list of precompiled header related sources.
15491549
precompiled_related= []
1550-
for_, configinspec['configurations'].iteritems():
1550+
for_, configinspec['configurations'].items():
15511551
forkinprecomp_keys:
15521552
f=config.get(k)
15531553
iff:
@@ -1558,7 +1558,7 @@ def _GetPrecompileRelatedFiles(spec):
15581558
def_ExcludeFilesFromBeingBuilt(p, spec, excluded_sources, excluded_idl,
15591559
list_excluded):
15601560
exclusions=_GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl)
1561-
forfile_name, excluded_configsinexclusions.iteritems():
1561+
forfile_name, excluded_configsinexclusions.items():
15621562
if (notlist_excludedand
15631563
len(excluded_configs) ==len(spec['configurations'])):
15641564
# If we're not listing excluded files, then they won't appear in the
@@ -1575,7 +1575,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15751575
# Exclude excluded sources from being built.
15761576
forfinexcluded_sources:
15771577
excluded_configs= []
1578-
forconfig_name, configinspec['configurations'].iteritems():
1578+
forconfig_name, configinspec['configurations'].items():
15791579
precomped= [_FixPath(config.get(i, '')) foriinprecomp_keys]
15801580
# Don't do this for ones that are precompiled header related.
15811581
iffnotinprecomped:
@@ -1585,7 +1585,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15851585
# Exclude them now.
15861586
forfinexcluded_idl:
15871587
excluded_configs= []
1588-
forconfig_name, configinspec['configurations'].iteritems():
1588+
forconfig_name, configinspec['configurations'].items():
15891589
excluded_configs.append((config_name, config))
15901590
exclusions[f] =excluded_configs
15911591
returnexclusions
@@ -1594,7 +1594,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15941594
def_AddToolFilesToMSVS(p, spec):
15951595
# Add in tool files (rules).
15961596
tool_files=OrderedSet()
1597-
for_, configinspec['configurations'].iteritems():
1597+
for_, configinspec['configurations'].items():
15981598
forfinconfig.get('msvs_tool_files', []):
15991599
tool_files.add(f)
16001600
forfintool_files:
@@ -1607,7 +1607,7 @@ def _HandlePreCompiledHeaders(p, sources, spec):
16071607
# kind (i.e. C vs. C++) as the precompiled header source stub needs
16081608
# to have use of precompiled headers disabled.
16091609
extensions_excluded_from_precompile= []
1610-
forconfig_name, configinspec['configurations'].iteritems():
1610+
forconfig_name, configinspec['configurations'].items():
16111611
source=config.get('msvs_precompiled_source')
16121612
ifsource:
16131613
source=_FixPath(source)
@@ -1628,7 +1628,7 @@ def DisableForSourceTree(source_tree):
16281628
else:
16291629
basename, extension=os.path.splitext(source)
16301630
ifextensioninextensions_excluded_from_precompile:
1631-
forconfig_name, configinspec['configurations'].iteritems():
1631+
forconfig_name, configinspec['configurations'].items():
16321632
tool=MSVSProject.Tool('VCCLCompilerTool',
16331633
{'UsePrecompiledHeader': '0',
16341634
'ForcedIncludeFiles': '$(NOINHERIT)'})
@@ -1679,7 +1679,7 @@ def _WriteMSVSUserFile(project_path, version, spec):
16791679
return# Nothing to add
16801680
# Write out the user file.
16811681
user_file=_CreateMSVSUserFile(project_path, version, spec)
1682-
forconfig_name, c_datainspec['configurations'].iteritems():
1682+
forconfig_name, c_datainspec['configurations'].items():
16831683
user_file.AddDebugSettings(_ConfigFullName(config_name, c_data),
16841684
action, environment, working_directory)
16851685
user_file.WriteIfChanged()
@@ -1730,7 +1730,7 @@ def _GetPathDict(root, path):
17301730
def_DictsToFolders(base_path, bucket, flat):
17311731
# Convert to folders recursively.
17321732
children= []
1733-
forfolder, contentsinbucket.iteritems():
1733+
forfolder, contentsinbucket.items():
17341734
iftype(contents) ==dict:
17351735
folder_children=_DictsToFolders(os.path.join(base_path, folder),
17361736
contents, flat)
@@ -1802,7 +1802,7 @@ def _GetPlatformOverridesOfProject(spec):
18021802
# Prepare a dict indicating which project configurations are used for which
18031803
# solution configurations for this target.
18041804
config_platform_overrides= {}
1805-
forconfig_name, cinspec['configurations'].iteritems():
1805+
forconfig_name, cinspec['configurations'].items():
18061806
config_fullname=_ConfigFullName(config_name, c)
18071807
platform=c.get('msvs_target_platform', _ConfigPlatform(c))
18081808
fixed_config_fullname='%s|%s'% (
@@ -1941,7 +1941,7 @@ def PerformBuild(data, configurations, params):
19411941
msvs_version=params['msvs_version']
19421942
devenv=os.path.join(msvs_version.path, 'Common7', 'IDE', 'devenv.com')
19431943

1944-
forbuild_file, build_file_dictindata.iteritems():
1944+
forbuild_file, build_file_dictindata.items():
19451945
(build_file_root, build_file_ext) =os.path.splitext(build_file)
19461946
ifbuild_file_ext!='.gyp':
19471947
continue
@@ -1990,7 +1990,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
19901990
configs=set()
19911991
forqualified_targetintarget_list:
19921992
spec=target_dicts[qualified_target]
1993-
forconfig_name, configinspec['configurations'].iteritems():
1993+
forconfig_name, configinspec['configurations'].items():
19941994
configs.add(_ConfigFullName(config_name, config))
19951995
configs=list(configs)
19961996

@@ -2630,7 +2630,7 @@ def _GetConfigurationCondition(name, settings):
26302630

26312631
def_GetMSBuildProjectConfigurations(configurations):
26322632
group= ['ItemGroup', {'Label': 'ProjectConfigurations'}]
2633-
for (name, settings) insorted(configurations.iteritems()):
2633+
for (name, settings) insorted(configurations.items()):
26342634
configuration, platform=_GetConfigurationAndPlatform(name, settings)
26352635
designation='%s|%s'% (configuration, platform)
26362636
group.append(
@@ -2700,7 +2700,7 @@ def _GetMSBuildGlobalProperties(spec, guid, gyp_file_name):
27002700

27012701
def_GetMSBuildConfigurationDetails(spec, build_file):
27022702
properties= {}
2703-
forname, settingsinspec['configurations'].iteritems():
2703+
forname, settingsinspec['configurations'].items():
27042704
msbuild_attributes=_GetMSBuildAttributes(spec, settings, build_file)
27052705
condition=_GetConfigurationCondition(name, settings)
27062706
character_set=msbuild_attributes.get('CharacterSet')
@@ -2729,7 +2729,7 @@ def _GetMSBuildPropertySheets(configurations):
27292729
user_props=r'$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props'
27302730
additional_props= {}
27312731
props_specified=False
2732-
forname, settingsinsorted(configurations.iteritems()):
2732+
forname, settingsinsorted(configurations.items()):
27332733
configuration=_GetConfigurationCondition(name, settings)
27342734
if'msbuild_props'insettings:
27352735
additional_props[configuration] =_FixPaths(settings['msbuild_props'])
@@ -2751,7 +2751,7 @@ def _GetMSBuildPropertySheets(configurations):
27512751
]
27522752
else:
27532753
sheets= []
2754-
forcondition, propsinadditional_props.iteritems():
2754+
forcondition, propsinadditional_props.items():
27552755
import_group= [
27562756
'ImportGroup',
27572757
{'Label': 'PropertySheets',
@@ -2878,7 +2878,7 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
28782878
new_paths='$(ExecutablePath);'+';'.join(new_paths)
28792879

28802880
properties= {}
2881-
for (name, configuration) insorted(configurations.iteritems()):
2881+
for (name, configuration) insorted(configurations.items()):
28822882
condition=_GetConfigurationCondition(name, configuration)
28832883
attributes=_GetMSBuildAttributes(spec, configuration, build_file)
28842884
msbuild_settings=configuration['finalized_msbuild_settings']
@@ -2903,7 +2903,7 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
29032903
_AddConditionalProperty(properties, condition, 'ExecutablePath',
29042904
new_paths)
29052905
tool_settings=msbuild_settings.get('', {})
2906-
forname, valueinsorted(tool_settings.iteritems()):
2906+
forname, valueinsorted(tool_settings.items()):
29072907
formatted_value=_GetValueFormattedForMSBuild('', name, value)
29082908
_AddConditionalProperty(properties, condition, name, formatted_value)
29092909
return_GetMSBuildPropertyGroup(spec, None, properties)
@@ -2972,7 +2972,7 @@ def GetEdges(node):
29722972
# NOTE: reverse(topsort(DAG)) = topsort(reverse_edges(DAG))
29732973
fornameinreversed(properties_ordered):
29742974
values=properties[name]
2975-
forvalue, conditionsinsorted(values.iteritems()):
2975+
forvalue, conditionsinsorted(values.items()):
29762976
iflen(conditions) ==num_configurations:
29772977
# If the value is the same all configurations,
29782978
# just add one unconditional entry.
@@ -2985,18 +2985,18 @@ def GetEdges(node):
29852985

29862986
def_GetMSBuildToolSettingsSections(spec, configurations):
29872987
groups= []
2988-
for (name, configuration) insorted(configurations.iteritems()):
2988+
for (name, configuration) insorted(configurations.items()):
29892989
msbuild_settings=configuration['finalized_msbuild_settings']
29902990
group= ['ItemDefinitionGroup',
29912991
{'Condition': _GetConfigurationCondition(name, configuration)}
29922992
]
2993-
fortool_name, tool_settingsinsorted(msbuild_settings.iteritems()):
2993+
fortool_name, tool_settingsinsorted(msbuild_settings.items()):
29942994
# Skip the tool named '' which is a holder of global settings handled
29952995
# by _GetMSBuildConfigurationGlobalProperties.
29962996
iftool_name:
29972997
iftool_settings:
29982998
tool= [tool_name]
2999-
forname, valueinsorted(tool_settings.iteritems()):
2999+
forname, valueinsorted(tool_settings.items()):
30003000
formatted_value=_GetValueFormattedForMSBuild(tool_name, name,
30013001
value)
30023002
tool.append([name, formatted_value])
@@ -3196,7 +3196,7 @@ def _AddSources2(spec, sources, exclusions, grouped_sources,
31963196
{'Condition': condition},
31973197
'true'])
31983198
# Add precompile if needed
3199-
forconfig_name, configurationinspec['configurations'].iteritems():
3199+
forconfig_name, configurationinspec['configurations'].items():
32003200
precompiled_source=configuration.get('msvs_precompiled_source', '')
32013201
ifprecompiled_source!='':
32023202
precompiled_source=_FixPath(precompiled_source)
@@ -3436,7 +3436,7 @@ def _GenerateActionsForMSBuild(spec, actions_to_add):
34363436
"""
34373437
sources_handled_by_action=OrderedSet()
34383438
actions_spec= []
3439-
forprimary_input, actionsinactions_to_add.iteritems():
3439+
forprimary_input, actionsinactions_to_add.items():
34403440
inputs=OrderedSet()
34413441
outputs=OrderedSet()
34423442
descriptions= []

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 7535e44

Browse files
rodrigcrvagg
authored andcommitted
gyp: replace deprecated functions
* assertEquals() with assertEqual() * iteritems() with items() for Python 3. * xrange() with range() for Python 3. #1150 Reviewed-By: Refael Ackermann <refack@gmail.com>
1 parent 2040cd2 commit 7535e44

22 files changed

Lines changed: 129 additions & 130 deletions

‎gyp/PRESUBMIT.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@
7676
def_LicenseHeader(input_api):
7777
# Accept any year number from 2009 to the current year.
7878
current_year=int(input_api.time.strftime('%Y'))
79-
allowed_years= (str(s) forsinreversed(xrange(2009, current_year+1)))
80-
79+
allowed_years= (str(s) forsinreversed(range(2009, current_year+1)))
8180
years_re='('+'|'.join(allowed_years) +')'
8281

8382
# The (c) is deprecated, but tolerate it until it's removed from all files.

‎gyp/pylib/gyp/MSVSSettings.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ def ConvertVCMacrosToMSBuild(s):
435435
'$(PlatformName)': '$(Platform)',
436436
'$(SafeInputName)': '%(Filename)',
437437
}
438-
forold, newinreplace_map.iteritems():
438+
forold, newinreplace_map.items():
439439
s=s.replace(old, new)
440440
s=FixVCMacroSlashes(s)
441441
returns
@@ -455,10 +455,10 @@ def ConvertToMSBuildSettings(msvs_settings, stderr=sys.stderr):
455455
dictionaries of settings and their values.
456456
"""
457457
msbuild_settings= {}
458-
formsvs_tool_name, msvs_tool_settingsinmsvs_settings.iteritems():
458+
formsvs_tool_name, msvs_tool_settingsinmsvs_settings.items():
459459
ifmsvs_tool_namein_msvs_to_msbuild_converters:
460460
msvs_tool=_msvs_to_msbuild_converters[msvs_tool_name]
461-
formsvs_setting, msvs_valueinmsvs_tool_settings.iteritems():
461+
formsvs_setting, msvs_valueinmsvs_tool_settings.items():
462462
ifmsvs_settinginmsvs_tool:
463463
# Invoke the translation function.
464464
try:
@@ -515,7 +515,7 @@ def _ValidateSettings(validators, settings, stderr):
515515
fortool_nameinsettings:
516516
iftool_nameinvalidators:
517517
tool_validators=validators[tool_name]
518-
forsetting, valueinsettings[tool_name].iteritems():
518+
forsetting, valueinsettings[tool_name].items():
519519
ifsettingintool_validators:
520520
try:
521521
tool_validators[setting](value)

‎gyp/pylib/gyp/MSVSUserFile.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def AddDebugSettings(self, config_name, command, environment = {},
9191

9292
ifenvironmentandisinstance(environment, dict):
9393
env_list= ['%s="%s"'% (key, val)
94-
for (key,val) inenvironment.iteritems()]
94+
for (key,val) inenvironment.items()]
9595
environment=' '.join(env_list)
9696
else:
9797
environment=''
@@ -135,7 +135,7 @@ def AddDebugSettings(self, config_name, command, environment = {},
135135
defWriteIfChanged(self):
136136
"""Writes the user file."""
137137
configs= ['Configurations']
138-
forconfig, specinsorted(self.configurations.iteritems()):
138+
forconfig, specinsorted(self.configurations.items()):
139139
configs.append(spec)
140140

141141
content= ['VisualStudioUserFile',

‎gyp/pylib/gyp/MSVSUtil.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ def InsertLargePdbShims(target_list, target_dicts, vars):
235235

236236
# Set up the shim to output its PDB to the same location as the final linker
237237
# target.
238-
forconfig_name, configinshim_dict.get('configurations').iteritems():
238+
forconfig_name, configinshim_dict.get('configurations').items():
239239
pdb_path=_GetPdbPath(target_dict, config_name, vars)
240240

241241
# A few keys that we don't want to propagate.

‎gyp/pylib/gyp/__init__.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def Noop(value):
209209
# We always want to ignore the environment when regenerating, to avoid
210210
# duplicate or changed flags in the environment at the time of regeneration.
211211
flags= ['--ignore-environment']
212-
forname, metadatainoptions._regeneration_metadata.iteritems():
212+
forname, metadatainoptions._regeneration_metadata.items():
213213
opt=metadata['opt']
214214
value=getattr(options, name)
215215
value_predicate=metadata['type'] =='path'andFixPathorNoop
@@ -434,7 +434,7 @@ def gyp_main(args):
434434
build_file_dir=os.path.abspath(os.path.dirname(build_file))
435435
build_file_dir_components=build_file_dir.split(os.path.sep)
436436
components_len=len(build_file_dir_components)
437-
forindexinxrange(components_len-1, -1, -1):
437+
forindexinrange(components_len-1, -1, -1):
438438
ifbuild_file_dir_components[index] =='src':
439439
options.depth=os.path.sep.join(build_file_dir_components)
440440
break

‎gyp/pylib/gyp/easy_xml.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def _ConstructContentList(xml_parts, specification, pretty, level=0):
8181
# Optionally in second position is a dictionary of the attributes.
8282
rest=specification[1:]
8383
ifrestandisinstance(rest[0], dict):
84-
forat, valinsorted(rest[0].iteritems()):
84+
forat, valinsorted(rest[0].items()):
8585
xml_parts.append(' %s="%s"'% (at, _XmlEscape(val, attr=True)))
8686
rest=rest[1:]
8787
ifrest:

‎gyp/pylib/gyp/generator/android.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ def WriteSourceFlags(self, spec, configs):
460460
Args:
461461
spec, configs: input from gyp.
462462
"""
463-
forconfigname, configinsorted(configs.iteritems()):
463+
forconfigname, configinsorted(configs.items()):
464464
extracted_includes= []
465465

466466
self.WriteLn('\n# Flags passed to both C and C++ files.')
@@ -790,7 +790,7 @@ def WriteTargetFlags(self, spec, configs, link_deps):
790790
static_libs, dynamic_libs, ldflags_libs=self.FilterLibraries(libraries)
791791

792792
ifself.type!='static_library':
793-
forconfigname, configinsorted(configs.iteritems()):
793+
forconfigname, configinsorted(configs.items()):
794794
ldflags=list(config.get('ldflags', []))
795795
self.WriteLn('')
796796
self.WriteList(ldflags, 'LOCAL_LDFLAGS_%s'%configname)
@@ -839,7 +839,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, part_of_all,
839839
settings=spec.get('aosp_build_settings', {})
840840
ifsettings:
841841
self.WriteLn('### Set directly by aosp_build_settings.')
842-
fork, vinsettings.iteritems():
842+
fork, vinsettings.items():
843843
ifisinstance(v, list):
844844
self.WriteList(v, k)
845845
else:

‎gyp/pylib/gyp/generator/gypd.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
8888
ifnotoutput_fileinoutput_files:
8989
output_files[output_file] =input_file
9090

91-
foroutput_file, input_fileinoutput_files.iteritems():
91+
foroutput_file, input_fileinoutput_files.items():
9292
output=open(output_file, 'w')
9393
pprint.pprint(data[input_file], output)
9494
output.close()

‎gyp/pylib/gyp/generator/make.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -674,7 +674,7 @@ def _ValidateSourcesForOSX(spec, all_sources):
674674
basenames.setdefault(basename, []).append(source)
675675

676676
error=''
677-
forbasename, filesinbasenames.iteritems():
677+
forbasename, filesinbasenames.items():
678678
iflen(files) >1:
679679
error+=' %s: %s\n'% (basename, ' '.join(files))
680680

@@ -1547,7 +1547,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, bundle_deps,
15471547
# Postbuilds expect to be run in the gyp file's directory, so insert an
15481548
# implicit postbuild to cd to there.
15491549
postbuilds.insert(0, gyp.common.EncodePOSIXShellList(['cd', self.path]))
1550-
foriinxrange(len(postbuilds)):
1550+
foriinrange(len(postbuilds)):
15511551
ifnotpostbuilds[i].startswith('$'):
15521552
postbuilds[i] =EscapeShellArgument(postbuilds[i])
15531553
self.WriteLn('%s: builddir := $(abs_builddir)'%QuoteSpaces(self.output))

‎gyp/pylib/gyp/generator/msvs.py‎

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ def _AddCustomBuildToolForMSVS(p, spec, primary_input,
451451
'CommandLine': cmd,
452452
})
453453
# Add to the properties of primary input for each config.
454-
forconfig_name, c_datainspec['configurations'].iteritems():
454+
forconfig_name, c_datainspec['configurations'].items():
455455
p.AddFileConfig(_FixPath(primary_input),
456456
_ConfigFullName(config_name, c_data), tools=[tool])
457457

@@ -971,7 +971,7 @@ def _ValidateSourcesForMSVSProject(spec, version):
971971
basenames.setdefault(basename, []).append(source)
972972

973973
error=''
974-
forbasename, filesinbasenames.iteritems():
974+
forbasename, filesinbasenames.items():
975975
iflen(files) >1:
976976
error+=' %s: %s\n'% (basename, ' '.join(files))
977977

@@ -1003,7 +1003,7 @@ def _GenerateMSVSProject(project, options, version, generator_flags):
10031003
relative_path_of_gyp_file=gyp.common.RelativePath(gyp_path, project_dir)
10041004

10051005
config_type=_GetMSVSConfigurationType(spec, project.build_file)
1006-
forconfig_name, configinspec['configurations'].iteritems():
1006+
forconfig_name, configinspec['configurations'].items():
10071007
_AddConfigurationToMSVSProject(p, spec, config_type, config_name, config)
10081008

10091009
# MSVC08 and prior version cannot handle duplicate basenames in the same
@@ -1369,10 +1369,10 @@ def _ConvertToolsToExpectedForm(tools):
13691369
A list of Tool objects.
13701370
"""
13711371
tool_list= []
1372-
fortool, settingsintools.iteritems():
1372+
fortool, settingsintools.items():
13731373
# Collapse settings with lists.
13741374
settings_fixed= {}
1375-
forsetting, valueinsettings.iteritems():
1375+
forsetting, valueinsettings.items():
13761376
iftype(value) ==list:
13771377
if ((tool=='VCLinkerTool'and
13781378
setting=='AdditionalDependencies') or
@@ -1547,7 +1547,7 @@ def _IdlFilesHandledNonNatively(spec, sources):
15471547
def_GetPrecompileRelatedFiles(spec):
15481548
# Gather a list of precompiled header related sources.
15491549
precompiled_related= []
1550-
for_, configinspec['configurations'].iteritems():
1550+
for_, configinspec['configurations'].items():
15511551
forkinprecomp_keys:
15521552
f=config.get(k)
15531553
iff:
@@ -1558,7 +1558,7 @@ def _GetPrecompileRelatedFiles(spec):
15581558
def_ExcludeFilesFromBeingBuilt(p, spec, excluded_sources, excluded_idl,
15591559
list_excluded):
15601560
exclusions=_GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl)
1561-
forfile_name, excluded_configsinexclusions.iteritems():
1561+
forfile_name, excluded_configsinexclusions.items():
15621562
if (notlist_excludedand
15631563
len(excluded_configs) ==len(spec['configurations'])):
15641564
# If we're not listing excluded files, then they won't appear in the
@@ -1575,7 +1575,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15751575
# Exclude excluded sources from being built.
15761576
forfinexcluded_sources:
15771577
excluded_configs= []
1578-
forconfig_name, configinspec['configurations'].iteritems():
1578+
forconfig_name, configinspec['configurations'].items():
15791579
precomped= [_FixPath(config.get(i, '')) foriinprecomp_keys]
15801580
# Don't do this for ones that are precompiled header related.
15811581
iffnotinprecomped:
@@ -1585,7 +1585,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15851585
# Exclude them now.
15861586
forfinexcluded_idl:
15871587
excluded_configs= []
1588-
forconfig_name, configinspec['configurations'].iteritems():
1588+
forconfig_name, configinspec['configurations'].items():
15891589
excluded_configs.append((config_name, config))
15901590
exclusions[f] =excluded_configs
15911591
returnexclusions
@@ -1594,7 +1594,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15941594
def_AddToolFilesToMSVS(p, spec):
15951595
# Add in tool files (rules).
15961596
tool_files=OrderedSet()
1597-
for_, configinspec['configurations'].iteritems():
1597+
for_, configinspec['configurations'].items():
15981598
forfinconfig.get('msvs_tool_files', []):
15991599
tool_files.add(f)
16001600
forfintool_files:
@@ -1607,7 +1607,7 @@ def _HandlePreCompiledHeaders(p, sources, spec):
16071607
# kind (i.e. C vs. C++) as the precompiled header source stub needs
16081608
# to have use of precompiled headers disabled.
16091609
extensions_excluded_from_precompile= []
1610-
forconfig_name, configinspec['configurations'].iteritems():
1610+
forconfig_name, configinspec['configurations'].items():
16111611
source=config.get('msvs_precompiled_source')
16121612
ifsource:
16131613
source=_FixPath(source)
@@ -1628,7 +1628,7 @@ def DisableForSourceTree(source_tree):
16281628
else:
16291629
basename, extension=os.path.splitext(source)
16301630
ifextensioninextensions_excluded_from_precompile:
1631-
forconfig_name, configinspec['configurations'].iteritems():
1631+
forconfig_name, configinspec['configurations'].items():
16321632
tool=MSVSProject.Tool('VCCLCompilerTool',
16331633
{'UsePrecompiledHeader': '0',
16341634
'ForcedIncludeFiles': '$(NOINHERIT)'})
@@ -1679,7 +1679,7 @@ def _WriteMSVSUserFile(project_path, version, spec):
16791679
return# Nothing to add
16801680
# Write out the user file.
16811681
user_file=_CreateMSVSUserFile(project_path, version, spec)
1682-
forconfig_name, c_datainspec['configurations'].iteritems():
1682+
forconfig_name, c_datainspec['configurations'].items():
16831683
user_file.AddDebugSettings(_ConfigFullName(config_name, c_data),
16841684
action, environment, working_directory)
16851685
user_file.WriteIfChanged()
@@ -1730,7 +1730,7 @@ def _GetPathDict(root, path):
17301730
def_DictsToFolders(base_path, bucket, flat):
17311731
# Convert to folders recursively.
17321732
children= []
1733-
forfolder, contentsinbucket.iteritems():
1733+
forfolder, contentsinbucket.items():
17341734
iftype(contents) ==dict:
17351735
folder_children=_DictsToFolders(os.path.join(base_path, folder),
17361736
contents, flat)
@@ -1802,7 +1802,7 @@ def _GetPlatformOverridesOfProject(spec):
18021802
# Prepare a dict indicating which project configurations are used for which
18031803
# solution configurations for this target.
18041804
config_platform_overrides= {}
1805-
forconfig_name, cinspec['configurations'].iteritems():
1805+
forconfig_name, cinspec['configurations'].items():
18061806
config_fullname=_ConfigFullName(config_name, c)
18071807
platform=c.get('msvs_target_platform', _ConfigPlatform(c))
18081808
fixed_config_fullname='%s|%s'% (
@@ -1941,7 +1941,7 @@ def PerformBuild(data, configurations, params):
19411941
msvs_version=params['msvs_version']
19421942
devenv=os.path.join(msvs_version.path, 'Common7', 'IDE', 'devenv.com')
19431943

1944-
forbuild_file, build_file_dictindata.iteritems():
1944+
forbuild_file, build_file_dictindata.items():
19451945
(build_file_root, build_file_ext) =os.path.splitext(build_file)
19461946
ifbuild_file_ext!='.gyp':
19471947
continue
@@ -1990,7 +1990,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
19901990
configs=set()
19911991
forqualified_targetintarget_list:
19921992
spec=target_dicts[qualified_target]
1993-
forconfig_name, configinspec['configurations'].iteritems():
1993+
forconfig_name, configinspec['configurations'].items():
19941994
configs.add(_ConfigFullName(config_name, config))
19951995
configs=list(configs)
19961996

@@ -2630,7 +2630,7 @@ def _GetConfigurationCondition(name, settings):
26302630

26312631
def_GetMSBuildProjectConfigurations(configurations):
26322632
group= ['ItemGroup', {'Label': 'ProjectConfigurations'}]
2633-
for (name, settings) insorted(configurations.iteritems()):
2633+
for (name, settings) insorted(configurations.items()):
26342634
configuration, platform=_GetConfigurationAndPlatform(name, settings)
26352635
designation='%s|%s'% (configuration, platform)
26362636
group.append(
@@ -2700,7 +2700,7 @@ def _GetMSBuildGlobalProperties(spec, guid, gyp_file_name):
27002700

27012701
def_GetMSBuildConfigurationDetails(spec, build_file):
27022702
properties= {}
2703-
forname, settingsinspec['configurations'].iteritems():
2703+
forname, settingsinspec['configurations'].items():
27042704
msbuild_attributes=_GetMSBuildAttributes(spec, settings, build_file)
27052705
condition=_GetConfigurationCondition(name, settings)
27062706
character_set=msbuild_attributes.get('CharacterSet')
@@ -2729,7 +2729,7 @@ def _GetMSBuildPropertySheets(configurations):
27292729
user_props=r'$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props'
27302730
additional_props= {}
27312731
props_specified=False
2732-
forname, settingsinsorted(configurations.iteritems()):
2732+
forname, settingsinsorted(configurations.items()):
27332733
configuration=_GetConfigurationCondition(name, settings)
27342734
if'msbuild_props'insettings:
27352735
additional_props[configuration] =_FixPaths(settings['msbuild_props'])
@@ -2751,7 +2751,7 @@ def _GetMSBuildPropertySheets(configurations):
27512751
]
27522752
else:
27532753
sheets= []
2754-
forcondition, propsinadditional_props.iteritems():
2754+
forcondition, propsinadditional_props.items():
27552755
import_group= [
27562756
'ImportGroup',
27572757
{'Label': 'PropertySheets',
@@ -2878,7 +2878,7 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
28782878
new_paths='$(ExecutablePath);'+';'.join(new_paths)
28792879

28802880
properties= {}
2881-
for (name, configuration) insorted(configurations.iteritems()):
2881+
for (name, configuration) insorted(configurations.items()):
28822882
condition=_GetConfigurationCondition(name, configuration)
28832883
attributes=_GetMSBuildAttributes(spec, configuration, build_file)
28842884
msbuild_settings=configuration['finalized_msbuild_settings']
@@ -2903,7 +2903,7 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
29032903
_AddConditionalProperty(properties, condition, 'ExecutablePath',
29042904
new_paths)
29052905
tool_settings=msbuild_settings.get('', {})
2906-
forname, valueinsorted(tool_settings.iteritems()):
2906+
forname, valueinsorted(tool_settings.items()):
29072907
formatted_value=_GetValueFormattedForMSBuild('', name, value)
29082908
_AddConditionalProperty(properties, condition, name, formatted_value)
29092909
return_GetMSBuildPropertyGroup(spec, None, properties)
@@ -2972,7 +2972,7 @@ def GetEdges(node):
29722972
# NOTE: reverse(topsort(DAG)) = topsort(reverse_edges(DAG))
29732973
fornameinreversed(properties_ordered):
29742974
values=properties[name]
2975-
forvalue, conditionsinsorted(values.iteritems()):
2975+
forvalue, conditionsinsorted(values.items()):
29762976
iflen(conditions) ==num_configurations:
29772977
# If the value is the same all configurations,
29782978
# just add one unconditional entry.
@@ -2985,18 +2985,18 @@ def GetEdges(node):
29852985

29862986
def_GetMSBuildToolSettingsSections(spec, configurations):
29872987
groups= []
2988-
for (name, configuration) insorted(configurations.iteritems()):
2988+
for (name, configuration) insorted(configurations.items()):
29892989
msbuild_settings=configuration['finalized_msbuild_settings']
29902990
group= ['ItemDefinitionGroup',
29912991
{'Condition': _GetConfigurationCondition(name, configuration)}
29922992
]
2993-
fortool_name, tool_settingsinsorted(msbuild_settings.iteritems()):
2993+
fortool_name, tool_settingsinsorted(msbuild_settings.items()):
29942994
# Skip the tool named '' which is a holder of global settings handled
29952995
# by _GetMSBuildConfigurationGlobalProperties.
29962996
iftool_name:
29972997
iftool_settings:
29982998
tool= [tool_name]
2999-
forname, valueinsorted(tool_settings.iteritems()):
2999+
forname, valueinsorted(tool_settings.items()):
30003000
formatted_value=_GetValueFormattedForMSBuild(tool_name, name,
30013001
value)
30023002
tool.append([name, formatted_value])
@@ -3196,7 +3196,7 @@ def _AddSources2(spec, sources, exclusions, grouped_sources,
31963196
{'Condition': condition},
31973197
'true'])
31983198
# Add precompile if needed
3199-
forconfig_name, configurationinspec['configurations'].iteritems():
3199+
forconfig_name, configurationinspec['configurations'].items():
32003200
precompiled_source=configuration.get('msvs_precompiled_source', '')
32013201
ifprecompiled_source!='':
32023202
precompiled_source=_FixPath(precompiled_source)
@@ -3436,7 +3436,7 @@ def _GenerateActionsForMSBuild(spec, actions_to_add):
34363436
"""
34373437
sources_handled_by_action=OrderedSet()
34383438
actions_spec= []
3439-
forprimary_input, actionsinactions_to_add.iteritems():
3439+
forprimary_input, actionsinactions_to_add.items():
34403440
inputs=OrderedSet()
34413441
outputs=OrderedSet()
34423442
descriptions= []

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Commit 7535e44

Browse files
rodrigcrvagg
authored andcommitted
gyp: replace deprecated functions
* assertEquals() with assertEqual() * iteritems() with items() for Python 3. * xrange() with range() for Python 3. #1150 Reviewed-By: Refael Ackermann <refack@gmail.com>
1 parent 2040cd2 commit 7535e44

22 files changed

Lines changed: 129 additions & 130 deletions

‎gyp/PRESUBMIT.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@
7676
def_LicenseHeader(input_api):
7777
# Accept any year number from 2009 to the current year.
7878
current_year=int(input_api.time.strftime('%Y'))
79-
allowed_years= (str(s) forsinreversed(xrange(2009, current_year+1)))
80-
79+
allowed_years= (str(s) forsinreversed(range(2009, current_year+1)))
8180
years_re='('+'|'.join(allowed_years) +')'
8281

8382
# The (c) is deprecated, but tolerate it until it's removed from all files.

‎gyp/pylib/gyp/MSVSSettings.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ def ConvertVCMacrosToMSBuild(s):
435435
'$(PlatformName)': '$(Platform)',
436436
'$(SafeInputName)': '%(Filename)',
437437
}
438-
forold, newinreplace_map.iteritems():
438+
forold, newinreplace_map.items():
439439
s=s.replace(old, new)
440440
s=FixVCMacroSlashes(s)
441441
returns
@@ -455,10 +455,10 @@ def ConvertToMSBuildSettings(msvs_settings, stderr=sys.stderr):
455455
dictionaries of settings and their values.
456456
"""
457457
msbuild_settings= {}
458-
formsvs_tool_name, msvs_tool_settingsinmsvs_settings.iteritems():
458+
formsvs_tool_name, msvs_tool_settingsinmsvs_settings.items():
459459
ifmsvs_tool_namein_msvs_to_msbuild_converters:
460460
msvs_tool=_msvs_to_msbuild_converters[msvs_tool_name]
461-
formsvs_setting, msvs_valueinmsvs_tool_settings.iteritems():
461+
formsvs_setting, msvs_valueinmsvs_tool_settings.items():
462462
ifmsvs_settinginmsvs_tool:
463463
# Invoke the translation function.
464464
try:
@@ -515,7 +515,7 @@ def _ValidateSettings(validators, settings, stderr):
515515
fortool_nameinsettings:
516516
iftool_nameinvalidators:
517517
tool_validators=validators[tool_name]
518-
forsetting, valueinsettings[tool_name].iteritems():
518+
forsetting, valueinsettings[tool_name].items():
519519
ifsettingintool_validators:
520520
try:
521521
tool_validators[setting](value)

‎gyp/pylib/gyp/MSVSUserFile.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def AddDebugSettings(self, config_name, command, environment = {},
9191

9292
ifenvironmentandisinstance(environment, dict):
9393
env_list= ['%s="%s"'% (key, val)
94-
for (key,val) inenvironment.iteritems()]
94+
for (key,val) inenvironment.items()]
9595
environment=' '.join(env_list)
9696
else:
9797
environment=''
@@ -135,7 +135,7 @@ def AddDebugSettings(self, config_name, command, environment = {},
135135
defWriteIfChanged(self):
136136
"""Writes the user file."""
137137
configs= ['Configurations']
138-
forconfig, specinsorted(self.configurations.iteritems()):
138+
forconfig, specinsorted(self.configurations.items()):
139139
configs.append(spec)
140140

141141
content= ['VisualStudioUserFile',

‎gyp/pylib/gyp/MSVSUtil.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ def InsertLargePdbShims(target_list, target_dicts, vars):
235235

236236
# Set up the shim to output its PDB to the same location as the final linker
237237
# target.
238-
forconfig_name, configinshim_dict.get('configurations').iteritems():
238+
forconfig_name, configinshim_dict.get('configurations').items():
239239
pdb_path=_GetPdbPath(target_dict, config_name, vars)
240240

241241
# A few keys that we don't want to propagate.

‎gyp/pylib/gyp/__init__.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def Noop(value):
209209
# We always want to ignore the environment when regenerating, to avoid
210210
# duplicate or changed flags in the environment at the time of regeneration.
211211
flags= ['--ignore-environment']
212-
forname, metadatainoptions._regeneration_metadata.iteritems():
212+
forname, metadatainoptions._regeneration_metadata.items():
213213
opt=metadata['opt']
214214
value=getattr(options, name)
215215
value_predicate=metadata['type'] =='path'andFixPathorNoop
@@ -434,7 +434,7 @@ def gyp_main(args):
434434
build_file_dir=os.path.abspath(os.path.dirname(build_file))
435435
build_file_dir_components=build_file_dir.split(os.path.sep)
436436
components_len=len(build_file_dir_components)
437-
forindexinxrange(components_len-1, -1, -1):
437+
forindexinrange(components_len-1, -1, -1):
438438
ifbuild_file_dir_components[index] =='src':
439439
options.depth=os.path.sep.join(build_file_dir_components)
440440
break

‎gyp/pylib/gyp/easy_xml.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def _ConstructContentList(xml_parts, specification, pretty, level=0):
8181
# Optionally in second position is a dictionary of the attributes.
8282
rest=specification[1:]
8383
ifrestandisinstance(rest[0], dict):
84-
forat, valinsorted(rest[0].iteritems()):
84+
forat, valinsorted(rest[0].items()):
8585
xml_parts.append(' %s="%s"'% (at, _XmlEscape(val, attr=True)))
8686
rest=rest[1:]
8787
ifrest:

‎gyp/pylib/gyp/generator/android.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ def WriteSourceFlags(self, spec, configs):
460460
Args:
461461
spec, configs: input from gyp.
462462
"""
463-
forconfigname, configinsorted(configs.iteritems()):
463+
forconfigname, configinsorted(configs.items()):
464464
extracted_includes= []
465465

466466
self.WriteLn('\n# Flags passed to both C and C++ files.')
@@ -790,7 +790,7 @@ def WriteTargetFlags(self, spec, configs, link_deps):
790790
static_libs, dynamic_libs, ldflags_libs=self.FilterLibraries(libraries)
791791

792792
ifself.type!='static_library':
793-
forconfigname, configinsorted(configs.iteritems()):
793+
forconfigname, configinsorted(configs.items()):
794794
ldflags=list(config.get('ldflags', []))
795795
self.WriteLn('')
796796
self.WriteList(ldflags, 'LOCAL_LDFLAGS_%s'%configname)
@@ -839,7 +839,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, part_of_all,
839839
settings=spec.get('aosp_build_settings', {})
840840
ifsettings:
841841
self.WriteLn('### Set directly by aosp_build_settings.')
842-
fork, vinsettings.iteritems():
842+
fork, vinsettings.items():
843843
ifisinstance(v, list):
844844
self.WriteList(v, k)
845845
else:

‎gyp/pylib/gyp/generator/gypd.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
8888
ifnotoutput_fileinoutput_files:
8989
output_files[output_file] =input_file
9090

91-
foroutput_file, input_fileinoutput_files.iteritems():
91+
foroutput_file, input_fileinoutput_files.items():
9292
output=open(output_file, 'w')
9393
pprint.pprint(data[input_file], output)
9494
output.close()

‎gyp/pylib/gyp/generator/make.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -674,7 +674,7 @@ def _ValidateSourcesForOSX(spec, all_sources):
674674
basenames.setdefault(basename, []).append(source)
675675

676676
error=''
677-
forbasename, filesinbasenames.iteritems():
677+
forbasename, filesinbasenames.items():
678678
iflen(files) >1:
679679
error+=' %s: %s\n'% (basename, ' '.join(files))
680680

@@ -1547,7 +1547,7 @@ def WriteTarget(self, spec, configs, deps, link_deps, bundle_deps,
15471547
# Postbuilds expect to be run in the gyp file's directory, so insert an
15481548
# implicit postbuild to cd to there.
15491549
postbuilds.insert(0, gyp.common.EncodePOSIXShellList(['cd', self.path]))
1550-
foriinxrange(len(postbuilds)):
1550+
foriinrange(len(postbuilds)):
15511551
ifnotpostbuilds[i].startswith('$'):
15521552
postbuilds[i] =EscapeShellArgument(postbuilds[i])
15531553
self.WriteLn('%s: builddir := $(abs_builddir)'%QuoteSpaces(self.output))

‎gyp/pylib/gyp/generator/msvs.py‎

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ def _AddCustomBuildToolForMSVS(p, spec, primary_input,
451451
'CommandLine': cmd,
452452
})
453453
# Add to the properties of primary input for each config.
454-
forconfig_name, c_datainspec['configurations'].iteritems():
454+
forconfig_name, c_datainspec['configurations'].items():
455455
p.AddFileConfig(_FixPath(primary_input),
456456
_ConfigFullName(config_name, c_data), tools=[tool])
457457

@@ -971,7 +971,7 @@ def _ValidateSourcesForMSVSProject(spec, version):
971971
basenames.setdefault(basename, []).append(source)
972972

973973
error=''
974-
forbasename, filesinbasenames.iteritems():
974+
forbasename, filesinbasenames.items():
975975
iflen(files) >1:
976976
error+=' %s: %s\n'% (basename, ' '.join(files))
977977

@@ -1003,7 +1003,7 @@ def _GenerateMSVSProject(project, options, version, generator_flags):
10031003
relative_path_of_gyp_file=gyp.common.RelativePath(gyp_path, project_dir)
10041004

10051005
config_type=_GetMSVSConfigurationType(spec, project.build_file)
1006-
forconfig_name, configinspec['configurations'].iteritems():
1006+
forconfig_name, configinspec['configurations'].items():
10071007
_AddConfigurationToMSVSProject(p, spec, config_type, config_name, config)
10081008

10091009
# MSVC08 and prior version cannot handle duplicate basenames in the same
@@ -1369,10 +1369,10 @@ def _ConvertToolsToExpectedForm(tools):
13691369
A list of Tool objects.
13701370
"""
13711371
tool_list= []
1372-
fortool, settingsintools.iteritems():
1372+
fortool, settingsintools.items():
13731373
# Collapse settings with lists.
13741374
settings_fixed= {}
1375-
forsetting, valueinsettings.iteritems():
1375+
forsetting, valueinsettings.items():
13761376
iftype(value) ==list:
13771377
if ((tool=='VCLinkerTool'and
13781378
setting=='AdditionalDependencies') or
@@ -1547,7 +1547,7 @@ def _IdlFilesHandledNonNatively(spec, sources):
15471547
def_GetPrecompileRelatedFiles(spec):
15481548
# Gather a list of precompiled header related sources.
15491549
precompiled_related= []
1550-
for_, configinspec['configurations'].iteritems():
1550+
for_, configinspec['configurations'].items():
15511551
forkinprecomp_keys:
15521552
f=config.get(k)
15531553
iff:
@@ -1558,7 +1558,7 @@ def _GetPrecompileRelatedFiles(spec):
15581558
def_ExcludeFilesFromBeingBuilt(p, spec, excluded_sources, excluded_idl,
15591559
list_excluded):
15601560
exclusions=_GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl)
1561-
forfile_name, excluded_configsinexclusions.iteritems():
1561+
forfile_name, excluded_configsinexclusions.items():
15621562
if (notlist_excludedand
15631563
len(excluded_configs) ==len(spec['configurations'])):
15641564
# If we're not listing excluded files, then they won't appear in the
@@ -1575,7 +1575,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15751575
# Exclude excluded sources from being built.
15761576
forfinexcluded_sources:
15771577
excluded_configs= []
1578-
forconfig_name, configinspec['configurations'].iteritems():
1578+
forconfig_name, configinspec['configurations'].items():
15791579
precomped= [_FixPath(config.get(i, '')) foriinprecomp_keys]
15801580
# Don't do this for ones that are precompiled header related.
15811581
iffnotinprecomped:
@@ -1585,7 +1585,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15851585
# Exclude them now.
15861586
forfinexcluded_idl:
15871587
excluded_configs= []
1588-
forconfig_name, configinspec['configurations'].iteritems():
1588+
forconfig_name, configinspec['configurations'].items():
15891589
excluded_configs.append((config_name, config))
15901590
exclusions[f] =excluded_configs
15911591
returnexclusions
@@ -1594,7 +1594,7 @@ def _GetExcludedFilesFromBuild(spec, excluded_sources, excluded_idl):
15941594
def_AddToolFilesToMSVS(p, spec):
15951595
# Add in tool files (rules).
15961596
tool_files=OrderedSet()
1597-
for_, configinspec['configurations'].iteritems():
1597+
for_, configinspec['configurations'].items():
15981598
forfinconfig.get('msvs_tool_files', []):
15991599
tool_files.add(f)
16001600
forfintool_files:
@@ -1607,7 +1607,7 @@ def _HandlePreCompiledHeaders(p, sources, spec):
16071607
# kind (i.e. C vs. C++) as the precompiled header source stub needs
16081608
# to have use of precompiled headers disabled.
16091609
extensions_excluded_from_precompile= []
1610-
forconfig_name, configinspec['configurations'].iteritems():
1610+
forconfig_name, configinspec['configurations'].items():
16111611
source=config.get('msvs_precompiled_source')
16121612
ifsource:
16131613
source=_FixPath(source)
@@ -1628,7 +1628,7 @@ def DisableForSourceTree(source_tree):
16281628
else:
16291629
basename, extension=os.path.splitext(source)
16301630
ifextensioninextensions_excluded_from_precompile:
1631-
forconfig_name, configinspec['configurations'].iteritems():
1631+
forconfig_name, configinspec['configurations'].items():
16321632
tool=MSVSProject.Tool('VCCLCompilerTool',
16331633
{'UsePrecompiledHeader': '0',
16341634
'ForcedIncludeFiles': '$(NOINHERIT)'})
@@ -1679,7 +1679,7 @@ def _WriteMSVSUserFile(project_path, version, spec):
16791679
return# Nothing to add
16801680
# Write out the user file.
16811681
user_file=_CreateMSVSUserFile(project_path, version, spec)
1682-
forconfig_name, c_datainspec['configurations'].iteritems():
1682+
forconfig_name, c_datainspec['configurations'].items():
16831683
user_file.AddDebugSettings(_ConfigFullName(config_name, c_data),
16841684
action, environment, working_directory)
16851685
user_file.WriteIfChanged()
@@ -1730,7 +1730,7 @@ def _GetPathDict(root, path):
17301730
def_DictsToFolders(base_path, bucket, flat):
17311731
# Convert to folders recursively.
17321732
children= []
1733-
forfolder, contentsinbucket.iteritems():
1733+
forfolder, contentsinbucket.items():
17341734
iftype(contents) ==dict:
17351735
folder_children=_DictsToFolders(os.path.join(base_path, folder),
17361736
contents, flat)
@@ -1802,7 +1802,7 @@ def _GetPlatformOverridesOfProject(spec):
18021802
# Prepare a dict indicating which project configurations are used for which
18031803
# solution configurations for this target.
18041804
config_platform_overrides= {}
1805-
forconfig_name, cinspec['configurations'].iteritems():
1805+
forconfig_name, cinspec['configurations'].items():
18061806
config_fullname=_ConfigFullName(config_name, c)
18071807
platform=c.get('msvs_target_platform', _ConfigPlatform(c))
18081808
fixed_config_fullname='%s|%s'% (
@@ -1941,7 +1941,7 @@ def PerformBuild(data, configurations, params):
19411941
msvs_version=params['msvs_version']
19421942
devenv=os.path.join(msvs_version.path, 'Common7', 'IDE', 'devenv.com')
19431943

1944-
forbuild_file, build_file_dictindata.iteritems():
1944+
forbuild_file, build_file_dictindata.items():
19451945
(build_file_root, build_file_ext) =os.path.splitext(build_file)
19461946
ifbuild_file_ext!='.gyp':
19471947
continue
@@ -1990,7 +1990,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
19901990
configs=set()
19911991
forqualified_targetintarget_list:
19921992
spec=target_dicts[qualified_target]
1993-
forconfig_name, configinspec['configurations'].iteritems():
1993+
forconfig_name, configinspec['configurations'].items():
19941994
configs.add(_ConfigFullName(config_name, config))
19951995
configs=list(configs)
19961996

@@ -2630,7 +2630,7 @@ def _GetConfigurationCondition(name, settings):
26302630

26312631
def_GetMSBuildProjectConfigurations(configurations):
26322632
group= ['ItemGroup', {'Label': 'ProjectConfigurations'}]
2633-
for (name, settings) insorted(configurations.iteritems()):
2633+
for (name, settings) insorted(configurations.items()):
26342634
configuration, platform=_GetConfigurationAndPlatform(name, settings)
26352635
designation='%s|%s'% (configuration, platform)
26362636
group.append(
@@ -2700,7 +2700,7 @@ def _GetMSBuildGlobalProperties(spec, guid, gyp_file_name):
27002700

27012701
def_GetMSBuildConfigurationDetails(spec, build_file):
27022702
properties= {}
2703-
forname, settingsinspec['configurations'].iteritems():
2703+
forname, settingsinspec['configurations'].items():
27042704
msbuild_attributes=_GetMSBuildAttributes(spec, settings, build_file)
27052705
condition=_GetConfigurationCondition(name, settings)
27062706
character_set=msbuild_attributes.get('CharacterSet')
@@ -2729,7 +2729,7 @@ def _GetMSBuildPropertySheets(configurations):
27292729
user_props=r'$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props'
27302730
additional_props= {}
27312731
props_specified=False
2732-
forname, settingsinsorted(configurations.iteritems()):
2732+
forname, settingsinsorted(configurations.items()):
27332733
configuration=_GetConfigurationCondition(name, settings)
27342734
if'msbuild_props'insettings:
27352735
additional_props[configuration] =_FixPaths(settings['msbuild_props'])
@@ -2751,7 +2751,7 @@ def _GetMSBuildPropertySheets(configurations):
27512751
]
27522752
else:
27532753
sheets= []
2754-
forcondition, propsinadditional_props.iteritems():
2754+
forcondition, propsinadditional_props.items():
27552755
import_group= [
27562756
'ImportGroup',
27572757
{'Label': 'PropertySheets',
@@ -2878,7 +2878,7 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
28782878
new_paths='$(ExecutablePath);'+';'.join(new_paths)
28792879

28802880
properties= {}
2881-
for (name, configuration) insorted(configurations.iteritems()):
2881+
for (name, configuration) insorted(configurations.items()):
28822882
condition=_GetConfigurationCondition(name, configuration)
28832883
attributes=_GetMSBuildAttributes(spec, configuration, build_file)
28842884
msbuild_settings=configuration['finalized_msbuild_settings']
@@ -2903,7 +2903,7 @@ def _GetMSBuildConfigurationGlobalProperties(spec, configurations, build_file):
29032903
_AddConditionalProperty(properties, condition, 'ExecutablePath',
29042904
new_paths)
29052905
tool_settings=msbuild_settings.get('', {})
2906-
forname, valueinsorted(tool_settings.iteritems()):
2906+
forname, valueinsorted(tool_settings.items()):
29072907
formatted_value=_GetValueFormattedForMSBuild('', name, value)
29082908
_AddConditionalProperty(properties, condition, name, formatted_value)
29092909
return_GetMSBuildPropertyGroup(spec, None, properties)
@@ -2972,7 +2972,7 @@ def GetEdges(node):
29722972
# NOTE: reverse(topsort(DAG)) = topsort(reverse_edges(DAG))
29732973
fornameinreversed(properties_ordered):
29742974
values=properties[name]
2975-
forvalue, conditionsinsorted(values.iteritems()):
2975+
forvalue, conditionsinsorted(values.items()):
29762976
iflen(conditions) ==num_configurations:
29772977
# If the value is the same all configurations,
29782978
# just add one unconditional entry.
@@ -2985,18 +2985,18 @@ def GetEdges(node):
29852985

29862986
def_GetMSBuildToolSettingsSections(spec, configurations):
29872987
groups= []
2988-
for (name, configuration) insorted(configurations.iteritems()):
2988+
for (name, configuration) insorted(configurations.items()):
29892989
msbuild_settings=configuration['finalized_msbuild_settings']
29902990
group= ['ItemDefinitionGroup',
29912991
{'Condition': _GetConfigurationCondition(name, configuration)}
29922992
]
2993-
fortool_name, tool_settingsinsorted(msbuild_settings.iteritems()):
2993+
fortool_name, tool_settingsinsorted(msbuild_settings.items()):
29942994
# Skip the tool named '' which is a holder of global settings handled
29952995
# by _GetMSBuildConfigurationGlobalProperties.
29962996
iftool_name:
29972997
iftool_settings:
29982998
tool= [tool_name]
2999-
forname, valueinsorted(tool_settings.iteritems()):
2999+
forname, valueinsorted(tool_settings.items()):
30003000
formatted_value=_GetValueFormattedForMSBuild(tool_name, name,
30013001
value)
30023002
tool.append([name, formatted_value])
@@ -3196,7 +3196,7 @@ def _AddSources2(spec, sources, exclusions, grouped_sources,
31963196
{'Condition': condition},
31973197
'true'])
31983198
# Add precompile if needed
3199-
forconfig_name, configurationinspec['configurations'].iteritems():
3199+
forconfig_name, configurationinspec['configurations'].items():
32003200
precompiled_source=configuration.get('msvs_precompiled_source', '')
32013201
ifprecompiled_source!='':
32023202
precompiled_source=_FixPath(precompiled_source)
@@ -3436,7 +3436,7 @@ def _GenerateActionsForMSBuild(spec, actions_to_add):
34363436
"""
34373437
sources_handled_by_action=OrderedSet()
34383438
actions_spec= []
3439-
forprimary_input, actionsinactions_to_add.iteritems():
3439+
forprimary_input, actionsinactions_to_add.items():
34403440
inputs=OrderedSet()
34413441
outputs=OrderedSet()
34423442
descriptions= []

0 commit comments

Comments
 (0)