Commit 004238d

Browse files
mcollinaaduh95
authored andcommitted
doc: clarify proxy threat model
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64366 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 241ece0 commit 004238d

3 files changed

Lines changed: 52 additions & 2 deletions

File tree

‎SECURITY.md‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,16 @@ then untrusted input must not lead to arbitrary JavaScript code execution.
221221
* The developers and infrastructure that run it.
222222
* The operating system that Node.js is running under and its configuration,
223223
along with anything under the control of the operating system.
224+
* The deployment network environment for the privacy of traffic and routing
225+
decisions, including internal networks through which Node.js traffic passes
226+
and configured HTTP(S) proxy servers. Built-in proxy support is intended to
227+
route traffic through proxies authorized for the deployment, often because a
228+
firewall requires one to access external networks. It is not intended to hide
229+
traffic from network operators or authorities governing the deployment.
230+
Untrusted or unauthorized proxies, as well as deployment policy or legal
231+
compliance controls around proxy use, are the responsibility of the deployment
232+
operator and are outside this threat model. This does not change that data
233+
parsed from network protocol peers is untrusted as described above.
224234
* The code it is asked to run, including JavaScript, WASM and native code, even
225235
if said code is dynamically loaded, e.g., all dependencies installed from the
226236
npm registry.
@@ -301,6 +311,19 @@ the community they pose.
301311
client consuming unsolicited or misordered responses within the same HTTP/1.1 connection
302312
reuse lifecycle are generally not considered Node.js vulnerabilities.
303313

314+
#### Unauthorized or untrusted HTTP proxy deployments
315+
316+
* Built-in HTTP proxy support is intended for routing outbound requests through
317+
a proxy authorized by the deployment, for example because a firewall requires
318+
one to reach external networks. It is not an anonymity, traffic-hiding, or
319+
policy-evasion feature.
320+
* Reports that depend on using an unauthorized proxy, expecting Node.js to
321+
provide privacy from a configured proxy or internal network, or expecting
322+
Node.js to enforce deployment-specific network policy or legal requirements
323+
are not considered Node.js vulnerabilities. Deployment operators are
324+
responsible for hardening such environments and controlling which proxy
325+
settings are allowed.
326+
304327
#### Malicious Third-Party Modules (CWE-1357)
305328

306329
* Code is trusted by Node.js. Therefore any scenario that requires a malicious

‎doc/api/cli.md‎

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3188,9 +3188,14 @@ added: v24.5.0
31883188
> Stability: 1.1 - Active Development
31893189
31903190
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY`
3191-
environment variables during startup, and tunnels requests over the
3191+
environment variables during startup, and routes requests through the
31923192
specified proxy.
31933193

3194+
Use this only with proxies that are trusted and authorized for the deployment.
3195+
Proxy support is intended for reaching external networks through authorized
3196+
proxy servers, for example when a firewall requires one. It is not for hiding
3197+
traffic or evading network policy. See [Built-in Proxy Support][].
3198+
31943199
This is equivalent to setting the [`NODE_USE_ENV_PROXY=1`][] environment variable.
31953200
When both are set, `--use-env-proxy` takes precedence.
31963201

@@ -3864,9 +3869,14 @@ added: v24.0.0
38643869
> Stability: 1.1 - Active Development
38653870
38663871
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY`
3867-
environment variables during startup, and tunnels requests over the
3872+
environment variables during startup, and routes requests through the
38683873
specified proxy.
38693874

3875+
Use this only with proxies that are trusted and authorized for the deployment.
3876+
Proxy support is intended for reaching external networks through authorized
3877+
proxy servers, for example when a firewall requires one. It is not for hiding
3878+
traffic or evading network policy. See [Built-in Proxy Support][].
3879+
38703880
This can also be enabled using the [`--use-env-proxy`][] command-line flag.
38713881
When both are set, `--use-env-proxy` takes precedence.
38723882

@@ -4170,6 +4180,7 @@ node --stack-trace-limit=12 -p -e "Error.stackTraceLimit" # prints 12
41704180
<!-- v8-options end -->
41714181

41724182
[#42511]: https://github.com/nodejs/node/issues/42511
4183+
[Built-in Proxy Support]: http.md#built-in-proxy-support
41734184
[Chrome DevTools Protocol]: https://chromedevtools.github.io/devtools-protocol/
41744185
[Chromium's policy for locally trusted certificates]: https://chromium.googlesource.com/chromium/src/+/main/net/data/ssl/chrome_root_store/faq.md#does-the-chrome-certificate-verifier-consider-local-trust-decisions
41754186
[CommonJS module]: modules.md

‎doc/api/http.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4525,6 +4525,22 @@ support.
45254525
45264526
If the request is made to a Unix domain socket, the proxy settings will be ignored.
45274527
4528+
### Proxy security considerations
4529+
4530+
Built-in proxy support routes outbound requests through an HTTP(S) proxy, often
4531+
because a firewall requires one to access external networks. It is not an
4532+
anonymity or traffic-hiding feature and does not attempt to hide traffic from
4533+
the proxy, the local network, network operators, or authorities that govern the
4534+
deployment.
4535+
4536+
Configure only proxies that are trusted and authorized for the deployment. A
4537+
proxy can observe connection metadata; for plain HTTP requests, or when TLS is
4538+
terminated or intercepted by the proxy, it can also observe request and response
4539+
contents. Node.js does not support treating an untrusted proxy as a privacy
4540+
boundary. Deployment operators are responsible for controlling proxy
4541+
configuration and for meeting deployment-specific network policy and legal
4542+
requirements.
4543+
45284544
### Proxy URL Format
45294545
45304546
Proxy URLs can use either HTTP or HTTPS protocols:

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Commit 004238d

Browse files
mcollinaaduh95
authored andcommitted
doc: clarify proxy threat model
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64366 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 241ece0 commit 004238d

3 files changed

Lines changed: 52 additions & 2 deletions

File tree

‎SECURITY.md‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,16 @@ then untrusted input must not lead to arbitrary JavaScript code execution.
221221
* The developers and infrastructure that run it.
222222
* The operating system that Node.js is running under and its configuration,
223223
along with anything under the control of the operating system.
224+
* The deployment network environment for the privacy of traffic and routing
225+
decisions, including internal networks through which Node.js traffic passes
226+
and configured HTTP(S) proxy servers. Built-in proxy support is intended to
227+
route traffic through proxies authorized for the deployment, often because a
228+
firewall requires one to access external networks. It is not intended to hide
229+
traffic from network operators or authorities governing the deployment.
230+
Untrusted or unauthorized proxies, as well as deployment policy or legal
231+
compliance controls around proxy use, are the responsibility of the deployment
232+
operator and are outside this threat model. This does not change that data
233+
parsed from network protocol peers is untrusted as described above.
224234
* The code it is asked to run, including JavaScript, WASM and native code, even
225235
if said code is dynamically loaded, e.g., all dependencies installed from the
226236
npm registry.
@@ -301,6 +311,19 @@ the community they pose.
301311
client consuming unsolicited or misordered responses within the same HTTP/1.1 connection
302312
reuse lifecycle are generally not considered Node.js vulnerabilities.
303313

314+
#### Unauthorized or untrusted HTTP proxy deployments
315+
316+
* Built-in HTTP proxy support is intended for routing outbound requests through
317+
a proxy authorized by the deployment, for example because a firewall requires
318+
one to reach external networks. It is not an anonymity, traffic-hiding, or
319+
policy-evasion feature.
320+
* Reports that depend on using an unauthorized proxy, expecting Node.js to
321+
provide privacy from a configured proxy or internal network, or expecting
322+
Node.js to enforce deployment-specific network policy or legal requirements
323+
are not considered Node.js vulnerabilities. Deployment operators are
324+
responsible for hardening such environments and controlling which proxy
325+
settings are allowed.
326+
304327
#### Malicious Third-Party Modules (CWE-1357)
305328

306329
* Code is trusted by Node.js. Therefore any scenario that requires a malicious

‎doc/api/cli.md‎

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3188,9 +3188,14 @@ added: v24.5.0
31883188
> Stability: 1.1 - Active Development
31893189
31903190
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY`
3191-
environment variables during startup, and tunnels requests over the
3191+
environment variables during startup, and routes requests through the
31923192
specified proxy.
31933193

3194+
Use this only with proxies that are trusted and authorized for the deployment.
3195+
Proxy support is intended for reaching external networks through authorized
3196+
proxy servers, for example when a firewall requires one. It is not for hiding
3197+
traffic or evading network policy. See [Built-in Proxy Support][].
3198+
31943199
This is equivalent to setting the [`NODE_USE_ENV_PROXY=1`][] environment variable.
31953200
When both are set, `--use-env-proxy` takes precedence.
31963201

@@ -3864,9 +3869,14 @@ added: v24.0.0
38643869
> Stability: 1.1 - Active Development
38653870
38663871
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY`
3867-
environment variables during startup, and tunnels requests over the
3872+
environment variables during startup, and routes requests through the
38683873
specified proxy.
38693874

3875+
Use this only with proxies that are trusted and authorized for the deployment.
3876+
Proxy support is intended for reaching external networks through authorized
3877+
proxy servers, for example when a firewall requires one. It is not for hiding
3878+
traffic or evading network policy. See [Built-in Proxy Support][].
3879+
38703880
This can also be enabled using the [`--use-env-proxy`][] command-line flag.
38713881
When both are set, `--use-env-proxy` takes precedence.
38723882

@@ -4170,6 +4180,7 @@ node --stack-trace-limit=12 -p -e "Error.stackTraceLimit" # prints 12
41704180
<!-- v8-options end -->
41714181

41724182
[#42511]: https://github.com/nodejs/node/issues/42511
4183+
[Built-in Proxy Support]: http.md#built-in-proxy-support
41734184
[Chrome DevTools Protocol]: https://chromedevtools.github.io/devtools-protocol/
41744185
[Chromium's policy for locally trusted certificates]: https://chromium.googlesource.com/chromium/src/+/main/net/data/ssl/chrome_root_store/faq.md#does-the-chrome-certificate-verifier-consider-local-trust-decisions
41754186
[CommonJS module]: modules.md

‎doc/api/http.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4525,6 +4525,22 @@ support.
45254525
45264526
If the request is made to a Unix domain socket, the proxy settings will be ignored.
45274527
4528+
### Proxy security considerations
4529+
4530+
Built-in proxy support routes outbound requests through an HTTP(S) proxy, often
4531+
because a firewall requires one to access external networks. It is not an
4532+
anonymity or traffic-hiding feature and does not attempt to hide traffic from
4533+
the proxy, the local network, network operators, or authorities that govern the
4534+
deployment.
4535+
4536+
Configure only proxies that are trusted and authorized for the deployment. A
4537+
proxy can observe connection metadata; for plain HTTP requests, or when TLS is
4538+
terminated or intercepted by the proxy, it can also observe request and response
4539+
contents. Node.js does not support treating an untrusted proxy as a privacy
4540+
boundary. Deployment operators are responsible for controlling proxy
4541+
configuration and for meeting deployment-specific network policy and legal
4542+
requirements.
4543+
45284544
### Proxy URL Format
45294545
45304546
Proxy URLs can use either HTTP or HTTPS protocols:

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 004238d

Browse files
mcollinaaduh95
authored andcommitted
doc: clarify proxy threat model
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64366 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 241ece0 commit 004238d

3 files changed

Lines changed: 52 additions & 2 deletions

File tree

‎SECURITY.md‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,16 @@ then untrusted input must not lead to arbitrary JavaScript code execution.
221221
* The developers and infrastructure that run it.
222222
* The operating system that Node.js is running under and its configuration,
223223
along with anything under the control of the operating system.
224+
* The deployment network environment for the privacy of traffic and routing
225+
decisions, including internal networks through which Node.js traffic passes
226+
and configured HTTP(S) proxy servers. Built-in proxy support is intended to
227+
route traffic through proxies authorized for the deployment, often because a
228+
firewall requires one to access external networks. It is not intended to hide
229+
traffic from network operators or authorities governing the deployment.
230+
Untrusted or unauthorized proxies, as well as deployment policy or legal
231+
compliance controls around proxy use, are the responsibility of the deployment
232+
operator and are outside this threat model. This does not change that data
233+
parsed from network protocol peers is untrusted as described above.
224234
* The code it is asked to run, including JavaScript, WASM and native code, even
225235
if said code is dynamically loaded, e.g., all dependencies installed from the
226236
npm registry.
@@ -301,6 +311,19 @@ the community they pose.
301311
client consuming unsolicited or misordered responses within the same HTTP/1.1 connection
302312
reuse lifecycle are generally not considered Node.js vulnerabilities.
303313

314+
#### Unauthorized or untrusted HTTP proxy deployments
315+
316+
* Built-in HTTP proxy support is intended for routing outbound requests through
317+
a proxy authorized by the deployment, for example because a firewall requires
318+
one to reach external networks. It is not an anonymity, traffic-hiding, or
319+
policy-evasion feature.
320+
* Reports that depend on using an unauthorized proxy, expecting Node.js to
321+
provide privacy from a configured proxy or internal network, or expecting
322+
Node.js to enforce deployment-specific network policy or legal requirements
323+
are not considered Node.js vulnerabilities. Deployment operators are
324+
responsible for hardening such environments and controlling which proxy
325+
settings are allowed.
326+
304327
#### Malicious Third-Party Modules (CWE-1357)
305328

306329
* Code is trusted by Node.js. Therefore any scenario that requires a malicious

‎doc/api/cli.md‎

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3188,9 +3188,14 @@ added: v24.5.0
31883188
> Stability: 1.1 - Active Development
31893189
31903190
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY`
3191-
environment variables during startup, and tunnels requests over the
3191+
environment variables during startup, and routes requests through the
31923192
specified proxy.
31933193

3194+
Use this only with proxies that are trusted and authorized for the deployment.
3195+
Proxy support is intended for reaching external networks through authorized
3196+
proxy servers, for example when a firewall requires one. It is not for hiding
3197+
traffic or evading network policy. See [Built-in Proxy Support][].
3198+
31943199
This is equivalent to setting the [`NODE_USE_ENV_PROXY=1`][] environment variable.
31953200
When both are set, `--use-env-proxy` takes precedence.
31963201

@@ -3864,9 +3869,14 @@ added: v24.0.0
38643869
> Stability: 1.1 - Active Development
38653870
38663871
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY`
3867-
environment variables during startup, and tunnels requests over the
3872+
environment variables during startup, and routes requests through the
38683873
specified proxy.
38693874

3875+
Use this only with proxies that are trusted and authorized for the deployment.
3876+
Proxy support is intended for reaching external networks through authorized
3877+
proxy servers, for example when a firewall requires one. It is not for hiding
3878+
traffic or evading network policy. See [Built-in Proxy Support][].
3879+
38703880
This can also be enabled using the [`--use-env-proxy`][] command-line flag.
38713881
When both are set, `--use-env-proxy` takes precedence.
38723882

@@ -4170,6 +4180,7 @@ node --stack-trace-limit=12 -p -e "Error.stackTraceLimit" # prints 12
41704180
<!-- v8-options end -->
41714181

41724182
[#42511]: https://github.com/nodejs/node/issues/42511
4183+
[Built-in Proxy Support]: http.md#built-in-proxy-support
41734184
[Chrome DevTools Protocol]: https://chromedevtools.github.io/devtools-protocol/
41744185
[Chromium's policy for locally trusted certificates]: https://chromium.googlesource.com/chromium/src/+/main/net/data/ssl/chrome_root_store/faq.md#does-the-chrome-certificate-verifier-consider-local-trust-decisions
41754186
[CommonJS module]: modules.md

‎doc/api/http.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4525,6 +4525,22 @@ support.
45254525
45264526
If the request is made to a Unix domain socket, the proxy settings will be ignored.
45274527
4528+
### Proxy security considerations
4529+
4530+
Built-in proxy support routes outbound requests through an HTTP(S) proxy, often
4531+
because a firewall requires one to access external networks. It is not an
4532+
anonymity or traffic-hiding feature and does not attempt to hide traffic from
4533+
the proxy, the local network, network operators, or authorities that govern the
4534+
deployment.
4535+
4536+
Configure only proxies that are trusted and authorized for the deployment. A
4537+
proxy can observe connection metadata; for plain HTTP requests, or when TLS is
4538+
terminated or intercepted by the proxy, it can also observe request and response
4539+
contents. Node.js does not support treating an untrusted proxy as a privacy
4540+
boundary. Deployment operators are responsible for controlling proxy
4541+
configuration and for meeting deployment-specific network policy and legal
4542+
requirements.
4543+
45284544
### Proxy URL Format
45294545
45304546
Proxy URLs can use either HTTP or HTTPS protocols:

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 004238d

Browse files
mcollinaaduh95
authored andcommitted
doc: clarify proxy threat model
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64366 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 241ece0 commit 004238d

3 files changed

Lines changed: 52 additions & 2 deletions

File tree

‎SECURITY.md‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,16 @@ then untrusted input must not lead to arbitrary JavaScript code execution.
221221
* The developers and infrastructure that run it.
222222
* The operating system that Node.js is running under and its configuration,
223223
along with anything under the control of the operating system.
224+
* The deployment network environment for the privacy of traffic and routing
225+
decisions, including internal networks through which Node.js traffic passes
226+
and configured HTTP(S) proxy servers. Built-in proxy support is intended to
227+
route traffic through proxies authorized for the deployment, often because a
228+
firewall requires one to access external networks. It is not intended to hide
229+
traffic from network operators or authorities governing the deployment.
230+
Untrusted or unauthorized proxies, as well as deployment policy or legal
231+
compliance controls around proxy use, are the responsibility of the deployment
232+
operator and are outside this threat model. This does not change that data
233+
parsed from network protocol peers is untrusted as described above.
224234
* The code it is asked to run, including JavaScript, WASM and native code, even
225235
if said code is dynamically loaded, e.g., all dependencies installed from the
226236
npm registry.
@@ -301,6 +311,19 @@ the community they pose.
301311
client consuming unsolicited or misordered responses within the same HTTP/1.1 connection
302312
reuse lifecycle are generally not considered Node.js vulnerabilities.
303313

314+
#### Unauthorized or untrusted HTTP proxy deployments
315+
316+
* Built-in HTTP proxy support is intended for routing outbound requests through
317+
a proxy authorized by the deployment, for example because a firewall requires
318+
one to reach external networks. It is not an anonymity, traffic-hiding, or
319+
policy-evasion feature.
320+
* Reports that depend on using an unauthorized proxy, expecting Node.js to
321+
provide privacy from a configured proxy or internal network, or expecting
322+
Node.js to enforce deployment-specific network policy or legal requirements
323+
are not considered Node.js vulnerabilities. Deployment operators are
324+
responsible for hardening such environments and controlling which proxy
325+
settings are allowed.
326+
304327
#### Malicious Third-Party Modules (CWE-1357)
305328

306329
* Code is trusted by Node.js. Therefore any scenario that requires a malicious

‎doc/api/cli.md‎

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3188,9 +3188,14 @@ added: v24.5.0
31883188
> Stability: 1.1 - Active Development
31893189
31903190
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY`
3191-
environment variables during startup, and tunnels requests over the
3191+
environment variables during startup, and routes requests through the
31923192
specified proxy.
31933193

3194+
Use this only with proxies that are trusted and authorized for the deployment.
3195+
Proxy support is intended for reaching external networks through authorized
3196+
proxy servers, for example when a firewall requires one. It is not for hiding
3197+
traffic or evading network policy. See [Built-in Proxy Support][].
3198+
31943199
This is equivalent to setting the [`NODE_USE_ENV_PROXY=1`][] environment variable.
31953200
When both are set, `--use-env-proxy` takes precedence.
31963201

@@ -3864,9 +3869,14 @@ added: v24.0.0
38643869
> Stability: 1.1 - Active Development
38653870
38663871
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY`
3867-
environment variables during startup, and tunnels requests over the
3872+
environment variables during startup, and routes requests through the
38683873
specified proxy.
38693874

3875+
Use this only with proxies that are trusted and authorized for the deployment.
3876+
Proxy support is intended for reaching external networks through authorized
3877+
proxy servers, for example when a firewall requires one. It is not for hiding
3878+
traffic or evading network policy. See [Built-in Proxy Support][].
3879+
38703880
This can also be enabled using the [`--use-env-proxy`][] command-line flag.
38713881
When both are set, `--use-env-proxy` takes precedence.
38723882

@@ -4170,6 +4180,7 @@ node --stack-trace-limit=12 -p -e "Error.stackTraceLimit" # prints 12
41704180
<!-- v8-options end -->
41714181

41724182
[#42511]: https://github.com/nodejs/node/issues/42511
4183+
[Built-in Proxy Support]: http.md#built-in-proxy-support
41734184
[Chrome DevTools Protocol]: https://chromedevtools.github.io/devtools-protocol/
41744185
[Chromium's policy for locally trusted certificates]: https://chromium.googlesource.com/chromium/src/+/main/net/data/ssl/chrome_root_store/faq.md#does-the-chrome-certificate-verifier-consider-local-trust-decisions
41754186
[CommonJS module]: modules.md

‎doc/api/http.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4525,6 +4525,22 @@ support.
45254525
45264526
If the request is made to a Unix domain socket, the proxy settings will be ignored.
45274527
4528+
### Proxy security considerations
4529+
4530+
Built-in proxy support routes outbound requests through an HTTP(S) proxy, often
4531+
because a firewall requires one to access external networks. It is not an
4532+
anonymity or traffic-hiding feature and does not attempt to hide traffic from
4533+
the proxy, the local network, network operators, or authorities that govern the
4534+
deployment.
4535+
4536+
Configure only proxies that are trusted and authorized for the deployment. A
4537+
proxy can observe connection metadata; for plain HTTP requests, or when TLS is
4538+
terminated or intercepted by the proxy, it can also observe request and response
4539+
contents. Node.js does not support treating an untrusted proxy as a privacy
4540+
boundary. Deployment operators are responsible for controlling proxy
4541+
configuration and for meeting deployment-specific network policy and legal
4542+
requirements.
4543+
45284544
### Proxy URL Format
45294545
45304546
Proxy URLs can use either HTTP or HTTPS protocols:

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Commit 004238d

Browse files
mcollinaaduh95
authored andcommitted
doc: clarify proxy threat model
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64366 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 241ece0 commit 004238d

3 files changed

Lines changed: 52 additions & 2 deletions

File tree

‎SECURITY.md‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,16 @@ then untrusted input must not lead to arbitrary JavaScript code execution.
221221
* The developers and infrastructure that run it.
222222
* The operating system that Node.js is running under and its configuration,
223223
along with anything under the control of the operating system.
224+
* The deployment network environment for the privacy of traffic and routing
225+
decisions, including internal networks through which Node.js traffic passes
226+
and configured HTTP(S) proxy servers. Built-in proxy support is intended to
227+
route traffic through proxies authorized for the deployment, often because a
228+
firewall requires one to access external networks. It is not intended to hide
229+
traffic from network operators or authorities governing the deployment.
230+
Untrusted or unauthorized proxies, as well as deployment policy or legal
231+
compliance controls around proxy use, are the responsibility of the deployment
232+
operator and are outside this threat model. This does not change that data
233+
parsed from network protocol peers is untrusted as described above.
224234
* The code it is asked to run, including JavaScript, WASM and native code, even
225235
if said code is dynamically loaded, e.g., all dependencies installed from the
226236
npm registry.
@@ -301,6 +311,19 @@ the community they pose.
301311
client consuming unsolicited or misordered responses within the same HTTP/1.1 connection
302312
reuse lifecycle are generally not considered Node.js vulnerabilities.
303313

314+
#### Unauthorized or untrusted HTTP proxy deployments
315+
316+
* Built-in HTTP proxy support is intended for routing outbound requests through
317+
a proxy authorized by the deployment, for example because a firewall requires
318+
one to reach external networks. It is not an anonymity, traffic-hiding, or
319+
policy-evasion feature.
320+
* Reports that depend on using an unauthorized proxy, expecting Node.js to
321+
provide privacy from a configured proxy or internal network, or expecting
322+
Node.js to enforce deployment-specific network policy or legal requirements
323+
are not considered Node.js vulnerabilities. Deployment operators are
324+
responsible for hardening such environments and controlling which proxy
325+
settings are allowed.
326+
304327
#### Malicious Third-Party Modules (CWE-1357)
305328

306329
* Code is trusted by Node.js. Therefore any scenario that requires a malicious

‎doc/api/cli.md‎

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3188,9 +3188,14 @@ added: v24.5.0
31883188
> Stability: 1.1 - Active Development
31893189
31903190
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY`
3191-
environment variables during startup, and tunnels requests over the
3191+
environment variables during startup, and routes requests through the
31923192
specified proxy.
31933193

3194+
Use this only with proxies that are trusted and authorized for the deployment.
3195+
Proxy support is intended for reaching external networks through authorized
3196+
proxy servers, for example when a firewall requires one. It is not for hiding
3197+
traffic or evading network policy. See [Built-in Proxy Support][].
3198+
31943199
This is equivalent to setting the [`NODE_USE_ENV_PROXY=1`][] environment variable.
31953200
When both are set, `--use-env-proxy` takes precedence.
31963201

@@ -3864,9 +3869,14 @@ added: v24.0.0
38643869
> Stability: 1.1 - Active Development
38653870
38663871
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY`
3867-
environment variables during startup, and tunnels requests over the
3872+
environment variables during startup, and routes requests through the
38683873
specified proxy.
38693874

3875+
Use this only with proxies that are trusted and authorized for the deployment.
3876+
Proxy support is intended for reaching external networks through authorized
3877+
proxy servers, for example when a firewall requires one. It is not for hiding
3878+
traffic or evading network policy. See [Built-in Proxy Support][].
3879+
38703880
This can also be enabled using the [`--use-env-proxy`][] command-line flag.
38713881
When both are set, `--use-env-proxy` takes precedence.
38723882

@@ -4170,6 +4180,7 @@ node --stack-trace-limit=12 -p -e "Error.stackTraceLimit" # prints 12
41704180
<!-- v8-options end -->
41714181

41724182
[#42511]: https://github.com/nodejs/node/issues/42511
4183+
[Built-in Proxy Support]: http.md#built-in-proxy-support
41734184
[Chrome DevTools Protocol]: https://chromedevtools.github.io/devtools-protocol/
41744185
[Chromium's policy for locally trusted certificates]: https://chromium.googlesource.com/chromium/src/+/main/net/data/ssl/chrome_root_store/faq.md#does-the-chrome-certificate-verifier-consider-local-trust-decisions
41754186
[CommonJS module]: modules.md

‎doc/api/http.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4525,6 +4525,22 @@ support.
45254525
45264526
If the request is made to a Unix domain socket, the proxy settings will be ignored.
45274527
4528+
### Proxy security considerations
4529+
4530+
Built-in proxy support routes outbound requests through an HTTP(S) proxy, often
4531+
because a firewall requires one to access external networks. It is not an
4532+
anonymity or traffic-hiding feature and does not attempt to hide traffic from
4533+
the proxy, the local network, network operators, or authorities that govern the
4534+
deployment.
4535+
4536+
Configure only proxies that are trusted and authorized for the deployment. A
4537+
proxy can observe connection metadata; for plain HTTP requests, or when TLS is
4538+
terminated or intercepted by the proxy, it can also observe request and response
4539+
contents. Node.js does not support treating an untrusted proxy as a privacy
4540+
boundary. Deployment operators are responsible for controlling proxy
4541+
configuration and for meeting deployment-specific network policy and legal
4542+
requirements.
4543+
45284544
### Proxy URL Format
45294545
45304546
Proxy URLs can use either HTTP or HTTPS protocols:

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 004238d

Browse files
mcollinaaduh95
authored andcommitted
doc: clarify proxy threat model
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64366 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 241ece0 commit 004238d

3 files changed

Lines changed: 52 additions & 2 deletions

File tree

‎SECURITY.md‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,16 @@ then untrusted input must not lead to arbitrary JavaScript code execution.
221221
* The developers and infrastructure that run it.
222222
* The operating system that Node.js is running under and its configuration,
223223
along with anything under the control of the operating system.
224+
* The deployment network environment for the privacy of traffic and routing
225+
decisions, including internal networks through which Node.js traffic passes
226+
and configured HTTP(S) proxy servers. Built-in proxy support is intended to
227+
route traffic through proxies authorized for the deployment, often because a
228+
firewall requires one to access external networks. It is not intended to hide
229+
traffic from network operators or authorities governing the deployment.
230+
Untrusted or unauthorized proxies, as well as deployment policy or legal
231+
compliance controls around proxy use, are the responsibility of the deployment
232+
operator and are outside this threat model. This does not change that data
233+
parsed from network protocol peers is untrusted as described above.
224234
* The code it is asked to run, including JavaScript, WASM and native code, even
225235
if said code is dynamically loaded, e.g., all dependencies installed from the
226236
npm registry.
@@ -301,6 +311,19 @@ the community they pose.
301311
client consuming unsolicited or misordered responses within the same HTTP/1.1 connection
302312
reuse lifecycle are generally not considered Node.js vulnerabilities.
303313

314+
#### Unauthorized or untrusted HTTP proxy deployments
315+
316+
* Built-in HTTP proxy support is intended for routing outbound requests through
317+
a proxy authorized by the deployment, for example because a firewall requires
318+
one to reach external networks. It is not an anonymity, traffic-hiding, or
319+
policy-evasion feature.
320+
* Reports that depend on using an unauthorized proxy, expecting Node.js to
321+
provide privacy from a configured proxy or internal network, or expecting
322+
Node.js to enforce deployment-specific network policy or legal requirements
323+
are not considered Node.js vulnerabilities. Deployment operators are
324+
responsible for hardening such environments and controlling which proxy
325+
settings are allowed.
326+
304327
#### Malicious Third-Party Modules (CWE-1357)
305328

306329
* Code is trusted by Node.js. Therefore any scenario that requires a malicious

‎doc/api/cli.md‎

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3188,9 +3188,14 @@ added: v24.5.0
31883188
> Stability: 1.1 - Active Development
31893189
31903190
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY`
3191-
environment variables during startup, and tunnels requests over the
3191+
environment variables during startup, and routes requests through the
31923192
specified proxy.
31933193

3194+
Use this only with proxies that are trusted and authorized for the deployment.
3195+
Proxy support is intended for reaching external networks through authorized
3196+
proxy servers, for example when a firewall requires one. It is not for hiding
3197+
traffic or evading network policy. See [Built-in Proxy Support][].
3198+
31943199
This is equivalent to setting the [`NODE_USE_ENV_PROXY=1`][] environment variable.
31953200
When both are set, `--use-env-proxy` takes precedence.
31963201

@@ -3864,9 +3869,14 @@ added: v24.0.0
38643869
> Stability: 1.1 - Active Development
38653870
38663871
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY`
3867-
environment variables during startup, and tunnels requests over the
3872+
environment variables during startup, and routes requests through the
38683873
specified proxy.
38693874

3875+
Use this only with proxies that are trusted and authorized for the deployment.
3876+
Proxy support is intended for reaching external networks through authorized
3877+
proxy servers, for example when a firewall requires one. It is not for hiding
3878+
traffic or evading network policy. See [Built-in Proxy Support][].
3879+
38703880
This can also be enabled using the [`--use-env-proxy`][] command-line flag.
38713881
When both are set, `--use-env-proxy` takes precedence.
38723882

@@ -4170,6 +4180,7 @@ node --stack-trace-limit=12 -p -e "Error.stackTraceLimit" # prints 12
41704180
<!-- v8-options end -->
41714181

41724182
[#42511]: https://github.com/nodejs/node/issues/42511
4183+
[Built-in Proxy Support]: http.md#built-in-proxy-support
41734184
[Chrome DevTools Protocol]: https://chromedevtools.github.io/devtools-protocol/
41744185
[Chromium's policy for locally trusted certificates]: https://chromium.googlesource.com/chromium/src/+/main/net/data/ssl/chrome_root_store/faq.md#does-the-chrome-certificate-verifier-consider-local-trust-decisions
41754186
[CommonJS module]: modules.md

‎doc/api/http.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4525,6 +4525,22 @@ support.
45254525
45264526
If the request is made to a Unix domain socket, the proxy settings will be ignored.
45274527
4528+
### Proxy security considerations
4529+
4530+
Built-in proxy support routes outbound requests through an HTTP(S) proxy, often
4531+
because a firewall requires one to access external networks. It is not an
4532+
anonymity or traffic-hiding feature and does not attempt to hide traffic from
4533+
the proxy, the local network, network operators, or authorities that govern the
4534+
deployment.
4535+
4536+
Configure only proxies that are trusted and authorized for the deployment. A
4537+
proxy can observe connection metadata; for plain HTTP requests, or when TLS is
4538+
terminated or intercepted by the proxy, it can also observe request and response
4539+
contents. Node.js does not support treating an untrusted proxy as a privacy
4540+
boundary. Deployment operators are responsible for controlling proxy
4541+
configuration and for meeting deployment-specific network policy and legal
4542+
requirements.
4543+
45284544
### Proxy URL Format
45294545
45304546
Proxy URLs can use either HTTP or HTTPS protocols:

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 004238d

Browse files
mcollinaaduh95
authored andcommitted
doc: clarify proxy threat model
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64366 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 241ece0 commit 004238d

3 files changed

Lines changed: 52 additions & 2 deletions

File tree

‎SECURITY.md‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,16 @@ then untrusted input must not lead to arbitrary JavaScript code execution.
221221
* The developers and infrastructure that run it.
222222
* The operating system that Node.js is running under and its configuration,
223223
along with anything under the control of the operating system.
224+
* The deployment network environment for the privacy of traffic and routing
225+
decisions, including internal networks through which Node.js traffic passes
226+
and configured HTTP(S) proxy servers. Built-in proxy support is intended to
227+
route traffic through proxies authorized for the deployment, often because a
228+
firewall requires one to access external networks. It is not intended to hide
229+
traffic from network operators or authorities governing the deployment.
230+
Untrusted or unauthorized proxies, as well as deployment policy or legal
231+
compliance controls around proxy use, are the responsibility of the deployment
232+
operator and are outside this threat model. This does not change that data
233+
parsed from network protocol peers is untrusted as described above.
224234
* The code it is asked to run, including JavaScript, WASM and native code, even
225235
if said code is dynamically loaded, e.g., all dependencies installed from the
226236
npm registry.
@@ -301,6 +311,19 @@ the community they pose.
301311
client consuming unsolicited or misordered responses within the same HTTP/1.1 connection
302312
reuse lifecycle are generally not considered Node.js vulnerabilities.
303313

314+
#### Unauthorized or untrusted HTTP proxy deployments
315+
316+
* Built-in HTTP proxy support is intended for routing outbound requests through
317+
a proxy authorized by the deployment, for example because a firewall requires
318+
one to reach external networks. It is not an anonymity, traffic-hiding, or
319+
policy-evasion feature.
320+
* Reports that depend on using an unauthorized proxy, expecting Node.js to
321+
provide privacy from a configured proxy or internal network, or expecting
322+
Node.js to enforce deployment-specific network policy or legal requirements
323+
are not considered Node.js vulnerabilities. Deployment operators are
324+
responsible for hardening such environments and controlling which proxy
325+
settings are allowed.
326+
304327
#### Malicious Third-Party Modules (CWE-1357)
305328

306329
* Code is trusted by Node.js. Therefore any scenario that requires a malicious

‎doc/api/cli.md‎

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3188,9 +3188,14 @@ added: v24.5.0
31883188
> Stability: 1.1 - Active Development
31893189
31903190
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY`
3191-
environment variables during startup, and tunnels requests over the
3191+
environment variables during startup, and routes requests through the
31923192
specified proxy.
31933193

3194+
Use this only with proxies that are trusted and authorized for the deployment.
3195+
Proxy support is intended for reaching external networks through authorized
3196+
proxy servers, for example when a firewall requires one. It is not for hiding
3197+
traffic or evading network policy. See [Built-in Proxy Support][].
3198+
31943199
This is equivalent to setting the [`NODE_USE_ENV_PROXY=1`][] environment variable.
31953200
When both are set, `--use-env-proxy` takes precedence.
31963201

@@ -3864,9 +3869,14 @@ added: v24.0.0
38643869
> Stability: 1.1 - Active Development
38653870
38663871
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY`
3867-
environment variables during startup, and tunnels requests over the
3872+
environment variables during startup, and routes requests through the
38683873
specified proxy.
38693874

3875+
Use this only with proxies that are trusted and authorized for the deployment.
3876+
Proxy support is intended for reaching external networks through authorized
3877+
proxy servers, for example when a firewall requires one. It is not for hiding
3878+
traffic or evading network policy. See [Built-in Proxy Support][].
3879+
38703880
This can also be enabled using the [`--use-env-proxy`][] command-line flag.
38713881
When both are set, `--use-env-proxy` takes precedence.
38723882

@@ -4170,6 +4180,7 @@ node --stack-trace-limit=12 -p -e "Error.stackTraceLimit" # prints 12
41704180
<!-- v8-options end -->
41714181

41724182
[#42511]: https://github.com/nodejs/node/issues/42511
4183+
[Built-in Proxy Support]: http.md#built-in-proxy-support
41734184
[Chrome DevTools Protocol]: https://chromedevtools.github.io/devtools-protocol/
41744185
[Chromium's policy for locally trusted certificates]: https://chromium.googlesource.com/chromium/src/+/main/net/data/ssl/chrome_root_store/faq.md#does-the-chrome-certificate-verifier-consider-local-trust-decisions
41754186
[CommonJS module]: modules.md

‎doc/api/http.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4525,6 +4525,22 @@ support.
45254525
45264526
If the request is made to a Unix domain socket, the proxy settings will be ignored.
45274527
4528+
### Proxy security considerations
4529+
4530+
Built-in proxy support routes outbound requests through an HTTP(S) proxy, often
4531+
because a firewall requires one to access external networks. It is not an
4532+
anonymity or traffic-hiding feature and does not attempt to hide traffic from
4533+
the proxy, the local network, network operators, or authorities that govern the
4534+
deployment.
4535+
4536+
Configure only proxies that are trusted and authorized for the deployment. A
4537+
proxy can observe connection metadata; for plain HTTP requests, or when TLS is
4538+
terminated or intercepted by the proxy, it can also observe request and response
4539+
contents. Node.js does not support treating an untrusted proxy as a privacy
4540+
boundary. Deployment operators are responsible for controlling proxy
4541+
configuration and for meeting deployment-specific network policy and legal
4542+
requirements.
4543+
45284544
### Proxy URL Format
45294545
45304546
Proxy URLs can use either HTTP or HTTPS protocols:

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Commit 004238d

Browse files
mcollinaaduh95
authored andcommitted
doc: clarify proxy threat model
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64366 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 241ece0 commit 004238d

3 files changed

Lines changed: 52 additions & 2 deletions

File tree

‎SECURITY.md‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,16 @@ then untrusted input must not lead to arbitrary JavaScript code execution.
221221
* The developers and infrastructure that run it.
222222
* The operating system that Node.js is running under and its configuration,
223223
along with anything under the control of the operating system.
224+
* The deployment network environment for the privacy of traffic and routing
225+
decisions, including internal networks through which Node.js traffic passes
226+
and configured HTTP(S) proxy servers. Built-in proxy support is intended to
227+
route traffic through proxies authorized for the deployment, often because a
228+
firewall requires one to access external networks. It is not intended to hide
229+
traffic from network operators or authorities governing the deployment.
230+
Untrusted or unauthorized proxies, as well as deployment policy or legal
231+
compliance controls around proxy use, are the responsibility of the deployment
232+
operator and are outside this threat model. This does not change that data
233+
parsed from network protocol peers is untrusted as described above.
224234
* The code it is asked to run, including JavaScript, WASM and native code, even
225235
if said code is dynamically loaded, e.g., all dependencies installed from the
226236
npm registry.
@@ -301,6 +311,19 @@ the community they pose.
301311
client consuming unsolicited or misordered responses within the same HTTP/1.1 connection
302312
reuse lifecycle are generally not considered Node.js vulnerabilities.
303313

314+
#### Unauthorized or untrusted HTTP proxy deployments
315+
316+
* Built-in HTTP proxy support is intended for routing outbound requests through
317+
a proxy authorized by the deployment, for example because a firewall requires
318+
one to reach external networks. It is not an anonymity, traffic-hiding, or
319+
policy-evasion feature.
320+
* Reports that depend on using an unauthorized proxy, expecting Node.js to
321+
provide privacy from a configured proxy or internal network, or expecting
322+
Node.js to enforce deployment-specific network policy or legal requirements
323+
are not considered Node.js vulnerabilities. Deployment operators are
324+
responsible for hardening such environments and controlling which proxy
325+
settings are allowed.
326+
304327
#### Malicious Third-Party Modules (CWE-1357)
305328

306329
* Code is trusted by Node.js. Therefore any scenario that requires a malicious

‎doc/api/cli.md‎

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3188,9 +3188,14 @@ added: v24.5.0
31883188
> Stability: 1.1 - Active Development
31893189
31903190
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY`
3191-
environment variables during startup, and tunnels requests over the
3191+
environment variables during startup, and routes requests through the
31923192
specified proxy.
31933193

3194+
Use this only with proxies that are trusted and authorized for the deployment.
3195+
Proxy support is intended for reaching external networks through authorized
3196+
proxy servers, for example when a firewall requires one. It is not for hiding
3197+
traffic or evading network policy. See [Built-in Proxy Support][].
3198+
31943199
This is equivalent to setting the [`NODE_USE_ENV_PROXY=1`][] environment variable.
31953200
When both are set, `--use-env-proxy` takes precedence.
31963201

@@ -3864,9 +3869,14 @@ added: v24.0.0
38643869
> Stability: 1.1 - Active Development
38653870
38663871
When enabled, Node.js parses the `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY`
3867-
environment variables during startup, and tunnels requests over the
3872+
environment variables during startup, and routes requests through the
38683873
specified proxy.
38693874

3875+
Use this only with proxies that are trusted and authorized for the deployment.
3876+
Proxy support is intended for reaching external networks through authorized
3877+
proxy servers, for example when a firewall requires one. It is not for hiding
3878+
traffic or evading network policy. See [Built-in Proxy Support][].
3879+
38703880
This can also be enabled using the [`--use-env-proxy`][] command-line flag.
38713881
When both are set, `--use-env-proxy` takes precedence.
38723882

@@ -4170,6 +4180,7 @@ node --stack-trace-limit=12 -p -e "Error.stackTraceLimit" # prints 12
41704180
<!-- v8-options end -->
41714181

41724182
[#42511]: https://github.com/nodejs/node/issues/42511
4183+
[Built-in Proxy Support]: http.md#built-in-proxy-support
41734184
[Chrome DevTools Protocol]: https://chromedevtools.github.io/devtools-protocol/
41744185
[Chromium's policy for locally trusted certificates]: https://chromium.googlesource.com/chromium/src/+/main/net/data/ssl/chrome_root_store/faq.md#does-the-chrome-certificate-verifier-consider-local-trust-decisions
41754186
[CommonJS module]: modules.md

‎doc/api/http.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4525,6 +4525,22 @@ support.
45254525
45264526
If the request is made to a Unix domain socket, the proxy settings will be ignored.
45274527
4528+
### Proxy security considerations
4529+
4530+
Built-in proxy support routes outbound requests through an HTTP(S) proxy, often
4531+
because a firewall requires one to access external networks. It is not an
4532+
anonymity or traffic-hiding feature and does not attempt to hide traffic from
4533+
the proxy, the local network, network operators, or authorities that govern the
4534+
deployment.
4535+
4536+
Configure only proxies that are trusted and authorized for the deployment. A
4537+
proxy can observe connection metadata; for plain HTTP requests, or when TLS is
4538+
terminated or intercepted by the proxy, it can also observe request and response
4539+
contents. Node.js does not support treating an untrusted proxy as a privacy
4540+
boundary. Deployment operators are responsible for controlling proxy
4541+
configuration and for meeting deployment-specific network policy and legal
4542+
requirements.
4543+
45284544
### Proxy URL Format
45294545
45304546
Proxy URLs can use either HTTP or HTTPS protocols:

0 commit comments

Comments
 (0)