lib: replace string prototype usage with alternatives

avivkeller · aduh95 · commit 014bf01efc11 · 2024-04-29T22:46:11.000+02:00
PR-URL: #52440 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
diff --git a/lib/internal/options.js b/lib/internal/options.js
@@ -5,6 +5,10 @@ const {
 getEmbedderOptions: getEmbedderOptionsFromBinding,
 } = internalBinding('options');
 
+const {
+ StringPrototypeSlice,
+} = primordials;
+
 let warnOnAllowUnauthorized = true;
 
 let optionsMap;
@@ -43,8 +47,15 @@ function refreshOptions() {
 
 function getOptionValue(optionName) {
 const options = getCLIOptionsFromBinding();
- if (optionName.startsWith('--no-')) {
- const option = options.get('--' + optionName.slice(5));
+ if (
+ optionName.length > 5 &&
+ optionName[0] === '-' &&
+ optionName[1] === '-' &&
+ optionName[2] === 'n' &&
+ optionName[3] === 'o' &&
+ optionName[4] === '-'
+ ) {
+ const option = options.get('--' + StringPrototypeSlice(optionName, 5));
 return option && !option.value;
 }
 return options.get(optionName)?.value;

-Original file line number
+Diff line change
 getEmbedderOptions: getEmbedderOptionsFromBinding,
 }=internalBinding('options');
 +const{
 + StringPrototypeSlice,
 +}=primordials;
++
 letwarnOnAllowUnauthorized=true;
 letoptionsMap;
 functiongetOptionValue(optionName){
 constoptions=getCLIOptionsFromBinding();
 -if(optionName.startsWith('--no-')){
 -constoption=options.get('--'+optionName.slice(5));
 +if(
 +optionName.length>5&&
 +optionName[0]==='-'&&
 +optionName[1]==='-'&&
 +optionName[2]==='n'&&
 +optionName[3]==='o'&&
 +optionName[4]==='-'
 +){
 +constoption=options.get('--'+StringPrototypeSlice(optionName,5));
 returnoption&&!option.value;
+}
 returnoptions.get(optionName)?.value;