Commit 01a8ae0

Browse files
RafaelGSSaduh95
authored andcommitted
permission: guard UDP handle adoption
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #65358 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 1d6ec2d commit 01a8ae0

3 files changed

Lines changed: 150 additions & 0 deletions

File tree

β€Žsrc/udp_wrap.ccβ€Ž

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@ void UDPWrap::DoBind(const FunctionCallbackInfo<Value>& args, int family) {
325325
err = uv_udp_bind(&wrap->handle_,
326326
reinterpret_cast<const sockaddr*>(&addr_storage),
327327
flags);
328+
if (err == 0) wrap->net_permission_granted_ = true;
328329
}
329330

330331
if (err == 0)
@@ -358,6 +359,7 @@ void UDPWrap::DoConnect(const FunctionCallbackInfo<Value>& args, int family) {
358359
if (err == 0) {
359360
err = uv_udp_connect(&wrap->handle_,
360361
reinterpret_cast<const sockaddr*>(&addr_storage));
362+
if (err == 0) wrap->net_permission_granted_ = true;
361363
}
362364

363365
args.GetReturnValue().Set(err);
@@ -368,9 +370,14 @@ void UDPWrap::Open(const FunctionCallbackInfo<Value>& args) {
368370
UDPWrap* wrap;
369371
ASSIGN_OR_RETURN_UNWRAP(
370372
&wrap, args.This(), args.GetReturnValue().Set(UV_EBADF));
373+
Environment* env = wrap->env();
374+
375+
THROW_IF_INSUFFICIENT_PERMISSIONS(env, permission::PermissionScope::kNet, "");
376+
371377
CHECK(args[0]->IsNumber());
372378
int fd = FromV8Value<int>(args[0]);
373379
int err = uv_udp_open(&wrap->handle_, fd);
380+
if (err == 0) wrap->net_permission_granted_ = true;
374381

375382
args.GetReturnValue().Set(err);
376383
}
@@ -697,6 +704,13 @@ void UDPWrapBase::RecvStart(const FunctionCallbackInfo<Value>& args) {
697704

698705
intUDPWrap::RecvStart() {
699706
if (IsHandleClosing()) returnUV_EBADF;
707+
708+
if (!net_permission_granted_) {
709+
THROW_IF_INSUFFICIENT_PERMISSIONS(
710+
env(), permission::PermissionScope::kNet, "", UV_EACCES);
711+
net_permission_granted_ = true;
712+
}
713+
700714
int err = uv_udp_recv_start(&handle_, OnAlloc, OnRecv);
701715
// UV_EALREADY means that the socket is already bound but that's okay
702716
if (err == UV_EALREADY)

β€Žsrc/udp_wrap.hβ€Ž

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@ class UDPWrap final : public HandleWrap,
214214

215215
uv_udp_t handle_;
216216

217+
bool net_permission_granted_ = false;
217218
bool current_send_has_callback_;
218219
v8::Local<v8::Object> current_send_req_wrap_;
219220
};
Lines changed: 135 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,135 @@
1+
// Flags: --expose-internals
2+
'use strict';
3+
4+
constcommon=require('../common');
5+
if(common.isWindows){
6+
common.skip('Sending dgram sockets to child processes is not supported');
7+
}
8+
9+
constassert=require('assert');
10+
constdgram=require('dgram');
11+
const{ fork, spawn }=require('child_process');
12+
13+
constmode=process.argv[2];
14+
constkStateSymbol=mode===undefined ?
15+
require('internal/dgram').kStateSymbol : undefined;
16+
17+
if(mode==='ipc-denied'){
18+
process.on('message',common.mustNotCall());
19+
process.send('ready');
20+
}elseif(mode==='ipc-drop'){
21+
process.once('message',common.mustCall((message,handle)=>{
22+
assert.strictEqual(message,'socket');
23+
assert(process.permission.has('net'));
24+
25+
process.permission.drop('net');
26+
assert(!process.permission.has('net'));
27+
28+
handle.once('message',common.mustCall((data)=>{
29+
assert.strictEqual(data.toString(),'after-drop');
30+
handle.close();
31+
process.send('received');
32+
}));
33+
process.send('receiving');
34+
}));
35+
process.send('ready');
36+
}else{
37+
constdeniedSocket=dgram.createSocket('udp4');
38+
deniedSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
39+
constchild=fork(__filename,['ipc-denied'],{
40+
execArgv: ['--permission','--allow-fs-read=*'],
41+
silent: true,
42+
});
43+
letstderr='';
44+
45+
child.stderr.setEncoding('utf8');
46+
child.stderr.on('data',(chunk)=>{stderr+=chunk;});
47+
child.once('message',common.mustCall((message)=>{
48+
assert.strictEqual(message,'ready');
49+
child.send('socket',deniedSocket);
50+
}));
51+
child.once('exit',common.mustCall((code,signal)=>{
52+
assert.strictEqual(code,1);
53+
assert.strictEqual(signal,null);
54+
assert.match(stderr,/ERR_ACCESS_DENIED/);
55+
assert.match(stderr,/permission:'Net'/);
56+
deniedSocket.close();
57+
}));
58+
}));
59+
60+
constdroppedSocket=dgram.createSocket('udp4');
61+
constsender=dgram.createSocket('udp4');
62+
droppedSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
63+
constchild=fork(__filename,['ipc-drop'],{
64+
execArgv: [
65+
'--permission',
66+
'--allow-net',
67+
'--allow-fs-read=*',
68+
],
69+
});
70+
lettimer;
71+
72+
child.on('message',common.mustCall((message)=>{
73+
if(message==='ready'){
74+
child.send('socket',droppedSocket);
75+
}elseif(message==='receiving'){
76+
const{ port }=droppedSocket.address();
77+
timer=setInterval(()=>{
78+
sender.send('after-drop',port,'127.0.0.1');
79+
},10);
80+
}else{
81+
assert.strictEqual(message,'received');
82+
clearInterval(timer);
83+
sender.close();
84+
droppedSocket.close();
85+
child.disconnect();
86+
}
87+
},3));
88+
child.once('exit',common.mustCall((code,signal)=>{
89+
assert.strictEqual(code,0);
90+
assert.strictEqual(signal,null);
91+
}));
92+
}));
93+
94+
constfdSocket=dgram.createSocket('udp4');
95+
fdSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
96+
constsource=`
97+
const assert = require('node:assert');
98+
const dgram = require('node:dgram');
99+
const socket = dgram.createSocket('udp4');
100+
let error;
101+
try {
102+
socket.bind({ fd: 3 });
103+
} catch (err) {
104+
error = err;
105+
}
106+
if (error) {
107+
assert.strictEqual(error.code, 'ERR_ACCESS_DENIED');
108+
assert.strictEqual(error.permission, 'Net');
109+
process.exit(0);
110+
}
111+
process.exit(1);
112+
`;
113+
constchild=spawn(
114+
process.execPath,
115+
['--permission','--eval',source],
116+
{
117+
stdio: [
118+
'ignore',
119+
'ignore',
120+
'pipe',
121+
fdSocket[kStateSymbol].handle.fd,
122+
],
123+
},
124+
);
125+
letstderr='';
126+
127+
child.stderr.setEncoding('utf8');
128+
child.stderr.on('data',(chunk)=>{stderr+=chunk;});
129+
child.once('exit',common.mustCall((code,signal)=>{
130+
assert.strictEqual(code,0,stderr);
131+
assert.strictEqual(signal,null);
132+
fdSocket.close();
133+
}));
134+
}));
135+
}

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Commit 01a8ae0

Browse files
RafaelGSSaduh95
authored andcommitted
permission: guard UDP handle adoption
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #65358 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 1d6ec2d commit 01a8ae0

3 files changed

Lines changed: 150 additions & 0 deletions

File tree

β€Žsrc/udp_wrap.ccβ€Ž

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@ void UDPWrap::DoBind(const FunctionCallbackInfo<Value>& args, int family) {
325325
err = uv_udp_bind(&wrap->handle_,
326326
reinterpret_cast<const sockaddr*>(&addr_storage),
327327
flags);
328+
if (err == 0) wrap->net_permission_granted_ = true;
328329
}
329330

330331
if (err == 0)
@@ -358,6 +359,7 @@ void UDPWrap::DoConnect(const FunctionCallbackInfo<Value>& args, int family) {
358359
if (err == 0) {
359360
err = uv_udp_connect(&wrap->handle_,
360361
reinterpret_cast<const sockaddr*>(&addr_storage));
362+
if (err == 0) wrap->net_permission_granted_ = true;
361363
}
362364

363365
args.GetReturnValue().Set(err);
@@ -368,9 +370,14 @@ void UDPWrap::Open(const FunctionCallbackInfo<Value>& args) {
368370
UDPWrap* wrap;
369371
ASSIGN_OR_RETURN_UNWRAP(
370372
&wrap, args.This(), args.GetReturnValue().Set(UV_EBADF));
373+
Environment* env = wrap->env();
374+
375+
THROW_IF_INSUFFICIENT_PERMISSIONS(env, permission::PermissionScope::kNet, "");
376+
371377
CHECK(args[0]->IsNumber());
372378
int fd = FromV8Value<int>(args[0]);
373379
int err = uv_udp_open(&wrap->handle_, fd);
380+
if (err == 0) wrap->net_permission_granted_ = true;
374381

375382
args.GetReturnValue().Set(err);
376383
}
@@ -697,6 +704,13 @@ void UDPWrapBase::RecvStart(const FunctionCallbackInfo<Value>& args) {
697704

698705
intUDPWrap::RecvStart() {
699706
if (IsHandleClosing()) returnUV_EBADF;
707+
708+
if (!net_permission_granted_) {
709+
THROW_IF_INSUFFICIENT_PERMISSIONS(
710+
env(), permission::PermissionScope::kNet, "", UV_EACCES);
711+
net_permission_granted_ = true;
712+
}
713+
700714
int err = uv_udp_recv_start(&handle_, OnAlloc, OnRecv);
701715
// UV_EALREADY means that the socket is already bound but that's okay
702716
if (err == UV_EALREADY)

β€Žsrc/udp_wrap.hβ€Ž

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@ class UDPWrap final : public HandleWrap,
214214

215215
uv_udp_t handle_;
216216

217+
bool net_permission_granted_ = false;
217218
bool current_send_has_callback_;
218219
v8::Local<v8::Object> current_send_req_wrap_;
219220
};
Lines changed: 135 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,135 @@
1+
// Flags: --expose-internals
2+
'use strict';
3+
4+
constcommon=require('../common');
5+
if(common.isWindows){
6+
common.skip('Sending dgram sockets to child processes is not supported');
7+
}
8+
9+
constassert=require('assert');
10+
constdgram=require('dgram');
11+
const{ fork, spawn }=require('child_process');
12+
13+
constmode=process.argv[2];
14+
constkStateSymbol=mode===undefined ?
15+
require('internal/dgram').kStateSymbol : undefined;
16+
17+
if(mode==='ipc-denied'){
18+
process.on('message',common.mustNotCall());
19+
process.send('ready');
20+
}elseif(mode==='ipc-drop'){
21+
process.once('message',common.mustCall((message,handle)=>{
22+
assert.strictEqual(message,'socket');
23+
assert(process.permission.has('net'));
24+
25+
process.permission.drop('net');
26+
assert(!process.permission.has('net'));
27+
28+
handle.once('message',common.mustCall((data)=>{
29+
assert.strictEqual(data.toString(),'after-drop');
30+
handle.close();
31+
process.send('received');
32+
}));
33+
process.send('receiving');
34+
}));
35+
process.send('ready');
36+
}else{
37+
constdeniedSocket=dgram.createSocket('udp4');
38+
deniedSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
39+
constchild=fork(__filename,['ipc-denied'],{
40+
execArgv: ['--permission','--allow-fs-read=*'],
41+
silent: true,
42+
});
43+
letstderr='';
44+
45+
child.stderr.setEncoding('utf8');
46+
child.stderr.on('data',(chunk)=>{stderr+=chunk;});
47+
child.once('message',common.mustCall((message)=>{
48+
assert.strictEqual(message,'ready');
49+
child.send('socket',deniedSocket);
50+
}));
51+
child.once('exit',common.mustCall((code,signal)=>{
52+
assert.strictEqual(code,1);
53+
assert.strictEqual(signal,null);
54+
assert.match(stderr,/ERR_ACCESS_DENIED/);
55+
assert.match(stderr,/permission:'Net'/);
56+
deniedSocket.close();
57+
}));
58+
}));
59+
60+
constdroppedSocket=dgram.createSocket('udp4');
61+
constsender=dgram.createSocket('udp4');
62+
droppedSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
63+
constchild=fork(__filename,['ipc-drop'],{
64+
execArgv: [
65+
'--permission',
66+
'--allow-net',
67+
'--allow-fs-read=*',
68+
],
69+
});
70+
lettimer;
71+
72+
child.on('message',common.mustCall((message)=>{
73+
if(message==='ready'){
74+
child.send('socket',droppedSocket);
75+
}elseif(message==='receiving'){
76+
const{ port }=droppedSocket.address();
77+
timer=setInterval(()=>{
78+
sender.send('after-drop',port,'127.0.0.1');
79+
},10);
80+
}else{
81+
assert.strictEqual(message,'received');
82+
clearInterval(timer);
83+
sender.close();
84+
droppedSocket.close();
85+
child.disconnect();
86+
}
87+
},3));
88+
child.once('exit',common.mustCall((code,signal)=>{
89+
assert.strictEqual(code,0);
90+
assert.strictEqual(signal,null);
91+
}));
92+
}));
93+
94+
constfdSocket=dgram.createSocket('udp4');
95+
fdSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
96+
constsource=`
97+
const assert = require('node:assert');
98+
const dgram = require('node:dgram');
99+
const socket = dgram.createSocket('udp4');
100+
let error;
101+
try {
102+
socket.bind({ fd: 3 });
103+
} catch (err) {
104+
error = err;
105+
}
106+
if (error) {
107+
assert.strictEqual(error.code, 'ERR_ACCESS_DENIED');
108+
assert.strictEqual(error.permission, 'Net');
109+
process.exit(0);
110+
}
111+
process.exit(1);
112+
`;
113+
constchild=spawn(
114+
process.execPath,
115+
['--permission','--eval',source],
116+
{
117+
stdio: [
118+
'ignore',
119+
'ignore',
120+
'pipe',
121+
fdSocket[kStateSymbol].handle.fd,
122+
],
123+
},
124+
);
125+
letstderr='';
126+
127+
child.stderr.setEncoding('utf8');
128+
child.stderr.on('data',(chunk)=>{stderr+=chunk;});
129+
child.once('exit',common.mustCall((code,signal)=>{
130+
assert.strictEqual(code,0,stderr);
131+
assert.strictEqual(signal,null);
132+
fdSocket.close();
133+
}));
134+
}));
135+
}

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 01a8ae0

Browse files
RafaelGSSaduh95
authored andcommitted
permission: guard UDP handle adoption
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #65358 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 1d6ec2d commit 01a8ae0

3 files changed

Lines changed: 150 additions & 0 deletions

File tree

β€Žsrc/udp_wrap.ccβ€Ž

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@ void UDPWrap::DoBind(const FunctionCallbackInfo<Value>& args, int family) {
325325
err = uv_udp_bind(&wrap->handle_,
326326
reinterpret_cast<const sockaddr*>(&addr_storage),
327327
flags);
328+
if (err == 0) wrap->net_permission_granted_ = true;
328329
}
329330

330331
if (err == 0)
@@ -358,6 +359,7 @@ void UDPWrap::DoConnect(const FunctionCallbackInfo<Value>& args, int family) {
358359
if (err == 0) {
359360
err = uv_udp_connect(&wrap->handle_,
360361
reinterpret_cast<const sockaddr*>(&addr_storage));
362+
if (err == 0) wrap->net_permission_granted_ = true;
361363
}
362364

363365
args.GetReturnValue().Set(err);
@@ -368,9 +370,14 @@ void UDPWrap::Open(const FunctionCallbackInfo<Value>& args) {
368370
UDPWrap* wrap;
369371
ASSIGN_OR_RETURN_UNWRAP(
370372
&wrap, args.This(), args.GetReturnValue().Set(UV_EBADF));
373+
Environment* env = wrap->env();
374+
375+
THROW_IF_INSUFFICIENT_PERMISSIONS(env, permission::PermissionScope::kNet, "");
376+
371377
CHECK(args[0]->IsNumber());
372378
int fd = FromV8Value<int>(args[0]);
373379
int err = uv_udp_open(&wrap->handle_, fd);
380+
if (err == 0) wrap->net_permission_granted_ = true;
374381

375382
args.GetReturnValue().Set(err);
376383
}
@@ -697,6 +704,13 @@ void UDPWrapBase::RecvStart(const FunctionCallbackInfo<Value>& args) {
697704

698705
intUDPWrap::RecvStart() {
699706
if (IsHandleClosing()) returnUV_EBADF;
707+
708+
if (!net_permission_granted_) {
709+
THROW_IF_INSUFFICIENT_PERMISSIONS(
710+
env(), permission::PermissionScope::kNet, "", UV_EACCES);
711+
net_permission_granted_ = true;
712+
}
713+
700714
int err = uv_udp_recv_start(&handle_, OnAlloc, OnRecv);
701715
// UV_EALREADY means that the socket is already bound but that's okay
702716
if (err == UV_EALREADY)

β€Žsrc/udp_wrap.hβ€Ž

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@ class UDPWrap final : public HandleWrap,
214214

215215
uv_udp_t handle_;
216216

217+
bool net_permission_granted_ = false;
217218
bool current_send_has_callback_;
218219
v8::Local<v8::Object> current_send_req_wrap_;
219220
};
Lines changed: 135 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,135 @@
1+
// Flags: --expose-internals
2+
'use strict';
3+
4+
constcommon=require('../common');
5+
if(common.isWindows){
6+
common.skip('Sending dgram sockets to child processes is not supported');
7+
}
8+
9+
constassert=require('assert');
10+
constdgram=require('dgram');
11+
const{ fork, spawn }=require('child_process');
12+
13+
constmode=process.argv[2];
14+
constkStateSymbol=mode===undefined ?
15+
require('internal/dgram').kStateSymbol : undefined;
16+
17+
if(mode==='ipc-denied'){
18+
process.on('message',common.mustNotCall());
19+
process.send('ready');
20+
}elseif(mode==='ipc-drop'){
21+
process.once('message',common.mustCall((message,handle)=>{
22+
assert.strictEqual(message,'socket');
23+
assert(process.permission.has('net'));
24+
25+
process.permission.drop('net');
26+
assert(!process.permission.has('net'));
27+
28+
handle.once('message',common.mustCall((data)=>{
29+
assert.strictEqual(data.toString(),'after-drop');
30+
handle.close();
31+
process.send('received');
32+
}));
33+
process.send('receiving');
34+
}));
35+
process.send('ready');
36+
}else{
37+
constdeniedSocket=dgram.createSocket('udp4');
38+
deniedSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
39+
constchild=fork(__filename,['ipc-denied'],{
40+
execArgv: ['--permission','--allow-fs-read=*'],
41+
silent: true,
42+
});
43+
letstderr='';
44+
45+
child.stderr.setEncoding('utf8');
46+
child.stderr.on('data',(chunk)=>{stderr+=chunk;});
47+
child.once('message',common.mustCall((message)=>{
48+
assert.strictEqual(message,'ready');
49+
child.send('socket',deniedSocket);
50+
}));
51+
child.once('exit',common.mustCall((code,signal)=>{
52+
assert.strictEqual(code,1);
53+
assert.strictEqual(signal,null);
54+
assert.match(stderr,/ERR_ACCESS_DENIED/);
55+
assert.match(stderr,/permission:'Net'/);
56+
deniedSocket.close();
57+
}));
58+
}));
59+
60+
constdroppedSocket=dgram.createSocket('udp4');
61+
constsender=dgram.createSocket('udp4');
62+
droppedSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
63+
constchild=fork(__filename,['ipc-drop'],{
64+
execArgv: [
65+
'--permission',
66+
'--allow-net',
67+
'--allow-fs-read=*',
68+
],
69+
});
70+
lettimer;
71+
72+
child.on('message',common.mustCall((message)=>{
73+
if(message==='ready'){
74+
child.send('socket',droppedSocket);
75+
}elseif(message==='receiving'){
76+
const{ port }=droppedSocket.address();
77+
timer=setInterval(()=>{
78+
sender.send('after-drop',port,'127.0.0.1');
79+
},10);
80+
}else{
81+
assert.strictEqual(message,'received');
82+
clearInterval(timer);
83+
sender.close();
84+
droppedSocket.close();
85+
child.disconnect();
86+
}
87+
},3));
88+
child.once('exit',common.mustCall((code,signal)=>{
89+
assert.strictEqual(code,0);
90+
assert.strictEqual(signal,null);
91+
}));
92+
}));
93+
94+
constfdSocket=dgram.createSocket('udp4');
95+
fdSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
96+
constsource=`
97+
const assert = require('node:assert');
98+
const dgram = require('node:dgram');
99+
const socket = dgram.createSocket('udp4');
100+
let error;
101+
try {
102+
socket.bind({ fd: 3 });
103+
} catch (err) {
104+
error = err;
105+
}
106+
if (error) {
107+
assert.strictEqual(error.code, 'ERR_ACCESS_DENIED');
108+
assert.strictEqual(error.permission, 'Net');
109+
process.exit(0);
110+
}
111+
process.exit(1);
112+
`;
113+
constchild=spawn(
114+
process.execPath,
115+
['--permission','--eval',source],
116+
{
117+
stdio: [
118+
'ignore',
119+
'ignore',
120+
'pipe',
121+
fdSocket[kStateSymbol].handle.fd,
122+
],
123+
},
124+
);
125+
letstderr='';
126+
127+
child.stderr.setEncoding('utf8');
128+
child.stderr.on('data',(chunk)=>{stderr+=chunk;});
129+
child.once('exit',common.mustCall((code,signal)=>{
130+
assert.strictEqual(code,0,stderr);
131+
assert.strictEqual(signal,null);
132+
fdSocket.close();
133+
}));
134+
}));
135+
}

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 01a8ae0

Browse files
RafaelGSSaduh95
authored andcommitted
permission: guard UDP handle adoption
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #65358 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 1d6ec2d commit 01a8ae0

3 files changed

Lines changed: 150 additions & 0 deletions

File tree

β€Žsrc/udp_wrap.ccβ€Ž

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@ void UDPWrap::DoBind(const FunctionCallbackInfo<Value>& args, int family) {
325325
err = uv_udp_bind(&wrap->handle_,
326326
reinterpret_cast<const sockaddr*>(&addr_storage),
327327
flags);
328+
if (err == 0) wrap->net_permission_granted_ = true;
328329
}
329330

330331
if (err == 0)
@@ -358,6 +359,7 @@ void UDPWrap::DoConnect(const FunctionCallbackInfo<Value>& args, int family) {
358359
if (err == 0) {
359360
err = uv_udp_connect(&wrap->handle_,
360361
reinterpret_cast<const sockaddr*>(&addr_storage));
362+
if (err == 0) wrap->net_permission_granted_ = true;
361363
}
362364

363365
args.GetReturnValue().Set(err);
@@ -368,9 +370,14 @@ void UDPWrap::Open(const FunctionCallbackInfo<Value>& args) {
368370
UDPWrap* wrap;
369371
ASSIGN_OR_RETURN_UNWRAP(
370372
&wrap, args.This(), args.GetReturnValue().Set(UV_EBADF));
373+
Environment* env = wrap->env();
374+
375+
THROW_IF_INSUFFICIENT_PERMISSIONS(env, permission::PermissionScope::kNet, "");
376+
371377
CHECK(args[0]->IsNumber());
372378
int fd = FromV8Value<int>(args[0]);
373379
int err = uv_udp_open(&wrap->handle_, fd);
380+
if (err == 0) wrap->net_permission_granted_ = true;
374381

375382
args.GetReturnValue().Set(err);
376383
}
@@ -697,6 +704,13 @@ void UDPWrapBase::RecvStart(const FunctionCallbackInfo<Value>& args) {
697704

698705
intUDPWrap::RecvStart() {
699706
if (IsHandleClosing()) returnUV_EBADF;
707+
708+
if (!net_permission_granted_) {
709+
THROW_IF_INSUFFICIENT_PERMISSIONS(
710+
env(), permission::PermissionScope::kNet, "", UV_EACCES);
711+
net_permission_granted_ = true;
712+
}
713+
700714
int err = uv_udp_recv_start(&handle_, OnAlloc, OnRecv);
701715
// UV_EALREADY means that the socket is already bound but that's okay
702716
if (err == UV_EALREADY)

β€Žsrc/udp_wrap.hβ€Ž

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@ class UDPWrap final : public HandleWrap,
214214

215215
uv_udp_t handle_;
216216

217+
bool net_permission_granted_ = false;
217218
bool current_send_has_callback_;
218219
v8::Local<v8::Object> current_send_req_wrap_;
219220
};
Lines changed: 135 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,135 @@
1+
// Flags: --expose-internals
2+
'use strict';
3+
4+
constcommon=require('../common');
5+
if(common.isWindows){
6+
common.skip('Sending dgram sockets to child processes is not supported');
7+
}
8+
9+
constassert=require('assert');
10+
constdgram=require('dgram');
11+
const{ fork, spawn }=require('child_process');
12+
13+
constmode=process.argv[2];
14+
constkStateSymbol=mode===undefined ?
15+
require('internal/dgram').kStateSymbol : undefined;
16+
17+
if(mode==='ipc-denied'){
18+
process.on('message',common.mustNotCall());
19+
process.send('ready');
20+
}elseif(mode==='ipc-drop'){
21+
process.once('message',common.mustCall((message,handle)=>{
22+
assert.strictEqual(message,'socket');
23+
assert(process.permission.has('net'));
24+
25+
process.permission.drop('net');
26+
assert(!process.permission.has('net'));
27+
28+
handle.once('message',common.mustCall((data)=>{
29+
assert.strictEqual(data.toString(),'after-drop');
30+
handle.close();
31+
process.send('received');
32+
}));
33+
process.send('receiving');
34+
}));
35+
process.send('ready');
36+
}else{
37+
constdeniedSocket=dgram.createSocket('udp4');
38+
deniedSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
39+
constchild=fork(__filename,['ipc-denied'],{
40+
execArgv: ['--permission','--allow-fs-read=*'],
41+
silent: true,
42+
});
43+
letstderr='';
44+
45+
child.stderr.setEncoding('utf8');
46+
child.stderr.on('data',(chunk)=>{stderr+=chunk;});
47+
child.once('message',common.mustCall((message)=>{
48+
assert.strictEqual(message,'ready');
49+
child.send('socket',deniedSocket);
50+
}));
51+
child.once('exit',common.mustCall((code,signal)=>{
52+
assert.strictEqual(code,1);
53+
assert.strictEqual(signal,null);
54+
assert.match(stderr,/ERR_ACCESS_DENIED/);
55+
assert.match(stderr,/permission:'Net'/);
56+
deniedSocket.close();
57+
}));
58+
}));
59+
60+
constdroppedSocket=dgram.createSocket('udp4');
61+
constsender=dgram.createSocket('udp4');
62+
droppedSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
63+
constchild=fork(__filename,['ipc-drop'],{
64+
execArgv: [
65+
'--permission',
66+
'--allow-net',
67+
'--allow-fs-read=*',
68+
],
69+
});
70+
lettimer;
71+
72+
child.on('message',common.mustCall((message)=>{
73+
if(message==='ready'){
74+
child.send('socket',droppedSocket);
75+
}elseif(message==='receiving'){
76+
const{ port }=droppedSocket.address();
77+
timer=setInterval(()=>{
78+
sender.send('after-drop',port,'127.0.0.1');
79+
},10);
80+
}else{
81+
assert.strictEqual(message,'received');
82+
clearInterval(timer);
83+
sender.close();
84+
droppedSocket.close();
85+
child.disconnect();
86+
}
87+
},3));
88+
child.once('exit',common.mustCall((code,signal)=>{
89+
assert.strictEqual(code,0);
90+
assert.strictEqual(signal,null);
91+
}));
92+
}));
93+
94+
constfdSocket=dgram.createSocket('udp4');
95+
fdSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
96+
constsource=`
97+
const assert = require('node:assert');
98+
const dgram = require('node:dgram');
99+
const socket = dgram.createSocket('udp4');
100+
let error;
101+
try {
102+
socket.bind({ fd: 3 });
103+
} catch (err) {
104+
error = err;
105+
}
106+
if (error) {
107+
assert.strictEqual(error.code, 'ERR_ACCESS_DENIED');
108+
assert.strictEqual(error.permission, 'Net');
109+
process.exit(0);
110+
}
111+
process.exit(1);
112+
`;
113+
constchild=spawn(
114+
process.execPath,
115+
['--permission','--eval',source],
116+
{
117+
stdio: [
118+
'ignore',
119+
'ignore',
120+
'pipe',
121+
fdSocket[kStateSymbol].handle.fd,
122+
],
123+
},
124+
);
125+
letstderr='';
126+
127+
child.stderr.setEncoding('utf8');
128+
child.stderr.on('data',(chunk)=>{stderr+=chunk;});
129+
child.once('exit',common.mustCall((code,signal)=>{
130+
assert.strictEqual(code,0,stderr);
131+
assert.strictEqual(signal,null);
132+
fdSocket.close();
133+
}));
134+
}));
135+
}

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Commit 01a8ae0

Browse files
RafaelGSSaduh95
authored andcommitted
permission: guard UDP handle adoption
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #65358 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 1d6ec2d commit 01a8ae0

3 files changed

Lines changed: 150 additions & 0 deletions

File tree

β€Žsrc/udp_wrap.ccβ€Ž

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@ void UDPWrap::DoBind(const FunctionCallbackInfo<Value>& args, int family) {
325325
err = uv_udp_bind(&wrap->handle_,
326326
reinterpret_cast<const sockaddr*>(&addr_storage),
327327
flags);
328+
if (err == 0) wrap->net_permission_granted_ = true;
328329
}
329330

330331
if (err == 0)
@@ -358,6 +359,7 @@ void UDPWrap::DoConnect(const FunctionCallbackInfo<Value>& args, int family) {
358359
if (err == 0) {
359360
err = uv_udp_connect(&wrap->handle_,
360361
reinterpret_cast<const sockaddr*>(&addr_storage));
362+
if (err == 0) wrap->net_permission_granted_ = true;
361363
}
362364

363365
args.GetReturnValue().Set(err);
@@ -368,9 +370,14 @@ void UDPWrap::Open(const FunctionCallbackInfo<Value>& args) {
368370
UDPWrap* wrap;
369371
ASSIGN_OR_RETURN_UNWRAP(
370372
&wrap, args.This(), args.GetReturnValue().Set(UV_EBADF));
373+
Environment* env = wrap->env();
374+
375+
THROW_IF_INSUFFICIENT_PERMISSIONS(env, permission::PermissionScope::kNet, "");
376+
371377
CHECK(args[0]->IsNumber());
372378
int fd = FromV8Value<int>(args[0]);
373379
int err = uv_udp_open(&wrap->handle_, fd);
380+
if (err == 0) wrap->net_permission_granted_ = true;
374381

375382
args.GetReturnValue().Set(err);
376383
}
@@ -697,6 +704,13 @@ void UDPWrapBase::RecvStart(const FunctionCallbackInfo<Value>& args) {
697704

698705
intUDPWrap::RecvStart() {
699706
if (IsHandleClosing()) returnUV_EBADF;
707+
708+
if (!net_permission_granted_) {
709+
THROW_IF_INSUFFICIENT_PERMISSIONS(
710+
env(), permission::PermissionScope::kNet, "", UV_EACCES);
711+
net_permission_granted_ = true;
712+
}
713+
700714
int err = uv_udp_recv_start(&handle_, OnAlloc, OnRecv);
701715
// UV_EALREADY means that the socket is already bound but that's okay
702716
if (err == UV_EALREADY)

β€Žsrc/udp_wrap.hβ€Ž

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@ class UDPWrap final : public HandleWrap,
214214

215215
uv_udp_t handle_;
216216

217+
bool net_permission_granted_ = false;
217218
bool current_send_has_callback_;
218219
v8::Local<v8::Object> current_send_req_wrap_;
219220
};
Lines changed: 135 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,135 @@
1+
// Flags: --expose-internals
2+
'use strict';
3+
4+
constcommon=require('../common');
5+
if(common.isWindows){
6+
common.skip('Sending dgram sockets to child processes is not supported');
7+
}
8+
9+
constassert=require('assert');
10+
constdgram=require('dgram');
11+
const{ fork, spawn }=require('child_process');
12+
13+
constmode=process.argv[2];
14+
constkStateSymbol=mode===undefined ?
15+
require('internal/dgram').kStateSymbol : undefined;
16+
17+
if(mode==='ipc-denied'){
18+
process.on('message',common.mustNotCall());
19+
process.send('ready');
20+
}elseif(mode==='ipc-drop'){
21+
process.once('message',common.mustCall((message,handle)=>{
22+
assert.strictEqual(message,'socket');
23+
assert(process.permission.has('net'));
24+
25+
process.permission.drop('net');
26+
assert(!process.permission.has('net'));
27+
28+
handle.once('message',common.mustCall((data)=>{
29+
assert.strictEqual(data.toString(),'after-drop');
30+
handle.close();
31+
process.send('received');
32+
}));
33+
process.send('receiving');
34+
}));
35+
process.send('ready');
36+
}else{
37+
constdeniedSocket=dgram.createSocket('udp4');
38+
deniedSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
39+
constchild=fork(__filename,['ipc-denied'],{
40+
execArgv: ['--permission','--allow-fs-read=*'],
41+
silent: true,
42+
});
43+
letstderr='';
44+
45+
child.stderr.setEncoding('utf8');
46+
child.stderr.on('data',(chunk)=>{stderr+=chunk;});
47+
child.once('message',common.mustCall((message)=>{
48+
assert.strictEqual(message,'ready');
49+
child.send('socket',deniedSocket);
50+
}));
51+
child.once('exit',common.mustCall((code,signal)=>{
52+
assert.strictEqual(code,1);
53+
assert.strictEqual(signal,null);
54+
assert.match(stderr,/ERR_ACCESS_DENIED/);
55+
assert.match(stderr,/permission:'Net'/);
56+
deniedSocket.close();
57+
}));
58+
}));
59+
60+
constdroppedSocket=dgram.createSocket('udp4');
61+
constsender=dgram.createSocket('udp4');
62+
droppedSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
63+
constchild=fork(__filename,['ipc-drop'],{
64+
execArgv: [
65+
'--permission',
66+
'--allow-net',
67+
'--allow-fs-read=*',
68+
],
69+
});
70+
lettimer;
71+
72+
child.on('message',common.mustCall((message)=>{
73+
if(message==='ready'){
74+
child.send('socket',droppedSocket);
75+
}elseif(message==='receiving'){
76+
const{ port }=droppedSocket.address();
77+
timer=setInterval(()=>{
78+
sender.send('after-drop',port,'127.0.0.1');
79+
},10);
80+
}else{
81+
assert.strictEqual(message,'received');
82+
clearInterval(timer);
83+
sender.close();
84+
droppedSocket.close();
85+
child.disconnect();
86+
}
87+
},3));
88+
child.once('exit',common.mustCall((code,signal)=>{
89+
assert.strictEqual(code,0);
90+
assert.strictEqual(signal,null);
91+
}));
92+
}));
93+
94+
constfdSocket=dgram.createSocket('udp4');
95+
fdSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
96+
constsource=`
97+
const assert = require('node:assert');
98+
const dgram = require('node:dgram');
99+
const socket = dgram.createSocket('udp4');
100+
let error;
101+
try {
102+
socket.bind({ fd: 3 });
103+
} catch (err) {
104+
error = err;
105+
}
106+
if (error) {
107+
assert.strictEqual(error.code, 'ERR_ACCESS_DENIED');
108+
assert.strictEqual(error.permission, 'Net');
109+
process.exit(0);
110+
}
111+
process.exit(1);
112+
`;
113+
constchild=spawn(
114+
process.execPath,
115+
['--permission','--eval',source],
116+
{
117+
stdio: [
118+
'ignore',
119+
'ignore',
120+
'pipe',
121+
fdSocket[kStateSymbol].handle.fd,
122+
],
123+
},
124+
);
125+
letstderr='';
126+
127+
child.stderr.setEncoding('utf8');
128+
child.stderr.on('data',(chunk)=>{stderr+=chunk;});
129+
child.once('exit',common.mustCall((code,signal)=>{
130+
assert.strictEqual(code,0,stderr);
131+
assert.strictEqual(signal,null);
132+
fdSocket.close();
133+
}));
134+
}));
135+
}

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 01a8ae0

Browse files
RafaelGSSaduh95
authored andcommitted
permission: guard UDP handle adoption
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #65358 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 1d6ec2d commit 01a8ae0

3 files changed

Lines changed: 150 additions & 0 deletions

File tree

β€Žsrc/udp_wrap.ccβ€Ž

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@ void UDPWrap::DoBind(const FunctionCallbackInfo<Value>& args, int family) {
325325
err = uv_udp_bind(&wrap->handle_,
326326
reinterpret_cast<const sockaddr*>(&addr_storage),
327327
flags);
328+
if (err == 0) wrap->net_permission_granted_ = true;
328329
}
329330

330331
if (err == 0)
@@ -358,6 +359,7 @@ void UDPWrap::DoConnect(const FunctionCallbackInfo<Value>& args, int family) {
358359
if (err == 0) {
359360
err = uv_udp_connect(&wrap->handle_,
360361
reinterpret_cast<const sockaddr*>(&addr_storage));
362+
if (err == 0) wrap->net_permission_granted_ = true;
361363
}
362364

363365
args.GetReturnValue().Set(err);
@@ -368,9 +370,14 @@ void UDPWrap::Open(const FunctionCallbackInfo<Value>& args) {
368370
UDPWrap* wrap;
369371
ASSIGN_OR_RETURN_UNWRAP(
370372
&wrap, args.This(), args.GetReturnValue().Set(UV_EBADF));
373+
Environment* env = wrap->env();
374+
375+
THROW_IF_INSUFFICIENT_PERMISSIONS(env, permission::PermissionScope::kNet, "");
376+
371377
CHECK(args[0]->IsNumber());
372378
int fd = FromV8Value<int>(args[0]);
373379
int err = uv_udp_open(&wrap->handle_, fd);
380+
if (err == 0) wrap->net_permission_granted_ = true;
374381

375382
args.GetReturnValue().Set(err);
376383
}
@@ -697,6 +704,13 @@ void UDPWrapBase::RecvStart(const FunctionCallbackInfo<Value>& args) {
697704

698705
intUDPWrap::RecvStart() {
699706
if (IsHandleClosing()) returnUV_EBADF;
707+
708+
if (!net_permission_granted_) {
709+
THROW_IF_INSUFFICIENT_PERMISSIONS(
710+
env(), permission::PermissionScope::kNet, "", UV_EACCES);
711+
net_permission_granted_ = true;
712+
}
713+
700714
int err = uv_udp_recv_start(&handle_, OnAlloc, OnRecv);
701715
// UV_EALREADY means that the socket is already bound but that's okay
702716
if (err == UV_EALREADY)

β€Žsrc/udp_wrap.hβ€Ž

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@ class UDPWrap final : public HandleWrap,
214214

215215
uv_udp_t handle_;
216216

217+
bool net_permission_granted_ = false;
217218
bool current_send_has_callback_;
218219
v8::Local<v8::Object> current_send_req_wrap_;
219220
};
Lines changed: 135 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,135 @@
1+
// Flags: --expose-internals
2+
'use strict';
3+
4+
constcommon=require('../common');
5+
if(common.isWindows){
6+
common.skip('Sending dgram sockets to child processes is not supported');
7+
}
8+
9+
constassert=require('assert');
10+
constdgram=require('dgram');
11+
const{ fork, spawn }=require('child_process');
12+
13+
constmode=process.argv[2];
14+
constkStateSymbol=mode===undefined ?
15+
require('internal/dgram').kStateSymbol : undefined;
16+
17+
if(mode==='ipc-denied'){
18+
process.on('message',common.mustNotCall());
19+
process.send('ready');
20+
}elseif(mode==='ipc-drop'){
21+
process.once('message',common.mustCall((message,handle)=>{
22+
assert.strictEqual(message,'socket');
23+
assert(process.permission.has('net'));
24+
25+
process.permission.drop('net');
26+
assert(!process.permission.has('net'));
27+
28+
handle.once('message',common.mustCall((data)=>{
29+
assert.strictEqual(data.toString(),'after-drop');
30+
handle.close();
31+
process.send('received');
32+
}));
33+
process.send('receiving');
34+
}));
35+
process.send('ready');
36+
}else{
37+
constdeniedSocket=dgram.createSocket('udp4');
38+
deniedSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
39+
constchild=fork(__filename,['ipc-denied'],{
40+
execArgv: ['--permission','--allow-fs-read=*'],
41+
silent: true,
42+
});
43+
letstderr='';
44+
45+
child.stderr.setEncoding('utf8');
46+
child.stderr.on('data',(chunk)=>{stderr+=chunk;});
47+
child.once('message',common.mustCall((message)=>{
48+
assert.strictEqual(message,'ready');
49+
child.send('socket',deniedSocket);
50+
}));
51+
child.once('exit',common.mustCall((code,signal)=>{
52+
assert.strictEqual(code,1);
53+
assert.strictEqual(signal,null);
54+
assert.match(stderr,/ERR_ACCESS_DENIED/);
55+
assert.match(stderr,/permission:'Net'/);
56+
deniedSocket.close();
57+
}));
58+
}));
59+
60+
constdroppedSocket=dgram.createSocket('udp4');
61+
constsender=dgram.createSocket('udp4');
62+
droppedSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
63+
constchild=fork(__filename,['ipc-drop'],{
64+
execArgv: [
65+
'--permission',
66+
'--allow-net',
67+
'--allow-fs-read=*',
68+
],
69+
});
70+
lettimer;
71+
72+
child.on('message',common.mustCall((message)=>{
73+
if(message==='ready'){
74+
child.send('socket',droppedSocket);
75+
}elseif(message==='receiving'){
76+
const{ port }=droppedSocket.address();
77+
timer=setInterval(()=>{
78+
sender.send('after-drop',port,'127.0.0.1');
79+
},10);
80+
}else{
81+
assert.strictEqual(message,'received');
82+
clearInterval(timer);
83+
sender.close();
84+
droppedSocket.close();
85+
child.disconnect();
86+
}
87+
},3));
88+
child.once('exit',common.mustCall((code,signal)=>{
89+
assert.strictEqual(code,0);
90+
assert.strictEqual(signal,null);
91+
}));
92+
}));
93+
94+
constfdSocket=dgram.createSocket('udp4');
95+
fdSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
96+
constsource=`
97+
const assert = require('node:assert');
98+
const dgram = require('node:dgram');
99+
const socket = dgram.createSocket('udp4');
100+
let error;
101+
try {
102+
socket.bind({ fd: 3 });
103+
} catch (err) {
104+
error = err;
105+
}
106+
if (error) {
107+
assert.strictEqual(error.code, 'ERR_ACCESS_DENIED');
108+
assert.strictEqual(error.permission, 'Net');
109+
process.exit(0);
110+
}
111+
process.exit(1);
112+
`;
113+
constchild=spawn(
114+
process.execPath,
115+
['--permission','--eval',source],
116+
{
117+
stdio: [
118+
'ignore',
119+
'ignore',
120+
'pipe',
121+
fdSocket[kStateSymbol].handle.fd,
122+
],
123+
},
124+
);
125+
letstderr='';
126+
127+
child.stderr.setEncoding('utf8');
128+
child.stderr.on('data',(chunk)=>{stderr+=chunk;});
129+
child.once('exit',common.mustCall((code,signal)=>{
130+
assert.strictEqual(code,0,stderr);
131+
assert.strictEqual(signal,null);
132+
fdSocket.close();
133+
}));
134+
}));
135+
}

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 01a8ae0

Browse files
RafaelGSSaduh95
authored andcommitted
permission: guard UDP handle adoption
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #65358 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 1d6ec2d commit 01a8ae0

3 files changed

Lines changed: 150 additions & 0 deletions

File tree

β€Žsrc/udp_wrap.ccβ€Ž

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@ void UDPWrap::DoBind(const FunctionCallbackInfo<Value>& args, int family) {
325325
err = uv_udp_bind(&wrap->handle_,
326326
reinterpret_cast<const sockaddr*>(&addr_storage),
327327
flags);
328+
if (err == 0) wrap->net_permission_granted_ = true;
328329
}
329330

330331
if (err == 0)
@@ -358,6 +359,7 @@ void UDPWrap::DoConnect(const FunctionCallbackInfo<Value>& args, int family) {
358359
if (err == 0) {
359360
err = uv_udp_connect(&wrap->handle_,
360361
reinterpret_cast<const sockaddr*>(&addr_storage));
362+
if (err == 0) wrap->net_permission_granted_ = true;
361363
}
362364

363365
args.GetReturnValue().Set(err);
@@ -368,9 +370,14 @@ void UDPWrap::Open(const FunctionCallbackInfo<Value>& args) {
368370
UDPWrap* wrap;
369371
ASSIGN_OR_RETURN_UNWRAP(
370372
&wrap, args.This(), args.GetReturnValue().Set(UV_EBADF));
373+
Environment* env = wrap->env();
374+
375+
THROW_IF_INSUFFICIENT_PERMISSIONS(env, permission::PermissionScope::kNet, "");
376+
371377
CHECK(args[0]->IsNumber());
372378
int fd = FromV8Value<int>(args[0]);
373379
int err = uv_udp_open(&wrap->handle_, fd);
380+
if (err == 0) wrap->net_permission_granted_ = true;
374381

375382
args.GetReturnValue().Set(err);
376383
}
@@ -697,6 +704,13 @@ void UDPWrapBase::RecvStart(const FunctionCallbackInfo<Value>& args) {
697704

698705
intUDPWrap::RecvStart() {
699706
if (IsHandleClosing()) returnUV_EBADF;
707+
708+
if (!net_permission_granted_) {
709+
THROW_IF_INSUFFICIENT_PERMISSIONS(
710+
env(), permission::PermissionScope::kNet, "", UV_EACCES);
711+
net_permission_granted_ = true;
712+
}
713+
700714
int err = uv_udp_recv_start(&handle_, OnAlloc, OnRecv);
701715
// UV_EALREADY means that the socket is already bound but that's okay
702716
if (err == UV_EALREADY)

β€Žsrc/udp_wrap.hβ€Ž

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@ class UDPWrap final : public HandleWrap,
214214

215215
uv_udp_t handle_;
216216

217+
bool net_permission_granted_ = false;
217218
bool current_send_has_callback_;
218219
v8::Local<v8::Object> current_send_req_wrap_;
219220
};
Lines changed: 135 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,135 @@
1+
// Flags: --expose-internals
2+
'use strict';
3+
4+
constcommon=require('../common');
5+
if(common.isWindows){
6+
common.skip('Sending dgram sockets to child processes is not supported');
7+
}
8+
9+
constassert=require('assert');
10+
constdgram=require('dgram');
11+
const{ fork, spawn }=require('child_process');
12+
13+
constmode=process.argv[2];
14+
constkStateSymbol=mode===undefined ?
15+
require('internal/dgram').kStateSymbol : undefined;
16+
17+
if(mode==='ipc-denied'){
18+
process.on('message',common.mustNotCall());
19+
process.send('ready');
20+
}elseif(mode==='ipc-drop'){
21+
process.once('message',common.mustCall((message,handle)=>{
22+
assert.strictEqual(message,'socket');
23+
assert(process.permission.has('net'));
24+
25+
process.permission.drop('net');
26+
assert(!process.permission.has('net'));
27+
28+
handle.once('message',common.mustCall((data)=>{
29+
assert.strictEqual(data.toString(),'after-drop');
30+
handle.close();
31+
process.send('received');
32+
}));
33+
process.send('receiving');
34+
}));
35+
process.send('ready');
36+
}else{
37+
constdeniedSocket=dgram.createSocket('udp4');
38+
deniedSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
39+
constchild=fork(__filename,['ipc-denied'],{
40+
execArgv: ['--permission','--allow-fs-read=*'],
41+
silent: true,
42+
});
43+
letstderr='';
44+
45+
child.stderr.setEncoding('utf8');
46+
child.stderr.on('data',(chunk)=>{stderr+=chunk;});
47+
child.once('message',common.mustCall((message)=>{
48+
assert.strictEqual(message,'ready');
49+
child.send('socket',deniedSocket);
50+
}));
51+
child.once('exit',common.mustCall((code,signal)=>{
52+
assert.strictEqual(code,1);
53+
assert.strictEqual(signal,null);
54+
assert.match(stderr,/ERR_ACCESS_DENIED/);
55+
assert.match(stderr,/permission:'Net'/);
56+
deniedSocket.close();
57+
}));
58+
}));
59+
60+
constdroppedSocket=dgram.createSocket('udp4');
61+
constsender=dgram.createSocket('udp4');
62+
droppedSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
63+
constchild=fork(__filename,['ipc-drop'],{
64+
execArgv: [
65+
'--permission',
66+
'--allow-net',
67+
'--allow-fs-read=*',
68+
],
69+
});
70+
lettimer;
71+
72+
child.on('message',common.mustCall((message)=>{
73+
if(message==='ready'){
74+
child.send('socket',droppedSocket);
75+
}elseif(message==='receiving'){
76+
const{ port }=droppedSocket.address();
77+
timer=setInterval(()=>{
78+
sender.send('after-drop',port,'127.0.0.1');
79+
},10);
80+
}else{
81+
assert.strictEqual(message,'received');
82+
clearInterval(timer);
83+
sender.close();
84+
droppedSocket.close();
85+
child.disconnect();
86+
}
87+
},3));
88+
child.once('exit',common.mustCall((code,signal)=>{
89+
assert.strictEqual(code,0);
90+
assert.strictEqual(signal,null);
91+
}));
92+
}));
93+
94+
constfdSocket=dgram.createSocket('udp4');
95+
fdSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
96+
constsource=`
97+
const assert = require('node:assert');
98+
const dgram = require('node:dgram');
99+
const socket = dgram.createSocket('udp4');
100+
let error;
101+
try {
102+
socket.bind({ fd: 3 });
103+
} catch (err) {
104+
error = err;
105+
}
106+
if (error) {
107+
assert.strictEqual(error.code, 'ERR_ACCESS_DENIED');
108+
assert.strictEqual(error.permission, 'Net');
109+
process.exit(0);
110+
}
111+
process.exit(1);
112+
`;
113+
constchild=spawn(
114+
process.execPath,
115+
['--permission','--eval',source],
116+
{
117+
stdio: [
118+
'ignore',
119+
'ignore',
120+
'pipe',
121+
fdSocket[kStateSymbol].handle.fd,
122+
],
123+
},
124+
);
125+
letstderr='';
126+
127+
child.stderr.setEncoding('utf8');
128+
child.stderr.on('data',(chunk)=>{stderr+=chunk;});
129+
child.once('exit',common.mustCall((code,signal)=>{
130+
assert.strictEqual(code,0,stderr);
131+
assert.strictEqual(signal,null);
132+
fdSocket.close();
133+
}));
134+
}));
135+
}

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Commit 01a8ae0

Browse files
RafaelGSSaduh95
authored andcommitted
permission: guard UDP handle adoption
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #65358 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 1d6ec2d commit 01a8ae0

3 files changed

Lines changed: 150 additions & 0 deletions

File tree

β€Žsrc/udp_wrap.ccβ€Ž

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@ void UDPWrap::DoBind(const FunctionCallbackInfo<Value>& args, int family) {
325325
err = uv_udp_bind(&wrap->handle_,
326326
reinterpret_cast<const sockaddr*>(&addr_storage),
327327
flags);
328+
if (err == 0) wrap->net_permission_granted_ = true;
328329
}
329330

330331
if (err == 0)
@@ -358,6 +359,7 @@ void UDPWrap::DoConnect(const FunctionCallbackInfo<Value>& args, int family) {
358359
if (err == 0) {
359360
err = uv_udp_connect(&wrap->handle_,
360361
reinterpret_cast<const sockaddr*>(&addr_storage));
362+
if (err == 0) wrap->net_permission_granted_ = true;
361363
}
362364

363365
args.GetReturnValue().Set(err);
@@ -368,9 +370,14 @@ void UDPWrap::Open(const FunctionCallbackInfo<Value>& args) {
368370
UDPWrap* wrap;
369371
ASSIGN_OR_RETURN_UNWRAP(
370372
&wrap, args.This(), args.GetReturnValue().Set(UV_EBADF));
373+
Environment* env = wrap->env();
374+
375+
THROW_IF_INSUFFICIENT_PERMISSIONS(env, permission::PermissionScope::kNet, "");
376+
371377
CHECK(args[0]->IsNumber());
372378
int fd = FromV8Value<int>(args[0]);
373379
int err = uv_udp_open(&wrap->handle_, fd);
380+
if (err == 0) wrap->net_permission_granted_ = true;
374381

375382
args.GetReturnValue().Set(err);
376383
}
@@ -697,6 +704,13 @@ void UDPWrapBase::RecvStart(const FunctionCallbackInfo<Value>& args) {
697704

698705
intUDPWrap::RecvStart() {
699706
if (IsHandleClosing()) returnUV_EBADF;
707+
708+
if (!net_permission_granted_) {
709+
THROW_IF_INSUFFICIENT_PERMISSIONS(
710+
env(), permission::PermissionScope::kNet, "", UV_EACCES);
711+
net_permission_granted_ = true;
712+
}
713+
700714
int err = uv_udp_recv_start(&handle_, OnAlloc, OnRecv);
701715
// UV_EALREADY means that the socket is already bound but that's okay
702716
if (err == UV_EALREADY)

β€Žsrc/udp_wrap.hβ€Ž

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@ class UDPWrap final : public HandleWrap,
214214

215215
uv_udp_t handle_;
216216

217+
bool net_permission_granted_ = false;
217218
bool current_send_has_callback_;
218219
v8::Local<v8::Object> current_send_req_wrap_;
219220
};
Lines changed: 135 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,135 @@
1+
// Flags: --expose-internals
2+
'use strict';
3+
4+
constcommon=require('../common');
5+
if(common.isWindows){
6+
common.skip('Sending dgram sockets to child processes is not supported');
7+
}
8+
9+
constassert=require('assert');
10+
constdgram=require('dgram');
11+
const{ fork, spawn }=require('child_process');
12+
13+
constmode=process.argv[2];
14+
constkStateSymbol=mode===undefined ?
15+
require('internal/dgram').kStateSymbol : undefined;
16+
17+
if(mode==='ipc-denied'){
18+
process.on('message',common.mustNotCall());
19+
process.send('ready');
20+
}elseif(mode==='ipc-drop'){
21+
process.once('message',common.mustCall((message,handle)=>{
22+
assert.strictEqual(message,'socket');
23+
assert(process.permission.has('net'));
24+
25+
process.permission.drop('net');
26+
assert(!process.permission.has('net'));
27+
28+
handle.once('message',common.mustCall((data)=>{
29+
assert.strictEqual(data.toString(),'after-drop');
30+
handle.close();
31+
process.send('received');
32+
}));
33+
process.send('receiving');
34+
}));
35+
process.send('ready');
36+
}else{
37+
constdeniedSocket=dgram.createSocket('udp4');
38+
deniedSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
39+
constchild=fork(__filename,['ipc-denied'],{
40+
execArgv: ['--permission','--allow-fs-read=*'],
41+
silent: true,
42+
});
43+
letstderr='';
44+
45+
child.stderr.setEncoding('utf8');
46+
child.stderr.on('data',(chunk)=>{stderr+=chunk;});
47+
child.once('message',common.mustCall((message)=>{
48+
assert.strictEqual(message,'ready');
49+
child.send('socket',deniedSocket);
50+
}));
51+
child.once('exit',common.mustCall((code,signal)=>{
52+
assert.strictEqual(code,1);
53+
assert.strictEqual(signal,null);
54+
assert.match(stderr,/ERR_ACCESS_DENIED/);
55+
assert.match(stderr,/permission:'Net'/);
56+
deniedSocket.close();
57+
}));
58+
}));
59+
60+
constdroppedSocket=dgram.createSocket('udp4');
61+
constsender=dgram.createSocket('udp4');
62+
droppedSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
63+
constchild=fork(__filename,['ipc-drop'],{
64+
execArgv: [
65+
'--permission',
66+
'--allow-net',
67+
'--allow-fs-read=*',
68+
],
69+
});
70+
lettimer;
71+
72+
child.on('message',common.mustCall((message)=>{
73+
if(message==='ready'){
74+
child.send('socket',droppedSocket);
75+
}elseif(message==='receiving'){
76+
const{ port }=droppedSocket.address();
77+
timer=setInterval(()=>{
78+
sender.send('after-drop',port,'127.0.0.1');
79+
},10);
80+
}else{
81+
assert.strictEqual(message,'received');
82+
clearInterval(timer);
83+
sender.close();
84+
droppedSocket.close();
85+
child.disconnect();
86+
}
87+
},3));
88+
child.once('exit',common.mustCall((code,signal)=>{
89+
assert.strictEqual(code,0);
90+
assert.strictEqual(signal,null);
91+
}));
92+
}));
93+
94+
constfdSocket=dgram.createSocket('udp4');
95+
fdSocket.bind(0,'127.0.0.1',common.mustCall(()=>{
96+
constsource=`
97+
const assert = require('node:assert');
98+
const dgram = require('node:dgram');
99+
const socket = dgram.createSocket('udp4');
100+
let error;
101+
try {
102+
socket.bind({ fd: 3 });
103+
} catch (err) {
104+
error = err;
105+
}
106+
if (error) {
107+
assert.strictEqual(error.code, 'ERR_ACCESS_DENIED');
108+
assert.strictEqual(error.permission, 'Net');
109+
process.exit(0);
110+
}
111+
process.exit(1);
112+
`;
113+
constchild=spawn(
114+
process.execPath,
115+
['--permission','--eval',source],
116+
{
117+
stdio: [
118+
'ignore',
119+
'ignore',
120+
'pipe',
121+
fdSocket[kStateSymbol].handle.fd,
122+
],
123+
},
124+
);
125+
letstderr='';
126+
127+
child.stderr.setEncoding('utf8');
128+
child.stderr.on('data',(chunk)=>{stderr+=chunk;});
129+
child.once('exit',common.mustCall((code,signal)=>{
130+
assert.strictEqual(code,0,stderr);
131+
assert.strictEqual(signal,null);
132+
fdSocket.close();
133+
}));
134+
}));
135+
}

0 commit comments

Comments
Β (0)