http2: expose writable stream state on compat response

cookesan · aduh95 · commit 01eed5901bdd · 2026-05-05T16:19:43.000+02:00
Signed-off-by: Terry Chen <terry@example.com> PR-URL: #63003 Fixes: #63000 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
diff --git a/lib/internal/http2/compat.js b/lib/internal/http2/compat.js
@@ -551,6 +551,10 @@ class Http2ServerResponse extends Stream {
 return this[kStream].writableHighWaterMark;
 }
 
+ get writableObjectMode() {
+ return this[kStream].writableObjectMode;
+ }
+
 get writableFinished() {
 return this[kStream].writableFinished;
 }
@@ -559,6 +563,10 @@ class Http2ServerResponse extends Stream {
 return this[kStream].writableLength;
 }
 
+ get writableNeedDrain() {
+ return this[kStream].writableNeedDrain;
+ }
+
 set statusCode(code) {
 code |= 0;
 if (code >= 100 && code < 200)
diff --git a/test/parallel/test-http2-res-writable-properties.js b/test/parallel/test-http2-res-writable-properties.js
@@ -7,11 +7,14 @@ const http2 = require('http2');
 const server = http2.createServer(common.mustCall((req, res) => {
 const hwm = req.socket.writableHighWaterMark;
 assert.strictEqual(res.writableHighWaterMark, hwm);
+ assert.strictEqual(res.writableObjectMode, res.stream.writableObjectMode);
+ assert.strictEqual(res.writableNeedDrain, res.stream.writableNeedDrain);
 assert.strictEqual(res.writableLength, 0);
 res.write('');
 const len = res.writableLength;
 res.write('asd');
 assert.strictEqual(res.writableLength, len + 3);
+ assert.strictEqual(res.writableNeedDrain, res.stream.writableNeedDrain);
 res.end();
 res.on('finish', common.mustCall(() => {
 assert.strictEqual(res.writableLength, 0);

Original file line number	Diff line number	Diff line change
`@@ -551,6 +551,10 @@ class Http2ServerResponse extends Stream {`
`551`	`551`	`returnthis[kStream].writableHighWaterMark;`
`552`	`552`	`}`
`553`	`553`
	`554`	`+getwritableObjectMode(){`
	`555`	`+returnthis[kStream].writableObjectMode;`
	`556`	`+}`
	`557`	`+`
`554`	`558`	`getwritableFinished(){`
`555`	`559`	`returnthis[kStream].writableFinished;`
`556`	`560`	`}`
`@@ -559,6 +563,10 @@ class Http2ServerResponse extends Stream {`
`559`	`563`	`returnthis[kStream].writableLength;`
`560`	`564`	`}`
`561`	`565`
	`566`	`+getwritableNeedDrain(){`
	`567`	`+returnthis[kStream].writableNeedDrain;`
	`568`	`+}`
	`569`	`+`
`562`	`570`	`setstatusCode(code){`
`563`	`571`	`code\|=0;`
`564`	`572`	`if(code>=100&&code<200)`
-Original file line number
+Diff line change
 constserver=http2.createServer(common.mustCall((req,res)=>{
 consthwm=req.socket.writableHighWaterMark;
 assert.strictEqual(res.writableHighWaterMark,hwm);
 +assert.strictEqual(res.writableObjectMode,res.stream.writableObjectMode);
 +assert.strictEqual(res.writableNeedDrain,res.stream.writableNeedDrain);
 assert.strictEqual(res.writableLength,0);
 res.write('');
 constlen=res.writableLength;
 res.write('asd');
 assert.strictEqual(res.writableLength,len+3);
 +assert.strictEqual(res.writableNeedDrain,res.stream.writableNeedDrain);
 res.end();
 res.on('finish',common.mustCall(()=>{
 assert.strictEqual(res.writableLength,0);