test: minor refactoring of onticketkeycallback

danbev · BridgeAR · commit 026e03cf3580 · 2018-12-05T19:41:55.000+01:00
The motivation for this commit is to make the the onticketkeycallback function more readable. PR-URL: #24718 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/parallel/test-https-resume-after-renew.js b/test/parallel/test-https-resume-after-renew.js
@@ -22,16 +22,13 @@ const hmac = Buffer.alloc(16, 'H');
 
 server._sharedCreds.context.enableTicketKeyCallback();
 server._sharedCreds.context.onticketkeycallback = function(name, iv, enc) {
- let newName, newIV;
 if (enc) {
- newName = Buffer.alloc(16, 'A');
- newIV = crypto.randomBytes(16);
- } else {
- // Renew
- return [ 2, hmac, aes ];
+ const newName = Buffer.alloc(16, 'A');
+ const newIV = crypto.randomBytes(16);
+ return [ 1, hmac, aes, newName, newIV ];
 }
-
- return [ 1, hmac, aes, newName, newIV ];
+ // Renew
+ return [ 2, hmac, aes ];
 };
 
 server.listen(0, function() {

-Original file line number
+Diff line change
 server._sharedCreds.context.enableTicketKeyCallback();
 server._sharedCreds.context.onticketkeycallback=function(name,iv,enc){
 -letnewName,newIV;
 if(enc){
 -newName=Buffer.alloc(16,'A');
 -newIV=crypto.randomBytes(16);
 -}else{
 -// Renew
 -return[2,hmac,aes];
 +constnewName=Buffer.alloc(16,'A');
 +constnewIV=crypto.randomBytes(16);
 +return[1,hmac,aes,newName,newIV];
+}
+-
 -return[1,hmac,aes,newName,newIV];
 +// Renew
 +return[2,hmac,aes];
 };
 server.listen(0,function(){