Skip to content

Commit 046bd79

Browse files
cjihrigMylesBorins
authored andcommitted
events: remove unreachable code
Commit 8d386ed stopped the Event Emitter implementation from storing arrays containing a single listener. This change left a section of code in removeListener() as unreachable. This commit removes the unreachable code. Refs: #12043 PR-URL: #12501 Backport-PR-URL: #13796 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 8bf64d1 commit 046bd79

1 file changed

Lines changed: 5 additions & 14 deletions

File tree

‎lib/events.js‎

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -349,22 +349,13 @@ EventEmitter.prototype.removeListener =
349349
if(position<0)
350350
returnthis;
351351

352-
if(list.length===1){
353-
if(--this._eventsCount===0){
354-
this._events=newEventHandlers();
355-
returnthis;
356-
}else{
357-
deleteevents[type];
358-
}
359-
}elseif(position===0){
352+
if(position===0)
360353
list.shift();
361-
if(list.length===1)
362-
events[type]=list[0];
363-
}else{
354+
else
364355
spliceOne(list,position);
365-
if(list.length===1)
366-
events[type]=list[0];
367-
}
356+
357+
if(list.length===1)
358+
events[type]=list[0];
368359

369360
if(events.removeListener)
370361
this.emit('removeListener',type,originalListener||listener);

0 commit comments

Comments
 (0)