test_runner: remove root tracking set

cjihrig · targos · commit 069ff1cc6389 · 2023-03-14T07:54:08.000+01:00
The wasRootSetup Set in the test harness appears to be redundant, since the startTime field can be used interchangeably. This commit removes wasRootSetup. PR-URL: #46961 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
diff --git a/lib/internal/test_runner/harness.js b/lib/internal/test_runner/harness.js
@@ -2,7 +2,6 @@
 const {
 ArrayPrototypeForEach,
 SafeMap,
- SafeWeakSet,
 } = primordials;
 const {
 createHook,
@@ -25,7 +24,6 @@ const {
 const { bigint: hrtime } = process.hrtime;
 
 const testResources = new SafeMap();
-const wasRootSetup = new SafeWeakSet();
 
 function createTestTree(options = kEmptyObject) {
 return setup(new Test({ __proto__: null, ...options, name: '<root>' }));
@@ -104,7 +102,7 @@ function collectCoverage(rootTest, coverage) {
 }
 
 function setup(root) {
- if (wasRootSetup.has(root)) {
+ if (root.startTime !== null) {
 return root;
 }
 
@@ -168,8 +166,6 @@ function setup(root) {
 coverage: null,
 };
 root.startTime = hrtime();
-
- wasRootSetup.add(root);
 return root;
 }
 

-Original file line number
+Diff line change
 const{
  ArrayPrototypeForEach,
  SafeMap,
 - SafeWeakSet,
 }=primordials;
 const{
  createHook,
 const{bigint: hrtime}=process.hrtime;
 consttestResources=newSafeMap();
 -constwasRootSetup=newSafeWeakSet();
 functioncreateTestTree(options=kEmptyObject){
 returnsetup(newTest({__proto__: null, ...options,name: '<root>'}));
+}
 functionsetup(root){
 -if(wasRootSetup.has(root)){
 +if(root.startTime!==null){
 returnroot;
+}
 coverage: null,
 };
 root.startTime=hrtime();
+-
 -wasRootSetup.add(root);
 returnroot;
+}