Skip to content

Commit 071a022

Browse files
TrottBethGriggs
authored andcommitted
http2: order declarations in core.js
Order declarations: * public modules in alphabetical order * internal modules in alphabetical order * process.binding() calls in alphabetical order * exports in alphabetical order Backport-PR-URL: #22850 PR-URL: #21689 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 2116ace commit 071a022

1 file changed

Lines changed: 38 additions & 32 deletions

File tree

‎lib/internal/http2/core.js‎

Lines changed: 38 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -2,42 +2,38 @@
22

33
/* eslint-disable no-use-before-define */
44

5-
require('internal/util').assertCrypto();
5+
const{
6+
assertCrypto,
7+
customInspectSymbol: kInspect,
8+
promisify
9+
}=require('internal/util');
10+
11+
assertCrypto();
612

7-
const{ async_id_symbol }=process.binding('async_wrap');
8-
consthttp=require('http');
9-
constbinding=process.binding('http2');
1013
constassert=require('assert');
1114
const{ Buffer }=require('buffer');
1215
constEventEmitter=require('events');
16+
constfs=require('fs');
17+
consthttp=require('http');
1318
constnet=require('net');
19+
const{ Duplex }=require('stream');
20+
const{
21+
_unrefActive,
22+
enroll,
23+
unenroll
24+
}=require('timers');
1425
consttls=require('tls');
26+
const{URL}=require('url');
1527
constutil=require('util');
16-
constfs=require('fs');
17-
consterrors=require('internal/errors');
28+
1829
const{ StreamWrap }=require('_stream_wrap');
19-
const{ Duplex }=require('stream');
20-
const{URL}=require('url');
30+
31+
consterrors=require('internal/errors');
32+
const{ utcDate }=require('internal/http');
2133
const{ onServerStream,
2234
Http2ServerRequest,
2335
Http2ServerResponse,
2436
}=require('internal/http2/compat');
25-
const{ utcDate }=require('internal/http');
26-
const{
27-
promisify,
28-
customInspectSymbol: kInspect
29-
}=require('internal/util');
30-
const{ isArrayBufferView }=require('internal/util/types');
31-
const{_connectionListener: httpConnectionListener}=http;
32-
const{ createPromise, promiseResolve }=process.binding('util');
33-
constdebug=util.debuglog('http2');
34-
35-
constkMaxFrameSize=(2**24)-1;
36-
constkMaxInt=(2**32)-1;
37-
constkMaxStreams=(2**31)-1;
38-
39-
// eslint-disable-next-line no-control-regex
40-
constkQuotedString=/^[\x09\x20-\x5b\x5d-\x7e\x80-\xff]*$/;
4137

4238
const{
4339
assertIsObject,
@@ -58,13 +54,23 @@ const {
5854
updateSettingsBuffer
5955
}=require('internal/http2/util');
6056

61-
const{
62-
_unrefActive,
63-
enroll,
64-
unenroll
65-
}=require('timers');
57+
const{ isArrayBufferView }=require('internal/util/types');
6658

59+
const{ async_id_symbol }=process.binding('async_wrap');
60+
constbinding=process.binding('http2');
6761
const{ ShutdownWrap, WriteWrap }=process.binding('stream_wrap');
62+
const{ createPromise, promiseResolve }=process.binding('util');
63+
64+
const{_connectionListener: httpConnectionListener}=http;
65+
constdebug=util.debuglog('http2');
66+
67+
constkMaxFrameSize=(2**24)-1;
68+
constkMaxInt=(2**32)-1;
69+
constkMaxStreams=(2**31)-1;
70+
71+
// eslint-disable-next-line no-control-regex
72+
constkQuotedString=/^[\x09\x20-\x5b\x5d-\x7e\x80-\xff]*$/;
73+
6874
const{ constants, nameForErrorCode }=binding;
6975

7076
constNETServer=net.Server;
@@ -2784,13 +2790,13 @@ function getUnpackedSettings(buf, options = {}) {
27842790

27852791
// Exports
27862792
module.exports={
2793+
connect,
27872794
constants,
2795+
createServer,
2796+
createSecureServer,
27882797
getDefaultSettings,
27892798
getPackedSettings,
27902799
getUnpackedSettings,
2791-
createServer,
2792-
createSecureServer,
2793-
connect,
27942800
Http2Session,
27952801
Http2Stream,
27962802
Http2ServerRequest,

0 commit comments

Comments
 (0)