stream: change stream to use index instead of for...of

HBSPS · targos · commit 0c32918eef22 · 2024-10-02T07:57:40.000+02:00
PR-URL: #54474 Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/stream.js b/lib/stream.js
@@ -61,7 +61,9 @@ Stream.isReadable = utils.isReadable;
 Stream.isWritable = utils.isWritable;
 
 Stream.Readable = require('internal/streams/readable');
-for (const key of ObjectKeys(streamReturningOperators)) {
+const streamKeys = ObjectKeys(streamReturningOperators);
+for (let i = 0; i < streamKeys.length; i++) {
+ const key = streamKeys[i];
 const op = streamReturningOperators[key];
 function fn(...args) {
 if (new.target) {
@@ -79,7 +81,9 @@ for (const key of ObjectKeys(streamReturningOperators)) {
 writable: true,
 });
 }
-for (const key of ObjectKeys(promiseReturningOperators)) {
+const promiseKeys = ObjectKeys(promiseReturningOperators);
+for (let i = 0; i < promiseKeys.length; i++) {
+ const key = promiseKeys[i];
 const op = promiseReturningOperators[key];
 function fn(...args) {
 if (new.target) {

-Original file line number
+Diff line change
 Stream.isWritable=utils.isWritable;
 Stream.Readable=require('internal/streams/readable');
 -for(constkeyofObjectKeys(streamReturningOperators)){
 +conststreamKeys=ObjectKeys(streamReturningOperators);
 +for(leti=0;i<streamKeys.length;i++){
 +constkey=streamKeys[i];
 constop=streamReturningOperators[key];
 functionfn(...args){
 if(new.target){
 writable: true,
 });
+}
 -for(constkeyofObjectKeys(promiseReturningOperators)){
 +constpromiseKeys=ObjectKeys(promiseReturningOperators);
 +for(leti=0;i<promiseKeys.length;i++){
 +constkey=promiseKeys[i];
 constop=promiseReturningOperators[key];
 functionfn(...args){
 if(new.target){