http2: set Http2Stream#sentHeaders for raw headers

When #57917 added support for sending
raw header arrays, Http2Stream#sentHeaders was set only for header
objects. This change also sets it for raw headers by lazily
instantiating the property to avoid any performance impact on the fast
path.
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #59244
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Author: RaisinTen

lib/internal/http2/core.js

@@ -254,6 +254,7 @@ const kProceed = Symbol('proceed');
 constkRemoteSettings=Symbol('remote-settings');
 constkRequestAsyncResource=Symbol('requestAsyncResource');
 constkSentHeaders=Symbol('sent-headers');
+constkRawHeaders=Symbol('raw-headers');
 constkSentTrailers=Symbol('sent-trailers');
 constkServer=Symbol('server');
 constkState=Symbol('state');
@@ -1807,12 +1808,14 @@ class ClientHttp2Session extends Http2Session {
 
 letheadersList;
 letheadersObject;
+letrawHeaders;
 letscheme;
 letauthority;
 letmethod;
 
 if(ArrayIsArray(headersParam)){
 ({
+ rawHeaders,
  headersList,
  scheme,
  authority,
@@ -1859,6 +1862,7 @@ class ClientHttp2Session extends Http2Session {
 // eslint-disable-next-line no-use-before-define
 conststream=newClientHttp2Stream(this,undefined,undefined,{});
 stream[kSentHeaders]=headersObject;// N.b. Only set for object headers, not raw headers
+stream[kRawHeaders]=rawHeaders;// N.b. Only set for raw headers, not object headers
 stream[kOrigin]=`${scheme}://${authority}`;
 constreqAsync=newAsyncResource('PendingRequest');
 stream[kRequestAsyncResource]=reqAsync;
@@ -2128,6 +2132,33 @@ class Http2Stream extends Duplex {
 }
 
 getsentHeaders(){
+if(this[kSentHeaders]||!this[kRawHeaders]){
+returnthis[kSentHeaders];
+}
+
+constrawHeaders=this[kRawHeaders];
+constheadersObject={__proto__: null};
+
+for(leti=0;i<rawHeaders.length;i+=2){
+constkey=rawHeaders[i];
+constvalue=rawHeaders[i+1];
+
+constexisting=headersObject[key];
+if(existing===undefined){
+headersObject[key]=value;
+}elseif(ArrayIsArray(existing)){
+existing.push(value);
+}else{
+headersObject[key]=[existing,value];
+}
+}
+
+if(rawHeaders[kSensitiveHeaders]!==undefined){
+headersObject[kSensitiveHeaders]=rawHeaders[kSensitiveHeaders];
+}
+
+this[kSentHeaders]=headersObject;
+
 returnthis[kSentHeaders];
 }
 

lib/internal/http2/util.js

@@ -678,15 +678,23 @@ function prepareRequestHeadersArray(headers, session) {
 thrownewERR_HTTP2_CONNECT_PATH();
 }
 
-constheadersList=buildNgHeaderString(
+constrawHeaders=
 additionalPsuedoHeaders.length ?
 additionalPsuedoHeaders.concat(headers) :
-headers,
+headers;
+
+if(headers[kSensitiveHeaders]!==undefined){
+rawHeaders[kSensitiveHeaders]=headers[kSensitiveHeaders];
+}
+
+constheadersList=buildNgHeaderString(
+rawHeaders,
 assertValidPseudoHeader,
 headers[kSensitiveHeaders],
 );
 
 return{
+ rawHeaders,
  headersList,
  scheme,
 authority: authority??headers[HTTP2_HEADER_HOST],

test/parallel/test-http2-raw-headers.js

@@ -39,6 +39,16 @@ const http2 = require('http2');
 'a','c',
 ]).end();
 
+assert.deepStrictEqual(req.sentHeaders,{
+'__proto__': null,
+':path': '/foobar',
+':scheme': 'http',
+':authority': `localhost:${server.address().port}`,
+':method': 'GET',
+'a': ['b','c'],
+'x-FOO': 'bar',
+});
+
 req.on('response',common.mustCall((headers)=>{
 assert.strictEqual(headers[':status'],200);
 client.close();

test/parallel/test-http2-sensitive-headers.js

@@ -72,6 +72,16 @@ const { duplexPair } = require('stream');
 
 constreq=client.request(rawHeaders);
 
+assert.deepStrictEqual(req.sentHeaders,{
+'__proto__': null,
+':method': 'GET',
+':authority': 'localhost:80',
+':scheme': 'http',
+':path': '/',
+'secret': 'secret-value',
+[http2.sensitiveHeaders]: ['secret'],
+});
+
 req.on('response',common.mustCall((headers)=>{
 assert.strictEqual(headers[':status'],200);
 }));