lib: refactor to use more primordials

PR-URL: #36140
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: aduh95

lib/internal/main/print_help.js

@@ -1,12 +1,17 @@
 'use strict';
 
 const{
+ ArrayPrototypeConcat,
+ ArrayPrototypeSort,
  Boolean,
- Map,
  MathFloor,
  MathMax,
  ObjectKeys,
  RegExp,
+ StringPrototypeTrimLeft,
+ StringPrototypeRepeat,
+ StringPrototypeReplace,
+ SafeMap,
 }=primordials;
 
 const{ types }=internalBinding('options');
@@ -23,7 +28,7 @@ for (const key of ObjectKeys(types))
 // Environment variables are parsed ad-hoc throughout the code base,
 // so we gather the documentation here.
 const{ hasIntl, hasSmallICU, hasNodeOptions }=internalBinding('config');
-constenvVars=newMap([
+constenvVars=newSafeMap(ArrayPrototypeConcat([
 ['NODE_DEBUG',{helpText: "','-separated list of core modules that "+
 'should print debug information'}],
 ['NODE_DEBUG_NATIVE',{helpText: "','-separated list of C++ core debug "+
@@ -51,28 +56,30 @@ const envVars = new Map([
 'to'}],
 ['UV_THREADPOOL_SIZE',{helpText: 'sets the number of threads used in '+
 'libuv\'s threadpool'}]
-].concat(hasIntl ? [
+],hasIntl ? [
 ['NODE_ICU_DATA',{helpText: 'data path for ICU (Intl object) data'+
 hasSmallICU ? '' : ' (will extend linked-in data)'}]
-] : []).concat(hasNodeOptions ? [
+] : []),(hasNodeOptions ? [
 ['NODE_OPTIONS',{helpText: 'set CLI options in the environment via a '+
 'space-separated list'}]
-] : []).concat(hasCrypto ? [
+] : []),hasCrypto ? [
 ['OPENSSL_CONF',{helpText: 'load OpenSSL configuration from file'}],
 ['SSL_CERT_DIR',{helpText: 'sets OpenSSL\'s directory of trusted '+
 'certificates when used in conjunction with --use-openssl-ca'}],
 ['SSL_CERT_FILE',{helpText: 'sets OpenSSL\'s trusted certificate file '+
 'when used in conjunction with --use-openssl-ca'}],
-] : []));
+] : []);
 
 
 functionindent(text,depth){
-returntext.replace(/^/gm,' '.repeat(depth));
+returnStringPrototypeReplace(text,/^/gm,StringPrototypeRepeat(' ',depth));
 }
 
 functionfold(text,width){
-returntext.replace(newRegExp(`([^\n]{0,${width}})( |$)`,'g'),
-(_,newLine,end)=>newLine+(end===' ' ? '\n' : ''));
+returnStringPrototypeReplace(text,
+newRegExp(`([^\n]{0,${width}})( |$)`,'g'),
+(_,newLine,end)=>
+newLine+(end===' ' ? '\n' : ''));
 }
 
 functiongetArgDescription(type){
@@ -94,13 +101,15 @@ function getArgDescription(type) {
 }
 }
 
-functionformat({ options, aliases =newMap(), firstColumn, secondColumn }){
+functionformat(
+{ options, aliases =newSafeMap(), firstColumn, secondColumn }
+){
 lettext='';
 letmaxFirstColumnUsed=0;
 
 for(const[
 name,{ helpText, type, value }
-]of[...options.entries()].sort()){
+]ofArrayPrototypeSort([...options.entries()])){
 if(!helpText)continue;
 
 letdisplayName=name;
@@ -136,12 +145,12 @@ function format({ options, aliases = new Map(), firstColumn, secondColumn }) {
 text+=displayName;
 maxFirstColumnUsed=MathMax(maxFirstColumnUsed,displayName.length);
 if(displayName.length>=firstColumn)
-text+='\n'+' '.repeat(firstColumn);
+text+='\n'+StringPrototypeRepeat(' ',firstColumn);
 else
-text+=' '.repeat(firstColumn-displayName.length);
+text+=StringPrototypeRepeat(' ',firstColumn-displayName.length);
 
-text+=indent(fold(displayHelpText,secondColumn),
-firstColumn).trimLeft()+'\n';
+text+=indent(StringPrototypeTrimLeft(fold(displayHelpText,secondColumn),
+firstColumn))+'\n';
 }
 
 if(maxFirstColumnUsed<firstColumn-4){

lib/internal/main/worker_thread.js

@@ -4,7 +4,10 @@
 // message port.
 
 const{
+ ArrayPrototypeConcat,
+ ArrayPrototypeSplice,
  ObjectDefineProperty,
+ PromisePrototypeCatch,
 }=primordials;
 
 const{
@@ -120,7 +123,7 @@ port.on('message', (message) => {
 initializeESMLoader();
 
 if(argv!==undefined){
-process.argv=process.argv.concat(argv);
+process.argv=ArrayPrototypeConcat(process.argv,argv);
 }
 publicWorker.parentPort=publicPort;
 publicWorker.workerData=workerData;
@@ -162,18 +165,18 @@ port.on('message', (message) => {
 enumerable: true,
 value: filename,
 });
-process.argv.splice(1,0,name);
+ArrayPrototypeSplice(process.argv,1,0,name);
 evalScript(name,filename);
 }elseif(doEval==='module'){
 const{ evalModule }=require('internal/process/execution');
-evalModule(filename).catch((e)=>{
+PromisePrototypeCatch(evalModule(filename),(e)=>{
 workerOnGlobalUncaughtException(e,true);
 });
 }else{
 // script filename
 // runMain here might be monkey-patched by users in --require.
 // XXX: the monkey-patchability here should probably be deprecated.
-process.argv.splice(1,0,filename);
+ArrayPrototypeSplice(process.argv,1,0,filename);
 CJSLoader.Module.runMain(filename);
 }
 }elseif(message.type===STDIO_PAYLOAD){