module: refactor NativeModule to avoid unsafe array iteration

aduh95 · targos · commit 0fdb5d59f7bd · 2021-06-11T09:30:02.000+02:00
PR-URL: #37656 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
diff --git a/lib/internal/bootstrap/loaders.js b/lib/internal/bootstrap/loaders.js
@@ -46,6 +46,7 @@
 const {
 ArrayPrototypeMap,
 ArrayPrototypePush,
+ ArrayPrototypeSlice,
 Error,
 ObjectCreate,
 ObjectDefineProperty,
@@ -239,8 +240,10 @@ class NativeModule {
 const { ModuleWrap } = internalBinding('module_wrap');
 const url = `node:${this.id}`;
 const nativeModule = this;
+ const exportsKeys = ArrayPrototypeSlice(this.exportKeys);
+ ArrayPrototypePush(exportsKeys, 'default');
 this.module = new ModuleWrap(
- url, undefined, [...this.exportKeys, 'default'],
+ url, undefined, exportsKeys,
 function() {
 nativeModule.syncExports();
 this.setExport('default', nativeModule.exports);

-Original file line number
+Diff line change
 const{
  ArrayPrototypeMap,
  ArrayPrototypePush,
 + ArrayPrototypeSlice,
  Error,
  ObjectCreate,
  ObjectDefineProperty,
 const{ ModuleWrap }=internalBinding('module_wrap');
 consturl=`node:${this.id}`;
 constnativeModule=this;
 +constexportsKeys=ArrayPrototypeSlice(this.exportKeys);
 +ArrayPrototypePush(exportsKeys,'default');
 this.module=newModuleWrap(
 -url,undefined,[...this.exportKeys,'default'],
 +url,undefined,exportsKeys,
 function(){
 nativeModule.syncExports();
 this.setExport('default',nativeModule.exports);