lib: revert to using default derived class constructors

PR-URL: #59650
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Author: Renegade334

lib/inspector/promises.js

@@ -3,9 +3,7 @@
 constinspector=require('inspector');
 const{ promisify }=require('internal/util');
 
-classSessionextendsinspector.Session{
-constructor(){super();}// eslint-disable-line no-useless-constructor
-}
+classSessionextendsinspector.Session{}
 Session.prototype.post=promisify(inspector.Session.prototype.post);
 
 module.exports={

lib/internal/buffer.js

@@ -953,14 +953,7 @@ function writeFloatBackwards(val, offset = 0) {
 returnoffset;
 }
 
-classFastBufferextendsUint8Array{
-// Using an explicit constructor here is necessary to avoid relying on
-// `Array.prototype[Symbol.iterator]`, which can be mutated by users.
-// eslint-disable-next-line no-useless-constructor
-constructor(bufferOrLength,byteOffset,length){
-super(bufferOrLength,byteOffset,length);
-}
-}
+classFastBufferextendsUint8Array{}
 
 functionaddBufferPrototypeMethods(proto){
 proto.readBigUInt64LE=readBigUInt64LE;

lib/internal/crypto/keys.js

@@ -235,11 +235,6 @@ const {
 }
 
 classAsymmetricKeyObjectextendsKeyObject{
-// eslint-disable-next-line no-useless-constructor
-constructor(type,handle){
-super(type,handle);
-}
-
 getasymmetricKeyType(){
 returnthis[kAsymmetricKeyType]||=this[kHandle].getAsymmetricKeyType();
 }

lib/internal/fs/glob.js

@@ -240,7 +240,6 @@ class Pattern {
 classResultSetextendsSafeSet{
  #root ='.';
  #isExcluded =()=>false;
-constructor(i){super(i);}// eslint-disable-line no-useless-constructor
 
 setup(root,isExcludedFn){
 this.#root =root;

lib/internal/modules/esm/module_map.js

@@ -23,8 +23,6 @@ const { validateString } = require('internal/validators');
  * This cache is *not* used when custom loaders are registered.
  */
 classResolveCacheextendsSafeMap{
-constructor(i){super(i);}// eslint-disable-line no-useless-constructor
-
 /**
  * Generates the internal serialized cache key and returns it along the actual cache object.
  *
@@ -87,7 +85,6 @@ class ResolveCache extends SafeMap {
  * Cache the results of the `load` step of the module resolution and loading process.
  */
 classLoadCacheextendsSafeMap{
-constructor(i){super(i);}// eslint-disable-line no-useless-constructor
 get(url,type=kImplicitTypeAttribute){
 validateString(url,'url');
 validateString(type,'type');

lib/internal/per_context/primordials.js

@@ -401,55 +401,36 @@ primordials.makeSafe = makeSafe;
 
 // Subclass the constructors because we need to use their prototype
 // methods later.
-// Defining the `constructor` is necessary here to avoid the default
-// constructor which uses the user-mutable `%ArrayIteratorPrototype%.next`.
 primordials.SafeMap=makeSafe(
 Map,
-classSafeMapextendsMap{
-constructor(i){super(i);}// eslint-disable-line no-useless-constructor
-},
+classSafeMapextendsMap{},
 );
 primordials.SafeWeakMap=makeSafe(
 WeakMap,
-classSafeWeakMapextendsWeakMap{
-constructor(i){super(i);}// eslint-disable-line no-useless-constructor
-},
+classSafeWeakMapextendsWeakMap{},
 );
 
 primordials.SafeSet=makeSafe(
 Set,
-classSafeSetextendsSet{
-constructor(i){super(i);}// eslint-disable-line no-useless-constructor
-},
+classSafeSetextendsSet{},
 );
 primordials.SafeWeakSet=makeSafe(
 WeakSet,
-classSafeWeakSetextendsWeakSet{
-constructor(i){super(i);}// eslint-disable-line no-useless-constructor
-},
+classSafeWeakSetextendsWeakSet{},
 );
 
 primordials.SafeFinalizationRegistry=makeSafe(
 FinalizationRegistry,
-classSafeFinalizationRegistryextendsFinalizationRegistry{
-// eslint-disable-next-line no-useless-constructor
-constructor(cleanupCallback){super(cleanupCallback);}
-},
+classSafeFinalizationRegistryextendsFinalizationRegistry{},
 );
 primordials.SafeWeakRef=makeSafe(
 WeakRef,
-classSafeWeakRefextendsWeakRef{
-// eslint-disable-next-line no-useless-constructor
-constructor(target){super(target);}
-},
+classSafeWeakRefextendsWeakRef{},
 );
 
 constSafePromise=makeSafe(
 Promise,
-classSafePromiseextendsPromise{
-// eslint-disable-next-line no-useless-constructor
-constructor(executor){super(executor);}
-},
+classSafePromiseextendsPromise{},
 );
 
 /**

lib/internal/readline/interface.js

@@ -348,10 +348,6 @@ ObjectSetPrototypeOf(InterfaceConstructor.prototype, EventEmitter.prototype);
 ObjectSetPrototypeOf(InterfaceConstructor,EventEmitter);
 
 classInterfaceextendsInterfaceConstructor{
-// eslint-disable-next-line no-useless-constructor
-constructor(input,output,completer,terminal){
-super(input,output,completer,terminal);
-}
 getcolumns(){
 if(this.output?.columns)returnthis.output.columns;
 returnInfinity;

lib/internal/repl/utils.js

@@ -92,10 +92,6 @@ function isRecoverableError(e, code) {
 .extend(
 (Parser)=>{
 returnclassextendsParser{
-// eslint-disable-next-line no-useless-constructor
-constructor(options,input,startPos){
-super(options,input,startPos);
-}
 nextToken(){
 super.nextToken();
 if(this.type===tt.eof)

lib/readline/promises.js

@@ -27,10 +27,6 @@ const {
 letaddAbortListener;
 
 classInterfaceextends_Interface{
-// eslint-disable-next-line no-useless-constructor
-constructor(input,output,completer,terminal){
-super(input,output,completer,terminal);
-}
 question(query,options=kEmptyObject){
 returnnewPromise((resolve,reject)=>{
 letcb=resolve;