assert,util: improve comparison performance

This makes sure that the toStringTag symbol is used, if available
instead of calculating the toString() value each time, if not
needed (the type checks make a brand check, so there is no need to
check the toStringTag, if non is defined on the object).
PR-URL: #61176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Author: BridgeAR

lib/internal/util/comparisons.js

@@ -41,6 +41,7 @@ const {
  StringPrototypeValueOf,
  Symbol,
  SymbolPrototypeValueOf,
+ SymbolToStringTag,
 TypedArrayPrototypeGetByteLength: getByteLength,
  TypedArrayPrototypeGetSymbolToStringTag,
  Uint16Array,
@@ -264,6 +265,17 @@ function innerDeepEqual(val1, val2, mode, memos) {
 returnobjectComparisonStart(val1,val2,mode,memos);
 }
 
+functionhasUnequalTag(val1,val2){
+returnval1[SymbolToStringTag]!==val2[SymbolToStringTag];
+}
+
+functionslowHasUnequalTag(val1Tag,val1,val2){
+if(val1[SymbolToStringTag]!==undefined&&val2[SymbolToStringTag]!==undefined){
+returnval1[SymbolToStringTag]!==val2[SymbolToStringTag];
+}
+returnval1Tag!==ObjectPrototypeToString(val2);
+}
+
 functionobjectComparisonStart(val1,val2,mode,memos){
 if(mode===kStrict){
 if(wellKnownConstructors.has(val1.constructor)||
@@ -276,16 +288,10 @@ function objectComparisonStart(val1, val2, mode, memos) {
 }
 }
 
-constval1Tag=ObjectPrototypeToString(val1);
-constval2Tag=ObjectPrototypeToString(val2);
-
-if(val1Tag!==val2Tag){
-returnfalse;
-}
-
 if(ArrayIsArray(val1)){
 if(!ArrayIsArray(val2)||
-(val1.length!==val2.length&&(mode!==kPartial||val1.length<val2.length))){
+(val1.length!==val2.length&&(mode!==kPartial||val1.length<val2.length))||
+hasUnequalTag(val1,val2)){
 returnfalse;
 }
 
@@ -296,22 +302,29 @@ function objectComparisonStart(val1, val2, mode, memos) {
 returnfalse;
 }
 returnkeyCheck(val1,val2,mode,memos,kIsArray,keys2);
-}elseif(val1Tag==='[object Object]'){
-returnkeyCheck(val1,val2,mode,memos,kNoIterator);
-}elseif(isDate(val1)){
-if(!isDate(val2)){
+}
+
+letval1Tag;
+if(val1[SymbolToStringTag]===undefined&&
+(val1Tag=ObjectPrototypeToString(val1))==='[object Object]'){
+if(slowHasUnequalTag(val1Tag,val1,val2)){
 returnfalse;
 }
-consttime1=DatePrototypeGetTime(val1);
-consttime2=DatePrototypeGetTime(val2);
-// eslint-disable-next-line no-self-compare
-if(time1!==time2&&(time1===time1||time2===time2)){
+returnkeyCheck(val1,val2,mode,memos,kNoIterator);
+}elseif(isSet(val1)){
+if(!isSet(val2)||
+(val1.size!==val2.size&&(mode!==kPartial||val1.size<val2.size))||
+hasUnequalTag(val1,val2)){
 returnfalse;
 }
-}elseif(isRegExp(val1)){
-if(!isRegExp(val2)||!areSimilarRegExps(val1,val2)){
+returnkeyCheck(val1,val2,mode,memos,kIsSet);
+}elseif(isMap(val1)){
+if(!isMap(val2)||
+(val1.size!==val2.size&&(mode!==kPartial||val1.size<val2.size))||
+hasUnequalTag(val1,val2)){
 returnfalse;
 }
+returnkeyCheck(val1,val2,mode,memos,kIsMap);
 }elseif(isArrayBufferView(val1)){
 if(TypedArrayPrototypeGetSymbolToStringTag(val1)!==
 TypedArrayPrototypeGetSymbolToStringTag(val2)){
@@ -339,20 +352,22 @@ function objectComparisonStart(val1, val2, mode, memos) {
 returnfalse;
 }
 returnkeyCheck(val1,val2,mode,memos,kNoIterator,keys2);
-}elseif(isSet(val1)){
-if(!isSet(val2)||
-(val1.size!==val2.size&&(mode!==kPartial||val1.size<val2.size))){
+}elseif(isDate(val1)){
+if(!isDate(val2)||hasUnequalTag(val1,val2)){
 returnfalse;
 }
-returnkeyCheck(val1,val2,mode,memos,kIsSet);
-}elseif(isMap(val1)){
-if(!isMap(val2)||
-(val1.size!==val2.size&&(mode!==kPartial||val1.size<val2.size))){
+consttime1=DatePrototypeGetTime(val1);
+consttime2=DatePrototypeGetTime(val2);
+// eslint-disable-next-line no-self-compare
+if(time1!==time2&&(time1===time1||time2===time2)){
+returnfalse;
+}
+}elseif(isRegExp(val1)){
+if(!isRegExp(val2)||!areSimilarRegExps(val1,val2)||hasUnequalTag(val1,val2)){
 returnfalse;
 }
-returnkeyCheck(val1,val2,mode,memos,kIsMap);
 }elseif(isAnyArrayBuffer(val1)){
-if(!isAnyArrayBuffer(val2)){
+if(!isAnyArrayBuffer(val2)||hasUnequalTag(val1,val2)){
 returnfalse;
 }
 if(mode!==kPartial||val1.byteLength===val2.byteLength){
@@ -362,6 +377,15 @@ function objectComparisonStart(val1, val2, mode, memos) {
 }elseif(!isPartialUint8Array(newUint8Array(val1),newUint8Array(val2))){
 returnfalse;
 }
+}elseif(slowHasUnequalTag(val1Tag??ObjectPrototypeToString(val1),val1,val2)||
+ArrayIsArray(val2)||
+isArrayBufferView(val2)||
+isSet(val2)||
+isMap(val2)||
+isDate(val2)||
+isRegExp(val2)||
+isAnyArrayBuffer(val2)){
+returnfalse;
 }elseif(isError(val1)){
 // Do not compare the stack as it might differ even though the error itself
 // is otherwise identical.
@@ -380,17 +404,6 @@ function objectComparisonStart(val1, val2, mode, memos) {
 if(!isEqualBoxedPrimitive(val1,val2)){
 returnfalse;
 }
-}elseif(ArrayIsArray(val2)||
-isArrayBufferView(val2)||
-isSet(val2)||
-isMap(val2)||
-isDate(val2)||
-isRegExp(val2)||
-isAnyArrayBuffer(val2)||
-isBoxedPrimitive(val2)||
-isNativeError(val2)||
-val2instanceofError){
-returnfalse;
 }elseif(isURL(val1)){
 if(!isURL(val2)||val1.href!==val2.href){
 returnfalse;
@@ -412,7 +425,12 @@ function objectComparisonStart(val1, val2, mode, memos) {
 ){
 returnfalse;
 }
-}elseif(isWeakMap(val1)||isWeakSet(val1)||isPromise(val1)){
+}elseif(isBoxedPrimitive(val2)||
+isNativeError(val2)||
+val2instanceofError||
+isWeakMap(val1)||
+isWeakSet(val1)||
+isPromise(val1)){
 returnfalse;
 }
 
@@ -879,18 +897,16 @@ function partialSparseArrayEquiv(a, b, mode, memos, startA, startB) {
 letaPos=startA;
 constkeysA=ObjectKeys(a);
 constkeysB=ObjectKeys(b);
-constkeysBLength=keysB.length;
-constkeysALength=keysA.length;
-constlenA=keysALength-startA;
-constlenB=keysBLength-startB;
+constlenA=keysA.length-startA;
+constlenB=keysB.length-startB;
 if(lenA<lenB){
 returnfalse;
 }
 for(leti=0;i<lenB;i++){
 constkeyB=keysB[startB+i];
 while(!innerDeepEqual(a[keysA[aPos]],b[keyB],mode,memos)){
 aPos++;
-if(aPos>keysALength-lenB+i){
+if(aPos>keysA.length-lenB+i){
 returnfalse;
 }
 }
@@ -922,8 +938,6 @@ function partialArrayEquiv(a, b, mode, memos) {
 }
 
 functionsparseArrayEquiv(a,b,mode,memos,i){
-// TODO(BridgeAR): Use internal method to only get index properties. The
-// same applies to the partial implementation.
 constkeysA=ObjectKeys(a);
 constkeysB=ObjectKeys(b);
 if(keysA.length!==keysB.length){