net: remoteAddress always undefined called before connected

PR-URL: #43011
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: Y1D7NG

lib/net.js

@@ -733,7 +733,7 @@ Socket.prototype._destroy = function(exception, cb) {
 };
 
 Socket.prototype._getpeername=function(){
-if(!this._handle||!this._handle.getpeername){
+if(!this._handle||!this._handle.getpeername||this.connecting){
 returnthis._peername||{};
 }elseif(!this._peername){
 this._peername={};
@@ -760,7 +760,9 @@ protoGetter('remoteAddress', function remoteAddress() {
 });
 
 protoGetter('remoteFamily',functionremoteFamily(){
-return`IPv${this._getpeername().family}`;
+const{ family }=this._getpeername();
+
+returnfamily ? `IPv${family}` : family;
 });
 
 protoGetter('remotePort',functionremotePort(){

test/parallel/test-net-remote-address-port.js

@@ -53,6 +53,14 @@ const server = net.createServer(common.mustCall(function(socket) {
 server.listen(0,function(){
 constclient=net.createConnection(this.address().port,'127.0.0.1');
 constclient2=net.createConnection(this.address().port);
+
+assert.strictEqual(client.remoteAddress,undefined);
+assert.strictEqual(client.remoteFamily,undefined);
+assert.strictEqual(client.remotePort,undefined);
+assert.strictEqual(client2.remoteAddress,undefined);
+assert.strictEqual(client2.remoteFamily,undefined);
+assert.strictEqual(client2.remotePort,undefined);
+
 client.on('connect',function(){
 assert.ok(remoteAddrCandidates.includes(client.remoteAddress));
 assert.ok(remoteFamilyCandidates.includes(client.remoteFamily));