Skip to content

Commit 11f4562

Browse files
vsemozhetbytaddaleax
authored andcommitted
benchmark: remove needless RegExp capturing
Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterwards at all; * some of the later captured groups are not used afterwards. PR-URL: #13718 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent d4a05b2 commit 11f4562

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎benchmark/common.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ function formatResult(data) {
217217
}
218218

219219
varrate=data.rate.toString().split('.');
220-
rate[0]=rate[0].replace(/(\d)(?=(\d\d\d)+(?!\d))/g,'$1,');
220+
rate[0]=rate[0].replace(/(\d)(?=(?:\d\d\d)+(?!\d))/g,'$1,');
221221
rate=(rate[1] ? rate.join('.') : rate[0]);
222222
return`${data.name}${conf}: ${rate}`;
223223
}

‎benchmark/run.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ if (format === 'csv') {
6060
console.log(`"${data.name}", "${conf}", ${data.rate}, ${data.time}`);
6161
}else{
6262
varrate=data.rate.toString().split('.');
63-
rate[0]=rate[0].replace(/(\d)(?=(\d\d\d)+(?!\d))/g,'$1,');
63+
rate[0]=rate[0].replace(/(\d)(?=(?:\d\d\d)+(?!\d))/g,'$1,');
6464
rate=(rate[1] ? rate.join('.') : rate[0]);
6565
console.log(`${data.name}${conf}: ${rate}`);
6666
}

0 commit comments

Comments
 (0)