tools: enable ESLint require-yield rule

PR-URL: #41463
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

Author: Trott

.eslintrc.js

@@ -320,6 +320,7 @@ module.exports = {
 'quotes': ['error','single',{avoidEscape: true}],
 'quote-props': ['error','consistent'],
 'rest-spread-spacing': 'error',
+'require-yield': 'error',
 'semi': 'error',
 'semi-spacing': 'error',
 'space-before-blocks': ['error','always'],

test/parallel/test-readable-from.js

@@ -126,7 +126,7 @@ async function toReadableOnDataNonObject() {
 }
 
 asyncfunctiondestroysTheStreamWhenThrowing(){
-asyncfunction*generate(){
+asyncfunction*generate(){// eslint-disable-line require-yield
 thrownewError('kaboom');
 }
 

test/parallel/test-stream-compose.js

@@ -234,7 +234,7 @@ const assert = require('assert');
 callback(null,chunk);
 })
 }),
-asyncfunction*(source){
+asyncfunction*(source){// eslint-disable-line require-yield
 lettmp='';
 forawait(constchunkofsource){
 tmp+=chunk;

test/parallel/test-stream-duplex-from.js

@@ -134,7 +134,7 @@ const { Duplex, Readable, Writable, pipeline } = require('stream');
 }
 yieldrest;
 }),
-asyncfunction*(source){
+asyncfunction*(source){// eslint-disable-line require-yield
 letret='';
 forawait(constxofsource){
 ret+=x;

test/parallel/test-stream-pipeline.js

@@ -699,8 +699,8 @@ const tsp = require('timers/promises');
 constret=pipeline(asyncfunction*(){
 awaitPromise.resolve();
 yield'hello';
-},asyncfunction*(source){
-forawait(constchunkofsource){}
+},asyncfunction*(source){// eslint-disable-line require-yield
+forawait(constchunkofsource){}// eslint-disable-line no-unused-vars
 },common.mustCall((err)=>{
 assert.strictEqual(err,undefined);
 }));
@@ -712,11 +712,11 @@ const tsp = require('timers/promises');
 // AsyncFunction destination is not returned and error is
 // propagated.
 
-constret=pipeline(asyncfunction*(){
+constret=pipeline(asyncfunction*(){// eslint-disable-line require-yield
 awaitPromise.resolve();
 thrownewError('kaboom');
-},asyncfunction*(source){
-forawait(constchunkofsource){}
+},asyncfunction*(source){// eslint-disable-line require-yield
+forawait(constchunkofsource){}// eslint-disable-line no-unused-vars
 },common.mustCall((err)=>{
 assert.strictEqual(err.message,'kaboom');
 }));
@@ -726,7 +726,7 @@ const tsp = require('timers/promises');
 
 {
 consts=newPassThrough();
-pipeline(asyncfunction*(){
+pipeline(asyncfunction*(){// eslint-disable-line require-yield
 thrownewError('kaboom');
 },s,common.mustCall((err)=>{
 assert.strictEqual(err.message,'kaboom');
@@ -736,7 +736,7 @@ const tsp = require('timers/promises');
 
 {
 consts=newPassThrough();
-pipeline(asyncfunction*(){
+pipeline(asyncfunction*(){// eslint-disable-line require-yield
 thrownewError('kaboom');
 }(),s,common.mustCall((err)=>{
 assert.strictEqual(err.message,'kaboom');
@@ -746,7 +746,7 @@ const tsp = require('timers/promises');
 
 {
 consts=newPassThrough();
-pipeline(function*(){
+pipeline(function*(){// eslint-disable-line require-yield
 thrownewError('kaboom');
 },s,common.mustCall((err,val)=>{
 assert.strictEqual(err.message,'kaboom');
@@ -756,7 +756,7 @@ const tsp = require('timers/promises');
 
 {
 consts=newPassThrough();
-pipeline(function*(){
+pipeline(function*(){// eslint-disable-line require-yield
 thrownewError('kaboom');
 }(),s,common.mustCall((err,val)=>{
 assert.strictEqual(err.message,'kaboom');
@@ -771,7 +771,7 @@ const tsp = require('timers/promises');
 yield'hello';
 yield'world';
 },s,asyncfunction(source){
-forawait(constchunkofsource){
+forawait(constchunkofsource){// eslint-disable-line no-unused-vars
 thrownewError('kaboom');
 }
 },common.mustCall((err,val)=>{
@@ -784,8 +784,8 @@ const tsp = require('timers/promises');
 consts=newPassThrough();
 constret=pipeline(function(){
 return['hello','world'];
-},s,asyncfunction*(source){
-forawait(constchunkofsource){
+},s,asyncfunction*(source){// eslint-disable-line require-yield
+forawait(constchunkofsource){// eslint-disable-line no-unused-vars
 thrownewError('kaboom');
 }
 },common.mustCall((err)=>{
@@ -1054,12 +1054,11 @@ const tsp = require('timers/promises');
 constws=newWritable({
 write: common.mustNotCall()
 });
-pipeline(rs,asyncfunction*(stream){
-/* eslint no-unused-vars: off */
-forawait(constchunkofstream){
+pipeline(rs,asyncfunction*(stream){// eslint-disable-line require-yield
+forawait(constchunkofstream){// eslint-disable-line no-unused-vars
 thrownewError('kaboom');
 }
-},asyncfunction*(source){
+},asyncfunction*(source){// eslint-disable-line require-yield
 forawait(constchunkofsource){
 res+=chunk;
 }
@@ -1394,7 +1393,7 @@ const tsp = require('timers/promises');
 constac=newAbortController();
 constsignal=ac.signal;
 pipelinep(
-asyncfunction*({ signal }){
+asyncfunction*({ signal }){// eslint-disable-line require-yield
 awaittsp.setTimeout(1e6,signal);
 },
 asyncfunction(source){

test/parallel/test-worker-message-port-terminate-transfer-list.js

@@ -18,6 +18,7 @@ if (!process.env.HAS_STARTED_WORKER) {
 
 // Make sure we don’t end up running JS after the infinite loop is broken.
 port1.postMessage({},{
+// eslint-disable-next-line require-yield
 transfer: (function*(){while(true);})()
 });