events: disabled manual construction AbortSignal

RaisinTen · codebytere · commit 1550073dbc2f · 2020-11-22T12:42:19.000-08:00
Fixes: #36064 PR-URL: #36094 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/lib/internal/abort_controller.js b/lib/internal/abort_controller.js
@@ -6,7 +6,9 @@
 const {
 ObjectAssign,
 ObjectDefineProperties,
+ ObjectSetPrototypeOf,
 Symbol,
+ TypeError,
 } = primordials;
 
 const {
@@ -35,6 +37,11 @@ function customInspect(self, obj, depth, options) {
 }
 
 class AbortSignal extends EventTarget {
+ constructor() {
+ // eslint-disable-next-line no-restricted-syntax
+ throw new TypeError('Illegal constructor');
+ }
+
 get aborted() { return !!this[kAborted]; }
 
 [customInspectSymbol](depth, options) {
@@ -50,6 +57,13 @@ ObjectDefineProperties(AbortSignal.prototype, {
 
 defineEventHandler(AbortSignal.prototype, 'abort');
 
+function createAbortSignal() {
+ const signal = new EventTarget();
+ ObjectSetPrototypeOf(signal, AbortSignal.prototype);
+ signal[kAborted] = false;
+ return signal;
+}
+
 function abortSignal(signal) {
 if (signal[kAborted]) return;
 signal[kAborted] = true;
@@ -65,7 +79,7 @@ function abortSignal(signal) {
 const kSignal = Symbol('signal');
 class AbortController {
 constructor() {
- this[kSignal] = new AbortSignal();
+ this[kSignal] = createAbortSignal();
 emitExperimentalWarning('AbortController');
 }
 
diff --git a/test/parallel/test-abortcontroller.js b/test/parallel/test-abortcontroller.js
@@ -3,7 +3,7 @@
 
 const common = require('../common');
 
-const { ok, strictEqual } = require('assert');
+const { ok, strictEqual, throws } = require('assert');
 
 {
 // Tests that abort is fired with the correct event type on AbortControllers
@@ -51,3 +51,12 @@ const { ok, strictEqual } = require('assert');
 strictEqual(firstTrusted, secondTrusted);
 strictEqual(untrusted, firstTrusted);
 }
+
+{
+ // Tests that AbortSignal is impossible to construct manually
+ const ac = new AbortController();
+ throws(
+ () => new ac.signal.constructor(),
+ /^TypeError: Illegal constructor$/
+ );
+}

-Original file line number
+Diff line change
 const{
  ObjectAssign,
  ObjectDefineProperties,
 + ObjectSetPrototypeOf,
  Symbol,
 + TypeError,
 }=primordials;
 const{
+}
 classAbortSignalextendsEventTarget{
 +constructor(){
 +// eslint-disable-next-line no-restricted-syntax
 +thrownewTypeError('Illegal constructor');
 +}
++
 getaborted(){return!!this[kAborted];}
 [customInspectSymbol](depth,options){
 defineEventHandler(AbortSignal.prototype,'abort');
 +functioncreateAbortSignal(){
 +constsignal=newEventTarget();
 +ObjectSetPrototypeOf(signal,AbortSignal.prototype);
 +signal[kAborted]=false;
 +returnsignal;
 +}
++
 functionabortSignal(signal){
 if(signal[kAborted])return;
 signal[kAborted]=true;
 constkSignal=Symbol('signal');
 classAbortController{
 constructor(){
 -this[kSignal]=newAbortSignal();
 +this[kSignal]=createAbortSignal();
 emitExperimentalWarning('AbortController');
+}
-Original file line number
+Diff line change
 constcommon=require('../common');
 -const{ ok, strictEqual }=require('assert');
 +const{ ok, strictEqual, throws}=require('assert');
+{
 // Tests that abort is fired with the correct event type on AbortControllers
 strictEqual(firstTrusted,secondTrusted);
 strictEqual(untrusted,firstTrusted);
+}
++
 +{
 +// Tests that AbortSignal is impossible to construct manually
 +constac=newAbortController();
 +throws(
 +()=>newac.signal.constructor(),
 +/^TypeError:Illegalconstructor$/
 +);
 +}