lib: create weakRef only if any signals provided

atlowChemi · danielleadams · commit 156292d44a54 · 2023-07-17T11:26:11.000-04:00
PR-URL: #48448 Backport-PR-URL: #48800 Fixes: #48419 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/abort_controller.js b/lib/internal/abort_controller.js
@@ -197,6 +197,9 @@ class AbortSignal extends EventTarget {
 static any(signals) {
 validateAbortSignalArray(signals, 'signals');
 const resultSignal = createAbortSignal({ composite: true });
+ if (!signals.length) {
+ return resultSignal;
+ }
 const resultSignalWeakRef = new WeakRef(resultSignal);
 resultSignal[kSourceSignals] = new SafeSet();
 for (let i = 0; i < signals.length; i++) {

-Original file line number
+Diff line change
 staticany(signals){
 validateAbortSignalArray(signals,'signals');
 constresultSignal=createAbortSignal({composite: true});
 +if(!signals.length){
 +returnresultSignal;
 +}
 constresultSignalWeakRef=newWeakRef(resultSignal);
 resultSignal[kSourceSignals]=newSafeSet();
 for(leti=0;i<signals.length;i++){