module: preserve URL in the parent created by createRequire()

Previously, createRequire() does not preserve the URL it gets
passed in the mock parent module created, which can be
observable if it's used together with module.registerHooks().
This patch adds preservation of the URL if createRequire()
is invoked with one.
PR-URL: #60974Fixes: #60973
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

Author: joyeecheung

lib/internal/modules/cjs/loader.js

@@ -135,7 +135,7 @@ const { BuiltinModule } = require('internal/bootstrap/realm');
 const{
  maybeCacheSourceMap,
 }=require('internal/source_map/source_map_cache');
-const{ pathToFileURL, fileURLToPath, isURL }=require('internal/url');
+const{ pathToFileURL, fileURLToPath, isURL,URL}=require('internal/url');
 const{
  pendingDeprecate,
  emitExperimentalWarning,
@@ -1922,7 +1922,7 @@ Module._extensions['.node'] = function(module, filename) {
  * @param {string} filename The path to the module
  * @returns {any}
  */
-functioncreateRequireFromPath(filename){
+functioncreateRequireFromPath(filename,fileURL){
 // Allow a directory to be passed as the filename
 consttrailingSlash=
 StringPrototypeEndsWith(filename,'/')||
@@ -1934,6 +1934,10 @@ function createRequireFromPath(filename) {
 
 constm=newModule(proxyPath);
 m.filename=proxyPath;
+if(fileURL!==undefined){
+// Save the URL if createRequire() was given a URL, to preserve search params, if any.
+m[kURL]=fileURL.href;
+}
 
 m.paths=Module._nodeModulePaths(m.path);
 returnmakeRequireFunction(m,null);
@@ -1944,28 +1948,32 @@ const createRequireError = 'must be a file URL object, file URL string, or ' +
 
 /**
  * Creates a new `require` function that can be used to load modules.
- * @param {string | URL} filename The path or URL to the module context for this `require`
+ * @param {string | URL} filenameOrURL The path or URL to the module context for this `require`
  * @throws {ERR_INVALID_ARG_VALUE} If `filename` is not a string or URL, or if it is a relative path that cannot be
  * resolved to an absolute path.
  * @returns {object}
  */
-functioncreateRequire(filename){
-letfilepath;
+functioncreateRequire(filenameOrURL){
+letfilepath,fileURL;
 
-if(isURL(filename)||
-(typeoffilename==='string'&&!path.isAbsolute(filename))){
+if(isURL(filenameOrURL)||
+(typeoffilenameOrURL==='string'&&!path.isAbsolute(filenameOrURL))){
 try{
-filepath=fileURLToPath(filename);
+// It might be an URL, try to convert it.
+// If it's a relative path, it would not parse and would be considered invalid per
+// the documented contract.
+fileURL=newURL(filenameOrURL);
+filepath=fileURLToPath(fileURL);
 }catch{
-thrownewERR_INVALID_ARG_VALUE('filename',filename,
+thrownewERR_INVALID_ARG_VALUE('filename',filenameOrURL,
 createRequireError);
 }
-}elseif(typeoffilename!=='string'){
-thrownewERR_INVALID_ARG_VALUE('filename',filename,createRequireError);
+}elseif(typeoffilenameOrURL!=='string'){
+thrownewERR_INVALID_ARG_VALUE('filename',filenameOrURL,createRequireError);
 }else{
-filepath=filename;
+filepath=filenameOrURL;
 }
-returncreateRequireFromPath(filepath);
+returncreateRequireFromPath(filepath,fileURL);
 }
 
 /**

test/fixtures/module-hooks/create-require-with-url.mjs

@@ -0,0 +1,3 @@
+import{createRequire}from'node:module'
+constrequire=createRequire(import.meta.url);
+require('./empty.mjs');

test/fixtures/module-hooks/empty.mjs

@@ -0,0 +1,26 @@
+// Verify that if URL is used to createRequire, that URL is passed to the resolve hook
+// as parentURL.
+import*ascommonfrom'../common/index.mjs';
+importassertfrom'node:assert';
+import{registerHooks}from'node:module';
+import*asfixturesfrom'../common/fixtures.mjs';
+
+constfixtureURL=fixtures.fileURL('module-hooks/create-require-with-url.mjs').href+'?test=1';
+registerHooks({
+resolve: common.mustCall((specifier,context,defaultResolve)=>{
+constresolved=defaultResolve(specifier,context,defaultResolve);
+if(specifier.startsWith('node:')){
+returnresolved;
+}
+
+if(specifier===fixtureURL){
+assert.strictEqual(context.parentURL,import.meta.url);
+}else{// From the createRequire call.
+assert.strictEqual(specifier,'./empty.mjs');
+assert.strictEqual(context.parentURL,fixtureURL);
+}
+returnresolved;
+},3),
+});
+
+awaitimport(fixtureURL);