http: skip body and next message of CONNECT res

When handling a response to `CONNECT` request - skip message body
and do not attempt to parse the next message. `CONNECT` requests are
used in similar sense to HTTP Upgrade.
Fix: #6198
PR-URL: #6279
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: indutny

lib/_http_client.js

@@ -432,7 +432,7 @@ function parserOnIncomingClient(res, shouldKeepAlive) {
 // Responses to CONNECT request is handled as Upgrade.
 if(req.method==='CONNECT'){
 res.upgrade=true;
-returntrue;// skip body
+return2;// skip body, and the rest
 }
 
 // Responses to HEAD requests are crazy.

lib/_http_common.js

@@ -94,7 +94,7 @@ function parserOnHeadersComplete(versionMajor, versionMinor, headers, method,
 
 parser.incoming.upgrade=upgrade;
 
-varskipBody=false;// response to HEAD or CONNECT
+varskipBody=0;// response to HEAD or CONNECT
 
 if(!upgrade){
 // For upgraded connections and CONNECT method request, we'll emit this
@@ -103,7 +103,10 @@ function parserOnHeadersComplete(versionMajor, versionMinor, headers, method,
 skipBody=parser.onIncoming(parser.incoming,shouldKeepAlive);
 }
 
-returnskipBody;
+if(typeofskipBody!=='number')
+returnskipBody ? 1 : 0;
+else
+returnskipBody;
 }
 
 // XXX This is a mess.

src/node_http_parser.cc

@@ -300,7 +300,7 @@ class Parser : public AsyncWrap {
 return -1;
  }
 
-return head_response->IsTrue() ? 1 : 0;
+return head_response->IntegerValue();
  }