n-api: make test_error functions static

Gabriel Schulhof · MylesBorins · commit 17dbf6c77f36 · 2018-05-08T14:22:25.000-07:00
PR-URL: #20373 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
diff --git a/test/addons-napi/test_error/test_error.c b/test/addons-napi/test_error/test_error.c
@@ -1,7 +1,7 @@
 #include <node_api.h>
 #include "../common.h"
 
-napi_value checkError(napi_env env, napi_callback_info info) {
+static napi_value checkError(napi_env env, napi_callback_info info) {
 size_t argc = 1;
 napi_value args[1];
 NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -15,7 +15,7 @@ napi_value checkError(napi_env env, napi_callback_info info) {
 return result;
 }
 
-napi_value throwExistingError(napi_env env, napi_callback_info info) {
+static napi_value throwExistingError(napi_env env, napi_callback_info info) {
 napi_value message;
 napi_value error;
 NAPI_CALL(env, napi_create_string_utf8(
@@ -25,42 +25,42 @@ napi_value throwExistingError(napi_env env, napi_callback_info info) {
 return NULL;
 }
 
-napi_value throwError(napi_env env, napi_callback_info info) {
+static napi_value throwError(napi_env env, napi_callback_info info) {
 NAPI_CALL(env, napi_throw_error(env, NULL, "error"));
 return NULL;
 }
 
-napi_value throwRangeError(napi_env env, napi_callback_info info) {
+static napi_value throwRangeError(napi_env env, napi_callback_info info) {
 NAPI_CALL(env, napi_throw_range_error(env, NULL, "range error"));
 return NULL;
 }
 
-napi_value throwTypeError(napi_env env, napi_callback_info info) {
+static napi_value throwTypeError(napi_env env, napi_callback_info info) {
 NAPI_CALL(env, napi_throw_type_error(env, NULL, "type error"));
 return NULL;
 }
 
-napi_value throwErrorCode(napi_env env, napi_callback_info info) {
+static napi_value throwErrorCode(napi_env env, napi_callback_info info) {
 NAPI_CALL(env, napi_throw_error(env, "ERR_TEST_CODE", "Error [error]"));
 return NULL;
 }
 
-napi_value throwRangeErrorCode(napi_env env, napi_callback_info info) {
+static napi_value throwRangeErrorCode(napi_env env, napi_callback_info info) {
 NAPI_CALL(env, napi_throw_range_error(env,
 "ERR_TEST_CODE",
 "RangeError [range error]"));
 return NULL;
 }
 
-napi_value throwTypeErrorCode(napi_env env, napi_callback_info info) {
+static napi_value throwTypeErrorCode(napi_env env, napi_callback_info info) {
 NAPI_CALL(env, napi_throw_type_error(env,
 "ERR_TEST_CODE",
 "TypeError [type error]"));
 return NULL;
 }
 
 
-napi_value createError(napi_env env, napi_callback_info info) {
+static napi_value createError(napi_env env, napi_callback_info info) {
 napi_value result;
 napi_value message;
 NAPI_CALL(env, napi_create_string_utf8(
@@ -69,7 +69,7 @@ napi_value createError(napi_env env, napi_callback_info info) {
 return result;
 }
 
-napi_value createRangeError(napi_env env, napi_callback_info info) {
+static napi_value createRangeError(napi_env env, napi_callback_info info) {
 napi_value result;
 napi_value message;
 NAPI_CALL(env, napi_create_string_utf8(
@@ -78,7 +78,7 @@ napi_value createRangeError(napi_env env, napi_callback_info info) {
 return result;
 }
 
-napi_value createTypeError(napi_env env, napi_callback_info info) {
+static napi_value createTypeError(napi_env env, napi_callback_info info) {
 napi_value result;
 napi_value message;
 NAPI_CALL(env, napi_create_string_utf8(
@@ -87,7 +87,7 @@ napi_value createTypeError(napi_env env, napi_callback_info info) {
 return result;
 }
 
-napi_value createErrorCode(napi_env env, napi_callback_info info) {
+static napi_value createErrorCode(napi_env env, napi_callback_info info) {
 napi_value result;
 napi_value message;
 napi_value code;
@@ -99,7 +99,7 @@ napi_value createErrorCode(napi_env env, napi_callback_info info) {
 return result;
 }
 
-napi_value createRangeErrorCode(napi_env env, napi_callback_info info) {
+static napi_value createRangeErrorCode(napi_env env, napi_callback_info info) {
 napi_value result;
 napi_value message;
 napi_value code;
@@ -113,7 +113,7 @@ napi_value createRangeErrorCode(napi_env env, napi_callback_info info) {
 return result;
 }
 
-napi_value createTypeErrorCode(napi_env env, napi_callback_info info) {
+static napi_value createTypeErrorCode(napi_env env, napi_callback_info info) {
 napi_value result;
 napi_value message;
 napi_value code;
@@ -135,7 +135,7 @@ static napi_value throwArbitrary(napi_env env, napi_callback_info info) {
 return NULL;
 }
 
-napi_value Init(napi_env env, napi_value exports) {
+static napi_value Init(napi_env env, napi_value exports) {
 napi_property_descriptor descriptors[] = {
 DECLARE_NAPI_PROPERTY("checkError", checkError),
 DECLARE_NAPI_PROPERTY("throwExistingError", throwExistingError),

-Original file line number
+Diff line change
@@ @@ -1,7 +1,7 @@ @@
 #include<node_api.h>
 #include"../common.h"
 -napi_valuecheckError(napi_envenv, napi_callback_infoinfo) {
 +staticnapi_valuecheckError(napi_envenv, napi_callback_infoinfo) {
 size_targc=1;
 napi_valueargs[1];
 NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
 returnresult;
+}
 -napi_valuethrowExistingError(napi_envenv, napi_callback_infoinfo) {
 +staticnapi_valuethrowExistingError(napi_envenv, napi_callback_infoinfo) {
 napi_valuemessage;
 napi_valueerror;
 NAPI_CALL(env, napi_create_string_utf8(
 returnNULL;
+}
 -napi_valuethrowError(napi_envenv, napi_callback_infoinfo) {
 +staticnapi_valuethrowError(napi_envenv, napi_callback_infoinfo) {
 NAPI_CALL(env, napi_throw_error(env, NULL, "error"));
 returnNULL;
+}
 -napi_valuethrowRangeError(napi_envenv, napi_callback_infoinfo) {
 +staticnapi_valuethrowRangeError(napi_envenv, napi_callback_infoinfo) {
 NAPI_CALL(env, napi_throw_range_error(env, NULL, "range error"));
 returnNULL;
+}
 -napi_valuethrowTypeError(napi_envenv, napi_callback_infoinfo) {
 +staticnapi_valuethrowTypeError(napi_envenv, napi_callback_infoinfo) {
 NAPI_CALL(env, napi_throw_type_error(env, NULL, "type error"));
 returnNULL;
+}
 -napi_valuethrowErrorCode(napi_envenv, napi_callback_infoinfo) {
 +staticnapi_valuethrowErrorCode(napi_envenv, napi_callback_infoinfo) {
 NAPI_CALL(env, napi_throw_error(env, "ERR_TEST_CODE", "Error [error]"));
 returnNULL;
+}
 -napi_valuethrowRangeErrorCode(napi_envenv, napi_callback_infoinfo) {
 +staticnapi_valuethrowRangeErrorCode(napi_envenv, napi_callback_infoinfo) {
 NAPI_CALL(env, napi_throw_range_error(env,
 "ERR_TEST_CODE",
 "RangeError [range error]"));
 returnNULL;
+}
 -napi_valuethrowTypeErrorCode(napi_envenv, napi_callback_infoinfo) {
 +staticnapi_valuethrowTypeErrorCode(napi_envenv, napi_callback_infoinfo) {
 NAPI_CALL(env, napi_throw_type_error(env,
 "ERR_TEST_CODE",
 "TypeError [type error]"));
 returnNULL;
+}
 -napi_valuecreateError(napi_envenv, napi_callback_infoinfo) {
 +staticnapi_valuecreateError(napi_envenv, napi_callback_infoinfo) {
 napi_valueresult;
 napi_valuemessage;
 NAPI_CALL(env, napi_create_string_utf8(
 returnresult;
+}
 -napi_valuecreateRangeError(napi_envenv, napi_callback_infoinfo) {
 +staticnapi_valuecreateRangeError(napi_envenv, napi_callback_infoinfo) {
 napi_valueresult;
 napi_valuemessage;
 NAPI_CALL(env, napi_create_string_utf8(
 returnresult;
+}
 -napi_valuecreateTypeError(napi_envenv, napi_callback_infoinfo) {
 +staticnapi_valuecreateTypeError(napi_envenv, napi_callback_infoinfo) {
 napi_valueresult;
 napi_valuemessage;
 NAPI_CALL(env, napi_create_string_utf8(
 returnresult;
+}
 -napi_valuecreateErrorCode(napi_envenv, napi_callback_infoinfo) {
 +staticnapi_valuecreateErrorCode(napi_envenv, napi_callback_infoinfo) {
 napi_valueresult;
 napi_valuemessage;
 napi_valuecode;
 returnresult;
+}
 -napi_valuecreateRangeErrorCode(napi_envenv, napi_callback_infoinfo) {
 +staticnapi_valuecreateRangeErrorCode(napi_envenv, napi_callback_infoinfo) {
 napi_valueresult;
 napi_valuemessage;
 napi_valuecode;
 returnresult;
+}
 -napi_valuecreateTypeErrorCode(napi_envenv, napi_callback_infoinfo) {
 +staticnapi_valuecreateTypeErrorCode(napi_envenv, napi_callback_infoinfo) {
 napi_valueresult;
 napi_valuemessage;
 napi_valuecode;
 returnNULL;
+}
 -napi_valueInit(napi_envenv, napi_valueexports) {
 +staticnapi_valueInit(napi_envenv, napi_valueexports) {
 napi_property_descriptordescriptors[] = {
 DECLARE_NAPI_PROPERTY("checkError", checkError),
 DECLARE_NAPI_PROPERTY("throwExistingError", throwExistingError),