assert: fix throws trace

The current stack trace thrown in case `assert.throws(fn, object)`
is used did not filter the stack trace. This fixes it.
Backport-PR-URL: #23223
PR-URL: #18595
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

Author: BridgeAR

lib/assert.js

@@ -661,11 +661,17 @@ assert.notStrictEqual = function notStrictEqual(actual, expected, message) {
 }
 };
 
-functioncreateMsg(msg,key,actual,expected){
-if(msg)
-returnmsg;
-return`${key}: expected ${inspect(expected[key])}, `+
-`not ${inspect(actual[key])}`;
+functioncompareExceptionKey(actual,expected,key,msg){
+if(!innerDeepEqual(actual[key],expected[key],true)){
+innerFail({
+actual: actual[key],
+expected: expected[key],
+message: msg||`${key}: expected ${inspect(expected[key])}, `+
+`not ${inspect(actual[key])}`,
+operator: 'throws',
+stackStartFn: assert.throws
+});
+}
 }
 
 functionexpectedException(actual,expected,msg){
@@ -680,23 +686,13 @@ function expectedException(actual, expected, msg) {
 // The name and message could be non enumerable. Therefore test them
 // explicitly.
 if('name'inexpected){
-assert.strictEqual(
-actual.name,
-expected.name,
-createMsg(msg,'name',actual,expected));
+compareExceptionKey(actual,expected,'name',msg);
 }
 if('message'inexpected){
-assert.strictEqual(
-actual.message,
-expected.message,
-createMsg(msg,'message',actual,expected));
+compareExceptionKey(actual,expected,'message',msg);
 }
-constkeys=Object.keys(expected);
-for(constkeyofkeys){
-assert.deepStrictEqual(
-actual[key],
-expected[key],
-createMsg(msg,key,actual,expected));
+for(constkeyofObject.keys(expected)){
+compareExceptionKey(actual,expected,key,msg);
 }
 returntrue;
 }

test/message/assert_throws_stack.js

@@ -0,0 +1,6 @@
+'use strict';
+
+require('../common');
+constassert=require('assert').strict;
+
+assert.throws(()=>{thrownewError('foo');},{bar: true});

test/message/assert_throws_stack.out

@@ -0,0 +1,14 @@
+assert.js:*
+ throw new errors.AssertionError(obj);
+ ^
+
+AssertionError [ERR_ASSERTION]: bar: expected true, not undefined
+ at Object.<anonymous> (*assert_throws_stack.js:*:*)
+ at *
+ at *
+ at *
+ at *
+ at *
+ at *
+ at *
+ at *