path,win: fix bug in resolve and normalize

Fixes: #54025
PR-URL: #55623
Backport-PR-URL: #59831
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: huseyinacacak-janea

lib/path.js

@@ -285,10 +285,16 @@ const win32 = {
 j++;
 }
 if(j===len||j!==last){
-// We matched a UNC root
-device=
-`\\\\${firstPart}\\${StringPrototypeSlice(path,last,j)}`;
-rootEnd=j;
+if(firstPart!=='.'&&firstPart!=='?'){
+// We matched a UNC root
+device=
+`\\\\${firstPart}\\${StringPrototypeSlice(path,last,j)}`;
+rootEnd=j;
+}else{
+// We matched a device root (e.g. \\\\.\\PHYSICALDRIVE0)
+device=`\\\\${firstPart}`;
+rootEnd=4;
+}
 }
 }
 }
@@ -398,17 +404,22 @@ const win32 = {
 !isPathSeparator(StringPrototypeCharCodeAt(path,j))){
 j++;
 }
-if(j===len){
-// We matched a UNC root only
-// Return the normalized version of the UNC root since there
-// is nothing left to process
-return`\\\\${firstPart}\\${StringPrototypeSlice(path,last)}\\`;
-}
-if(j!==last){
-// We matched a UNC root with leftovers
-device=
-`\\\\${firstPart}\\${StringPrototypeSlice(path,last,j)}`;
-rootEnd=j;
+if(j===len||j!==last){
+if(firstPart==='.'||firstPart==='?'){
+// We matched a device root (e.g. \\\\.\\PHYSICALDRIVE0)
+device=`\\\\${firstPart}`;
+rootEnd=4;
+}elseif(j===len){
+// We matched a UNC root only
+// Return the normalized version of the UNC root since there
+// is nothing left to process
+return`\\\\${firstPart}\\${StringPrototypeSlice(path,last)}\\`;
+}else{
+// We matched a UNC root with leftovers
+device=
+`\\\\${firstPart}\\${StringPrototypeSlice(path,last,j)}`;
+rootEnd=j;
+}
 }
 }
 }

src/path.cc

@@ -171,9 +171,16 @@ std::string PathResolve(Environment* env,
  j++;
  }
 if (j == len || j != last) {
-// We matched a UNC root
- device = "\\\\" + firstPart + "\\" + path.substr(last, j - last);
- rootEnd = j;
+if (firstPart != "." && firstPart != "?") {
+// We matched a UNC root
+ device =
+"\\\\" + firstPart + "\\" + path.substr(last, j - last);
+ rootEnd = j;
+ } else {
+// We matched a device root (e.g. \\\\.\\PHYSICALDRIVE0)
+ device = "\\\\" + firstPart;
+ rootEnd = 4;
+ }
  }
  }
  }

test/cctest/test_path.cc

@@ -35,6 +35,10 @@ TEST_F(PathTest, PathResolve) {
 EXPECT_EQ(
 PathResolve(*env, {"C:\\foo\\tmp.3\\", "..\\tmp.3\\cycles\\root.js"}),
 "C:\\foo\\tmp.3\\cycles\\root.js");
+EXPECT_EQ(PathResolve(*env, {"\\\\.\\PHYSICALDRIVE0"}),
+"\\\\.\\PHYSICALDRIVE0");
+EXPECT_EQ(PathResolve(*env, {"\\\\?\\PHYSICALDRIVE0"}),
+"\\\\?\\PHYSICALDRIVE0");
 #else
 EXPECT_EQ(PathResolve(*env, {"/var/lib", "../", "file/"}), "/var/file");
 EXPECT_EQ(PathResolve(*env, {"/var/lib", "/../", "file/"}), "/file");

test/parallel/test-path-makelong.js

@@ -79,7 +79,7 @@ assert.strictEqual(path.win32.toNamespacedPath('\\\\foo\\bar'),
 '\\\\?\\UNC\\foo\\bar\\');
 assert.strictEqual(path.win32.toNamespacedPath('//foo//bar'),
 '\\\\?\\UNC\\foo\\bar\\');
-assert.strictEqual(path.win32.toNamespacedPath('\\\\?\\foo'),'\\\\?\\foo\\');
+assert.strictEqual(path.win32.toNamespacedPath('\\\\?\\foo'),'\\\\?\\foo');
 assert.strictEqual(path.win32.toNamespacedPath('\\\\?\\c:\\Windows/System'),'\\\\?\\c:\\Windows\\System');
 assert.strictEqual(path.win32.toNamespacedPath(null),null);
 assert.strictEqual(path.win32.toNamespacedPath(true),true);

test/parallel/test-path-normalize.js

@@ -40,6 +40,8 @@ assert.strictEqual(
 '..\\..\\..\\..\\baz'
 );
 assert.strictEqual(path.win32.normalize('foo/bar\\baz'),'foo\\bar\\baz');
+assert.strictEqual(path.win32.normalize('\\\\.\\foo'),'\\\\.\\foo');
+assert.strictEqual(path.win32.normalize('\\\\.\\foo\\'),'\\\\.\\foo\\');
 
 // Tests related to CVE-2024-36139. Path traversal should not result in changing
 // the root directory on Windows.
@@ -58,10 +60,10 @@ assert.strictEqual(path.win32.normalize('/test/../??/D:/Test'), '\\??\\D:\\Test'
 assert.strictEqual(path.win32.normalize('/test/../?/D:/Test'),'\\?\\D:\\Test');
 assert.strictEqual(path.win32.normalize('//test/../??/D:/Test'),'\\\\test\\..\\??\\D:\\Test');
 assert.strictEqual(path.win32.normalize('//test/../?/D:/Test'),'\\\\test\\..\\?\\D:\\Test');
-assert.strictEqual(path.win32.normalize('\\\\?\\test/../?/D:/Test'),'\\\\?\\test\\?\\D:\\Test');
-assert.strictEqual(path.win32.normalize('\\\\?\\test/../../?/D:/Test'),'\\\\?\\test\\?\\D:\\Test');
-assert.strictEqual(path.win32.normalize('\\\\.\\test/../?/D:/Test'),'\\\\.\\test\\?\\D:\\Test');
-assert.strictEqual(path.win32.normalize('\\\\.\\test/../../?/D:/Test'),'\\\\.\\test\\?\\D:\\Test');
+assert.strictEqual(path.win32.normalize('\\\\?\\test/../?/D:/Test'),'\\\\?\\?\\D:\\Test');
+assert.strictEqual(path.win32.normalize('\\\\?\\test/../../?/D:/Test'),'\\\\?\\?\\D:\\Test');
+assert.strictEqual(path.win32.normalize('\\\\.\\test/../?/D:/Test'),'\\\\.\\?\\D:\\Test');
+assert.strictEqual(path.win32.normalize('\\\\.\\test/../../?/D:/Test'),'\\\\.\\?\\D:\\Test');
 assert.strictEqual(path.win32.normalize('//server/share/dir/../../../?/D:/file'),
 '\\\\server\\share\\?\\D:\\file');
 assert.strictEqual(path.win32.normalize('//server/goodshare/../badshare/file'),

test/parallel/test-path-resolve.js

@@ -33,6 +33,8 @@ const resolveTests = [
 [['c:/','///some//dir'],'c:\\some\\dir'],
 [['C:\\foo\\tmp.3\\','..\\tmp.3\\cycles\\root.js'],
 'C:\\foo\\tmp.3\\cycles\\root.js'],
+[['\\\\.\\PHYSICALDRIVE0'],'\\\\.\\PHYSICALDRIVE0'],
+[['\\\\?\\PHYSICALDRIVE0'],'\\\\?\\PHYSICALDRIVE0'],
 ],
 ],
 [path.posix.resolve,