module: refactor ts parser loading

marco-ippolito · targos · commit 1ba20007037d · 2024-08-14T08:15:29.000+02:00
PR-URL: #54243 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
diff --git a/lib/internal/modules/helpers.js b/lib/internal/modules/helpers.js
@@ -300,11 +300,29 @@ function getBuiltinModule(id) {
 return normalizedId ? require(normalizedId) : undefined;
 }
 
-let parseTS;
+let typeScriptParser;
 
-function lazyLoadTSParser() {
- parseTS ??= require('internal/deps/amaro/dist/index').transformSync;
- return parseTS;
+/**
+ * Load the TypeScript parser.
+ * @param {Function} parser - A function that takes a string of TypeScript code
+ * and returns an object with a `code` property.
+ * @returns {Function} The TypeScript parser function.
+ */
+function loadTypeScriptParser(parser) {
+ if (typeScriptParser) {
+ return typeScriptParser;
+ }
+
+ if (parser) {
+ typeScriptParser = parser;
+ } else {
+ const amaro = require('internal/deps/amaro/dist/index');
+ // Default option for Amaro is to perform Type Stripping only.
+ const defaultOptions = { __proto__: null, mode: 'strip-only' };
+ // Curry the transformSync function with the default options.
+ typeScriptParser = (source) => amaro.transformSync(source, defaultOptions);
+ }
+ return typeScriptParser;
 }
 
 /**
@@ -313,9 +331,10 @@ function lazyLoadTSParser() {
 * @returns {string} JavaScript code.
 */
 function tsParse(source) {
+ // TODO(@marco-ippolito) Checking empty string or non string input should be handled in Amaro.
 if (!source || typeof source !== 'string') { return ''; }
- const transformSync = lazyLoadTSParser();
- const { code } = transformSync(source, { __proto__: null, mode: 'strip-only' });
+ const parse = loadTypeScriptParser();
+ const { code } = parse(source);
 return code;
 }
 

-Original file line number
+Diff line change
 returnnormalizedId ? require(normalizedId) : undefined;
+}
 -letparseTS;
 +lettypeScriptParser;
 -functionlazyLoadTSParser(){
 -parseTS??=require('internal/deps/amaro/dist/index').transformSync;
 -returnparseTS;
 +/**
 + * Load the TypeScript parser.
 + * @param {Function} parser - A function that takes a string of TypeScript code
 + * and returns an object with a `code` property.
 + * @returns {Function} The TypeScript parser function.
 + */
 +functionloadTypeScriptParser(parser){
 +if(typeScriptParser){
 +returntypeScriptParser;
 +}
++
 +if(parser){
 +typeScriptParser=parser;
 +}else{
 +constamaro=require('internal/deps/amaro/dist/index');
 +// Default option for Amaro is to perform Type Stripping only.
 +constdefaultOptions={__proto__: null,mode: 'strip-only'};
 +// Curry the transformSync function with the default options.
 +typeScriptParser=(source)=>amaro.transformSync(source,defaultOptions);
 +}
 +returntypeScriptParser;
+}
 /**
  * @returns {string} JavaScript code.
  */
 functiontsParse(source){
 +// TODO(@marco-ippolito) Checking empty string or non string input should be handled in Amaro.
 if(!source||typeofsource!=='string'){return'';}
 -consttransformSync=lazyLoadTSParser();
 -const{ code }=transformSync(source,{__proto__: null,mode: 'strip-only'});
 +constparse=loadTypeScriptParser();
 +const{ code }=parse(source);
 returncode;
+}