tools: use Set instead of { [key]: true } object

tniessen · danielleadams · commit 1cbdc984fb14 · 2022-03-14T09:32:04.000-04:00
PR-URL: #41675 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
diff --git a/tools/doc/allhtml.mjs b/tools/doc/allhtml.mjs
@@ -18,14 +18,11 @@ let apicontent = '';
 
 // Identify files that should be skipped. As files are processed, they
 // are added to this list to prevent dupes.
-const seen = {
- 'all.html': true,
- 'index.html': true
-};
+const seen = new Set(['all.html', 'index.html']);
 
 for (const link of toc.match(/<a.*?>/g)) {
 const href = /href="(.*?)"/.exec(link)[1];
- if (!htmlFiles.includes(href) || seen[href]) continue;
+ if (!htmlFiles.includes(href) || seen.has(href)) continue;
 const data = fs.readFileSync(new URL(`./${href}`, source), 'utf8');
 
 // Split the doc.
@@ -68,7 +65,7 @@ for (const link of toc.match(/<a.*?>/g)) {
 .trim() + '\n';
 
 // Mark source as seen.
- seen[href] = true;
+ seen.add(href);
 }
 
 // Replace various mentions of index with all.

-Original file line number
+Diff line change
 // Identify files that should be skipped. As files are processed, they
 // are added to this list to prevent dupes.
 -constseen={
 -'all.html': true,
 -'index.html': true
 -};
 +constseen=newSet(['all.html','index.html']);
 for(constlinkoftoc.match(/<a.*?>/g)){
 consthref=/href="(.*?)"/.exec(link)[1];
 -if(!htmlFiles.includes(href)||seen[href])continue;
 +if(!htmlFiles.includes(href)||seen.has(href))continue;
 constdata=fs.readFileSync(newURL(`./${href}`,source),'utf8');
 // Split the doc.
 .trim()+'\n';
 // Mark source as seen.
 -seen[href]=true;
 +seen.add(href);
+}
 // Replace various mentions of index with all.