net: allow missing callback for Socket.connect

Arguments of Socket.prototype.connect should be also normalized,
causing error when called without callback.
Changed Socket.prototype.connect's code same as net.connect and added
test.
Fixes: #11761
PR-URL: #11762
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

Author: vhain

lib/net.js

@@ -899,24 +899,18 @@ function connect(self, address, port, addressType, localAddress, localPort) {
 }
 
 
-Socket.prototype.connect=function(options,cb){
+Socket.prototype.connect=function(){
+constargs=newArray(arguments.length);
+for(vari=0;i<arguments.length;i++)
+args[i]=arguments[i];
+// TODO(joyeecheung): use destructuring when V8 is fast enough
+constnormalized=normalizeArgs(args);
+constoptions=normalized[0];
+constcb=normalized[1];
+
 if(this.write!==Socket.prototype.write)
 this.write=Socket.prototype.write;
 
-if(options===null||typeofoptions!=='object'){
-// Old API:
-// connect(port[, host][, cb])
-// connect(path[, cb]);
-constargs=newArray(arguments.length);
-for(vari=0;i<arguments.length;i++)
-args[i]=arguments[i];
-constnormalized=normalizeArgs(args);
-constnormalizedOptions=normalized[0];
-constnormalizedCb=normalized[1];
-returnSocket.prototype.connect.call(this,
-normalizedOptions,normalizedCb);
-}
-
 if(this.destroyed){
 this._readableState.reading=false;
 this._readableState.ended=false;

test/parallel/test-net-socket-connect-without-cb.js

@@ -0,0 +1,20 @@
+'use strict';
+constcommon=require('../common');
+
+// This test ensures that socket.connect can be called without callback
+// which is optional.
+
+constnet=require('net');
+
+constserver=net.createServer(common.mustCall(function(conn){
+conn.end();
+server.close();
+})).listen(0,common.mustCall(function(){
+constclient=newnet.Socket();
+
+client.on('connect',common.mustCall(function(){
+client.end();
+}));
+
+client.connect(server.address());
+}));