stream: improve writable.write() performance

Backport-PR-URL: #32169
PR-URL: #31624
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: mscdex

lib/_stream_writable.js

@@ -268,35 +268,8 @@ Writable.prototype.pipe = function() {
 };
 
 
-functionwriteAfterEnd(stream,cb){
-conster=newERR_STREAM_WRITE_AFTER_END();
-// TODO: defer error events consistently everywhere, not just the cb
-errorOrDestroy(stream,er);
-process.nextTick(cb,er);
-}
-
-// Checks that a user-supplied chunk is valid, especially for the particular
-// mode the stream is in. Currently this means that `null` is never accepted
-// and undefined/non-string values are only allowed in object mode.
-functionvalidChunk(stream,state,chunk,cb){
-varer;
-
-if(chunk===null){
-er=newERR_STREAM_NULL_VALUES();
-}elseif(typeofchunk!=='string'&&!state.objectMode){
-er=newERR_INVALID_ARG_TYPE('chunk',['string','Buffer'],chunk);
-}
-if(er){
-errorOrDestroy(stream,er);
-process.nextTick(cb,er);
-returnfalse;
-}
-returntrue;
-}
-
 Writable.prototype.write=function(chunk,encoding,cb){
 conststate=this._writableState;
-varret=false;
 constisBuf=!state.objectMode&&Stream._isUint8Array(chunk);
 
 // Do not use Object.getPrototypeOf as it is slower since V8 7.3.
@@ -306,29 +279,42 @@ Writable.prototype.write = function(chunk, encoding, cb) {
 
 if(typeofencoding==='function'){
 cb=encoding;
-encoding=null;
+encoding=state.defaultEncoding;
+}else{
+if(!encoding)
+encoding=state.defaultEncoding;
+if(typeofcb!=='function')
+cb=nop;
 }
 
 if(isBuf)
 encoding='buffer';
-elseif(!encoding)
-encoding=state.defaultEncoding;
-
-if(typeofcb!=='function')
-cb=nop;
 
+leterr;
 if(state.ending){
-writeAfterEnd(this,cb);
+err=newERR_STREAM_WRITE_AFTER_END();
 }elseif(state.destroyed){
-consterr=newERR_STREAM_DESTROYED('write');
-process.nextTick(cb,err);
-errorOrDestroy(this,err);
-}elseif(isBuf||validChunk(this,state,chunk,cb)){
-state.pendingcb++;
-ret=writeOrBuffer(this,state,chunk,encoding,cb);
+err=newERR_STREAM_DESTROYED('write');
+}elseif(chunk===null){
+err=newERR_STREAM_NULL_VALUES();
+}else{
+if(!isBuf&&!state.objectMode){
+if(typeofchunk!=='string'){
+err=newERR_INVALID_ARG_TYPE('chunk',['string','Buffer'],chunk);
+}elseif(encoding!=='buffer'&&state.decodeStrings!==false){
+chunk=Buffer.from(chunk,encoding);
+encoding='buffer';
+}
+}
+if(err===undefined){
+state.pendingcb++;
+returnwriteOrBuffer(this,state,chunk,encoding,cb);
+}
 }
 
-returnret;
+process.nextTick(cb,err);
+errorOrDestroy(this,err,true);
+returnfalse;
 };
 
 Writable.prototype.cork=function(){
@@ -363,13 +349,6 @@ Writable.prototype.setDefaultEncoding = function setDefaultEncoding(encoding) {
 // in the queue, and wait our turn. Otherwise, call _write
 // If we return false, then we need a drain event, so set that flag.
 functionwriteOrBuffer(stream,state,chunk,encoding,cb){
-if(!state.objectMode&&
-state.decodeStrings!==false&&
-encoding!=='buffer'&&
-typeofchunk==='string'){
-chunk=Buffer.from(chunk,encoding);
-encoding='buffer';
-}
 constlen=state.objectMode ? 1 : chunk.length;
 
 state.length+=len;