test : compare objects not identical by reference

meelie · MylesBorins · commit 1ec692327672 · 2018-12-26T11:18:55.000-05:00
PR-URL: #24189 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/parallel/test-assert-deep.js b/test/parallel/test-assert-deep.js
@@ -947,6 +947,27 @@ assert.throws(() => assert.deepStrictEqual(new Boolean(true), {}),
 );
 }
 
+// Strict equal with identical objects that are not identical
+// by reference and longer than 30 elements
+// E.g., assert.deepStrictEqual({ a: Symbol() }, { a: Symbol() })
+{
+ const a = {};
+ const b = {};
+ for (let i = 0; i < 35; i++) {
+ a[`symbol${i}`] = Symbol();
+ b[`symbol${i}`] = Symbol();
+ }
+
+ assert.throws(
+ () => assert.deepStrictEqual(a, b),
+ {
+ code: 'ERR_ASSERTION',
+ name: 'AssertionError [ERR_ASSERTION]',
+ message: /\.\.\./g
+ }
+ );
+}
+
 // Basic valueOf check.
 {
 const a = new String(1);

-Original file line number
+Diff line change
 );
+}
 +// Strict equal with identical objects that are not identical
 +// by reference and longer than 30 elements
 +// E.g., assert.deepStrictEqual({ a: Symbol() }, { a: Symbol() })
 +{
 +consta={};
 +constb={};
 +for(leti=0;i<35;i++){
 +a[`symbol${i}`]=Symbol();
 +b[`symbol${i}`]=Symbol();
 +}
++
 +assert.throws(
 +()=>assert.deepStrictEqual(a,b),
 +{
 +code: 'ERR_ASSERTION',
 +name: 'AssertionError [ERR_ASSERTION]',
 +message: /\.\.\./g
 +}
 +);
 +}
++
 // Basic valueOf check.
+{
 consta=newString(1);