lib: fix http client socket path

PR-URL: #51900
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: theanarkh

lib/_http_client.js

@@ -336,7 +336,16 @@ function ClientRequest(input, options, cb) {
 // No agent, default to Connection:close.
 this._last=true;
 this.shouldKeepAlive=false;
-if(typeofoptsWithoutSignal.createConnection==='function'){
+letopts=optsWithoutSignal;
+if(opts.path||opts.socketPath){
+opts={ ...optsWithoutSignal};
+if(opts.socketPath){
+opts.path=opts.socketPath;
+}elseif(opts.path){
+opts.path=undefined;
+}
+}
+if(typeofopts.createConnection==='function'){
 constoncreate=once((err,socket)=>{
 if(err){
 process.nextTick(()=>this.emit('error',err));
@@ -346,17 +355,16 @@ function ClientRequest(input, options, cb) {
 });
 
 try{
-constnewSocket=optsWithoutSignal.createConnection(optsWithoutSignal,
-oncreate);
+constnewSocket=opts.createConnection(opts,oncreate);
 if(newSocket){
 oncreate(null,newSocket);
 }
 }catch(err){
 oncreate(err);
 }
 }else{
-debug('CLIENT use net.createConnection',optsWithoutSignal);
-this.onSocket(net.createConnection(optsWithoutSignal));
+debug('CLIENT use net.createConnection',opts);
+this.onSocket(net.createConnection(opts));
 }
 }
 }

test/parallel/test-http-client-with-create-connection.js

@@ -0,0 +1,55 @@
+'use strict';
+constcommon=require('../common');
+consthttp=require('http');
+constnet=require('net');
+consttmpdir=require('../common/tmpdir');
+
+tmpdir.refresh();
+
+letcount=0;
+letserver1;
+letserver2;
+
+functionrequest(options){
+count++;
+http.get({
+ ...options,
+createConnection: (...args)=>{
+returnnet.connect(...args);
+}
+},(res)=>{
+res.resume();
+res.on('end',()=>{
+if(--count===0){
+server1.close();
+server2.close();
+}
+});
+});
+}
+
+server1=http.createServer((req,res)=>{
+res.end('ok');
+}).listen(common.PIPE,()=>{
+server2=http.createServer((req,res)=>{
+res.end('ok');
+}).listen(()=>{
+request({
+path: '/',
+socketPath: common.PIPE,
+});
+
+request({
+socketPath: common.PIPE,
+});
+
+request({
+path: '/',
+port: server2.address().port,
+});
+
+request({
+port: server2.address().port,
+});
+});
+});